Project Vector3 five times slower?

Author

Message

Mistrel

Retired Moderator

19

Years of Service

User Offline

Joined: 9th Nov 2005

Location:

Posted: 21st Aug 2007 20:47

Link

Is it unusual for Project Vector3 to be five times slower when called from my dll than directly from DBP?

http://3dfolio.com

Back to top

Profile PM Email Website

IanM

Retired Moderator

22

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 21st Aug 2007 21:40

Link

It would be unexpected - it should be the same speed or maybe a little faster. Make sure that you are only loading the function pointer once.

Utility plugins collection and
http://www.matrix1.demon.co.uk for older plug-ins and example code

Back to top

Profile PM Email Website

Mistrel

Retired Moderator

19

Years of Service

User Offline

Joined: 9th Nov 2005

Location:

Posted: 21st Aug 2007 23:31 Edited at: 21st Aug 2007 23:41

Link

Yea. I'm only calling ?ProjectVector3@@YAXHHHHH@Z. That's it.

Can you confirm if this is a problem in C++? I'm using PureBasic, though it should be just as fast.

This is my DBP code. I mirrored the Project3Dto2D in PureBasic but replaced the globals with static variables. It returns the result vector as an integer.

global project3d2d_screenxy,project3d2d_projection,project3d2d_view,project3d2d_world
project3d2d_screenxy=find free vector()
void=make vector3(project3d2d_screenxy)
project3d2d_projection=find free vector()
void=make matrix4(project3d2d_projection)
projection matrix4 project3d2d_projection
project3d2d_view=find free vector()
void=make matrix4(project3d2d_view)
view matrix4 project3d2d_view
project3d2d_world=find free vector()
void=make matrix4(project3d2d_world)
world matrix4 project3d2d_world

null = make vector3(100)
null = make matrix4(300) : projection matrix4 300
null = make matrix4(400) : view matrix4 400
null = make matrix4(500) : world matrix4 500

backdrop on

start=timer()
for i=1 to 200000
project3dTo2d(project3d2d_screenxy,25,35,45)
x#=x vector3(project3d2d_screenxy)
y#=y vector3(project3d2d_screenxy)
next i
finish1#=timer()-start

a=Project3D2D(25,35,45)
start=timer()
for i=1 to 200000
a=Project3D2D(25,35,45)
x#=x vector3(a)
y#=y vector3(a)
next i
finish2#=timer()-start

do
text 10,10,str$(finish1#/1000)
text 10,25,str$(finish2#/1000)
loop

wait key
end

function project3dTo2d(result as integer,x as float, y as float, z as float)
   set vector3 result,x,y,z
   view matrix4 project3d2d_view
   project vector3 result,result,project3d2d_projection,project3d2d_view,project3d2d_world
endfunction

+ Code Snippet

global project3d2d_screenxy,project3d2d_projection,project3d2d_view,project3d2d_world
project3d2d_screenxy=find free vector()
void=make vector3(project3d2d_screenxy)
project3d2d_projection=find free vector()
void=make matrix4(project3d2d_projection)
projection matrix4 project3d2d_projection
project3d2d_view=find free vector()
void=make matrix4(project3d2d_view)
view matrix4 project3d2d_view
project3d2d_world=find free vector()
void=make matrix4(project3d2d_world)
world matrix4 project3d2d_world

null = make vector3(100)
null = make matrix4(300) : projection matrix4 300
null = make matrix4(400) : view matrix4 400
null = make matrix4(500) : world matrix4 500

backdrop on

start=timer()
for i=1 to 200000
project3dTo2d(project3d2d_screenxy,25,35,45)
x#=x vector3(project3d2d_screenxy)
y#=y vector3(project3d2d_screenxy)
next i
finish1#=timer()-start

a=Project3D2D(25,35,45)
start=timer()
for i=1 to 200000
a=Project3D2D(25,35,45)
x#=x vector3(a)
y#=y vector3(a)
next i
finish2#=timer()-start

do
text 10,10,str$(finish1#/1000)
text 10,25,str$(finish2#/1000)
loop

wait key
end

function project3dTo2d(result as integer,x as float, y as float, z as float)
   set vector3 result,x,y,z
   view matrix4 project3d2d_view
   project vector3 result,result,project3d2d_projection,project3d2d_view,project3d2d_world
endfunction

This is my PB function. All of my DBP calls are macros. There are no additional functions being called at all so it should be fast.

+ Code Snippet

ProcedureCDLL Project3D2D(x.f,y.f,z.f)
	Static FirstRun,ScreenXY,Projection,View,World
	If Not FirstRun
		ScreenXY=DBPFind_Free_Vector()
		DBPMake_Vector3(ScreenXY)
		Projection=DBPFind_Free_Vector()
		DBPMake_Matrix4(Projection)
		DBPProjection_Matrix4(Projection)
		View=DBPFind_Free_Vector()
		DBPMake_Matrix4(View)
		DBPView_Matrix4(View)
		World=DBPFind_Free_Vector()
		DBPMake_Matrix4(World)
		DBPWorld_Matrix4(World)
		FirstRun=1
	Else
		;DBPSet_Vector3(ScreenXY,X,Y,Z) ; Commented for debugging
		;DBPView_Matrix4(View) ; Commented for debugging
	EndIf
		DBPProject_Vector3(ScreenXY,ScreenXY,Projection,View,World)
	ProcedureReturn ScreenXY
EndProcedure

http://3dfolio.com

Back to top

Profile PM Email Website

IanM

Retired Moderator

22

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 21st Aug 2007 23:55

Link

Is that Freddix's library you are using? It might be a good idea to ask him - I see nothing wrong in what you are doing there.

Utility plugins collection and
http://www.matrix1.demon.co.uk for older plug-ins and example code

Back to top

Profile PM Email Website

Mistrel

Retired Moderator

19

Years of Service

User Offline

Joined: 9th Nov 2005

Location:

Posted: 22nd Aug 2007 00:33 Edited at: 22nd Aug 2007 00:45

Link

I'm not using PurePlugin. I'm locating the function pointer by its name and then calling it.

CallCFunctionFast(GetFunction(#Library,"Function"),Param1,Param2)

I even tried moving the pointer lookup to the constructor instead of having it search for every call. It didn't help at all.

http://3dfolio.com

Back to top

Profile PM Email Website

IanM

Retired Moderator

22

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 22nd Aug 2007 01:10

Link

Ok, that example would be very slow indeed - it will do a lookup of the function pointer on every call.

Even if you stored the result of the lookup into a variable and used that, there's the overhead of the CallCFunctionFast function to consider.

Isn't there any way to call a function pointer directly in PureBasic, like there is in C++? That's the only way you are going to be able to make the call at full speed.

Utility plugins collection and
http://www.matrix1.demon.co.uk for older plug-ins and example code

Back to top

Profile PM Email Website

Mistrel

Retired Moderator

19

Years of Service

User Offline

Joined: 9th Nov 2005

Location:

Posted: 22nd Aug 2007 18:53 Edited at: 22nd Aug 2007 18:53

Link

I haven't found the source of the problem yet. Here is a link to my post on the PureBasic forums if you would like to see what they're saying.

http://www.purebasic.fr/english/viewtopic.php?p=207633#207633

http://3dfolio.com

Back to top

Profile PM Email Website

IanM

Retired Moderator

22

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 22nd Aug 2007 19:42

Link

Ok, I've read through that thread - The basic speed problem does seem to be that you are making a lookup each loop.

If I were you I'd concentrate on getting the function pointer stored in a global first, even if it means still doing the lookup within your function, and then either moving that lookup into a function that can be exported as the mangled C++ name of ReceiveCoreDataPtr (that would be ?ReceiveCoreDataPtr@@YAXPAX@Z - no return value, accepts a single void pointer), or if that's not possible, wrap the lookup in an IF statement so that lookup only takes place if the function pointer has a value of 0.

You might also consider firing an email to Freddix for advice - He's the PureBasic expert around here, not me :p

Utility plugins collection and
http://www.matrix1.demon.co.uk for older plug-ins and example code

Back to top

Profile PM Email Website

Freddix

AGK Developer

22

Years of Service

User Offline

Joined: 19th Sep 2002

Location: France

Posted: 22nd Aug 2007 19:59 Edited at: 22nd Aug 2007 20:08

Link

EDIT : Ergh! Sorry I didn't carefully read your procedure.
I'm not sure but, it should be cool to include a message requester inside your procedure to be sure, it will setup the vectors only once.

You also shouldn't use MACRO(s).
I advice you to firstly setup all DarkBASIC Professionals command pointers for example :

Setup The DarkBASIC Professional commands this way :

Quote: "
Global MyPointer.l
Procedure AllSETUP()
If OpenLibrary( 1, "DBProBitmapExtends.dll")
MyPointer = IsFunction( 1 , "BMP_Init" )
CloseLibrary( 1 )
Endif
EndProcedure
"

Create wrapping commands using this method :

Quote: "
Procedure.l BMP_Init()
Retour.l = CallCFunctionFast( MyPointer )
ProcedureReturn Retour
EndProcedure
"

And use directly the commands from your plugin.
It should be faster.

MyPointer.l =

Gandalf said: "All we have to decide is what to do with the time that is given to us"
Odyssey-Creators - X-Quad Editor - 3DMapEditor

Back to top

Profile PM Email Website

Mistrel

Retired Moderator

19

Years of Service

User Offline

Joined: 9th Nov 2005

Location:

Posted: 22nd Aug 2007 20:45 Edited at: 22nd Aug 2007 20:46

Link

I would think your method to be slower. It's the same thing I'm doing but wrapped up in a procedure instead of a macro.

IanM, would you please confirm whether this is an issue in C++? The way I'm writing it should be the same.

Quote: "Isn't there any way to call a function pointer directly in PureBasic, like there is in C++? That's the only way you are going to be able to make the call at full speed."

Quote: "That's what CallCFunctionFast does."

Quote: "
CallCFunctionFast()

Syntax

Result = CallCFunctionFast(*FunctionPointer [,Parameter1 [, Parameter2...]])
Description

Calls a function directly, using its address. "

http://3dfolio.com

Back to top

Profile PM Email Website

IanM

Retired Moderator

22

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 22nd Aug 2007 21:12

Link

What Freddix is showing you is the way that netmaestro from the PB forum was suggesting in his 3rd post - a setup function, and then the actual function. It's what I suggested also in my last post.

The method I use in C++ appears to be identical (as far as I can tell) to netmaestro's second post

+ Code Snippet

// In the setup function
typedef void(*Function)(int, int, int, int, int);
HANDLE VectorHandle = LoadLibrary("DBProVectorsDebug.dll");
Function MyFunction = (Function)GetProcAddress(VectorHandle, "?ProjectVector3@@YAXHHHHH@Z");
// In your DBPro callable functions
MyFunction(1, 2, 3, 4, 5);

So that is create a function type (PB: Prototype), create a variable based on that type and populate it with the function address, then call the function by treating the variable as if it were a function.

Utility plugins collection and
http://www.matrix1.demon.co.uk for older plug-ins and example code

Back to top

Profile PM Email Website

Mistrel

Retired Moderator

19

Years of Service

User Offline

Joined: 9th Nov 2005

Location:

Posted: 23rd Aug 2007 00:36 Edited at: 23rd Aug 2007 00:37

Link

I tried to use a prototype instead. It only improved performance by 0.005 seconds. But in that case I had the function lookup still inside the function. I kept getting memory errors if I set it up outside the function and shared it or declared it as a global.

http://3dfolio.com

Back to top

Profile PM Email Website

Mistrel

Retired Moderator

19

Years of Service

User Offline

Joined: 9th Nov 2005

Location:

Posted: 26th Aug 2007 06:51 Edited at: 26th Aug 2007 22:52

Link

I've managed to get it down to 200% slower but that's it. IanM, can you confirm that this actually runs faster in C++?

http://3dfolio.com

Back to top

Profile PM Email Website

Sorry your browser is not supported!

DLL Talk / Project Vector3 five times slower?