Help optimising code - GameCreators Forum

Author

Message

Viper Dragon Games

17

Years of Service

User Offline

Joined: 22nd Apr 2007

Location: In front of my computer

Posted: 25th Oct 2007 21:28

Link

hi I know I joined awhile ago but I never really messed with DBP or DBC at all.

well here is what I'm trying to do I'm making a hang man game but not to good at code and my code is well over 700 lines and was woundering
if there was any way to shorten it up im not good at functions plus please dont tell me to you a mouse button function cause i want no mouse in this game so here is my code please help if you can

set display mode 800,600,32 : sync on : sync rate 0 :ink rgb(0,0,0),0 = black : backdrop off
hide mouse
draw to back : set image colorkey 255,255,255 :

load image "images\Homag.png",7
load image "images\newgame.png",1
load image "images\TheSimpsons1.png",2
load image "images\highscores.png",3
load image "images\options.png",4
load image "images\quitgame.png",5
load image "images\noose.png",6
load image "images\SYC.png",8
load image "images\homerpic.jpg",9
load image "images\margepic.jpg",10
load image "images\bartpic.jpg",11
load image "images\lisapic.jpg",12
load image "images\maggiepic.jpg",13
load image "images\grampspic.jpg",14
load image "images\nedspic.jpg",15
load image "images\melhousepic.jpg",16
load image "images\bobpic.jpg",17
load image "images\krustyspic.jpg",18

load music "simpsonsgame.mp3",1
load music "simpsonsintro.mp3",2
load sound "homer\brain.wav",1
load sound "homer\ebert.wav",2
load sound "homer\bologna.wav",3
load sound "homer\awcrap.wav",4
load sound "homer\homer-wh.wav",5
load sound "homer\ahllo.wav",6

play music 2
loop music 1
volume=100-99
if music exist(1)=1
print "volume:" ; music volume(1)
set music volume 1,75
endif
start:
cls
sprite 2,0,0,2
sprite 1,25,390,1
sprite 3,25,440,3
sprite 4,25,490,4
sprite 5,15,540,5
sync

ngicon:
sprite 6,230,370,6
sync
repeat
rotate sprite 1,3
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
wait 0100
sync
rotate sprite 1,0
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
wait 0100
sync
rotate sprite 1,-3
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
wait 0100
sync
rotate sprite 1,0
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
wait 0100
sync
if upkey()=1 then goto quicon
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
until downkey()=1
goto hsicon

hsicon:
sprite 6,245,420,6
sync
repeat
rotate sprite 3,3
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
wait 0100
sync
rotate sprite 3,0
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
wait 0100
sync
rotate sprite 3,-3
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
wait 0100
sync
rotate sprite 3,0
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
wait 0100
sync
if upkey()=1 then goto ngicon
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
until downkey()=1
goto opicon

opicon:
sprite 6,195,470,6
sync
repeat
rotate sprite 4,3
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
wait 0100
sync
rotate sprite 4,0
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
wait 0100
sync
rotate sprite 4,-3
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
wait 0100
sync
rotate sprite 4,0
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
wait 0100
sync
if upkey()=1 then goto hsicon
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
until downkey()=1
goto quicon

quicon:
sprite 6,230,520,6
sync
repeat
rotate sprite 5,3
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
wait 0050
sync
rotate sprite 5,0
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
wait 0050
sync
rotate sprite 5,-3
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
wait 0050
sync
rotate sprite 5,0
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
wait 0050
sync
if upkey()=1 then goto opicon
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
until downkey()=1
goto ngicon

ChrSelect:
cls
hide sprite 1
hide sprite 2
hide sprite 3
hide sprite 4
hide sprite 5
hide sprite 6
sprite 7,0,0,7
sprite 8,150,15,8
sprite 9,25,80,9
sprite 10,120,80,10
sprite 11,215,80,11
sprite 12,310,80,12
sprite 13,405,80,13
sprite 14,25,170,14
sprite 15,120,170,15
sprite 16,215,170,16
sprite 17,310,170,17
sprite 18,405,170,18

show sprite 7
   show sprite 8
   show sprite 9
   show sprite 10
   show sprite 11
   show sprite 12
   show sprite 13
   show sprite 14
   show sprite 15
   show sprite 16
   show sprite 17
   show sprite 18

sync

NewGame:

HighScores:

Options:

homer:
wait 0100
sprite 19,60,40,6
   show sprite 19
sync
wait 0100
repeat
if returnkey()=1
   play sound 6
   wait 2000
   end
endif
if downkey()=1 then goto gramps
if leftkey()=1 then goto krusty
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto marge

marge:
wait 0100
sprite 19,156,40,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if downkey()=1 then goto ned
if leftkey()=1 then goto homer
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto bart

bart:
wait 0100
sprite 19,252,40,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if downkey()=1 then goto melhouse
if leftkey()=1 then goto marge
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto lisa

lisa:
wait 0100
sprite 19,348,40,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if downkey()=1 then goto bob
if leftkey()=1 then goto bart
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto maggie

maggie:
wait 0100
sprite 19,444,40,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if downkey()=1 then goto krusty
if leftkey()=1 then goto lisa
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto gramps

gramps:
wait 0100
sprite 19,60,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto homer
if leftkey()=1 then goto maggie
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto ned

ned:
wait 0100
sprite 19,156,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto marge
if leftkey()=1 then goto gramps
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto melhouse

melhouse:
wait 0100
sprite 19,252,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto bart
if leftkey()=1 then goto ned
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto bob

bob:
wait 0100
sprite 19,348,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto lisa
if leftkey()=1 then goto melhouse
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto krusty

krusty:
wait 0100
sprite 19,444,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto maggie
if leftkey()=1 then goto bob
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto homer

+ Code Snippet

set display mode 800,600,32 : sync on : sync rate 0 :ink rgb(0,0,0),0 = black : backdrop off
hide mouse
draw to back : set image colorkey 255,255,255 :

load image "images\Homag.png",7
load image "images\newgame.png",1
load image "images\TheSimpsons1.png",2
load image "images\highscores.png",3
load image "images\options.png",4
load image "images\quitgame.png",5
load image "images\noose.png",6
load image "images\SYC.png",8
load image "images\homerpic.jpg",9
load image "images\margepic.jpg",10
load image "images\bartpic.jpg",11
load image "images\lisapic.jpg",12
load image "images\maggiepic.jpg",13
load image "images\grampspic.jpg",14
load image "images\nedspic.jpg",15
load image "images\melhousepic.jpg",16
load image "images\bobpic.jpg",17
load image "images\krustyspic.jpg",18


load music "simpsonsgame.mp3",1
load music "simpsonsintro.mp3",2
load sound "homer\brain.wav",1
load sound "homer\ebert.wav",2
load sound "homer\bologna.wav",3
load sound "homer\awcrap.wav",4
load sound "homer\homer-wh.wav",5
load sound "homer\ahllo.wav",6



play music 2
loop music 1
volume=100-99
if music exist(1)=1
print "volume:" ; music volume(1)
set music volume 1,75
endif
start:
cls
sprite 2,0,0,2
sprite 1,25,390,1
sprite 3,25,440,3
sprite 4,25,490,4
sprite 5,15,540,5
sync



ngicon:
sprite 6,230,370,6
sync
repeat
rotate sprite 1,3
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
wait 0100
sync
rotate sprite 1,0
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
wait 0100
sync
rotate sprite 1,-3
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
wait 0100
sync
rotate sprite 1,0
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
wait 0100
sync
if upkey()=1 then goto quicon
if returnkey()=1
   play sound 1
   goto ChrSelect
endif
until downkey()=1
goto hsicon

hsicon:
sprite 6,245,420,6
sync
repeat
rotate sprite 3,3
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
wait 0100
sync
rotate sprite 3,0
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
wait 0100
sync
rotate sprite 3,-3
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
wait 0100
sync
rotate sprite 3,0
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
wait 0100
sync
if upkey()=1 then goto ngicon
if returnkey()=1
   play sound 2
   `wait 3000
   `goto HighScores
   goto hsicon
endif
until downkey()=1
goto opicon

opicon:
sprite 6,195,470,6
sync
repeat
rotate sprite 4,3
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
wait 0100
sync
rotate sprite 4,0
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
wait 0100
sync
rotate sprite 4,-3
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
wait 0100
sync
rotate sprite 4,0
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
wait 0100
sync
if upkey()=1 then goto hsicon
if returnkey()=1
   play sound 3
   `wait 8500
   `goto Options
   goto opicon
endif
until downkey()=1
goto quicon

quicon:
sprite 6,230,520,6
sync
repeat
rotate sprite 5,3
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
wait 0050
sync
rotate sprite 5,0
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
wait 0050
sync
rotate sprite 5,-3
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
wait 0050
sync
rotate sprite 5,0
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
wait 0050
sync
if upkey()=1 then goto opicon
if returnkey()=1
   play sound 4
   wait 2000
   end
endif
until downkey()=1
goto ngicon

ChrSelect:
cls
hide sprite 1
hide sprite 2
hide sprite 3
hide sprite 4
hide sprite 5
hide sprite 6
sprite 7,0,0,7
sprite 8,150,15,8
sprite 9,25,80,9
sprite 10,120,80,10
sprite 11,215,80,11
sprite 12,310,80,12
sprite 13,405,80,13
sprite 14,25,170,14
sprite 15,120,170,15
sprite 16,215,170,16
sprite 17,310,170,17
sprite 18,405,170,18

   show sprite 7
   show sprite 8
   show sprite 9
   show sprite 10
   show sprite 11
   show sprite 12
   show sprite 13
   show sprite 14
   show sprite 15
   show sprite 16
   show sprite 17
   show sprite 18

sync





NewGame:



HighScores:



Options:










homer:
wait 0100
sprite 19,60,40,6
   show sprite 19
sync
wait 0100
repeat
if returnkey()=1
   play sound 6
   wait 2000
   end
endif
if downkey()=1 then goto gramps
if leftkey()=1 then goto krusty
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto marge


marge:
wait 0100
sprite 19,156,40,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if downkey()=1 then goto ned
if leftkey()=1 then goto homer
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto bart


bart:
wait 0100
sprite 19,252,40,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if downkey()=1 then goto melhouse
if leftkey()=1 then goto marge
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto lisa


lisa:
wait 0100
sprite 19,348,40,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if downkey()=1 then goto bob
if leftkey()=1 then goto bart
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto maggie


maggie:
wait 0100
sprite 19,444,40,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if downkey()=1 then goto krusty
if leftkey()=1 then goto lisa
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto gramps


gramps:
wait 0100
sprite 19,60,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto homer
if leftkey()=1 then goto maggie
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto ned


ned:
wait 0100
sprite 19,156,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto marge
if leftkey()=1 then goto gramps
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto melhouse


melhouse:
wait 0100
sprite 19,252,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto bart
if leftkey()=1 then goto ned
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto bob


bob:
wait 0100
sprite 19,348,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto lisa
if leftkey()=1 then goto melhouse
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto krusty


krusty:
wait 0100
sprite 19,444,130,6
sync
wait 0100
repeat
if returnkey()=1
   play sound 5
   wait 1000
   `end
endif
if upkey()=1 then goto maggie
if leftkey()=1 then goto bob
if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif
sync
wait 0100
until rightkey()=1
wait 0100
goto homer

ps please help me with getting rid of the goto it seem to slow down code i think

Back to top

Profile PM

BatVink

Moderator

21

Years of Service

User Offline

Joined: 4th Apr 2003

Location: Gods own County, UK

Posted: 25th Oct 2007 21:38 Edited at: 25th Oct 2007 21:39

Link

1. Post with a meaningful title!

=========================================================
2. This:

+ Code Snippet

if spacekey()=1
   hide sprite 7
   hide sprite 8
   hide sprite 9
   hide sprite 10
   hide sprite 11
   hide sprite 12
   hide sprite 13
   hide sprite 14
   hide sprite 15
   hide sprite 16
   hide sprite 17
   hide sprite 18
   hide sprite 19
   show sprite 1
   show sprite 2
   show sprite 3
   show sprite 4
   show sprite 5
   show sprite 6
   goto start
endif

Can be reduced to this:

+ Code Snippet

if spacekey()=1
   for n = 7 to 19   
      hide sprite n
   next n
   for n = 1 to 6
      show sprite n
   next n
   goto start
endif

============================================================
3. Because you do the above several times, you can do this. replace it with a function call:

+ Code Snippet

if spacekey()=1
   ToggleSprites()
   goto start
endif

and at the end of your code, add the function:

+ Code Snippet

function ToggleSprites()

   for n = 7 to 19   
      hide sprite n
   next n
   for n = 1 to 6
      show sprite n
   next n

endfunction

Try that for starters

Back to top

Profile PM Email

Viper Dragon Games

17

Years of Service

User Offline

Joined: 22nd Apr 2007

Location: In front of my computer

Posted: 25th Oct 2007 22:05 Edited at: 21st Nov 2007 15:58

Link

@BatVink
Thanks that took my code down from over 700+ lines to 523 lines wow big dif and im not being sarcastic.

@anyone that can still help
i was woundering if there was also any way to make my keyboard select movments into a function like the up arrow and etc. but where they will also go where i need them to say the x cordnate and y cordnate
if so please help me

ps.. all help is thankful alot..

Back to top

Profile PM

TDK

Retired Moderator

22

Years of Service

User Offline

Joined: 19th Nov 2002

Location: UK

Posted: 30th Oct 2007 05:05

Link

Your code contains a number of major errors, but this is normal if you are learning to program. Things will improve with experience.

I will probably be criticized for saying this, but you really should go and read a few tutorials for beginners so you know what procedures and functions are and how to use them.

As Batvink showed you, they are probably the number one way to reduce the number of lines in your program.

A programmer with the knowledge gained from a few tutorials would probably write the exact same program 10 to 15 times smaller.

You could start here:

http://forum.thegamecreators.com/?m=forum_view&t=99497&b=10

Also, what you have written is generally classed as 'spaghetti code' as it jumps all over the place with the use of the Goto command. It's use can be dangerous unless you really know what you are doing and shouldn't be used apart from very exceptional cases - and even then there are ways to avoid using it at all.

Tutorials will show you better and more efficient ways of writing your programs.

Good luck!

TDK_Man

* TDK's Game Programming Forums - Open To All - DB & Team Request Boards *

Back to top

Profile PM Email Website

jason p sage

17

Years of Service

User Offline

Joined: 10th Jun 2007

Location: Ellington, CT USA

Posted: 30th Oct 2007 05:05

Link

I don't understand what you are asking.

I can tell you that you want the learn the KEYSTATE command and you will want this in your code. It's big - but it WON'T slow your code down:

#CONSTANT cnScanCode_A=30
  #CONSTANT cnScanCode_B=48
  #CONSTANT cnScanCode_C=46
  #CONSTANT cnScanCode_D=32
  #CONSTANT cnScanCode_E=18
  #CONSTANT cnScanCode_F=33
  #CONSTANT cnScanCode_G=34
  #CONSTANT cnScanCode_H=35
  #CONSTANT cnScanCode_I=23
  #CONSTANT cnScanCode_J=36
  #CONSTANT cnScanCode_K=37
  #CONSTANT cnScanCode_L=38
  #CONSTANT cnScanCode_M=50
  #CONSTANT cnScanCode_N=49
  #CONSTANT cnScanCode_O=24
  #CONSTANT cnScanCode_P=25
  #CONSTANT cnScanCode_Q=16
  #CONSTANT cnScanCode_R=19
  #CONSTANT cnScanCode_S=31
  #CONSTANT cnScanCode_T=20
  #CONSTANT cnScanCode_U=22
  #CONSTANT cnScanCode_V=47
  #CONSTANT cnScanCode_W=17
  #CONSTANT cnScanCode_X=45
  #CONSTANT cnScanCode_Y=21
  #CONSTANT cnScanCode_Z=44
  #CONSTANT cnScanCode_F1=59
  #CONSTANT cnScanCode_F2=60
  #CONSTANT cnScanCode_F3=61
  #CONSTANT cnScanCode_F4=62
  #CONSTANT cnScanCode_F5=63
  #CONSTANT cnScanCode_F6=64
  #CONSTANT cnScanCode_F7=65
  #CONSTANT cnScanCode_F8=66
  #CONSTANT cnScanCode_F9=67
  #CONSTANT cnScanCode_F10=68
  #CONSTANT cnScanCode_LeftSingleQuote=41
  #CONSTANT cnScanCode_1=2
  #CONSTANT cnScanCode_2=3
  #CONSTANT cnScanCode_3=4
  #CONSTANT cnScanCode_4=5
  #CONSTANT cnScanCode_5=6
  #CONSTANT cnScanCode_6=7
  #CONSTANT cnScanCode_7=8
  #CONSTANT cnScanCode_8=9
  #CONSTANT cnScanCode_9=10
  #CONSTANT cnScanCode_0=11
  #CONSTANT cnScanCode_Minus=12
  #CONSTANT cnScanCode_Equal=13
  #CONSTANT cnScanCode_BackSpace=14
  #CONSTANT cnScanCode_Tab=15
  #CONSTANT cnScanCode_LeftBracket=26
  #CONSTANT cnScanCode_RightBracket=27
  #CONSTANT cnScanCode_BackSlash=43
  #CONSTANT cnScanCode_Enter=28
  #CONSTANT cnScanCode_Caps=58
  #CONSTANT cnScanCode_LShift=42
  #CONSTANT cnScanCode_RShift=54
  #CONSTANT cnScanCode_SemiColon=39
  #CONSTANT cnScanCode_SingleQuote=40
  #CONSTANT cnScanCode_Comma=51
  #CONSTANT cnScanCode_Period=52
  #CONSTANT cnScanCode_ForwardSlash=53
  #CONSTANT cncanCode_LWinKey=219
  #CONSTANT cnScanCode_LAlt=56
  #CONSTANT cnScanCode_RAlt=184
  #CONSTANT cnScanCode_RWinKey=220
  #CONSTANT cnScanCode_WinMenu=221
  #CONSTANT cnScanCode_LCntl=29
  #CONSTANT cnScanCode_RCntl=157
  #CONSTANT cnScanCode_PrintScreen=183
  #CONSTANT cnScanCode_ScollLock=70
  #CONSTANT cnScanCode_Pause=197
  `#CONSTANT cnScanCode_Break=197 Same Key
  #CONSTANT cnScanCode_Ins=210
  #CONSTANT cnScanCode_Del=211
  #CONSTANT cnScanCode_Home=199
  #CONSTANT cnScanCode_End=207
  #CONSTANT cnScanCode_PgUp=201
  #CONSTANT cnScanCode_PgDn=209
  #CONSTANT cnScanCode_UpArrow=200
  #CONSTANT cnScanCode_DownArrow=208
  #CONSTANT cnScanCode_LeftArrow=203
  #CONSTANT cnScanCode_RightArrow=205
  #CONSTANT cnScanCode_NumLock=69
  #CONSTANT cnScanCode_NumForwardSlash=181
  #CONSTANT cnScanCode_NumStar=55
  #CONSTANT cnScanCode_NumMinus=74
  #CONSTANT cnScanCode_NumPlus=78
  #CONSTANT cnScanCode_NumEnter=156
  #CONSTANT cnScanCode_NumPeriod=83
  #CONSTANT cnScanCode_Num1=79
  #CONSTANT cnScanCode_Num2=80
  #CONSTANT cnScanCode_Num3=81
  #CONSTANT cnScanCode_Num4=75
  #CONSTANT cnScanCode_Num5=76
  #CONSTANT cnScanCode_Num6=77
  #CONSTANT cnScanCode_Num7=71
  #CONSTANT cnScanCode_Num8=72
  #CONSTANT cnScanCode_Num9=73
  #CONSTANT cnScanCode_Num0=82
  #CONSTANT cnScanCode_SpaceBar = 57

+ Code Snippet

  #CONSTANT cnScanCode_A=30
  #CONSTANT cnScanCode_B=48
  #CONSTANT cnScanCode_C=46
  #CONSTANT cnScanCode_D=32
  #CONSTANT cnScanCode_E=18
  #CONSTANT cnScanCode_F=33
  #CONSTANT cnScanCode_G=34
  #CONSTANT cnScanCode_H=35
  #CONSTANT cnScanCode_I=23
  #CONSTANT cnScanCode_J=36
  #CONSTANT cnScanCode_K=37
  #CONSTANT cnScanCode_L=38
  #CONSTANT cnScanCode_M=50
  #CONSTANT cnScanCode_N=49
  #CONSTANT cnScanCode_O=24
  #CONSTANT cnScanCode_P=25
  #CONSTANT cnScanCode_Q=16
  #CONSTANT cnScanCode_R=19
  #CONSTANT cnScanCode_S=31
  #CONSTANT cnScanCode_T=20
  #CONSTANT cnScanCode_U=22
  #CONSTANT cnScanCode_V=47
  #CONSTANT cnScanCode_W=17
  #CONSTANT cnScanCode_X=45
  #CONSTANT cnScanCode_Y=21
  #CONSTANT cnScanCode_Z=44
  #CONSTANT cnScanCode_F1=59
  #CONSTANT cnScanCode_F2=60
  #CONSTANT cnScanCode_F3=61
  #CONSTANT cnScanCode_F4=62
  #CONSTANT cnScanCode_F5=63
  #CONSTANT cnScanCode_F6=64
  #CONSTANT cnScanCode_F7=65
  #CONSTANT cnScanCode_F8=66
  #CONSTANT cnScanCode_F9=67
  #CONSTANT cnScanCode_F10=68
  #CONSTANT cnScanCode_LeftSingleQuote=41
  #CONSTANT cnScanCode_1=2
  #CONSTANT cnScanCode_2=3
  #CONSTANT cnScanCode_3=4
  #CONSTANT cnScanCode_4=5
  #CONSTANT cnScanCode_5=6
  #CONSTANT cnScanCode_6=7
  #CONSTANT cnScanCode_7=8
  #CONSTANT cnScanCode_8=9
  #CONSTANT cnScanCode_9=10
  #CONSTANT cnScanCode_0=11
  #CONSTANT cnScanCode_Minus=12
  #CONSTANT cnScanCode_Equal=13
  #CONSTANT cnScanCode_BackSpace=14
  #CONSTANT cnScanCode_Tab=15
  #CONSTANT cnScanCode_LeftBracket=26
  #CONSTANT cnScanCode_RightBracket=27
  #CONSTANT cnScanCode_BackSlash=43
  #CONSTANT cnScanCode_Enter=28
  #CONSTANT cnScanCode_Caps=58
  #CONSTANT cnScanCode_LShift=42
  #CONSTANT cnScanCode_RShift=54
  #CONSTANT cnScanCode_SemiColon=39
  #CONSTANT cnScanCode_SingleQuote=40
  #CONSTANT cnScanCode_Comma=51
  #CONSTANT cnScanCode_Period=52
  #CONSTANT cnScanCode_ForwardSlash=53
  #CONSTANT cncanCode_LWinKey=219
  #CONSTANT cnScanCode_LAlt=56
  #CONSTANT cnScanCode_RAlt=184
  #CONSTANT cnScanCode_RWinKey=220
  #CONSTANT cnScanCode_WinMenu=221
  #CONSTANT cnScanCode_LCntl=29
  #CONSTANT cnScanCode_RCntl=157
  #CONSTANT cnScanCode_PrintScreen=183
  #CONSTANT cnScanCode_ScollLock=70
  #CONSTANT cnScanCode_Pause=197
  `#CONSTANT cnScanCode_Break=197 Same Key
  #CONSTANT cnScanCode_Ins=210
  #CONSTANT cnScanCode_Del=211
  #CONSTANT cnScanCode_Home=199
  #CONSTANT cnScanCode_End=207
  #CONSTANT cnScanCode_PgUp=201
  #CONSTANT cnScanCode_PgDn=209
  #CONSTANT cnScanCode_UpArrow=200
  #CONSTANT cnScanCode_DownArrow=208
  #CONSTANT cnScanCode_LeftArrow=203
  #CONSTANT cnScanCode_RightArrow=205
  #CONSTANT cnScanCode_NumLock=69
  #CONSTANT cnScanCode_NumForwardSlash=181
  #CONSTANT cnScanCode_NumStar=55
  #CONSTANT cnScanCode_NumMinus=74
  #CONSTANT cnScanCode_NumPlus=78
  #CONSTANT cnScanCode_NumEnter=156
  #CONSTANT cnScanCode_NumPeriod=83
  #CONSTANT cnScanCode_Num1=79
  #CONSTANT cnScanCode_Num2=80
  #CONSTANT cnScanCode_Num3=81
  #CONSTANT cnScanCode_Num4=75
  #CONSTANT cnScanCode_Num5=76
  #CONSTANT cnScanCode_Num6=77
  #CONSTANT cnScanCode_Num7=71
  #CONSTANT cnScanCode_Num8=72
  #CONSTANT cnScanCode_Num9=73
  #CONSTANT cnScanCode_Num0=82
  #CONSTANT cnScanCode_SpaceBar = 57

How do you use THAT? Like This:

+ Code Snippet

  if keystate(cnScanCode_SpaceBar)=1
    print "Spacebar was pressed"
  endif

Good Luck!

http://www.jasonpetersage.com/?PAGE=ironinfantry&SECTION=ironinfantry

Back to top

Profile PM Email Website

Sorry your browser is not supported!

Newcomers DBPro Corner / Help optimising code