Camera logic woes - GameCreators Forum

Author

Message

tomtetlaw

15

Years of Service

User Offline

Joined: 18th Jan 2009

Location:

Posted: 5th Aug 2009 10:28

Link

I can\'t seem to find why my logic isn\'t working, I\'m sure it\'s something really simple that I\'m just overlooking. But I have programmed it so that when the user pressed W, A, S or D, it should move the camera accordingly, but it doesn\'t. Here\'s the relevant code:

Here is where it\'s defined

+ Code Snippet

void ciCamera::Update( )
{// For updating the position/rotation of the camera and positioning the gun
	if(dbKeyState(KEY_W))
		pz += 0.5;

	if(dbKeyState(KEY_A))
		px -= 0.5;

	if(dbKeyState(KEY_S)) 
		pz -= 0.5;

	if(dbKeyState(KEY_D))
		px += 0.5;

	camerax = dbWrapValue( camerax + dbMouseMoveY() * 0.04f );
	cameray = dbWrapValue( cameray + dbMouseMoveX() * 0.04f );

	dbXRotateCamera( camerax );
	dbYRotateCamera( cameray );

	float oldpx = px;
	float oldpy = py;
	float oldpz = pz;

	if( oldpx != px ||
		oldpy != py ||
		oldpz != pz ) //If the position has changed
		dbPositionCamera( px, py, pz );
}

here is where it\'s called:

+ Code Snippet

ciCamera cam( dbCameraPositionX(),
		dbCameraPositionY(),
		dbCameraPositionZ(),
		0,0,0, \"media/H-Shotgun-Static.x\" );

	// our main loop
	while( LoopGDK( ) )
	{
		cam.Update( );
		// update the screen
		dbSync ( );
	}

Any help would be greatly appreciated

#ifdef __NEWBIE__
MakeAnAwesomeGame(lots of badies, lots of guns, lots of stuff to do, BIG level)
#endif

Back to top

Profile PM Email

Mista Wilson

16

Years of Service

User Offline

Joined: 27th Aug 2008

Location: Brisbane, Australia

Posted: 5th Aug 2009 10:45

Link

Have you defined you scancodes somewhere ? Otherwise the indentifier KEY_A will be nothing.

Are you initializing the value px and pz to 0(or whatever they are meant to be) when you instance the class(in its constructor) ?

According to you Update loop, its taking the current value of px and pz and increment/decrementing it, if the value isnt initialized to 0, it will be some random number that coulde be massively out of range...

Also this bit :

+ Code Snippet

float oldpx = px;
	float oldpy = py;
	float oldpz = pz;

	if( oldpx != px ||
		oldpy != py ||
		oldpz != pz ) //If the position has changed
		dbPositionCamera( px, py, pz );

looks to me like the assignment of px to oldpx and then the comparison of whether oldpx is inequal to px is in the wrong order. By assigning those values there and checking them on the next line, they will always be the same, so the camera will never think it has moved.... hope that makes sense.. to fix it, I would assign you "oldpx, oldpz" variables at the top of the loop, before you assign new values to the "px, pz" variables.

If it ain't broke.... DONT FIX IT !!!

Back to top

Profile PM Email

tomtetlaw

15

Years of Service

User Offline

Joined: 18th Jan 2009

Location:

Posted: 5th Aug 2009 11:30

Link

Ok thanks that fixed it, but my gun won't follow my camera, it's there, just not moving, can you tell me why this is?

#ifdef __NEWBIE__
MakeAnAwesomeGame(lots of badies, lots of guns, lots of stuff to do, BIG level)
#endif

Back to top

Profile PM Email

Mista Wilson

16

Years of Service

User Offline

Joined: 27th Aug 2008

Location: Brisbane, Australia

Posted: 5th Aug 2009 12:22

Link

Without seeing the code that is responsible for your gun and its positioning/rendering i cant say im sorry, if you can post more code someone may be able to help

If it ain't broke.... DONT FIX IT !!!

Back to top

Profile PM Email

tomtetlaw

15

Years of Service

User Offline

Joined: 18th Jan 2009

Location:

Posted: 5th Aug 2009 12:29

Link

This is all the code regarding the gun

+ Code Snippet

dbPositionObject( gunid, dbCameraPositionX(),
	dbCameraPositionY(), dbCameraPositionZ( )+2 );
	dbLockObjectOn( gunid );

#ifdef __NEWBIE__
MakeAnAwesomeGame(lots of badies, lots of guns, lots of stuff to do, BIG level)
#endif

Back to top

Profile PM Email

tomtetlaw

15

Years of Service

User Offline

Joined: 18th Jan 2009

Location:

Posted: 5th Aug 2009 13:00

Link

sorry for the double post
THis is the code now:

+ Code Snippet

dbLoadObject( lpGunFileName, gunid );
		dbPositionObject( gunid, 
			dbCameraPositionX(),
			dbCameraPositionY(),
			dbCameraPositionZ()
		);
		dbRotateObject( gunid, 
			dbCameraAngleX(),
			dbCameraAngleY(),
			dbCameraAngleZ()
		);
		dbLockObjectOn( gunid );

#ifdef __NEWBIE__
MakeAnAwesomeGame(lots of badies, lots of guns, lots of stuff to do, BIG level)
#endif

Back to top

Profile PM Email

Sorry your browser is not supported!

Dark GDK / Camera logic woes