Problem with IF Statements after upgrade

Author

Message

The Guardian

16

Years of Service

User Offline

Joined: 13th Sep 2009

Location:

Posted: 2nd Apr 2010 08:30

Link

Okay, here's my dilemma...

When I discovered my DB Pro wasn't working with Windows 7, I upgraded it, and it seemed to work okay when working with IF statements. However, I also upgraded it to 7.4 shortly afterward.

Now, my IF Statements don't seem to work. I was watching a tutorial on Health Bars by the people who made DarkPRINCIPLES, and my code wont decrease or increase like it's supposed to. Below I have my code and a link to said tutorial. I'd appreciate any help that can be provided to me.

+ Code Snippet

Sync
Sync Rate 30
Backdrop On
Color Backdrop 0

health = 100

Do

if inkey$() = "q"
   dec health
   if health < 0 then health = 0
endif

if inkey$() = "w"
   inc health
   if health > 100 then health = 100
endif

Box 10, 10, health*2, 20

Sync
Loop

Health Bar Tutorial

Back to top

Profile PM

Van B

Moderator

23

Years of Service

User Offline

Joined: 8th Oct 2002

Location: Sunnyvale

Posted: 2nd Apr 2010 13:45

Link

Some slight adjustments to try, not sure if these will work but its worth a go...

+ Code Snippet

Sync On
Sync Rate 30
Backdrop On
Color Backdrop 0

health = 100

Do

i$=upper$(inkey$())
if i$ = "Q"
   dec health,1
   if health < 0 then health = 0
endif

if i$ = "W"
   inc health,1
   if health > 100 then health = 100
endif

Box 10, 10, 10+(health*2), 20
text 10,22,str$(health)

Sync
Loop

Things that pop, are that you haven't used SYNC ON, you sync'd the start of your code instead, so changed that. I always specify the value when INCrementing or DECrementing, so added a ,1. I also set inkey$() to a variable, and made it capitalize, so just check the capital, like "W", then it won't care if caps lock is on. I added a health text to show the actual value - if that is there, and there's still no BOX, then it must be an issue with the box drawing. Unlikely, but it should serve as a good test.

The main one I think would be the SYNC ON thing though.

Health, Ammo, and bacon and eggs!

Back to top

Profile PM Email

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 2nd Apr 2010 14:51 Edited at: 2nd Apr 2010 14:53

Link

The problem is that you need "sync on" not "sync" at the start of your code - and cls at the start of the loop. Then everything is fine.

+ Code Snippet

Sync on    ` changed this
Sync Rate 30
Backdrop On
Color Backdrop 0

health = 100

Do

cls     ` added this

if inkey$() = "q"
   dec health
   if health < 0 then health = 0
endif

if inkey$() = "w"
   inc health
   if health > 100 then health = 100
endif

Box 10, 10, health*2, 20

Sync
Loop

Without the cls the screen is not being cleared so the original bar still shows - all you are doing otherwise is overwriting part of the white with white so you don't see the change.

Without the sync on you get an annoying flicker.

Edit: The cls isn't needed if you have 3D objects in the scene as the screen is automatically cleared each sync in that case.

Back to top

Profile PM Email

The Guardian

16

Years of Service

User Offline

Joined: 13th Sep 2009

Location:

Posted: 2nd Apr 2010 19:23 Edited at: 3rd Apr 2010 05:54

Link

Thanks a lot to the both of you. Hopefully I'll be able to catch things like that better in the future.

EDIT: Okay, there is another problem.

In the second part of the tutorial, it talks about using a black box to cover up the health bar so that when a gradient is applied to the box, then the colors wont be balanced. I.E. if it goes from dark red to light blue, then instead of both colors being balanced no matter the width, the lower the health got, you'd see less and less of the blue. Here is my code as it is now.

+ Code Snippet

Sync On
Sync Rate 30
Backdrop On
Color Backdrop 0

health = 100

Do

i$=upper$(inkey$())
if i$ = "Q"
   dec health, 1
   if health < 0 then health = 0
endif

if i$ = "W"
   inc health, 1
   if health > 100 then health = 100
endif

Box 10, 10, 10+(health*2), 20, RGB(100, 0, 0), RGB(100, 0, 0), RGB(255, 0, 0), RGB(255, 0, 0)
text 10, 22, "Health:"
text 70, 22, str$(health)

Box (health*2), 10, 10+(health*2), 20, RGB(0, 0, 0), RGB(0, 0, 0), RGB(0, 0, 0), RGB(0, 0, 0)

if health > 10
   Ink RGB(255, 255, 255), 0
Else
   Ink RGB(255, 0, 0), 0
Endif

Sync
Loop

Back to top

Profile PM

Hawkblood

16

Years of Service

User Offline

Joined: 5th Dec 2009

Location:

Posted: 7th Apr 2010 17:05

Link

I'm not sure what you are trying to accomplish with that code but, I think you are going to have a problem with the black box being in the way. Aside form that, what is your question?

You could use something like this for your health bar:

+ Code Snippet

Box 10, 10, 10+(health*2), 20, RGB(100, 0, 0), RGB(100, 0, 0), RGB(155*(health/100.0)+100, 0, 0), RGB(155*(health/100.0)+100, 0, 0)

The fastest code is the code never written.

Back to top

Profile PM Email Website

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 7th Apr 2010 17:28

Link

Is this what you're trying to do?

+ Code Snippet

Sync On
Sync Rate 30
Backdrop On
Color Backdrop 0

health = 100

Do

i$=upper$(inkey$())
if i$ = "Q"
   dec health, 1
   if health < 0 then health = 0
endif

if i$ = "W"
   inc health, 1
   if health > 100 then health = 100
endif

Box 10, 10, 210, 20, RGB(255, 0, 0), RGB(255, 0, 0), RGB(0, 255, 0), RGB(0, 255, 0)
text 10, 22, "Health:"
text 70, 22, str$(health)

Box (health*2), 10, 210, 20, RGB(0, 0, 0), RGB(0, 0, 0), RGB(0, 0, 0), RGB(0, 0, 0)

if health > 10
   Ink RGB(255, 255, 255), 0
Else
   Ink RGB(255, 0, 0), 0
Endif

Sync
Loop

(I used red and green.)

Back to top

Profile PM Email

The Guardian

16

Years of Service

User Offline

Joined: 13th Sep 2009

Location:

Posted: 15th Apr 2010 01:14

Link

Green Gandalf, that is exactly what I'm trying to do. Thank you so much.

Back to top

Profile PM

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Problem with IF Statements after upgrade