Lighting shader range issue - GameCreators Forum

Author

Message

Madscientist

16

Years of Service

User Offline

Joined: 23rd Aug 2009

Location: Between a rock and a hard place

Posted: 16th Apr 2010 23:19 Edited at: 16th Apr 2010 23:20

Link

I've posted a similar question before but I didn't really get a good solid answer.
I am using evolve's multipass lighting fx.
http://www.evolved-software.com/shaders/Shaders_Lighting.html
I'm using the normal mapping shader but i'm having trouble with the db funtions that go with the shader. The lights shut off after the camera is a certain distance from them. But if I increase the range of the lights, they get brighter. How would I increase the range without increasing the brightness?
This is the code in the lighting functions

Function GetObjectLight( O , L )
   PosX#=object position x(O):PosY#=object position y(O):PosZ#=object position z(O)
   col=COLBOX(LightPos#(L,0),LightPos#(L,1),LightPos#(L,2),PosX#,PosY#,PosZ#,ObjectSize#(O,0)+LightCol#(L,3),ObjectSize#(O,1)+LightCol#(L,3),ObjectSize#(O,2)+LightCol#(L,3))
   if col=1
   AddLight=0
      for OL=0 to 5
         if ObjectLight(O,OL)=L then AddLight=1
      next OL
   if AddLight=0
      for OL=0 to 5
         if ObjectLight(O,OL)=0 and AddLight=0 then ObjectLight(O,OL)=L:AddLight=1
      next OL
   endif
   endif
   if col=0
      for OL=0 to 5
         if ObjectLight(O,OL)=L then ObjectLight(O,OL)=0
      next OL
   endif
      for OL=0 to 5
   if ObjectLight(O,OL)=0
      AddLight=0
      for OL2=OL+1 to 5
         if AddLight=0 and ObjectLight(O,OL2)>0 then ObjectLight(O,OL)=ObjectLight(O,OL2):AddLight=1:ObjectLight(O,OL2)=0
      next OL2
   endif
      next OL
Endfunction

Function COLBOX(X#,Y#,Z#,pX#,pY#,pZ#,Sx#,Sy#,Sz#)
   col=0
   if X#<(pX#+Sx#)
      if X#>(pX#-Sx#)
         if Y#<(pY#+SY#)
            if Y#>(pY#-SY#)
               if Z#<(pZ#+SZ#)
                  if Z#>(pZ#-SZ#)
                     col=1
                  endif
               endif
            endif
         endif
      endif
   endif
Endfunction col

Function SetObjectLight( O , Effect)
   LN=0
   for OL=0 to 5
      if ObjectLight(O,OL)>0
         set vector4 1,LightPos#(ObjectLight(O,OL),0),LightPos#(ObjectLight(O,OL),1),LightPos#(ObjectLight(O,OL),2),0
         set effect constant vector Effect,"LightPosition_"+str$(OL+1),1
         set vector4 1,LightCol#(ObjectLight(O,OL),0),LightCol#(ObjectLight(O,OL),1),LightCol#(ObjectLight(O,OL),2),0
         set effect constant vector Effect,"LightColor_"+str$(OL+1),1
         LN=LN+1
      endif
   	  set effect constant float Effect,"LightRange_"+str$(OL+1),LightCol#(ObjectLight(O,OL),3)   
   next OL

if LN>0 then set effect technique Effect,"Light"+str$(LN)
   if LN=0 then set effect technique Effect,"Ambient"
   set vector4 1,camera position x(),camera position y(),camera position z(),0
   set effect constant float Effect,"BrightNess",F#
Endfunction

+ Code Snippet

Function GetObjectLight( O , L )
   PosX#=object position x(O):PosY#=object position y(O):PosZ#=object position z(O)
   col=COLBOX(LightPos#(L,0),LightPos#(L,1),LightPos#(L,2),PosX#,PosY#,PosZ#,ObjectSize#(O,0)+LightCol#(L,3),ObjectSize#(O,1)+LightCol#(L,3),ObjectSize#(O,2)+LightCol#(L,3))
   if col=1
   AddLight=0
      for OL=0 to 5
         if ObjectLight(O,OL)=L then AddLight=1
      next OL
   if AddLight=0
      for OL=0 to 5
         if ObjectLight(O,OL)=0 and AddLight=0 then ObjectLight(O,OL)=L:AddLight=1
      next OL
   endif
   endif
   if col=0
      for OL=0 to 5
         if ObjectLight(O,OL)=L then ObjectLight(O,OL)=0
      next OL
   endif
      for OL=0 to 5
   if ObjectLight(O,OL)=0
      AddLight=0
      for OL2=OL+1 to 5
         if AddLight=0 and ObjectLight(O,OL2)>0 then ObjectLight(O,OL)=ObjectLight(O,OL2):AddLight=1:ObjectLight(O,OL2)=0
      next OL2
   endif
      next OL
Endfunction

Function COLBOX(X#,Y#,Z#,pX#,pY#,pZ#,Sx#,Sy#,Sz#)
   col=0
   if X#<(pX#+Sx#)
      if X#>(pX#-Sx#)
         if Y#<(pY#+SY#)
            if Y#>(pY#-SY#)
               if Z#<(pZ#+SZ#)
                  if Z#>(pZ#-SZ#)
                     col=1
                  endif
               endif
            endif
         endif
      endif
   endif
Endfunction col

Function SetObjectLight( O , Effect)
   LN=0
   for OL=0 to 5
      if ObjectLight(O,OL)>0
         set vector4 1,LightPos#(ObjectLight(O,OL),0),LightPos#(ObjectLight(O,OL),1),LightPos#(ObjectLight(O,OL),2),0
         set effect constant vector Effect,"LightPosition_"+str$(OL+1),1
         set vector4 1,LightCol#(ObjectLight(O,OL),0),LightCol#(ObjectLight(O,OL),1),LightCol#(ObjectLight(O,OL),2),0
         set effect constant vector Effect,"LightColor_"+str$(OL+1),1
         LN=LN+1
      endif
   	  set effect constant float Effect,"LightRange_"+str$(OL+1),LightCol#(ObjectLight(O,OL),3)   
   next OL

   if LN>0 then set effect technique Effect,"Light"+str$(LN)
   if LN=0 then set effect technique Effect,"Ambient"
   set vector4 1,camera position x(),camera position y(),camera position z(),0
   set effect constant float Effect,"BrightNess",F#
Endfunction

And I call it up like this

+ Code Snippet

   For L=1 to 3
   		For X=1 to 3
   			UpdateObject(Level(X))
   			GetObjectLight(Level(X),L)
   			SetObjectLight(Level(X),NMFX)
  		 Next X
  		 UpdateObject(Weapon(Crossbow))
  		 GetObjectLight(Weapon(Crossbow),L)
  		 SetObjectLight(Weapon(Crossbow),NMFX) 		 
  	Next L

If it hasn't exploded yet, I haven't touched it.

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 17th Apr 2010 01:01

Link

Quote: "But if I increase the range of the lights, they get brighter"

How else do you expect to see a light that's turned off at a certain range - except by making it brighter at that distance?

Back to top

Profile PM Email

Madscientist

16

Years of Service

User Offline

Joined: 23rd Aug 2009

Location: Between a rock and a hard place

Posted: 17th Apr 2010 04:09 Edited at: 17th Apr 2010 04:09

Link

What i mean is that the light suddenly just blinks off.
see pictures taken from just being in the light range and then backing just out of it.
In range:

Out of range:

If it hasn't exploded yet, I haven't touched it.

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 17th Apr 2010 13:55

Link

I see what you mean. There must be a coding error somewhere because the light should be attenuated gradually down to zero brightness.

What is your code trying to do exactly? It looks very complicated at first sight.

Back to top

Profile PM Email

Madscientist

16

Years of Service

User Offline

Joined: 23rd Aug 2009

Location: Between a rock and a hard place

Posted: 17th Apr 2010 15:17

Link

I just figured out that prob but ran into another in soving it.
Well the lighting fuctions came with the shader but I edited them a little to fit my needs. The GetObjectLight( O , L ) function checks if the light is in range and if it is, its turned on. I just figured out that if I change the function that gets the range of the light (LightCol#(0,3) is the range or the light)

+ Code Snippet

col=COLBOX(LightPos#(L,0),LightPos#(L,1),LightPos#(L,2),PosX#,PosY#,PosZ#,ObjectSize#(O,0)+LightCol#(L,3),ObjectSize#(O,1)+LightCol#(L,3),ObjectSize#(O,2)+LightCol#(L,3))

to

+ Code Snippet

col=COLBOX(LightPos#(L,0),LightPos#(L,1),LightPos#(L,2),PosX#,PosY#,PosZ#,ObjectSize#(O,0)+10,ObjectSize#(O,1)+10,ObjectSize#(O,2)+10)

it will increase the light's range but not the brightness, but then my fps drops from 60 to around 35 which is a big problem.

If it hasn't exploded yet, I haven't touched it.

Back to top

Profile PM

Madscientist

16

Years of Service

User Offline

Joined: 23rd Aug 2009

Location: Between a rock and a hard place

Posted: 20th Apr 2010 22:24 Edited at: 20th Apr 2010 22:31

Link

Well I found that my game really runs slow when I add more complex objects such as tables and cages since the shader has to light those surfaces. Is there any suggestions on how to improve the speed of my game? Also even when I turn on Vsync and set my sync rate to 60 my fps jumps around from 40 to 70.

If it hasn't exploded yet, I haven't touched it.

Back to top

Profile PM

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Lighting shader range issue