Can anyone spot my NESTING ERROR?

Author

Message

Junebug

13

Years of Service

User Offline

Joined: 19th Jan 2011

Location:

Posted: 19th Jan 2011 19:10 Edited at: 19th Jan 2011 21:10

Link

My code:

`*****************************************
`*****************************************
`***
`***   TITLE - Super Fruit Vs. The Cavity
`***   VERSION - 1.0 Last Updated 1.11.11
`***   DEVELOPER - Tommy Twiss
`***   COPYRIGHT - Ingenious Student Labs
`***   DATE CREATED - 1.10.2011
`***
`  ***
`  ***   START SYSTEM SETUP SECTION
`  ***
         sync on
         sync rate 30
         autocam on
         hide mouse
         randomize timer()
`  ***
`  ***   STOP SYSTEM SETUP SECTION
`  ***
`	***************************************
`	***
`		***   START INTRO SECTION
`		***
`		***
`		***   INTRO SECTION HEADER
`		***
            `DECLARE VARIABLES

`SCREEN DISPLAY
					cls 0
               ink rgb(255,255,255),0
               center text 320,240,"Super Fruit Vs. The Cavity"
               center text 320,260,"HIT ANY KEY TO BEGIN"
		do
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 1.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 2.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 3.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 4.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 5.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
			sync
		loop
            `LOAD SOUNDS
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   INTRO SECTION LOOP
`     ***
			IntroLoopSection:
            do
               `SCREEN DISPLAY
               `CONTROL INPUT
                  if keystate( scancode() ) = 1 then goto OptionsSection
               `REFRESH SCREEN
                  sync
            loop
`  ***
`  ***   END INTRO SECTION
`  ***
`  *****************************************
`  ***
`  ***   START OPTIONS SECTION
`  ***
`     ***
`     ***   OPTIONS SECTION HEADER
`     ***
            OptionsSection:
            `DECLARE VARIABLES

`MyTimer / sync rate = seconds on timer (approx.)
MyTimer = 1500 
`How powerful gravity is
Gravity# = 1
`How strong the player can jump
MyPower = 10
`How fast the player can run
MySpeed = 9
`Starting score is 0
MyScore = 0
`Start without jumping or falling
MyAcceleration# = 0.0

`Levels
                  TotalLevels = 1 : `Total number of levels
                  LevelNumber = 1 : `Start on Level 1
            `SCREEN DISPLAY
               cls 0
					Load Bitmap "images/Super Fruit vs The Cavity.bmp"
               ink rgb(255,255,255),0
               center text 320,260,"HIT THE SPACE BAR TO BEGIN"
            `LOAD SOUNDS
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   OPTIONS SECTION LOOP
`     ***
            do
               if scancode() = 0 then exit
            loop
            do
               `SCREEN DISPLAY
               `CONTROL INPUT
                  if spacekey()=1 then goto LevelIntroSection
               `REFRESH SCREEN
                  sync
            loop
`  ***
`  ***   END OPTIONS SECTION
`  ***
`  *****************************************
`  ***
`  ***   START LEVEL INTRO SECTION
`  ***
`     ***
`     ***   LEVEL INTRO SECTION HEADER
`     ***
            LevelIntroSection:
            `DECLARE VARIABLES
            `SCREEN DISPLAY
               cls 0
               ink rgb(255,255,255),0
               center text 320,220, "LEVEL"
               set cursor 320,240
               print LevelNumber
               center text 320,260, "HIT ANY KEY TO BEGIN"
            `LOAD SOUNDS
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   LEVEL INTRO SECTION LOOP
`     ***
            do
               if scancode() = 0 then exit
            loop
            do
               `SCREEN DISPLAY
               `CONTROL INPUT
                  if keystate( scancode() ) = 1 then goto MainSection
               `REFRESH SCREEN
                  sync
            loop
`  ***
`  ***   END LEVEL INTRO SECTION
`  ***
`  *****************************************
`  ***
`  ***   START MAIN SECTION
`  ***
`     ***
`     ***   MAIN SECTION HEADER
`     ***
            MainSection:
            `DECLARE VARIABLES
               `Player Character
               `Projectiles
               `Enemies
               `Other
            `LOAD IMAGES
load image "Super Fruit.bmp",1
load image "cave02.bmp",2
load image "steel01.bmp",3
load image "rocky01.bmp",4

`SCREEN DISPLAY
               cls 0
               backdrop on
               `TEXT
               `HEADS-UP DISPLAY (HUD)
            `OBJECT CREATION
               `World Map
` Walls

` North Wall
   make object box 2,2000,1000,10
   rotate object 2,0,0,0
   position object 2, 0,500,1005
   texture object 2,2

` East Wall
   make object box 3,2000,1000,10
   rotate object 3,0,90,0
   position object 3, 1005,500,0
   texture object 3,2

` South Wall
   make object box 4,2000,1000,10
   rotate object 4,0,180,0
   position object 4, 0,500,-1005
   texture object 4,2

` West Wall
   make object box 5,2000,1000,10
   rotate object 5,0,270,0
   position object 5, -1005,500,0
   texture object 5,2

` Floor
make object box 6,2000,1000,2000 : position object 6,0,-500,0 : color object 6,rgb(0,255,0)
make object collision box 6,-1000,-500,-1000,1000,500,1000,0
texture object 6,3

rem Steps
NumberOfSteps = 7
for t=0 to NumberOfSteps-1
   make object box t+7,50,10,50
   position object t+7,0,5+(t*20),100+(t*100)
	texture object t+7,4
   make object collision box t+7,-25,-5,-25,25,5,25,0

rem Fruits
NumberOfFruits = 20
FruitColor = 0
for t = 1 to NumberOfFruits

if FruitColor = 0
      r = 255 : g = 0
   endif
   if FruitColor = 1
      r = 255 : g = 255
   endif
   if FruitColor = 2
      r = 0 : g = 255
   endif
   if FruitColor = 3
      r = 255 : g = 125
   endif
   FruitColor = FruitColor + 1
   if FruitColor = 4 then FruitColor = 0

make object sphere t + NumberOfFruits ,50
   color object t + NumberOfFruits , rgb(r,g,0)
   position object t + NumberOfFruits ,Rnd(1900)-950,30,Rnd(1900)-950
   make object collision box t + NumberOfFruits ,-25,-25,-25,25,25,25,0
next t

rem Super Fruit
   make object sphere 8,100
   texture object 8,1
   position object 8 ,0,250,900
   make object collision box 100,-50,-50,-50,50,50,50,0

`Player Character
                  make object cylinder 1,100
							texture object 1,1
            `LOAD MODELS
            `SET LIGHTS
            `SET CAMERA
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   MAIN SECTION LOOP
`     ***
            do
               if scancode() = 0 then exit
            loop
            do
               `SPECIAL EFFECTS
               `OBJECT ORIENTATIONS (Pre-Movement, Pre-Collision)
                  `Player Character
                     1pX# = object position X(1)
                     1pY# = object position Y(1)
                     1pZ# = object position Z(1)
                     1aX = object angle X(1)
                     1aY = object angle Y(1)
                     1aZ = object angle Z(1)
                  `Projectiles
                  `Enemies
               `LIVE SCREEN DISPLAY
                  `TEXT
                     center text 320,440,"USE ARROW KEYS TO MOVE   |   PRESS 'Q' TO QUIT"
                  `HUD
               `CONTROL INPUT
                  `Acceleration and Pitch
                     if Upkey()=1 then move object 1,10
                     if Downkey()=1 then move object 1,-10
                  `Turning and Banking
                     if Leftkey()=1 then Yrotate object 1,wrapvalue(1aY-5)
                     if Rightkey()=1 then Yrotate object 1,wrapvalue(1aY+5)
                  `Releasing Projectiles
                  `Quit Game
                     if Inkey$() = "q"
                        ClearWorld()
                        goto EndSection
                     endif
               `TRANSFORM OBJECTS
               `MOVE OBJECTS
                  `Player Character
                  `Projectiles
                  `Enemies
               `OBJECT ORIENTATIONS (Post-Movement, Pre-Collision)
                  `Player Character
                     new1pX# = object position X(1)
                     new1pY# = object position Y(1)
                     new1pZ# = object position Z(1)
                     new1aX = object angle X(1)
                     new1aY = object angle Y(1)
                     new1aZ = object angle Z(1)
                  `Projectiles
                  `Enemies
               `CHECK COLLISIONS
                  `Player Character
                     `Walls
                     `Pick-Ups
                     `Enemies
                  `Projectiles
                     `Walls
                     `Enemies
                  `Enemies
                     `Walls
               `OBJECT ORIENTATIONS (Post-Movement, Post-Collision)
                  `Player Character
                     1pX# = object position X(1)
                     1pY# = object position Y(1)
                     1pZ# = object position Z(1)
                     1aX = object angle X(1)
                     1aY = object angle Y(1)
                     1aZ = object angle Z(1)
                  `Projectiles
                  `Enemies
               `CHECK PLAYER EXPIRATION
               `MOVE CAMERA
               `MOVE LIGHT
               `REFRESH SCREEN
                  sync
            loop
`  ***
`  ***   STOP MAIN SECTION
`  ***
`  *****************************************
`  ***
`  ***   START END SECTION
`  ***
`     ***
`     ***   END SECTION HEADER
`     ***
            EndSection:
            `DECLARE VARIABLES
            `SCREEN DISPLAY
               cls 0
               ink rgb(255,255,255),0
               center text 320,220, "GAME OVER"
               center text 320,260, "PLAY AGAIN [Y/N]?"
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   END SECTION LOOP
`     ***
            do
               if scancode() = 0 then exit
            loop
            do
            `CONTROL INPUT
               if Inkey$() = "y" then goto OptionsSection
               if Inkey$() = "n"
                  cls 0
                  end
               endif
            `REFRESH SCREEN
               sync
            loop
            end
`  ***
`  *** STOP END SECTION
`  ***
`  *****************************************
`  *****************************************
`  ***
`  ***   START FUNCTIONS
`  ***
`     ***
`     ***   CLEAR WORLD - ClearWorld
`     ***   Remove all existing 3D elements from world
`     ***
            function ClearWorld
               for x = 1 to 1000
                  if object exist(x) = 1 then delete object x
                  if matrix exist(x) = 1 then delete matrix x
                  if mesh exist(x) = 1 then delete mesh x
                  if light exist(x) = 1 then delete light x
                  if x <= 32
                     if animation exist(x) = 1 then delete animation x
                  endif
               next x
               `Static Objects
                  make object cube 1,5
                  make static object 1
                  delete object 1
                  delete static objects
               fog off
               backdrop off
               cls 0
            endfunction
`  ***
`  ***   STOP FUNCTIONS
`  ***
`***
`***  END PROGRAM
`***
`*****************************************
`*****************************************

+ Code Snippet

`*****************************************
`*****************************************
`***
`***   TITLE - Super Fruit Vs. The Cavity
`***   VERSION - 1.0 Last Updated 1.11.11
`***   DEVELOPER - Tommy Twiss
`***   COPYRIGHT - Ingenious Student Labs
`***   DATE CREATED - 1.10.2011
`***
`  ***
`  ***   START SYSTEM SETUP SECTION
`  ***
         sync on
         sync rate 30
         autocam on
         hide mouse
         randomize timer()
`  ***
`  ***   STOP SYSTEM SETUP SECTION
`  ***
`	***************************************
`	***
`		***   START INTRO SECTION
`		***
`		***
`		***   INTRO SECTION HEADER
`		***
            `DECLARE VARIABLES

            `SCREEN DISPLAY
					cls 0
               ink rgb(255,255,255),0
               center text 320,240,"Super Fruit Vs. The Cavity"
               center text 320,260,"HIT ANY KEY TO BEGIN"
		do
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 1.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 2.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 3.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 4.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
				load bitmap "images/Tooth 5.jpg"
					if keystate( scancode() ) = 1 then goto IntroLoopSection
			sync
		loop
            `LOAD SOUNDS
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   INTRO SECTION LOOP
`     ***
			IntroLoopSection:
            do
               `SCREEN DISPLAY
               `CONTROL INPUT
                  if keystate( scancode() ) = 1 then goto OptionsSection
               `REFRESH SCREEN
                  sync
            loop
`  ***
`  ***   END INTRO SECTION
`  ***
`  *****************************************
`  ***
`  ***   START OPTIONS SECTION
`  ***
`     ***
`     ***   OPTIONS SECTION HEADER
`     ***
            OptionsSection:
            `DECLARE VARIABLES

`MyTimer / sync rate = seconds on timer (approx.)
MyTimer = 1500 
`How powerful gravity is
Gravity# = 1
`How strong the player can jump
MyPower = 10
`How fast the player can run
MySpeed = 9
`Starting score is 0
MyScore = 0
`Start without jumping or falling
MyAcceleration# = 0.0

               `Levels
                  TotalLevels = 1 : `Total number of levels
                  LevelNumber = 1 : `Start on Level 1
            `SCREEN DISPLAY
               cls 0
					Load Bitmap "images/Super Fruit vs The Cavity.bmp"
               ink rgb(255,255,255),0
               center text 320,260,"HIT THE SPACE BAR TO BEGIN"
            `LOAD SOUNDS
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   OPTIONS SECTION LOOP
`     ***
            do
               if scancode() = 0 then exit
            loop
            do
               `SCREEN DISPLAY
               `CONTROL INPUT
                  if spacekey()=1 then goto LevelIntroSection
               `REFRESH SCREEN
                  sync
            loop
`  ***
`  ***   END OPTIONS SECTION
`  ***
`  *****************************************
`  ***
`  ***   START LEVEL INTRO SECTION
`  ***
`     ***
`     ***   LEVEL INTRO SECTION HEADER
`     ***
            LevelIntroSection:
            `DECLARE VARIABLES
            `SCREEN DISPLAY
               cls 0
               ink rgb(255,255,255),0
               center text 320,220, "LEVEL"
               set cursor 320,240
               print LevelNumber
               center text 320,260, "HIT ANY KEY TO BEGIN"
            `LOAD SOUNDS
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   LEVEL INTRO SECTION LOOP
`     ***
            do
               if scancode() = 0 then exit
            loop
            do
               `SCREEN DISPLAY
               `CONTROL INPUT
                  if keystate( scancode() ) = 1 then goto MainSection
               `REFRESH SCREEN
                  sync
            loop
`  ***
`  ***   END LEVEL INTRO SECTION
`  ***
`  *****************************************
`  ***
`  ***   START MAIN SECTION
`  ***
`     ***
`     ***   MAIN SECTION HEADER
`     ***
            MainSection:
            `DECLARE VARIABLES
               `Player Character
               `Projectiles
               `Enemies
               `Other
            `LOAD IMAGES
load image "Super Fruit.bmp",1
load image "cave02.bmp",2
load image "steel01.bmp",3
load image "rocky01.bmp",4


            `SCREEN DISPLAY
               cls 0
               backdrop on
               `TEXT
               `HEADS-UP DISPLAY (HUD)
            `OBJECT CREATION
               `World Map
` Walls

   ` North Wall
   make object box 2,2000,1000,10
   rotate object 2,0,0,0
   position object 2, 0,500,1005
   texture object 2,2

   ` East Wall
   make object box 3,2000,1000,10
   rotate object 3,0,90,0
   position object 3, 1005,500,0
   texture object 3,2

   ` South Wall
   make object box 4,2000,1000,10
   rotate object 4,0,180,0
   position object 4, 0,500,-1005
   texture object 4,2

   ` West Wall
   make object box 5,2000,1000,10
   rotate object 5,0,270,0
   position object 5, -1005,500,0
   texture object 5,2

` Floor
make object box 6,2000,1000,2000 : position object 6,0,-500,0 : color object 6,rgb(0,255,0)
make object collision box 6,-1000,-500,-1000,1000,500,1000,0
texture object 6,3

rem Steps
NumberOfSteps = 7
for t=0 to NumberOfSteps-1
   make object box t+7,50,10,50
   position object t+7,0,5+(t*20),100+(t*100)
	texture object t+7,4
   make object collision box t+7,-25,-5,-25,25,5,25,0


rem Fruits
NumberOfFruits = 20
FruitColor = 0
for t = 1 to NumberOfFruits

   if FruitColor = 0
      r = 255 : g = 0
   endif
   if FruitColor = 1
      r = 255 : g = 255
   endif
   if FruitColor = 2
      r = 0 : g = 255
   endif
   if FruitColor = 3
      r = 255 : g = 125
   endif
   FruitColor = FruitColor + 1
   if FruitColor = 4 then FruitColor = 0

   make object sphere t + NumberOfFruits ,50
   color object t + NumberOfFruits , rgb(r,g,0)
   position object t + NumberOfFruits ,Rnd(1900)-950,30,Rnd(1900)-950
   make object collision box t + NumberOfFruits ,-25,-25,-25,25,25,25,0
next t

rem Super Fruit
   make object sphere 8,100
   texture object 8,1
   position object 8 ,0,250,900
   make object collision box 100,-50,-50,-50,50,50,50,0

               `Player Character
                  make object cylinder 1,100
							texture object 1,1
            `LOAD MODELS
            `SET LIGHTS
            `SET CAMERA
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   MAIN SECTION LOOP
`     ***
            do
               if scancode() = 0 then exit
            loop
            do
               `SPECIAL EFFECTS
               `OBJECT ORIENTATIONS (Pre-Movement, Pre-Collision)
                  `Player Character
                     1pX# = object position X(1)
                     1pY# = object position Y(1)
                     1pZ# = object position Z(1)
                     1aX = object angle X(1)
                     1aY = object angle Y(1)
                     1aZ = object angle Z(1)
                  `Projectiles
                  `Enemies
               `LIVE SCREEN DISPLAY
                  `TEXT
                     center text 320,440,"USE ARROW KEYS TO MOVE   |   PRESS 'Q' TO QUIT"
                  `HUD
               `CONTROL INPUT
                  `Acceleration and Pitch
                     if Upkey()=1 then move object 1,10
                     if Downkey()=1 then move object 1,-10
                  `Turning and Banking
                     if Leftkey()=1 then Yrotate object 1,wrapvalue(1aY-5)
                     if Rightkey()=1 then Yrotate object 1,wrapvalue(1aY+5)
                  `Releasing Projectiles
                  `Quit Game
                     if Inkey$() = "q"
                        ClearWorld()
                        goto EndSection
                     endif
               `TRANSFORM OBJECTS
               `MOVE OBJECTS
                  `Player Character
                  `Projectiles
                  `Enemies
               `OBJECT ORIENTATIONS (Post-Movement, Pre-Collision)
                  `Player Character
                     new1pX# = object position X(1)
                     new1pY# = object position Y(1)
                     new1pZ# = object position Z(1)
                     new1aX = object angle X(1)
                     new1aY = object angle Y(1)
                     new1aZ = object angle Z(1)
                  `Projectiles
                  `Enemies
               `CHECK COLLISIONS
                  `Player Character
                     `Walls
                     `Pick-Ups
                     `Enemies
                  `Projectiles
                     `Walls
                     `Enemies
                  `Enemies
                     `Walls
               `OBJECT ORIENTATIONS (Post-Movement, Post-Collision)
                  `Player Character
                     1pX# = object position X(1)
                     1pY# = object position Y(1)
                     1pZ# = object position Z(1)
                     1aX = object angle X(1)
                     1aY = object angle Y(1)
                     1aZ = object angle Z(1)
                  `Projectiles
                  `Enemies
               `CHECK PLAYER EXPIRATION
               `MOVE CAMERA
               `MOVE LIGHT
               `REFRESH SCREEN
                  sync
            loop
`  ***
`  ***   STOP MAIN SECTION
`  ***
`  *****************************************
`  ***
`  ***   START END SECTION
`  ***
`     ***
`     ***   END SECTION HEADER
`     ***
            EndSection:
            `DECLARE VARIABLES
            `SCREEN DISPLAY
               cls 0
               ink rgb(255,255,255),0
               center text 320,220, "GAME OVER"
               center text 320,260, "PLAY AGAIN [Y/N]?"
            `SOUND EFFECTS
            `SPECIAL EFFECTS
            `REFRESH SCREEN
               sync
`     ***
`     ***   END SECTION LOOP
`     ***
            do
               if scancode() = 0 then exit
            loop
            do
            `CONTROL INPUT
               if Inkey$() = "y" then goto OptionsSection
               if Inkey$() = "n"
                  cls 0
                  end
               endif
            `REFRESH SCREEN
               sync
            loop
            end
`  ***
`  *** STOP END SECTION
`  ***
`  *****************************************
`  *****************************************
`  ***
`  ***   START FUNCTIONS
`  ***
`     ***
`     ***   CLEAR WORLD - ClearWorld
`     ***   Remove all existing 3D elements from world
`     ***
            function ClearWorld
               for x = 1 to 1000
                  if object exist(x) = 1 then delete object x
                  if matrix exist(x) = 1 then delete matrix x
                  if mesh exist(x) = 1 then delete mesh x
                  if light exist(x) = 1 then delete light x
                  if x <= 32
                     if animation exist(x) = 1 then delete animation x
                  endif
               next x
               `Static Objects
                  make object cube 1,5
                  make static object 1
                  delete object 1
                  delete static objects
               fog off
               backdrop off
               cls 0
            endfunction
`  ***
`  ***   STOP FUNCTIONS
`  ***
`***
`***  END PROGRAM
`***
`*****************************************
`*****************************************

When I run this code, it says "SYNTAX ERROR. NESTING ERROR AT LINE 422"
Your help is greatly appreciated, thank you to whoever can help

Back to top

Profile PM Email

Latch

17

Years of Service

User Offline

Joined: 23rd Jul 2006

Location:

Posted: 19th Jan 2011 22:08

Link

In this section:

+ Code Snippet

rem Steps
NumberOfSteps = 7
for t=0 to NumberOfSteps-1
   make object box t+7,50,10,50
   position object t+7,0,5+(t*20),100+(t*100)
   texture object t+7,4
   make object collision box t+7,-25,-5,-25,25,5,25,0

At around line 217 your for t has no next.

Enjoy your day.

Back to top

Profile PM

Libervurto

17

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 24th Jan 2011 21:01

Link

Hi Junebug,
Welcome to our little corner of the DB world.

I'd suggest using two spaces to indent rather than tabs.
I'd also suggest only indenting code inside a multi-line statement e.g.

+ Code Snippet

rem Say hi.
for x = 1 to 2
  print "Yo Junebug!"
next x

I understand it can be helpful to mark out different sections of code but I would recommend finding another way to do that rather than using indentation, otherwise your code starts spilling over the page.

Everything worthwhile requires effort.

Back to top

Profile PM Email

BN2 Productions

20

Years of Service

User Offline

Joined: 22nd Jan 2004

Location:

Posted: 24th Jan 2011 23:37

Link

Quote: "I understand it can be helpful to mark out different sections of code but I would recommend finding another way to do that rather than using indentation, otherwise your code starts spilling over the page.
"

Blank lines and REM commands work wonders for this. Sometimes just putting blank lines as physical separators can greatly increase readability of the code (though you don't really understand it much better, but that's what the REM's are for).

Great Quote:
"Time...LINE??? Time isn't made out of lines...it is made out of circles. That is why clocks are round!" -Caboose

Back to top

Profile PM

Junebug

13

Years of Service

User Offline

Joined: 19th Jan 2011

Location:

Posted: 28th Jan 2011 18:43

Link

Quote: "In this section:

+ Code Snippet
rem Steps
NumberOfSteps = 7
for t=0 to NumberOfSteps-1
make object box t+7,50,10,50
position object t+7,0,5+(t*20),100+(t*100)
texture object t+7,4
make object collision box t+7,-25,-5,-25,25,5,25,0

At around line 217 your for t has no next
"

yea thanks, but I had actually found that the same day I posted this.

Quote: "I'd also suggest only indenting code inside a multi-line statement e.g. + Code Snippet
rem Say hi.
for x = 1 to 2
print "Yo Junebug!"
next x

I understand it can be helpful to mark out different sections of code but I would recommend finding another way to do that rather than using indentation, otherwise your code starts spilling over the page.
"

yea I understand, that code is the template my teacher gave me in my video game design class, I just went with it.

Maybe someone can help me with collision boxes, it's really confusing me

+ Code Snippet

`Steps
NumberOfSteps = 8
for t=0 to NumberOfSteps-1
   make object box t+7,100,20,100
   position object t+7,0,5+(t*20),100+(t*100)
	texture object t+7,4
   make object collision box t+7,-50,-10,-50,50,10,50,0
next t

`Steps
NumberOfExtraSteps = 8
for g=0 to NumberOfExtraSteps-1
	make object box 700+g,100,20,100
	position object 700+g,60+(t*-20),3+(t*20),800
	texture object 700+g,4
	make object collision box 700+g,-50,-10,-50,50,10,50,0
	set object collision on 700+g
next g

I made the second set of stairs, yet only 1 stair appears. I'm making the 2nd set start at the top of the 1st set, but I want them to go negative on the x-axis, so going left, and going up like the first set but the collision box doesn't work

Back to top

Profile PM Email

Libervurto

17

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 29th Jan 2011 14:49

Link

Your teacher wrote that!?
Why do teachers still use capital letters and gotos everywhere?

Don't get me wrong, I'm sure your teacher is very knowledgeable but there are better ways to structure programs these days.

Everything worthwhile requires effort.

Back to top

Profile PM Email

Libervurto

17

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 29th Jan 2011 15:41 Edited at: 29th Jan 2011 16:40

Link

I don't know what you were trying to do here:

+ Code Snippet

do
  if keystate( scancode() ) = 1 then goto IntroLoopSection
  load bitmap "images/Tooth 1.jpg"
  if keystate( scancode() ) = 1 then goto IntroLoopSection
  load bitmap "images/Tooth 2.jpg"
  if keystate( scancode() ) = 1 then goto IntroLoopSection
  load bitmap "images/Tooth 3.jpg"
  if keystate( scancode() ) = 1 then goto IntroLoopSection
  load bitmap "images/Tooth 4.jpg"
  if keystate( scancode() ) = 1 then goto IntroLoopSection
  load bitmap "images/Tooth 5.jpg"
  if keystate( scancode() ) = 1 then goto IntroLoopSection
  sync
loop

Are you trying to give the user a choice of which bitmaps to load?
At the moment it will try to load each bitmap until you interrupt by pressing a key, or if you don't press a key it will loop and then try to load them again causing an error.

I'll be writing a lot of small bits of code below, I think it's easier to read short code without code boxes, so for those small snippets I will put ## at the start of the line to indicate that it is code.

Bitmaps
When you load a bitmap you must give it a number:

## load bitmap "images/Tooth 3.jpg",3

So now when we use bitmap 3, dark basic knows we are talking about Tooth 3.jpg. Note that I could give the bitmap any integer number I wanted, but using 3 makes it easier to remember that this refers to Tooth 3.

Since numbers are used to refer to media, we could also use variables to refer to them:

## tooth3 = 3
## load bitmap "images/Tooth 3.jpg", tooth3

We have to be careful not to change the value of tooth3 if we're going to use it in this way; unfortunately DB (dark basic) doesn't provide constants - like variables but once set they cannot be changed.
I rarely use this technique myself, but it might help if you have lots of media and find it hard to remember what each number refers to.

Keystate and Scancode
Your statement to check if any key is pressed is clever but can be simplified:

## if keystate( scancode() ) = 1 then goto IntroLoopSection

This returns the scancode of the input to the keystate function which then checks if that key is being pressed. But if scancode returns a value then the key it refers too IS being pressed! So all we really need to do is test whether scancode returns a value:

## if scancode() > 0 then goto IntroLoopSection

Conditional Loops
Your DO loop cycles until a condition is met for it to jump to the IntroLoopSection label.
If you want a loop to break or repeat depending on whether a condition is met, use one of the three conditional loops, which I will now explain.

The repeat-until loop executes the code between its opening and closing statements, evaluates the expression given to until, and if true, breaks out of the loop and continues down the program.
Summary: a repeat-until loop repeats until the condition is true.

The while-endwhile loop tests its condition first and ONLY executes the code between the statements if the condition is true. Once it reaches the endwhile it loops back to the top and evaluates the condition again.
Summary: a while loop repeats while the condition is still true.

The for-next adjusts a counter variable until it is outside the limit you have assigned to the loop. For loops are actually just a type of while loop but using counters is so common that for loops are given their own special syntax. Here's a for loop:

+ Code Snippet

for x = 1 to 10
  print x
next x

and here's the same thing written as a while loop:

+ Code Snippet

while x<11
  print x
  x=x+1
endwhile

So you see FOR loops make this common task easier.

Back To The Code
Here's an edited version of your loop using everything I've explained (now we know that trying to load the same media twice causes an error I've moved the loading outside the loop).

+ Code Snippet

load bitmap "images/Tooth 1.jpg", 1
load bitmap "images/Tooth 2.jpg", 2
load bitmap "images/Tooth 3.jpg", 3
load bitmap "images/Tooth 4.jpg", 4
load bitmap "images/Tooth 5.jpg", 5

rem wait for key press
repeat
  print "Press any key to continue"
  sync
  cls
until scancode()>0

rem === INTRO ===
print "Intro Loop Section"
print "Since we now have a conditional loop we don't need a label to jump to."
sync

Hope that helps you.

Everything worthwhile requires effort.

Back to top

Profile PM Email

Junebug

13

Years of Service

User Offline

Joined: 19th Jan 2011

Location:

Posted: 29th Jan 2011 22:12

Link

Quote: "Your teacher wrote that!?
Why do teachers still use capital letters and gotos everywhere?

Don't get me wrong, I'm sure your teacher is very knowledgeable but there are better ways to structure programs these days."

Yea, we're making this game in only 4 weeks or so, it's not like it's gonna matter how it's written, as long as it works.

Quote: "I don't know what you were trying to do here:
+ Code Snippet
Are you trying to give the user a choice of which bitmaps to load?
At the moment it will try to load each bitmap until you interrupt by pressing a key, or if you don't press a key it will loop and then try to load them again causing an error.
"

It's actually not creating an error, it's like an artificial .gif in the game, its just a loading screen but since I couldn't figure out how to insert a .gif file, I just put in each image individually and then made them load sequentially over and over until any key is pressed, if u run the code I have, it looks like a .gif of those 5 images.

And again, I'm not concerned with how my coding looks, I asked about those collision boxes, can you please help me with those sir?

Back to top

Profile PM Email

Libervurto

17

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 29th Jan 2011 22:43 Edited at: 29th Jan 2011 23:28

Link

Quote: "it's not like it's gonna matter how it's written, as long as it works."

Often these are one and the same thing, problems like your nesting error might have been easier to find if your program was easier to read.

Quote: "It's actually not creating an error, it's like an artificial .gif in the game, its just a loading screen"

Oh I see, sorry it has been a while since I used bitmaps and I forgot it pastes to screen if no number is given.
In that case you could do it like this:

+ Code Snippet

load bitmap "images/Tooth 1.jpg", 1
load bitmap "images/Tooth 2.jpg", 2
load bitmap "images/Tooth 3.jpg", 3
load bitmap "images/Tooth 4.jpg", 4
load bitmap "images/Tooth 5.jpg", 5

rem Loading screen
repeat
  for bmp = 1 to 5
    rem copy bitmap to screen (bitmap 0)
    copy bitmap bmp,0
    print "Press any key to continue"
    if scancode()>0 then bmp=8
    sync:cls
  next bmp
until bmp=9

I used a trick to exit both loops by changing one variable. When a key is pressed I force it to equal 8 (it is then incremented to 9 by NEXT bmp), we know it would only ever naturally equal 1-6 (remember the for loop only exits when bmp is outside the range so it would be 6 after the for loop) so we can be confident that if bmp is equal to any value outside the range 1-6 it must have been tampered with, in this case we know that a key has been pressed.

I haven't gotten your code working yet but when I do I'll see if I can give you some help with your collision boxes, unless another helpful soul comes along first.

[edit]

## make object sphere 8,100
## position object 8 ,0,250,900
## make object collision box 100,-50,-50,-50,50,50,50,0

Shouldn't that be 8 as well?

[edit]

The RGB command is quite slow so if you can it is best to store colour values outside the loop

+ Code Snippet

  rem store fruit colours
  red = rgb(255,0,0)
  orange = rgb(255,125,0)
  yellow = rgb(255,255,0)
  green = rgb(0,255,0)

  rem Fruits
  NumberOfFruits = 20
  FruitColor = 0

  for t = 1 to NumberOfFruits
    if FruitColor = 0 then colour = red
    if FruitColor = 1 then colour = yellow
    if FruitColor = 2 then colour = green
    if FruitColor = 3 then colour = orange
    FruitColor = FruitColor + 1
    if FruitColor = 4 then FruitColor = 0

    make object sphere t+NumberOfFruits ,50
    color object t+NumberOfFruits ,colour
    position object t+NumberOfFruits ,Rnd(1900)-950,30,Rnd(1900)-950
    make object collision box t + NumberOfFruits ,-25,-25,-25,25,25,25,0
  next t

Everything worthwhile requires effort.

Back to top

Profile PM Email

Junebug

13

Years of Service

User Offline

Joined: 19th Jan 2011

Location:

Posted: 30th Jan 2011 00:02

Link

Quote: "In that case you could do it like this:
+ Code Snippet"

I thank you for that

Quote: "
[edit]

## make object sphere 8,100
## position object 8 ,0,250,900
## make object collision box 100,-50,-50,-50,50,50,50,0

Shouldn't that be 8 as well?
"

yes, understand that I'm going through my code and changing things, cleaning it up, everyday, so I have indeed fixed that, it is now
## make object sphrer 200,100
## position object 200,0,250,900
## make object collision box 200,-50,-50,-50,50,50,50,0

Thank you for all your help, I appreciate it. Let me know when you have these collision box codes figured out, I'm depending on them by next Friday.

Back to top

Profile PM Email

Libervurto

17

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 30th Jan 2011 00:13

Link

Good job

Quote: "Let me know when you have these collision box codes figured out, I'm depending on them by next Friday."

What are you having trouble with? Do you have a book to learn from?

Everything worthwhile requires effort.

Back to top

Profile PM Email

Junebug

13

Years of Service

User Offline

Joined: 19th Jan 2011

Location:

Posted: 30th Jan 2011 00:45

Link

Quote: "Quote: "Let me know when you have these collision box codes figured out, I'm depending on them by next Friday."
What are you having trouble with? Do you have a book to learn from?"

afraid not, I have no clue how the codes work besides that the first 3 are the bottom front left corner of the 3D object and the next three are the top back right corner of the 3D object

Back to top

Profile PM Email

Libervurto

17

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 30th Jan 2011 12:22

Link

Quote: "I have no clue how the codes work besides that the first 3 are the bottom front left corner of the 3D object and the next three are the top back right corner of the 3D object"

Yeah that's right, and the last parameter is a flag to tell DB if you want the collision box to rotate with the object (set it to 1 for yes or 0 for no).
All this does is set up a collision box, it wont automatically deal with collisions. For that we need to use the OBJECT COLLISION command.

Do you have access to the help files? If not I have attached them to this post for you to download. --->

Everything worthwhile requires effort.

Attachments

Login to view attachments

Back to top

Profile PM Email

Junebug

13

Years of Service

User Offline

Joined: 19th Jan 2011

Location:

Posted: 31st Jan 2011 18:36

Link

I have access to the help files, they're in the help tab at the top, I really cannot figure out how to get the collision box to work with my steps

+ Code Snippet

`Steps
NumberOfExtraSteps = 8
for g=0 to NumberOfExtraSteps-1
	make object box 700+g,100,20,100
	position object 700+g,60+(t*-20),3+(t*20),800
	texture object 700+g,4
	make object collision box 700+g,-50,-10,-50,50,10,50,0
	set object collision on 700+g
next g

It's really confusing, plus I can only get 1 of those steps to appear.

Back to top

Profile PM Email

Libervurto

17

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 31st Jan 2011 19:31

Link

You seem to have changed the t's to g's and missed the ones in the position object parameters. That's why you only see one step, it is actually all 7 in the same position.

Have you looked up OBJECT COLLISION() in the help files? You need to use that command to test for collisions between objects.

Everything worthwhile requires effort.

Back to top

Profile PM Email

Junebug

13

Years of Service

User Offline

Joined: 19th Jan 2011

Location:

Posted: 31st Jan 2011 20:01

Link

Quote: "You seem to have changed the t's to g's"

wow, I cannot believe I did that.. well, there's still the issue of the collision box not working for those steps

+ Code Snippet

`Steps
NumberOfExtraSteps = 8
for g=0 to NumberOfExtraSteps-1
	make object box 700+g,100,20,100
	make object collision box 700+g,-50,-10,-50,50,10,50,0
	position object 700+g,-60+(g*-100),145+(g*20),800
	texture object 700+g,4
next g

the collision box should work, why isn't it?

Back to top

Profile PM Email

Sorry your browser is not supported!

DarkBASIC Discussion / Can anyone spot my NESTING ERROR?

Attachments