Simple terrain gen problems - GameCreators Forum

Author

Message

Satchmo

21

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 31st Jan 2011 20:51 Edited at: 31st Jan 2011 20:52

Link

So I came across this easy method of generating terrain through code, here, and have spent a bit of time putting it into dbp. I've been having some erratic behaviour with it however, and I can't seem to get it functioning properly. No matter what I set the terrain height min/max "Rlimit" to, all the values end up being very close to zero, with the odd outlier being around 10 or 15 or so, even if all the values around it are near zero. I'm also having some issues with all the values right on the bottom being exactly zero. One again the site I'm using is http://www.gameprogrammer.com/fractal.html.

Rem Project: terraingen
Rem Created: Sunday, January 30, 2011

Rem ***** Main Source File *****
Rem ***** Included Source File *****

Rem initialize
randomize timer()
set display mode 1650,768,32

Rem some variables
`Arrays
dim land#(33,33)

`Single
scounter=1 :`number of squares in the grid so far
lcounter = 1 :`square root of scounter
Roughness# = 0.5 :`How rough the terrain should be
rlimit# = 20.0 :`The min/max height value(max/min would be rlimit/2)
slen = 32 :`How many "squares" in a grid, this is one less than the array values 33-32

`Genrate a seed vaulue in the middle
land#(17,17) = (rnd(rlimit#)-(rlimit#/2))
rlimit# = rlimit#*Roughness#

for n = 1 to 5

Rem -------do a diamond pass
  for x = 1 to sqrt(scounter)
   for y = 1 to sqrt(scounter)

land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2)) = (land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land#(slen/scounter*x,slen/lcounter*y-(slen/scounter))+land#(slen/lcounter*x,slen/lcounter*y))/slen + (rnd(rlimit#)-(rlimit#/2))

next y
  next x

Rem  -------do a square pass
 `Do the vertical squares first
  for x = 1 to lcounter
   for y = 1 to lcounter+1

if y = 1
      land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter/2),slen-(slen/lcounter/2)))/slen + (rnd(rlimit#)-(rlimit#/2))
    endif

if y = (sqrt(scounter)+1) :`check if the point is on the far edge
      land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land#(slen/lcounter*x-(slen/lcounter/2),(slen/lcounter/2))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-((slen/lcounter)+(slen/lcounter/2))))/slen + (rnd(rlimit#)-(rlimit#/2))
    endif

if y>1 and y< lcounter+1 :`if point is on the close edge
      land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-((slen/lcounter)+(slen/lcounter/2))))/slen + (rnd(rlimit#)-(rlimit#/2))
    endif

next y
  next x
  
  `horizontal ones
  for x = 1 to lcounter+1
   for y = 1 to lcounter

if x=1
       land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen-(slen/lcounter/2) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit#)-(rlimit#/2))
     endif
     
     if x = lcounter+1
       land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land#((slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-((slen/lcounter) + (slen/lcounter/2)) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit#)-(rlimit#/2))
     endif
     
     if x>1 and x<lcounter+1
       land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-((slen/lcounter) + (slen/lcounter/2)) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit#)-(rlimit#/2))
     endif

next y
  next x

scounter = 2^(n*2) :`Number of squares can be derived from the number of passes
  lcounter = sqrt(scounter) :`length of sides can be derived from the square root of the number of squares
  rlimit# = rlimit#*Roughness# : `reduce the limit based on the roughness value

next n

Rem --------Print the results
cls
for y = 1 to 33
   for x = 1 to 33

set cursor x*70,y*15

print land#(x,y)

next y
next x

sync
suspend for key

+ Code Snippet


Rem Project: terraingen
Rem Created: Sunday, January 30, 2011

Rem ***** Main Source File *****
Rem ***** Included Source File *****

Rem initialize
randomize timer()
set display mode 1650,768,32

Rem some variables
`Arrays
dim land#(33,33)

`Single
scounter=1 :`number of squares in the grid so far
lcounter = 1 :`square root of scounter
Roughness# = 0.5 :`How rough the terrain should be
rlimit# = 20.0 :`The min/max height value(max/min would be rlimit/2)
slen = 32 :`How many "squares" in a grid, this is one less than the array values 33-32

`Genrate a seed vaulue in the middle
land#(17,17) = (rnd(rlimit#)-(rlimit#/2))
rlimit# = rlimit#*Roughness#

for n = 1 to 5

Rem -------do a diamond pass
  for x = 1 to sqrt(scounter)
   for y = 1 to sqrt(scounter)

     land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2)) = (land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land#(slen/scounter*x,slen/lcounter*y-(slen/scounter))+land#(slen/lcounter*x,slen/lcounter*y))/slen + (rnd(rlimit#)-(rlimit#/2))

   next y
  next x

Rem  -------do a square pass
 `Do the vertical squares first
  for x = 1 to lcounter
   for y = 1 to lcounter+1

    if y = 1
      land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter/2),slen-(slen/lcounter/2)))/slen + (rnd(rlimit#)-(rlimit#/2))
    endif

    if y = (sqrt(scounter)+1) :`check if the point is on the far edge
      land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land#(slen/lcounter*x-(slen/lcounter/2),(slen/lcounter/2))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-((slen/lcounter)+(slen/lcounter/2))))/slen + (rnd(rlimit#)-(rlimit#/2))
    endif

    if y>1 and y< lcounter+1 :`if point is on the close edge
      land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-((slen/lcounter)+(slen/lcounter/2))))/slen + (rnd(rlimit#)-(rlimit#/2))
    endif

   next y
  next x
  
  `horizontal ones
  for x = 1 to lcounter+1
   for y = 1 to lcounter

     if x=1
       land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen-(slen/lcounter/2) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit#)-(rlimit#/2))
     endif
     
     if x = lcounter+1
       land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land#((slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-((slen/lcounter) + (slen/lcounter/2)) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit#)-(rlimit#/2))
     endif
     
     if x>1 and x<lcounter+1
       land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land#(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land#(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land#(slen/lcounter*x-((slen/lcounter) + (slen/lcounter/2)) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit#)-(rlimit#/2))
     endif

    next y
  next x

  scounter = 2^(n*2) :`Number of squares can be derived from the number of passes
  lcounter = sqrt(scounter) :`length of sides can be derived from the square root of the number of squares
  rlimit# = rlimit#*Roughness# : `reduce the limit based on the roughness value

next n 


Rem --------Print the results
cls
for y = 1 to 33
   for x = 1 to 33

     set cursor x*70,y*15

     print land#(x,y)

   next y
next x

sync
suspend for key

Should compile right away, but watch the screen resolution. Anyone is welcome to use this code if we can figure it out btw.

Ty in advanced,
Satchmo

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 31st Jan 2011 23:58

Link

I'm not sure whether this is relevant but it would be safer to ensure that all your types match. For example, you have things like rnd(rlimit#) - but the rnd() command requires an integer argument not a float. The float might be correctly cast to an integer first but it's good practice to be safe.

Have you tried outputting intermediate values, or perhaps a smaller grid, to see where things first go wrong? Shouldn't take too long find the error yourself. For example, have you checked that you are using the correct locations in the array when you do the two main steps?

Back to top

Profile PM Email

Satchmo

21

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 1st Feb 2011 00:14

Link

I've gone through the locations a few times but it's possible I missed something, I'll try some experimenting on a smaller grid. Ty for the info about the rnd command I'll test that out.

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 1st Feb 2011 12:24 Edited at: 1st Feb 2011 13:02

Link

Post back if you're still stuck and I'll take a look.

I've successfully coded the diamond-square algorithm before so I ought to be able to spot the problem when I delve into it properly.

But you'll find it more satisfying if you fix it yourself - especially since you've done the main part of the code already.

Edit Couldn't resist taking a quick look.

I suggest you take a close look at your logic. Work carefully through your code for the case n = 1. Does it do what it's supposed to do? I believe it doesn't.

Back to top

Profile PM Email

Satchmo

21

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 1st Feb 2011 22:36 Edited at: 1st Feb 2011 22:39

Link

Ty for the support, I managed to "kind of" fix it and it is indeed very satisfying. But I'm still having a problem... I'm not sure whether it's a side effect of the diamond square algorithm or a problem in my code, but I'm getting this artifacts, odd bumps appearing in a pattern across my map. It's using minecraft-style blocks, and while the general terrain shape is there, something is a bit off.

Are these just a result of going from doubles to integers? Or a natural side effect of the algorithm? Or is my code off

Rem Project: terraingen
Rem Created: Sunday, January 30, 2011

Rem ***** Main Source File *****
Rem ***** Included Source File *****

Rem initialize
randomize timer()
set display mode 1650,768,32

Rem some variables
`Arrays
dim land(17,17)

`Single
scounter=1 :`number of squares in the grid so far
lcounter = 1 :`square root of scounter
Roughness# = 0.20 :`How rough the terrain should be
rlimit = 30 :`The min/max height value(max/min would be rlimit/2)
slen = 16 :`How many "squares" in a grid, this is one less than the array values 33-32

`Genrate a seed vaulue in the middle
`land(9,9) = (rnd(rlimit)-(rlimit/2))
`rlimit = rlimit*Roughness

for n = 1 to 4

Rem -------do a diamond pass
  for x = 1 to lcounter
   for y = 1 to lcounter
   
`     land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2)) = (land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land(slen/scounter*x,slen/lcounter*y-(slen/scounter))+land(slen/lcounter*x,slen/lcounter*y))
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4 + (rnd(rlimit)-(rlimit/2))
   next y
  next x
       
          
Rem  -------do a square pass
 `Do the vertical squares first
  for x = 1 to lcounter
   for y = 1 to lcounter+1

if y = 1
`      land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter/2),slen-(slen/lcounter/2)))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,slen-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4 + (rnd(rlimit)-(rlimit/2))
    endif

if y = (lcounter+1) :`check if the point is on the far edge
 `     land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land(slen/lcounter*x-(slen/lcounter/2),(slen/lcounter/2))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-((slen/lcounter)+(slen/lcounter/2))))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-((slen/lcounter)+(slen/lcounter/2))+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4 + (rnd(rlimit)-(rlimit/2))

endif

if y>1 and y<lcounter+1 :`if point is on the close edge
 `     land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-((slen/lcounter)+(slen/lcounter/2))))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-((slen/lcounter)+(slen/lcounter/2))+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4 + (rnd(rlimit)-(rlimit/2))
    endif

next y
  next x
  
  `horizontal ones
  for x = 1 to lcounter+1
   for y = 1 to lcounter

if x=1
  `     land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen-(slen/lcounter/2) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(lcounter-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4 + (rnd(rlimit)-(rlimit/2))
     endif
     
     if x = lcounter+1
 `      land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land((slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-((slen/lcounter) + (slen/lcounter/2)) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land((slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4 + (rnd(rlimit)-(rlimit/2))
     endif
     
     if x>1 and x<lcounter+1
  `     land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-((slen/lcounter) + (slen/lcounter/2)) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit)-(rlimit/2))
    `  land((slen/lcounter*x)-(slen/lcounter/2),(slen/lcounter*y)) = 2
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4 + (rnd(rlimit)-(rlimit/2))
     endif

next y
  next x
  
 `  land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1) Above
 `  land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1) Below
`   land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) Right
 `  land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1) Left
  
 `  land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1) Above
 `  land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1) Below
 `  land((slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) Right
 `  land(lcounter-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) Left  
  
  
     
  scounter = 2^(n*2) :`Number of squares can be derived from the number of passes
  lcounter = sqrt(scounter) :`length of sides can be derived from the square root of the number of squares

rlimit = rlimit*Roughness# : `reduce the limit based on the roughness value

next n

Rem --------Print the results
cls
for y = 1 to 17
   for x = 1 to 17

set cursor x*60,y*15

print left$(str$(land(x,y)),5)

next y
next x

`set cursor 0,500
`print scounter
sync
suspend for key

+ Code Snippet

Rem Project: terraingen
Rem Created: Sunday, January 30, 2011

Rem ***** Main Source File *****
Rem ***** Included Source File *****

Rem initialize
randomize timer()
set display mode 1650,768,32

Rem some variables
`Arrays
dim land(17,17)

`Single
scounter=1 :`number of squares in the grid so far
lcounter = 1 :`square root of scounter
Roughness# = 0.20 :`How rough the terrain should be
rlimit = 30 :`The min/max height value(max/min would be rlimit/2)
slen = 16 :`How many "squares" in a grid, this is one less than the array values 33-32

`Genrate a seed vaulue in the middle
`land(9,9) = (rnd(rlimit)-(rlimit/2))
`rlimit = rlimit*Roughness

for n = 1 to 4

Rem -------do a diamond pass
  for x = 1 to lcounter
   for y = 1 to lcounter
   
`     land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2)) = (land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land(slen/scounter*x,slen/lcounter*y-(slen/scounter))+land(slen/lcounter*x,slen/lcounter*y))
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4 + (rnd(rlimit)-(rlimit/2))
   next y
  next x
       
          
Rem  -------do a square pass
 `Do the vertical squares first
  for x = 1 to lcounter
   for y = 1 to lcounter+1

    if y = 1
`      land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter/2),slen-(slen/lcounter/2)))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,slen-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4 + (rnd(rlimit)-(rlimit/2))
    endif

    if y = (lcounter+1) :`check if the point is on the far edge
 `     land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land(slen/lcounter*x-(slen/lcounter/2),(slen/lcounter/2))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-((slen/lcounter)+(slen/lcounter/2))))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-((slen/lcounter)+(slen/lcounter/2))+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4 + (rnd(rlimit)-(rlimit/2))

    endif

    if y>1 and y<lcounter+1 :`if point is on the close edge
 `     land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter)) = (land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x,slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-((slen/lcounter)+(slen/lcounter/2))))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-((slen/lcounter)+(slen/lcounter/2))+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4 + (rnd(rlimit)-(rlimit/2))
    endif

   next y
  next x
  
  `horizontal ones
  for x = 1 to lcounter+1
   for y = 1 to lcounter

     if x=1
  `     land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen-(slen/lcounter/2) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(lcounter-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4 + (rnd(rlimit)-(rlimit/2))
     endif
     
     if x = lcounter+1
 `      land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land((slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-((slen/lcounter) + (slen/lcounter/2)) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit)-(rlimit/2))
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land((slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4 + (rnd(rlimit)-(rlimit/2))
     endif
     
     if x>1 and x<lcounter+1
  `     land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter/2)) = (land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y-(slen/lcounter))+land(slen/lcounter*x-(slen/lcounter),slen/lcounter*y)+land(slen/lcounter*x-(slen/lcounter/2),slen/lcounter*y-(slen/lcounter/2))+land(slen/lcounter*x-((slen/lcounter) + (slen/lcounter/2)) ,slen/lcounter*y-(slen/lcounter/2)))/slen + (rnd(rlimit)-(rlimit/2))
    `  land((slen/lcounter*x)-(slen/lcounter/2),(slen/lcounter*y)) = 2
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4 + (rnd(rlimit)-(rlimit/2))
     endif

    next y
  next x
  
 `  land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1) Above
 `  land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1) Below
`   land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) Right
 `  land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1) Left
  
 `  land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1) Above
 `  land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1) Below
 `  land((slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) Right
 `  land(lcounter-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) Left  
  
  
     
  scounter = 2^(n*2) :`Number of squares can be derived from the number of passes
  lcounter = sqrt(scounter) :`length of sides can be derived from the square root of the number of squares

  rlimit = rlimit*Roughness# : `reduce the limit based on the roughness value

next n 


Rem --------Print the results
cls
for y = 1 to 17
   for x = 1 to 17

     set cursor x*60,y*15

     print left$(str$(land(x,y)),5)

   next y
next x

`set cursor 0,500
`print scounter
sync
suspend for key

This is just the terrain gen code with print out. I'll post the visualizer code if it makes it easier.

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 2nd Feb 2011 20:58 Edited at: 2nd Feb 2011 21:08

Link

Quote: "Are these just a result of going from doubles to integers? Or a natural side effect of the algorithm?"

I doubt it. I suspect a bug in the code but haven't found it yet. I'll keep looking.

Edit May have found it. I suspect you've converted to integers in the wrong place. The following code is a quick fix to your code and works with floats rather than integers:

Rem Project: terraingen
Rem Created: Sunday, January 30, 2011

Rem ***** Main Source File *****
Rem ***** Included Source File *****

Rem initialize
randomize timer()
set display mode desktop width(), desktop height(),32

Rem some variables
`Arrays
power = 8
arraySize = 2^power+1
dim land(arraySize,arraySize) as float ` change this to integer and see what happens

`Single
scounter=1 :`number of squares in the grid so far
lcounter = 1 :`square root of scounter
Roughness# = 0.20 :`How rough the terrain should be
rlimit = 30 :`The min/max height value(max/min would be rlimit/2)
slen = arraySize - 1 :`How many "squares" in a grid, this is one less than the array values 33-32

for n = 1 to power

Rem -------do a diamond pass
  for x = 1 to lcounter
   for y = 1 to lcounter
   
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
   next y
  next x
       
          
Rem  -------do a square pass
 `Do the vertical squares first
  for x = 1 to lcounter
   for y = 1 to lcounter+1

if y = 1
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,slen-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
    endif

if y = (lcounter+1) :`check if the point is on the far edge
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-((slen/lcounter)+(slen/lcounter/2))+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4.0 + (rnd(rlimit)-(rlimit/2))

endif

if y>1 and y<lcounter+1 :`if point is on the close edge
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-((slen/lcounter)+(slen/lcounter/2))+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
    endif

next y
  next x
  
  `horizontal ones
  for x = 1 to lcounter+1
   for y = 1 to lcounter

if x=1
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(lcounter-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
     endif
     
     if x = lcounter+1
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land((slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
     endif
     
     if x>1 and x<lcounter+1
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
     endif

next y
  next x
  
  scounter = 2^(n*2) :`Number of squares can be derived from the number of passes
  lcounter = sqrt(scounter) :`length of sides can be derived from the square root of the number of squares

rlimit = rlimit*Roughness# : `reduce the limit based on the roughness value

next n

Rem --------Print the results
cls
for y = 1 to arraySize
   for x = 1 to arraySize

set cursor x*60,y*15

`print left$(str$(land(x,y)),5)
 `    print " "+str$(land(x,y),2)
     red = max(0, min(255, int((land(x, y)+15.0)*(255.0/30.0))))
 `        print " "+str$(red)
     dot x, y, rgb(red, 0, 0)
   next y
next x

sync

repeat
until spacekey()

+ Code Snippet

Rem Project: terraingen
Rem Created: Sunday, January 30, 2011

Rem ***** Main Source File *****
Rem ***** Included Source File *****

Rem initialize
randomize timer()
set display mode desktop width(), desktop height(),32

Rem some variables
`Arrays
power = 8
arraySize = 2^power+1
dim land(arraySize,arraySize) as float ` change this to integer and see what happens

`Single
scounter=1 :`number of squares in the grid so far
lcounter = 1 :`square root of scounter
Roughness# = 0.20 :`How rough the terrain should be
rlimit = 30 :`The min/max height value(max/min would be rlimit/2)
slen = arraySize - 1 :`How many "squares" in a grid, this is one less than the array values 33-32

for n = 1 to power

Rem -------do a diamond pass
  for x = 1 to lcounter
   for y = 1 to lcounter
   
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
   next y
  next x
       
          
Rem  -------do a square pass
 `Do the vertical squares first
  for x = 1 to lcounter
   for y = 1 to lcounter+1

    if y = 1
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,slen-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
    endif

    if y = (lcounter+1) :`check if the point is on the far edge
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-((slen/lcounter)+(slen/lcounter/2))+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4.0 + (rnd(rlimit)-(rlimit/2))

    endif

    if y>1 and y<lcounter+1 :`if point is on the close edge
      land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter)+1) = (land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-((slen/lcounter)+(slen/lcounter/2))+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)+1,(slen/lcounter*y)-(slen/lcounter)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
    endif

   next y
  next x
  
  `horizontal ones
  for x = 1 to lcounter+1
   for y = 1 to lcounter

     if x=1
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(lcounter-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
     endif
     
     if x = lcounter+1
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land((slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
     endif
     
     if x>1 and x<lcounter+1
      land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter/2)+1) = (land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)-(slen/lcounter)+1)+land(((slen/lcounter)*x)-(slen/lcounter)+1,(slen/lcounter*y)+1)+land(((slen/lcounter)*x)-(slen/lcounter/2)+1,(slen/lcounter*y)-(slen/lcounter/2)+1)+land(((slen/lcounter)*x)-((slen/lcounter)+(slen/lcounter/2))+1,(slen/lcounter*y)-(slen/lcounter/2)+1))/4.0 + (rnd(rlimit)-(rlimit/2))
     endif

    next y
  next x
  
  scounter = 2^(n*2) :`Number of squares can be derived from the number of passes
  lcounter = sqrt(scounter) :`length of sides can be derived from the square root of the number of squares

  rlimit = rlimit*Roughness# : `reduce the limit based on the roughness value

next n 


Rem --------Print the results
cls
for y = 1 to arraySize
   for x = 1 to arraySize

     set cursor x*60,y*15

     `print left$(str$(land(x,y)),5)
 `    print " "+str$(land(x,y),2)
     red = max(0, min(255, int((land(x, y)+15.0)*(255.0/30.0))))
 `        print " "+str$(red)
     dot x, y, rgb(red, 0, 0)
   next y
next x

sync

repeat
until spacekey()

The above code produces a 256x256 red scale image of your terrain. If you change the type of the "land" array to integer you'll see what goes wrong. That may be part of your problem.

You'll probably notice some strange peaks and hollows. That may be a feature of the basic diamond-square algorithm but could also be the scaling I've used. I didn't try to improve that.

Back to top

Profile PM Email

Satchmo

21

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 3rd Feb 2011 02:12

Link

Yup you were right and it works perfectly if I convert it to integers afterwards. Though my problem is fixed I couldn't get your code running, some sort of problem with min max. Are they variables or functions or commands?

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 3rd Feb 2011 02:55

Link

Quote: "some sort of problem with min max"

Oops. Sorry. They are two functions from IanM's indispensible Matrix1 plug-ins. They just return the max and min of their arguments so max(0, -1) is just 0, etc. I've used them to keep the colour values in the range 0 to 255.

Back to top

Profile PM Email

omegafold

15

Years of Service

User Offline

Joined: 12th Jan 2011

Location:

Posted: 3rd Feb 2011 06:37

Link

Random terrain?
I just saw this post and thought I might suggest one possibility;
instead of using a fractal/ rnd generator, I have made random landscapes using blender 2.49b; you just make a plane or cube or whatever and then hotkey w to subdivide then move just 2 or 3 points around then subdivide multiple. I found it handy since you can also use the hotkey 'K' to cut sections any way you like, even drawing a line by hand through lots of points. If you click on the mesh tab you can also cut down the polygons using a mesh reducer or something. Tons of landscapes are possible. My fav trick is to make a sharp overhanding cliff or 2 and then hit W then 'smooth' option a few times.
I'm still waiting to see direct x 11 export ability for blender b4 I get this dark basic pro.

Back to top

Profile PM Email

Satchmo

21

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 4th Feb 2011 03:52 Edited at: 4th Feb 2011 03:53

Link

New problem! Okay so to reduce lag I've been combining the objects into 9x9 chunks, and laying them out as such. The chunks come out alright but I cant seem to get the height working. I think it's something to do with the positioning being screwed up when I convert from mesh to object.

+ Code Snippet

Rem Generate chunks to combine several objects into 1

rem add limbs
cc=0
obj = 400

rem make a mesh of the cube object for adding limbs
make mesh from object 2,25

for h = 1 to 16
 for n = 1 to 16

   rem make core object
   make object plain obj,0,0
   cc = 0
   
   for x = 1 to 8
    for z = 1 to 8
       for y = 1 to 128  

          if terrain(h*8-8+x,n*8-8+z,y).otype = 1
            cc=cc+1 
            add limb obj,cc,2    
            offset limb obj,cc,x,y,z
            
          endif
          
        next y
      
    next y
   next x
`delete mesh 1

rem make core object with limbs into one mesh
make mesh from object 1,obj
delete object obj
make object obj,1,1 : rem the last integer specifies the image to texture the object with
position object obj,h*8-7,0,n*8-7
rem apply attributes
`set object filter obj,0
`sc_setupObject obj,1,2   
    
  obj = obj + 1
 
 next n
next h

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 4th Feb 2011 13:05

Link

I think we need more details.

At first sight your code seems to be making a 16x16 array of objects with each object consisting of up to 8x8x128 = 8192 limbs. Reading between the lines these limbs are cubes stacked on top of each other subject to the value of terrain(h*8-8+x,n*8-8+z,y).otype. However you give no details about that array so it's hard for us to comment.

In this sort of situation I'd work carefully through a much smaller array and see where exactly things go wrong.

Am I right in thinking that it's just the y offset that's wrong?

Actually, the usual order is x, y, z. Is that change deliberate in the terrain array, i.e. x, z, y?

Back to top

Profile PM Email

markostalin

15

Years of Service

User Offline

Joined: 4th Feb 2011

Location:

Posted: 4th Feb 2011 13:18

Link

Where have you get these photos from these are huge

havaianas

Back to top

Profile PM

Satchmo

21

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 4th Feb 2011 22:13

Link

I am splitting the terrain into a 16x16 grid with each chunk consisting of 8x8 cubes. The physical appearance of the terrain isn't supposed to be any different than before, it's just less objects. The xzy thing is indeed deliberate because I wanted to have x,z,height it just seemed a bit easier but you;re right it's confusing.

The y offset should not be wrong, because for each chunk I create a plain object and offset the cubes from that plain by their height. So each chunk by itself is correct but something seems to happen

+ Code Snippet

rem make core object with limbs into one mesh
make mesh from object 1,obj
delete object obj
make object obj,1,1 : rem the last integer specifies the image to texture the object with
position object obj,h*8-7,0,n*8-7

right there, almost as if some object info is changed or the pivot point is changed or something, which is what makes this problem so confusing.

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 4th Feb 2011 22:40

Link

Are you sure it's the heights that are wrong? Also, are they consistently wrong in some way?

Are you using the correct vertical scale? Could that be the problem?

Back to top

Profile PM Email

Satchmo

21

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 4th Feb 2011 23:58

Link

The height of the chunks seems to be wrong consistently, in that the height of the chunks itself seems to be the opposite of where it should be, (I.e) two pieces of a hill would be at 2 4 instead of 4 2) so you see the hill break in half and go lower even while the chunks themselves show the hill should be going upwards). I'm trying to see if the offsetting has anything to do with this or not.

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 5th Feb 2011 00:28 Edited at: 5th Feb 2011 00:45

Link

That sounds like it's nothing to do with the heights or the offsets as such.

Have you checked that you've been consistent with your use of the x and z coordinates?

Edit As a guess I'd look at the way z varies in your terrain array. Does increasing the z index correspond to decreasing the world z coordinate? That would happen if x and z match the U and V coordinates of a bitmap for example. If so then that would cause your problem. Just change the direction of the z offsets to fix this.

Back to top

Profile PM Email

Satchmo

21

Years of Service

User Offline

Joined: 29th May 2005

Location:

Posted: 5th Feb 2011 04:37

Link

Thanks for the help. Turned out not to be a height issue at all I simply was mis using the offset limb command, just needed to invert the offset value.

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 5th Feb 2011 13:26

Link

Yes.

Back to top

Profile PM Email

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Simple terrain gen problems