Function Error - GameCreators Forum

Author

Message

luma

13

Years of Service

User Offline

Joined: 8th Mar 2011

Location: Porto, Portugal

Posted: 9th Mar 2011 00:05

Link

Hi,

I'm new on this and i have a problem with a function that a cant figure it out.

I have this function that creates a ball every time the main loop do a pass.

+ Code Snippet

function ball(n)
        make object sphere n,2 
        xrotate object n,90
        fix object pivot n    
        position object n,rnd(150-50)+50,50,rnd(150-50)+50        
        color object n,rgb(rnd(150),30,30)
        AI Add Enemy n
        AI Set Entity Speed n,rnd(25-10)+10 
ENDFUNCTION

this function have a n=1 before the loop and a n=n+1 inside the loop after a call the function ball(n).
And i have the following error - The name 'ball' duplicated in the program at line 276.

any ideas about what is wrong?

tyvm
luma

Back to top

Profile PM

Lucas Tiridath

AGK Developer

16

Years of Service

User Offline

Joined: 28th Sep 2008

Location: Kings Langley, UK

Posted: 9th Mar 2011 11:24

Link

Could you post the rest of your code? I can't immediately see from this what the problem is although someone else might be able to.

Back to top

Profile PM Email Website

luma

13

Years of Service

User Offline

Joined: 8th Mar 2011

Location: Porto, Portugal

Posted: 9th Mar 2011 11:53

Link

Sure, here:

cls
set display mode 1280,800,32

set window off

sync on
sync rate 0

hide mouse

//timer
init_time#=timer()/1000
time#=init_time#

//camera player 1
        make camera 1
        position camera 1,0,75,0 : point camera 1,0,0,0

//player
        make object sphere 10,2
        color object 10,rgb (255,255,255)
//o chão
        make object box 11,150,1,150
        position object 11,0,0,0
        color object 11,rgb (50,50,50)
       
//balls of fire

AI Start
AI Set Radius 1

//balls

function ball(n)
            make object sphere n,2
            xrotate object n,90
            fix object pivot n   
            position object n,rnd(150),50,rnd(150)       
            color object n,rgb(rnd(100),50,50)
        AI Add Enemy n
        AI Set Entity Speed n,rnd(30)  
endfunction

set object collision to spheres 10
   
//GAME LOOP
	
	n=1

do

ball(n)

n=n+1

//posição player 1    
    pick screen mousex(),mouseY(),50
    vectorx# = get pick vector x()
    vectory# = get pick vector y()
    vectorz# = get pick vector z()
    distancey# = -camera position y()*50/vectory#
    vectorx# = vectorx#*distancey# + camera position x()
    vectorz# = vectorz#*distancey# + camera position z()
    position object 10,vectorx#,50,vectorz#+3
 
//movimento ball of fire      
        AI Entity Go To Position 1,object position x (10),object position z (10)
        AI Entity Go To Position 2,object position x (10),object position z (10)
        AI Entity Go To Position 3,object position x (10),object position z (10)
        AI Entity Go To Position 4,object position x (10),object position z (10)
        AI Entity Go To Position 5,object position x (10),object position z (10)
        AI Entity Go To Position 6,object position x (10),object position z (10)
        AI Entity Go To Position 7,object position x (10),object position z (10)
        AI Entity Go To Position 8,object position x (10),object position z (10)
        AI Entity Go To Position 9,object position x (10),object position z (10)

AI Update
       
//collision    
        If Object collision(10,1)>0 then goto _JA_FOSTE
        If Object collision(10,2)>0 then goto _JA_FOSTE
        If Object collision(10,3)>0 then goto _JA_FOSTE
        If Object collision(10,4)>0 then goto _JA_FOSTE
        If Object collision(10,5)>0 then goto _JA_FOSTE
        If Object collision(10,6)>0 then goto _JA_FOSTE
        If Object collision(10,7)>0 then goto _JA_FOSTE
        If Object collision(10,8)>0 then goto _JA_FOSTE
        If Object collision(10,9)>0 then goto _JA_FOSTE

//timer
          // set text transparent
           SET TEXT FONT "verdana"
           SET TEXT SIZE 50
           ink rgb(200,200,200),rgb(0,0,0)
  
  
    `collect updated time
    time#=timer()/1000-init_time#
    `to make it count down from a value just minus time from that value
    time#=60-time#
    `convert to minuits and seconds
    sec=floor(time#-min*60)
    center text 620,25,str$(sec)

sync

loop

//JA FOSTE   
_JA_FOSTE:

SET TEXT FONT "verdana"
        SET TEXT SIZE 50
            ink rgb(170,30,30),rgb(0,0,0)
            center text 620,400,"GAME OVER"   
    sync
        wait key
        cls
    end

+ Code Snippet

cls
set display mode 1280,800,32

set window off

sync on
sync rate 0

hide mouse

//timer
init_time#=timer()/1000
time#=init_time#

//camera player 1
        make camera 1
        position camera 1,0,75,0 : point camera 1,0,0,0

//player
        make object sphere 10,2
        color object 10,rgb (255,255,255)
//o chão
        make object box 11,150,1,150
        position object 11,0,0,0
        color object 11,rgb (50,50,50)
       
//balls of fire

AI Start
AI Set Radius 1

        //balls

function ball(n)
            make object sphere n,2
            xrotate object n,90
            fix object pivot n   
            position object n,rnd(150),50,rnd(150)       
            color object n,rgb(rnd(100),50,50)
        AI Add Enemy n
        AI Set Entity Speed n,rnd(30)  
endfunction

set object collision to spheres 10
   
//GAME LOOP
	
	n=1

    do

	ball(n)

	n=n+1

//posição player 1    
    pick screen mousex(),mouseY(),50
    vectorx# = get pick vector x()
    vectory# = get pick vector y()
    vectorz# = get pick vector z()
    distancey# = -camera position y()*50/vectory#
    vectorx# = vectorx#*distancey# + camera position x()
    vectorz# = vectorz#*distancey# + camera position z()
    position object 10,vectorx#,50,vectorz#+3
 
//movimento ball of fire      
        AI Entity Go To Position 1,object position x (10),object position z (10)
        AI Entity Go To Position 2,object position x (10),object position z (10)
        AI Entity Go To Position 3,object position x (10),object position z (10)
        AI Entity Go To Position 4,object position x (10),object position z (10)
        AI Entity Go To Position 5,object position x (10),object position z (10)
        AI Entity Go To Position 6,object position x (10),object position z (10)
        AI Entity Go To Position 7,object position x (10),object position z (10)
        AI Entity Go To Position 8,object position x (10),object position z (10)
        AI Entity Go To Position 9,object position x (10),object position z (10)

        AI Update
       
//collision    
        If Object collision(10,1)>0 then goto _JA_FOSTE
        If Object collision(10,2)>0 then goto _JA_FOSTE
        If Object collision(10,3)>0 then goto _JA_FOSTE
        If Object collision(10,4)>0 then goto _JA_FOSTE
        If Object collision(10,5)>0 then goto _JA_FOSTE
        If Object collision(10,6)>0 then goto _JA_FOSTE
        If Object collision(10,7)>0 then goto _JA_FOSTE
        If Object collision(10,8)>0 then goto _JA_FOSTE
        If Object collision(10,9)>0 then goto _JA_FOSTE

//timer
          // set text transparent
           SET TEXT FONT "verdana"
           SET TEXT SIZE 50
           ink rgb(200,200,200),rgb(0,0,0)
  
  
    `collect updated time
    time#=timer()/1000-init_time#
    `to make it count down from a value just minus time from that value
    time#=60-time#
    `convert to minuits and seconds
    sec=floor(time#-min*60)
    center text 620,25,str$(sec)


    sync

        loop       

//JA FOSTE   
_JA_FOSTE:

        SET TEXT FONT "verdana"
        SET TEXT SIZE 50
            ink rgb(170,30,30),rgb(0,0,0)
            center text 620,400,"GAME OVER"   
    sync
        wait key
        cls
    end

here is the thing. All I want is to have a function that substitutes an old for/next:

+ Code Snippet

for n=1 to 9
            make object sphere n,2
            xrotate object n,90
            fix object pivot n   
            position object n,rnd(150),50,rnd(150)       
            color object n,rgb(rnd(100),50,50)
        AI Add Enemy n
        AI Set Entity Speed n,rnd(30)  
next n

with a function it will be more handy to build levels and so on.

Back to top

Profile PM

LBFN

17

Years of Service

User Offline

Joined: 7th Apr 2007

Location: USA

Posted: 9th Mar 2011 16:37 Edited at: 9th Mar 2011 16:39

Link

First off, your program runs into a function. Place all functions at the end of your code.

I would suggest that you create an additional function that will give you a unique object number every time. You will need a global variable to track it. Use

+ Code Snippet

 global CurrentObject : CurrentObject = 99

near the start of your code and code the function:

+ Code Snippet

function GetFreeObject()
    repeat
        inc CurrentObject
    until object exist(CurrentObject) = 0
endfunction CurrentObject

From within your do -loop, the call is made like this:

+ Code Snippet

n = GetFreeObject()
ball(n)

This way, you know that you will never create the same object twice. You should use the GetFreeObject() function for all of your objects in the game, not just the ones for your ball(n) function.

EDIT: Bear in mind that you will need to store the ball numbers in some way so that you can recall them for checking position, collision, etc. I would use TYPE variables myself, but you could use an array also.

Back to top

Profile PM Email

luma

13

Years of Service

User Offline

Joined: 8th Mar 2011

Location: Porto, Portugal

Posted: 12th Mar 2011 16:38

Link

Well i get the same error but now with the "GetFreeObject":
The name 'GetFreeObject' duplicated in the program at line 297.

Is there anything out of its place?

cls
set display mode 1280,800,32

set window off

sync on
sync rate 0

hide mouse

global CurrentObject
CurrentObject = 99

//timer
init_time#=timer()/1000
time#=init_time#

//camera player 1
        make camera 1
        position camera 1,0,75,0 : point camera 1,0,0,0

//player
        make object sphere 10,2
        color object 10,rgb (255,255,255)
//o chão
        make object box 11,150,1,150
        position object 11,0,0,0
        color object 11,rgb (50,50,50)
          
          
                
//balls of fire
 
AI Start
AI Set Radius 1
set object collision to spheres 10

n = GetFreeObject()

//GAME LOOP

do

ball(n)

//posição player 1     
    pick screen mousex(),mouseY(),50
    vectorx# = get pick vector x()
    vectory# = get pick vector y()
    vectorz# = get pick vector z()
    distancey# = -camera position y()*50/vectory#
    vectorx# = vectorx#*distancey# + camera position x() 
    vectorz# = vectorz#*distancey# + camera position z() 
    position object 10,vectorx#,50,vectorz#+3

//movimento ball of fire       
        AI Entity Go To Position 1,object position x (10),object position z (10)
        AI Entity Go To Position 2,object position x (10),object position z (10)
        AI Entity Go To Position 3,object position x (10),object position z (10)
        AI Entity Go To Position 4,object position x (10),object position z (10)
        AI Entity Go To Position 5,object position x (10),object position z (10)
        AI Entity Go To Position 6,object position x (10),object position z (10)
        AI Entity Go To Position 7,object position x (10),object position z (10)
        AI Entity Go To Position 8,object position x (10),object position z (10)
        AI Entity Go To Position 9,object position x (10),object position z (10)

AI Update
        
//collision     
        If Object collision(10,1)>0 then goto _JA_FOSTE
        If Object collision(10,2)>0 then goto _JA_FOSTE
        If Object collision(10,3)>0 then goto _JA_FOSTE
        If Object collision(10,4)>0 then goto _JA_FOSTE
        If Object collision(10,5)>0 then goto _JA_FOSTE
        If Object collision(10,6)>0 then goto _JA_FOSTE
        If Object collision(10,7)>0 then goto _JA_FOSTE
        If Object collision(10,8)>0 then goto _JA_FOSTE
        If Object collision(10,9)>0 then goto _JA_FOSTE

//timer
          // set text transparent
           SET TEXT FONT "verdana"
           SET TEXT SIZE 50
           ink rgb(200,200,200),rgb(0,0,0)
        
   
//collect updated time
    time#=timer()/1000-init_time#
//to make it count down from a value just minus time from that value
    time#=60-time#
//convert to minuits and seconds
    sec=floor(time#-min*60)
    center text 620,25,str$(sec)
        if sec=0
            center text 600,400,"TU É QUE CORRES..."
            sync
            wait key
            end
        endif

sync

loop

//JA FOSTE    
_JA_FOSTE:

SET TEXT FONT "verdana"
        SET TEXT SIZE 50
            ink rgb(170,30,30),rgb(0,0,0)
            center text 620,400,"JÁ FOSTE!"    
    sync
        wait key 
        cls
    end

function GetFreeObject()
    repeat
        inc CurrentObject
    until object exist(CurrentObject) = 0
endfunction CurrentObject

function ball(n)
        make object sphere n,2 
        xrotate object n,90
        fix object pivot n    
        position object n,rnd(150-50)+50,50,rnd(150-50)+50        
        color object n,rgb(rnd(150),30,30)
        AI Add Enemy n
        AI Set Entity Speed n,rnd(25-10)+10 
ENDFUNCTION

+ Code Snippet

cls
set display mode 1280,800,32

set window off

sync on
sync rate 0

hide mouse


global CurrentObject
CurrentObject = 99 




//timer
init_time#=timer()/1000
time#=init_time#


//camera player 1
        make camera 1
        position camera 1,0,75,0 : point camera 1,0,0,0

//player
        make object sphere 10,2
        color object 10,rgb (255,255,255)
//o chão
        make object box 11,150,1,150
        position object 11,0,0,0
        color object 11,rgb (50,50,50)
          
          
                
//balls of fire
 
AI Start
AI Set Radius 1
set object collision to spheres 10

n = GetFreeObject()

//GAME LOOP

        do

ball(n)


//posição player 1     
    pick screen mousex(),mouseY(),50
    vectorx# = get pick vector x()
    vectory# = get pick vector y()
    vectorz# = get pick vector z()
    distancey# = -camera position y()*50/vectory#
    vectorx# = vectorx#*distancey# + camera position x() 
    vectorz# = vectorz#*distancey# + camera position z() 
    position object 10,vectorx#,50,vectorz#+3
 

 
//movimento ball of fire       
        AI Entity Go To Position 1,object position x (10),object position z (10)
        AI Entity Go To Position 2,object position x (10),object position z (10)
        AI Entity Go To Position 3,object position x (10),object position z (10)
        AI Entity Go To Position 4,object position x (10),object position z (10)
        AI Entity Go To Position 5,object position x (10),object position z (10)
        AI Entity Go To Position 6,object position x (10),object position z (10)
        AI Entity Go To Position 7,object position x (10),object position z (10)
        AI Entity Go To Position 8,object position x (10),object position z (10)
        AI Entity Go To Position 9,object position x (10),object position z (10)

        AI Update
        
//collision     
        If Object collision(10,1)>0 then goto _JA_FOSTE
        If Object collision(10,2)>0 then goto _JA_FOSTE
        If Object collision(10,3)>0 then goto _JA_FOSTE
        If Object collision(10,4)>0 then goto _JA_FOSTE
        If Object collision(10,5)>0 then goto _JA_FOSTE
        If Object collision(10,6)>0 then goto _JA_FOSTE
        If Object collision(10,7)>0 then goto _JA_FOSTE
        If Object collision(10,8)>0 then goto _JA_FOSTE
        If Object collision(10,9)>0 then goto _JA_FOSTE

//timer
          // set text transparent
           SET TEXT FONT "verdana"
           SET TEXT SIZE 50
           ink rgb(200,200,200),rgb(0,0,0)
        
   
//collect updated time
    time#=timer()/1000-init_time#
//to make it count down from a value just minus time from that value
    time#=60-time#
//convert to minuits and seconds
    sec=floor(time#-min*60)
    center text 620,25,str$(sec)
        if sec=0
            center text 600,400,"TU É QUE CORRES..."
            sync
            wait key
            end
        endif

    sync

        loop        

//JA FOSTE    
_JA_FOSTE:

        SET TEXT FONT "verdana"
        SET TEXT SIZE 50
            ink rgb(170,30,30),rgb(0,0,0)
            center text 620,400,"JÁ FOSTE!"    
    sync
        wait key 
        cls
    end
   


function GetFreeObject()
    repeat
        inc CurrentObject
    until object exist(CurrentObject) = 0
endfunction CurrentObject

function ball(n)
        make object sphere n,2 
        xrotate object n,90
        fix object pivot n    
        position object n,rnd(150-50)+50,50,rnd(150-50)+50        
        color object n,rgb(rnd(150),30,30)
        AI Add Enemy n
        AI Set Entity Speed n,rnd(25-10)+10 
ENDFUNCTION

Back to top

Profile PM

LBFN

17

Years of Service

User Offline

Joined: 7th Apr 2007

Location: USA

Posted: 12th Mar 2011 17:55 Edited at: 13th Mar 2011 13:17

Link

Here is how you can use it effectively:

Rem Project: Dark Basic Pro Project
Rem Created: Saturday, March 12, 2011

Rem ***** Main Source File *****
cls
set display mode 1154,768,32
set window off
sync on
sync rate 0
hide mouse
GameOver = 0

global CurrentObject
CurrentObject = 99

//timer
init_time#=timer()/1000
time#=init_time#

//camera player 1
        make camera 1
        position camera 1,0,75,0 : point camera 1,0,0,0

//player
        player = GetFreeObject()
        make object sphere player,2
        color object player,rgb (255,255,255)
//o chão
        chao = GetFreeObject()
        make object box chao,150,1,150
        position object chao,0,0,0
        color object chao,rgb (50,50,50)
         
         
               
//balls of fire

AI Start
AI Set Radius 1
set object collision to spheres player

// create ten spheres
dim BallObjNum(9)
for k = 1 to 9
     n = GetFreeObject()
     BallObjNum(k) = n
     ball(n)
next k

//GAME LOOP

do

//posição player 1   
    pick screen mousex(),mouseY(),50
    vectorx# = get pick vector x()
    vectory# = get pick vector y()
    vectorz# = get pick vector z()
    distancey# = -camera position y()*50/vectory#
    vectorx# = vectorx#*distancey# + camera position x()
    vectorz# = vectorz#*distancey# + camera position z()
    position object player,vectorx#,50,vectorz#+3

//movimento ball of fire     
    for k = 1 to 9
        AI Entity Go To Position BallObjNum(k),object position x (player),object position z (player)
    next k
    AI Update
       
//collision   
        for k = 1 to 9
            if object collision(player,BallObjNum(k)) = 1 then goto _JA_FOSTE
        next k

//timer
          // set text transparent
          SET TEXT FONT "verdana"
          SET TEXT SIZE 50
          ink rgb(200,200,200),rgb(0,0,0)
       
 
//collect updated time
    time#=timer()/1000-init_time#
//to make it count down from a value just minus time from that value
    time#=60-time#
//convert to minuits and seconds
    sec=floor(time#-min*60)
    center text 620,25,str$(sec)
        if sec=0
            center text 600,400,"TU É QUE CORRES..."
            sync
            wait key
            end
        endif

sync

loop

//JA FOSTE   
_JA_FOSTE:

SET TEXT FONT "verdana"
    SET TEXT SIZE 50
    ink rgb(170,30,30),rgb(0,0,0)
    center text 620,400,"JÁ FOSTE!"   
    sync
    wait key
    cls
    end

function GetFreeObject()
    repeat
        inc CurrentObject
    until object exist(CurrentObject) = 0
endfunction CurrentObject

function ball(n)
        make object sphere n,2
        xrotate object n,90
        fix object pivot n   
        position object n,rnd(150-50)+50,50,rnd(150-50)+50       
        color object n,rgb(rnd(150),30,30)
        AI Add Enemy n
        AI Set Entity Speed n,rnd(25-10)+10
ENDFUNCTION

+ Code Snippet

Rem Project: Dark Basic Pro Project
Rem Created: Saturday, March 12, 2011

Rem ***** Main Source File *****
cls
set display mode 1154,768,32
set window off
sync on
sync rate 0
hide mouse
GameOver = 0

global CurrentObject
CurrentObject = 99

//timer
init_time#=timer()/1000
time#=init_time#


//camera player 1
        make camera 1
        position camera 1,0,75,0 : point camera 1,0,0,0

//player
        player = GetFreeObject()
        make object sphere player,2
        color object player,rgb (255,255,255)
//o chão
        chao = GetFreeObject()
        make object box chao,150,1,150
        position object chao,0,0,0
        color object chao,rgb (50,50,50)
         
         
               
//balls of fire

AI Start
AI Set Radius 1
set object collision to spheres player

// create ten spheres
dim BallObjNum(9)
for k = 1 to 9
     n = GetFreeObject()
     BallObjNum(k) = n
     ball(n)
next k

//GAME LOOP

        do

//posição player 1   
    pick screen mousex(),mouseY(),50
    vectorx# = get pick vector x()
    vectory# = get pick vector y()
    vectorz# = get pick vector z()
    distancey# = -camera position y()*50/vectory#
    vectorx# = vectorx#*distancey# + camera position x()
    vectorz# = vectorz#*distancey# + camera position z()
    position object player,vectorx#,50,vectorz#+3



//movimento ball of fire     
    for k = 1 to 9
        AI Entity Go To Position BallObjNum(k),object position x (player),object position z (player)
    next k
    AI Update
       
//collision   
        for k = 1 to 9
            if object collision(player,BallObjNum(k)) = 1 then goto _JA_FOSTE
        next k

//timer
          // set text transparent
          SET TEXT FONT "verdana"
          SET TEXT SIZE 50
          ink rgb(200,200,200),rgb(0,0,0)
       
 
//collect updated time
    time#=timer()/1000-init_time#
//to make it count down from a value just minus time from that value
    time#=60-time#
//convert to minuits and seconds
    sec=floor(time#-min*60)
    center text 620,25,str$(sec)
        if sec=0
            center text 600,400,"TU É QUE CORRES..."
            sync
            wait key
            end
        endif

    sync

        loop       

//JA FOSTE   
_JA_FOSTE:

    SET TEXT FONT "verdana"
    SET TEXT SIZE 50
    ink rgb(170,30,30),rgb(0,0,0)
    center text 620,400,"JÁ FOSTE!"   
    sync
    wait key
    cls
    end  
 


function GetFreeObject()
    repeat
        inc CurrentObject
    until object exist(CurrentObject) = 0
endfunction CurrentObject

function ball(n)
        make object sphere n,2
        xrotate object n,90
        fix object pivot n   
        position object n,rnd(150-50)+50,50,rnd(150-50)+50       
        color object n,rgb(rnd(150),30,30)
        AI Add Enemy n
        AI Set Entity Speed n,rnd(25-10)+10
ENDFUNCTION

EDIT: I would note that I consider using GOTO a poor programming practice, but I left it in, as it is your program and not mine. I would suggest writing a subroutine that handles when a player dies and another subroutine when the game is to be restarted.

Back to top

Profile PM Email

Sorry your browser is not supported!

Newcomers DBPro Corner / Function Error