Text adventure combat function bug

Author

Message

Omnomer

13

Years of Service

User Offline

Joined: 12th Mar 2011

Location: a goauld mothership

Posted: 22nd Mar 2011 02:37

Link

In the text adventure I'm making I have a function (below) but any text to be printed or input comands within my function don't happen. Can anyone explain why?
Function easycombat()

If Class$ = "Fighter"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your sword at the monster"
		print "2. Stab the monster"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 5
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Barbarian"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your Ax at the monster"
		print "2. Punch the monster"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Rouge"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your shortsword at the monster"
		print "2. Stab the monster with your Knife"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Thief"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your Dagger at the monster"
		print "2. Stab the monster with your Knife"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Wizard"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Cast a fireball at the monster"
		print "2. Wack the monster with your staff"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Cleric"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Smite the monster with holy might"
		print "2. Heal yourself"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			Hp = Hp + 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
EndFunction

+ Code Snippet

	If Class$ = "Fighter"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your sword at the monster"
		print "2. Stab the monster"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 5
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Barbarian"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your Ax at the monster"
		print "2. Punch the monster"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Rouge"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your shortsword at the monster"
		print "2. Stab the monster with your Knife"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Thief"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your Dagger at the monster"
		print "2. Stab the monster with your Knife"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Wizard"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Cast a fireball at the monster"
		print "2. Wack the monster with your staff"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Cleric"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Smite the monster with holy might"
		print "2. Heal yourself"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			Hp = Hp + 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
EndFunction

Mwahahahahahahahahahahahahaha

Back to top

Profile PM

Burning Feet Man

16

Years of Service

User Offline

Joined: 4th Jan 2008

Location: Sydney, Australia

Posted: 22nd Mar 2011 05:44

Link

For starters, have a look at the "Select Case" commands. It'll save you writing half a dozen if statements.

If you're aware of the "Select Case" commands, is there a reason as to why you're not using them?

Help build an online DarkBASIC Professional help archive.
DarkBasic Help Wikia

Back to top

Profile PM Website

Rich Dersheimer

AGK Developer

15

Years of Service

User Offline

Joined: 1st Jul 2009

Location: Inside the box

Posted: 22nd Mar 2011 06:28 Edited at: 22nd Mar 2011 06:55

Link

In keeping with BFM's tradition of not answering your question...

Did you know that "Rouge" is "a cosmetic used to color the cheeks and emphasize the cheekbones"? You probably mean "Rogue" though.

Kidding aside, it's hard to say why your function is not printing or accepting input, without seeing the rest (or part of the rest) of your code.

Some questions do come to mind though...

Is Class$ declared as a global? If not, then all your IF/THEN tests will fail, as Class$ will always equal an empty string. That's where BFM's suggestion of using SELECT/CASE can be quite handy. A simple CASE DEFAULT would catch any value for Class$ that is not specifically tested.

Thus:

function easycombat()
    select Class$
    case "Fighter"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your sword at the monster"
        print "2. Stab the monster"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 5
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
     case "Barbarian"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your Ax at the monster"
        print "2. Punch the monster"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    case "Rouge"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your shortsword at the monster"
        print "2. Stab the monster with your Knife"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    case "Thief"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your Dagger at the monster"
        print "2. Stab the monster with your Knife"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    case "Wizard"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Cast a fireball at the monster"
        print "2. Wack the monster with your staff"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    case "Cleric"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Smite the monster with holy might"
        print "2. Heal yourself"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            Hp = Hp + 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    CASE DEFAULT
           print "NO CORRECT CLASS FOUND"
    ENDCASE
    
endselect

EndFunction

+ Code Snippet

function easycombat()
    select Class$
    case "Fighter"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your sword at the monster"
        print "2. Stab the monster"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 5
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
     case "Barbarian"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your Ax at the monster"
        print "2. Punch the monster"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    case "Rouge"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your shortsword at the monster"
        print "2. Stab the monster with your Knife"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    case "Thief"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your Dagger at the monster"
        print "2. Stab the monster with your Knife"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    case "Wizard"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Cast a fireball at the monster"
        print "2. Wack the monster with your staff"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    case "Cleric"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Smite the monster with holy might"
        print "2. Heal yourself"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            Hp = Hp + 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endcase
    
    CASE DEFAULT
           print "NO CORRECT CLASS FOUND"
    ENDCASE
    
endselect

EndFunction

Also, the variable "HP" should be global, so that it persists through calling the easycombat() function.

Of course there could be some other problem. Are you using sync commands? Have you changed the ink color? And so on...

Back to top

Profile PM Email

Burning Feet Man

16

Years of Service

User Offline

Joined: 4th Jan 2008

Location: Sydney, Australia

Posted: 22nd Mar 2011 06:58

Link

Too funny Rich.

I'm in the middle of an Autodesk bootcamp, so it's a little difficult to pull apart code in my half hour lunch break.

When I was first learning about functions, I found the easiest way to troubleshoot them was by moving my failing function code out from the failing function and into my main loop. Often you'll find it's simply a non-global variable being assumed as global by the programmer to be causing the problem.

Specifically though, in the code example provided in Omnomer's original post, I think it's the "ExitFunction" commands that are killing his function. I've been taught not to code using the "ExitFunction" command.

It's all about Sequence, Selection & Iteration.

Basically, every time a DBpro coder uses ExitFunction, a glitch in the Matrix kills a kitten.

Help build an online DarkBASIC Professional help archive.
DarkBasic Help Wikia

Back to top

Profile PM Website

Rich Dersheimer

AGK Developer

15

Years of Service

User Offline

Joined: 1st Jul 2009

Location: Inside the box

Posted: 22nd Mar 2011 08:40 Edited at: 22nd Mar 2011 08:45

Link

Quote: "Basically, every time a DBpro coder uses ExitFunction, a glitch in the Matrix kills a kitten."

LOL!

I don't think he ever reaches the exitfunction command, my gut feeling is that Class$ is local, and none if the IF tests pass. When I declare Class$ as global and assign it "Fighter" the function works well enough.

But I could be wrong...

global Class$="Fighter"
global Hp = 50
do
    easycombat()
loop
end

function easycombat()
    If Class$ = "Fighter"
        MonsterHP = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHP
        print "What do you do?(1-3)"
        print "1. Swing your sword at the monster"
        print "2. Stab the monster"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHP = MonsterHP - 5
        endif
        If Choice = 2
            MonsterHP = MonsterHP - 5
        endif
        If MonsterHP < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Barbarian"
        MonsterHP = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHP
        print "What do you do?(1-3)"
        print "1. Swing your Ax at the monster"
        print "2. Punch the monster"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Rouge"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your shortsword at the monster"
        print "2. Stab the monster with your Knife"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Thief"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your Dagger at the monster"
        print "2. Stab the monster with your Knife"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Wizard"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Cast a fireball at the monster"
        print "2. Wack the monster with your staff"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Cleric"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Smite the monster with holy might"
        print "2. Heal yourself"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            Hp = Hp + 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
EndFunction

+ Code Snippet

global Class$="Fighter"
global Hp = 50
do
    easycombat()
loop
end

function easycombat()
    If Class$ = "Fighter"
        MonsterHP = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHP
        print "What do you do?(1-3)"
        print "1. Swing your sword at the monster"
        print "2. Stab the monster"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHP = MonsterHP - 5
        endif
        If Choice = 2
            MonsterHP = MonsterHP - 5
        endif
        If MonsterHP < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Barbarian"
        MonsterHP = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHP
        print "What do you do?(1-3)"
        print "1. Swing your Ax at the monster"
        print "2. Punch the monster"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Rouge"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your shortsword at the monster"
        print "2. Stab the monster with your Knife"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Thief"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Swing your Dagger at the monster"
        print "2. Stab the monster with your Knife"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Wizard"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Cast a fireball at the monster"
        print "2. Wack the monster with your staff"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            MonsterHp = MonsterHp - 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
    
    If Class$ = "Cleric"
        MonsterHp = 2
        print "YourHp = ";Hp
        print "MonsterHp = ";MonsterHp
        print "What do you do?(1-3)"
        print "1. Smite the monster with holy might"
        print "2. Heal yourself"
        print "3. Nothing"
        Input Choice
        
        If Choice = 1
            MonsterHp = MonsterHp - 5
        endif
        If Choice = 2
            Hp = Hp + 2
        endif
        If MonsterHp < 1
            exitfunction
        endif
            print "The monster attacks you"
            Hp = Hp-1
    endif
EndFunction

Back to top

Profile PM Email

Omnomer

13

Years of Service

User Offline

Joined: 12th Mar 2011

Location: a goauld mothership

Posted: 23rd Mar 2011 01:46 Edited at: 23rd Mar 2011 01:54

Link

Wow thanks for the quick response. You fixed my code. The problem was the local/global issue
Burning Feet Man: I didn't know about the select case comand I'll look into it though.
Rich Dersheimer: No I didn't know I was spelling rogue wrong. I thought Class was local but I guess not so I changed that too. Here's the rest of my game code and yess I know it is "spagietycode" but don't comment on that.

Rem By Omnomer
Rem If you know what "the game" is you just lost it!XD
Rem This is the intro
print "Welcome to Firvon! A text adventure"
print "What is your name?"
Input Name$
print "Hello ";Name$;". What is your class? (1-6)"
print "1. Fighter"
print "2. Barbarian"
print "2. Rogue"
print "4. Thief"
print "3. Wizard"
print "6. Cleric"
Input Choice

Rem This is a lot of if statements to Distinguish class of the character

If Choice = 1
	Global Class$ = "Fighter"
	Global Hp = 10
endif

If Choice = 2
	Global Class$ = "Barbarian"
	Global Hp = 12
endif

If Choice = 3
	Global Class$ = "Rogue"
	Global Hp = 6
endif

If Choice = 4
	Global Class$ = "Thief"
	Global Hp = 6
endif

If Choice = 5
	Global Class$ = "Wizard"
	Global Hp = 6
endif

If Choice = 6
	Global Class$ = "Cleric"
	Global Hp = 6
endif

Rem This is where the Actual game code goes for the game
Start:
	cls
	print "So ";Name$;" where do you want to go?(1-3)"
	print "1. Dark Forrest by your Town"
	print "2. Dungeon a few miles away"
	print "3. Town where you happen to be"
	Rem The hash of code starts here. Go to the Dark forrest, the rest are still incomplete.
	
	input Choice
	
	If Choice = 1
		Goto DarkForest
	endif
	
	If Choice = 2
		Goto Dungeon
	endif
	
	If Choice = 3
		Goto Town
	endif

DarkForest:
		cls
		print "You are tired after a long day. In front of you are some scary seeming woods."
		print "You hear some something sneak by. The wind seems to pull you in, to the forrest. What do you do?(1-4)"
		print "1. Rest for the night."
		print "2. Venture into the forrest."
		print "3. Chase whatever made that sound."
		print "4. Scamper back to where you started with your tail between your legs."
		input Choice
		
		If Choice = 1
			Goto DarkForestmorning
		endif
		
		If Choice = 2
			Goto DarkForestpath
		endif
		
		If Choice = 3
			Goto DarkForestbrush
		endif
		
		If Choice = 4
			Goto Start
		endif
	
	DarkForestmorning:
		cls
		print "In the morning you feel fresh and ready to have an adventure."
		print "But as you see the Dark Forest you begin to feel a chill and depresed. What do you do?(1-3)"
		print "1. Venture along the path."
		print "2. See if you can find whatever made that sound last night"
		print "3. Scamper back to where you started with your tail between your legs."
		input Choice
		
		If Choice = 1
			Goto DarkForestpath
		endif
		
		If Choice = 2
			Goto DarkForestbrush
		endif
		
		If Choice = 3
			Goto Start
		endif
	
	DarkForestpath:
		cls
		print "The path is overgrown and in places not even there. You can easily see why people call it the dark forrest."
		print "You come across a roaring beast. It's an orc and it terifies you."
		print "You do the only concivable thing and go to battle with the monster."
		easycombat()
		print "You continue along the path until it ends at an old mine. Do you enter the mine(1) or go back to where you started(2)?"
		input Choice
		
		If Choice = 1
			goto Oldmine
		endif
		
		If Choice = 2
			goto Start
		endif
	
	DarkForestbrush:
		cls
		print "You whack slowly through the various"
		print "ferns and bushes and by the time that the sun goen down you can still see the spot where you started."
		print "You are ehausted and can't wack another bush. You are sick of trying to track something you clearly can't."
		print "You do the only thing anyone short of a god could do and sleep for the night.(press any key to continue)"
		wait key
		goto DarkForestmorning
	
	Oldmine:
		cls
		print "The mine is humid and stuffy. The walls are slimy to the touch and make you shiver. "
		wait key

Dungeon:
	END

Town:
	END

Functions:
Function easycombat()
	If Class$ = "Fighter"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your sword at the monster"
		print "2. Stab the monster"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 5
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Barbarian"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your Ax at the monster"
		print "2. Punch the monster"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Rogue"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your shortsword at the monster"
		print "2. Stab the monster with your Knife"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Thief"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your Dagger at the monster"
		print "2. Stab the monster with your Knife"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Wizard"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Cast a fireball at the monster"
		print "2. Wack the monster with your staff"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Cleric"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Smite the monster with holy might"
		print "2. Heal yourself"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			Hp = Hp + 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
EndFunction

+ Code Snippet

Rem By Omnomer
Rem If you know what "the game" is you just lost it!XD
Rem This is the intro
print "Welcome to Firvon! A text adventure"
print "What is your name?"
Input Name$
print "Hello ";Name$;". What is your class? (1-6)"
print "1. Fighter"
print "2. Barbarian"
print "2. Rogue"
print "4. Thief"
print "3. Wizard"
print "6. Cleric"
Input Choice

Rem This is a lot of if statements to Distinguish class of the character

If Choice = 1
	Global Class$ = "Fighter"
	Global Hp = 10
endif

If Choice = 2
	Global Class$ = "Barbarian"
	Global Hp = 12
endif

If Choice = 3
	Global Class$ = "Rogue"
	Global Hp = 6
endif

If Choice = 4
	Global Class$ = "Thief"
	Global Hp = 6
endif

If Choice = 5
	Global Class$ = "Wizard"
	Global Hp = 6
endif

If Choice = 6
	Global Class$ = "Cleric"
	Global Hp = 6
endif

Rem This is where the Actual game code goes for the game
Start:
	cls
	print "So ";Name$;" where do you want to go?(1-3)"
	print "1. Dark Forrest by your Town"
	print "2. Dungeon a few miles away"
	print "3. Town where you happen to be"
	Rem The hash of code starts here. Go to the Dark forrest, the rest are still incomplete.
	
	input Choice
	
	If Choice = 1
		Goto DarkForest
	endif
	
	If Choice = 2
		Goto Dungeon
	endif
	
	If Choice = 3
		Goto Town
	endif

DarkForest:
		cls
		print "You are tired after a long day. In front of you are some scary seeming woods."
		print "You hear some something sneak by. The wind seems to pull you in, to the forrest. What do you do?(1-4)"
		print "1. Rest for the night."
		print "2. Venture into the forrest."
		print "3. Chase whatever made that sound."
		print "4. Scamper back to where you started with your tail between your legs."
		input Choice
		
		If Choice = 1
			Goto DarkForestmorning
		endif
		
		If Choice = 2
			Goto DarkForestpath
		endif
		
		If Choice = 3
			Goto DarkForestbrush
		endif
		
		If Choice = 4
			Goto Start
		endif
	
	DarkForestmorning:
		cls
		print "In the morning you feel fresh and ready to have an adventure."
		print "But as you see the Dark Forest you begin to feel a chill and depresed. What do you do?(1-3)"
		print "1. Venture along the path."
		print "2. See if you can find whatever made that sound last night"
		print "3. Scamper back to where you started with your tail between your legs."
		input Choice
		
		If Choice = 1
			Goto DarkForestpath
		endif
		
		If Choice = 2
			Goto DarkForestbrush
		endif
		
		If Choice = 3
			Goto Start
		endif
	
	DarkForestpath:
		cls
		print "The path is overgrown and in places not even there. You can easily see why people call it the dark forrest."
		print "You come across a roaring beast. It's an orc and it terifies you."
		print "You do the only concivable thing and go to battle with the monster."
		easycombat()
		print "You continue along the path until it ends at an old mine. Do you enter the mine(1) or go back to where you started(2)?"
		input Choice
		
		If Choice = 1
			goto Oldmine
		endif
		
		If Choice = 2
			goto Start
		endif
	
	DarkForestbrush:
		cls
		print "You whack slowly through the various"
		print "ferns and bushes and by the time that the sun goen down you can still see the spot where you started."
		print "You are ehausted and can't wack another bush. You are sick of trying to track something you clearly can't."
		print "You do the only thing anyone short of a god could do and sleep for the night.(press any key to continue)"
		wait key
		goto DarkForestmorning
	
	Oldmine:
		cls
		print "The mine is humid and stuffy. The walls are slimy to the touch and make you shiver. "
		wait key
	

Dungeon:
	END

Town:
	END

Functions:
Function easycombat()
	If Class$ = "Fighter"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your sword at the monster"
		print "2. Stab the monster"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 5
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Barbarian"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your Ax at the monster"
		print "2. Punch the monster"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Rogue"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your shortsword at the monster"
		print "2. Stab the monster with your Knife"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Thief"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Swing your Dagger at the monster"
		print "2. Stab the monster with your Knife"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Wizard"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Cast a fireball at the monster"
		print "2. Wack the monster with your staff"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			MonsterHp = MonsterHp - 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
	
	If Class$ = "Cleric"
		MonsterHp = 2
		print "YourHp = ";Hp
		print "MonsterHp = ";MonsterHp
		print "What do you do?(1-3)"
		print "1. Smite the monster with holy might"
		print "2. Heal yourself"
		print "3. Nothing"
		Input Choice
		
		If Choice = 1
			MonsterHp = MonsterHp - 5
		endif
		If Choice = 2
			Hp = Hp + 2
		endif
		If MonsterHp < 1
			exitfunction
		endif
			print "The monster attacks you"
			Hp = Hp-1
	endif
EndFunction

Mwahahahahahahahahahahahahaha

Back to top

Profile PM

Burning Feet Man

16

Years of Service

User Offline

Joined: 4th Jan 2008

Location: Sydney, Australia

Posted: 23rd Mar 2011 02:32

Link

Ok, definitely go read up on Select Case before progressing with your project. Then employ it in your current code as a way of learning.

Help build an online DarkBASIC Professional help archive.
DarkBasic Help Wikia

Back to top

Profile PM Website

Omnomer

13

Years of Service

User Offline

Joined: 12th Mar 2011

Location: a goauld mothership

Posted: 23rd Mar 2011 05:43

Link

Um BFM isn't the select case command almost EXACTLY like the Ifs i've been using? No offense ment

Mwahahahahahahahahahahahahaha

Back to top

Profile PM

Burning Feet Man

16

Years of Service

User Offline

Joined: 4th Jan 2008

Location: Sydney, Australia

Posted: 23rd Mar 2011 08:33

Link

Well, you know what they say... You can hammer a nail in by using a spanner. It's all about using the right tool for the job.

Help build an online DarkBASIC Professional help archive.
DarkBasic Help Wikia

Back to top

Profile PM Website

Omnomer

13

Years of Service

User Offline

Joined: 12th Mar 2011

Location: a goauld mothership

Posted: 23rd Mar 2011 19:54

Link

Nobody says that

Mwahahahahahahahahahahahahaha

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers DBPro Corner / Text adventure combat function bug