Deleting objects with in an array

Author

Message

Daniel wright 2311

User Banned

Posted: 2nd Apr 2011 22:22 Edited at: 2nd Apr 2011 22:33

So im reposting this hoping for some help, this is the code, The objects nights will not hide with in this array, I do not know why? Its driving me crazy. I cant move them,I cant hide them, I cant even delete them, Ive tryed everything. after the timer

timekill(nights)=timekill(nights)+1

I cant do anything with object nights but I can delete object 4 with no problems, object 4 is not set in any array, So i know it the array doing it.

rem This is my bullets object 4

if object Collision ( 3, nights )=1 then position object 4,object position x(nights), object position y(nights)+50, object position z(nights):showstun2=1

rem this is what happens if bullets hit you

if showstun2=1
show object 4
point Object 4, camera position x(0), camera position y(0)-2, camera position z(0)
showstuned2=showstuned2+1
endif

if showstuned2=60
showstun2=0

hide object 4
dec EnemyHealth(nights)
showstuned2=0
endif

rem, this is my enimys health set in an array

if EnemyHealth(nights)=1 then killed1(nights)=1

rem this is the result of your death

if killed1(nights)=1
show object 4
point Object 4, camera position x(0), camera position y(0)-2, camera position z(0)
timekill(nights)=timekill(nights)+1
endif

rem this is the timer upsetting me so much

if timekill(nights)=100
SC_removeObject nights
hide object nights-rem this is the problem right here
hide object 4
dec EnemyHealth(nights)
timekill(nights)=0
killed1(nights)=0
endif
endif
NEXT NIGHTS

+ Code Snippet

rem This is my bullets object 4

if object Collision ( 3, nights )=1 then position object 4,object position x(nights), object position y(nights)+50, object position z(nights):showstun2=1

rem this is what happens if bullets hit you

if showstun2=1
show object 4
point Object 4, camera position x(0), camera position y(0)-2, camera position z(0)
showstuned2=showstuned2+1
endif

if showstuned2=60
showstun2=0

hide object 4
dec EnemyHealth(nights)
showstuned2=0
endif

rem, this is my enimys health set in an array

if EnemyHealth(nights)=1 then killed1(nights)=1

rem this is the result of your death

if killed1(nights)=1
show object 4
point Object 4, camera position x(0), camera position y(0)-2, camera position z(0)
timekill(nights)=timekill(nights)+1
endif

rem this is the timer upsetting me so much

if timekill(nights)=100
SC_removeObject nights
hide object nights-rem this is the problem right here
hide object 4
dec EnemyHealth(nights)
timekill(nights)=0
killed1(nights)=0
endif
endif
NEXT NIGHTS

my signature keeps being erased by a mod So this is my new signature.

Back to top

Profile

Daniel wright 2311

User Banned

Posted: 3rd Apr 2011 03:51

Link

Well, Ive waited for an answer on this with no help, SO IM BUMPING THIS WITH HOPES SOMEONE WILL LOOK INTO HEALPING ME, I STILL HAVE NOT FIGURED IT OUT.

my signature keeps being erased by a mod So this is my new signature.

Back to top

Profile

BillR

23

Years of Service

User Offline

Joined: 19th Mar 2003

Location: United States

Posted: 3rd Apr 2011 06:47 Edited at: 3rd Apr 2011 07:04

Link

well we know the hide object command works, so your conditional code

+ Code Snippet

if timekill(nights)=100

never gets executed.....time for some debug code

+ Code Snippet

rem - main loop
do
   rem - your other main code is here

   rem add this code - or something similar
   set cursor 0,0
   for i=5 to 20
      print timekill(i)
   next i

   sync
loop

Using debug code to show the values of your variables is a great way
to help track down where the problems are with your code.

It is ALWAYS best to post code we can compile for testing to help solve your problem
And please don't double post for the same problem.

If you want to post all your code here or email it to me or post a compilable example with the same problem, I will find out where the problem is.

Back to top

Profile PM Email

Daniel wright 2311

User Banned

Posted: 3rd Apr 2011 10:30

Link

So any how, i had to write all my code long hand, here is all i did, this is what i was trying my best to avoid.

rem loose health for enimys array

for nights1 = 5 to 20

if enemy(nights1).ehealth=-1 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=-2 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=-3 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=-4 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=-5 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=0  then hide object nights1:position object nights1, 0,-200,0

if object Collision ( 3, 5 )=1 then attack1=1

if attack1=1
attac1=attac1+1
endif

if attac1=60
attack1=0
dec enemy(5).ehealth,1
attac1=0
endif

if object Collision ( 3, 6 )=1 then attack2=1

if attack2=1
attac2=attac2+1
endif

if attac2=60
attack2=0
dec enemy(6).ehealth,1
attac2=0
endif

if object Collision ( 3, 7 )=1 then attack3=1

if attack3=1
attac3=attac3+1
endif

if attac3=60
attack3=0
dec enemy(7).ehealth,1
attac3=0
endif

if object Collision ( 3, 8 )=1 then attack4=1

if attack4=1
attac4=attac4+1
endif

if attac4=60
attack4=0
dec enemy(8).ehealth,1
attac4=0
endif

if object Collision ( 3, 9 )=1 then attack5=1

if attack5=1
attac5=attac5+1
endif

if attac5=60
attack5=0
dec enemy(9).ehealth,1
attac5=0
endif

if object Collision ( 3, 10 )=1 then attack6=1

if attack6=1
attac6=attac6+1
endif

if attac6=60
attack6=0
dec enemy(10).ehealth,1
attac6=0
endif

if object Collision ( 3, 11 )=1 then attack7=1

if attack7=1
attac7=attac7+1
endif

if attac7=60
attack7=0
dec enemy(11).ehealth,1
attac7=0
endif

if object Collision ( 3, 12 )=1 then attack8=1

if attack8=1
attac8=attac8+1
endif

if attac8=60
attack8=0
dec enemy(12).ehealth,1
attac8=0
endif

if object Collision ( 3, 13 )=1 then attack9=1

if attack9=1
attac9=attac9+1
endif

if attac9=60
attack9=0
dec enemy(13).ehealth,1
attac9=0
endif

if object Collision ( 3, 14 )=1 then attack10=1

if attack10=1
attac10=attac10+1
endif

if attac10=60
attack10=0
dec enemy(14).ehealth,1
attac10=0
endif

if object Collision ( 3, 15 )=1 then attack11=1

if attack11=1
attac11=attac11+1
endif

if attac11=60
attack11=0
dec enemy(15).ehealth,1
attac11=0
endif

if object Collision ( 3, 16 )=1 then attack12=1

if attack12=1
attac12=attac12+1
endif

if attac12=60
attack12=0
dec enemy(16).ehealth,1
attac12=0
endif

if object Collision ( 3, 17 )=1 then attack13=1

if attack13=1
attac13=attac13+1
endif

if attac13=60
attack13=0
dec enemy(17).ehealth,1
attac13=0
endif

if object Collision ( 3, 18 )=1 then attack14=1

if attack14=1
attac14=attac14+1
endif

if attac14=60
attack14=0
dec enemy(18).ehealth,1
attac14=0
endif

if object Collision ( 3, 19 )=1 then attack15=1

if attack15=1
attac15=attac15+1
endif

if attac15=60
attack15=0
dec enemy(19).ehealth,1
attac15=0
endif

if object Collision ( 3, 20 )=1 then attack16=1

if attack16=1
attac16=attac16+1
endif

if attac16=60
attack16=0
dec enemy(20).ehealth,1
attac16=0
endif

+ Code Snippet

rem loose health for enimys array

for nights1 = 5 to 20

if enemy(nights1).ehealth=-1 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=-2 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=-3 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=-4 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=-5 then enemy(nights1).ehealth=0
if enemy(nights1).ehealth=0  then hide object nights1:position object nights1, 0,-200,0


if object Collision ( 3, 5 )=1 then attack1=1

if attack1=1
attac1=attac1+1
endif

if attac1=60
attack1=0
dec enemy(5).ehealth,1
attac1=0
endif

if object Collision ( 3, 6 )=1 then attack2=1

if attack2=1
attac2=attac2+1
endif

if attac2=60
attack2=0
dec enemy(6).ehealth,1
attac2=0
endif

if object Collision ( 3, 7 )=1 then attack3=1

if attack3=1
attac3=attac3+1
endif

if attac3=60
attack3=0
dec enemy(7).ehealth,1
attac3=0
endif

if object Collision ( 3, 8 )=1 then attack4=1

if attack4=1
attac4=attac4+1
endif

if attac4=60
attack4=0
dec enemy(8).ehealth,1
attac4=0
endif

if object Collision ( 3, 9 )=1 then attack5=1

if attack5=1
attac5=attac5+1
endif

if attac5=60
attack5=0
dec enemy(9).ehealth,1
attac5=0
endif

if object Collision ( 3, 10 )=1 then attack6=1

if attack6=1
attac6=attac6+1
endif

if attac6=60
attack6=0
dec enemy(10).ehealth,1
attac6=0
endif

if object Collision ( 3, 11 )=1 then attack7=1

if attack7=1
attac7=attac7+1
endif

if attac7=60
attack7=0
dec enemy(11).ehealth,1
attac7=0
endif

if object Collision ( 3, 12 )=1 then attack8=1

if attack8=1
attac8=attac8+1
endif

if attac8=60
attack8=0
dec enemy(12).ehealth,1
attac8=0
endif

if object Collision ( 3, 13 )=1 then attack9=1

if attack9=1
attac9=attac9+1
endif

if attac9=60
attack9=0
dec enemy(13).ehealth,1
attac9=0
endif

if object Collision ( 3, 14 )=1 then attack10=1

if attack10=1
attac10=attac10+1
endif

if attac10=60
attack10=0
dec enemy(14).ehealth,1
attac10=0
endif

if object Collision ( 3, 15 )=1 then attack11=1

if attack11=1
attac11=attac11+1
endif

if attac11=60
attack11=0
dec enemy(15).ehealth,1
attac11=0
endif

if object Collision ( 3, 16 )=1 then attack12=1

if attack12=1
attac12=attac12+1
endif

if attac12=60
attack12=0
dec enemy(16).ehealth,1
attac12=0
endif

if object Collision ( 3, 17 )=1 then attack13=1

if attack13=1
attac13=attac13+1
endif

if attac13=60
attack13=0
dec enemy(17).ehealth,1
attac13=0
endif

if object Collision ( 3, 18 )=1 then attack14=1

if attack14=1
attac14=attac14+1
endif

if attac14=60
attack14=0
dec enemy(18).ehealth,1
attac14=0
endif

if object Collision ( 3, 19 )=1 then attack15=1

if attack15=1
attac15=attac15+1
endif

if attac15=60
attack15=0
dec enemy(19).ehealth,1
attac15=0
endif

if object Collision ( 3, 20 )=1 then attack16=1

if attack16=1
attac16=attac16+1
endif

if attac16=60
attack16=0
dec enemy(20).ehealth,1
attac16=0
endif

my signature keeps being erased by a mod So this is my new signature.

Back to top

Profile

IanM

Retired Moderator

23

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 3rd Apr 2011 18:01

Link

Indentation. Really, it's the easiest and best programming tool in your toolbox.

I also notice that you have variables such as attac1 (without a k) and attack1 - are they supposed to be different variables?

Also, you have 16 of each of these. Replace them with an array.

You also have a lot of repeated code checking for collisions - if you use an array like I suggested, you can make a single loop to check for collisions.

You are also missing a ton of ENDIF statements. If you indent, you'd notice this immediately.

Finally, you have no NEXT to your FOR loop - if the end of the loop is at the end of the code, then your collision checks are useless after the first set has taken place, for example if object 3 is in collision with object 19 first time through the loop, it's still going to be in collision through the rest of the loops.

Get the latest Matrix1Utility plug-ins (23-DEC-2010)

Back to top

Profile PM Email Website

Daniel wright 2311

User Banned

Posted: 3rd Apr 2011 20:11

Link

@IanM

Hello,

Quote: "I also notice that you have variables such as attac1 (without a k) and attack1 - are they supposed to be different variables?"

this was on purpose

Quote: "Also, you have 16 of each of these. Replace them with an array."

check the first post, that was what the whole thread is about my friend.

Quote: "You are also missing a ton of ENDIF statements. If you indent, you'd notice this immediately."

Ive never used indent

Quote: "Finally, you have no NEXT to your FOR loop - if the end of the loop is at the end of the code, then your collision checks are useless after the first set has taken place, for example if object 3 is in collision with object 19 first time through the loop, it's still going to be in collision through the rest of the loops."

The long hand code I posted works perfect, its the code in the first post I need help with, this code I just posted is what I was trying to avoid.

thanks for your help

my signature keeps being erased by a mod So this is my new signature.

Back to top

Profile

IanM

Retired Moderator

23

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 3rd Apr 2011 23:30

Link

Quote: "check the first post, that was what the whole thread is about my friend"

Really? Ok, then quote the bit where it talks about attack and attac arrays

Quote: "Ive never used indent"

Then I think I'm through here... if you can't be bothered to make your code easy to read, I won't read it.

Good luck

Get the latest Matrix1Utility plug-ins (23-DEC-2010)

Back to top

Profile PM Email Website

Daniel wright 2311

User Banned

Posted: 4th Apr 2011 00:07 Edited at: 4th Apr 2011 00:07

Link

@ ianM

Here is the code I was needing help with with explainations behind it if it helps you help me, thanks

rem This is my bullets object 4

if object Collision ( 3, nights )=1 then position object 4,object position x(nights), object position y(nights)+50, object position z(nights):showstun2=1

rem this is what happens if bullets hit you

if showstun2=1
show object 4
point Object 4, camera position x(0), camera position y(0)-2, camera position z(0)
showstuned2=showstuned2+1
endif

if showstuned2=60
showstun2=0

hide object 4
dec EnemyHealth(nights)
showstuned2=0
endif

[b]rem, this is my enimys health set in an array[/b]

if EnemyHealth(nights)=1 then killed1(nights)=1

[b]rem this is the result of your death[/b]

if killed1(nights)=1
show object 4
point Object 4, camera position x(0), camera position y(0)-2, camera position z(0)
timekill(nights)=timekill(nights)+1
endif

[b]rem this is the timer upsetting me so much[/b]

if timekill(nights)=100
SC_removeObject nights
hide object nights-[b]rem this is the problem right here[/b]
hide object 4
dec EnemyHealth(nights)
timekill(nights)=0
killed1(nights)=0
endif
endif
NEXT NIGHTS

+ Code Snippet

rem This is my bullets object 4

if object Collision ( 3, nights )=1 then position object 4,object position x(nights), object position y(nights)+50, object position z(nights):showstun2=1

rem this is what happens if bullets hit you

if showstun2=1
show object 4
point Object 4, camera position x(0), camera position y(0)-2, camera position z(0)
showstuned2=showstuned2+1
endif

if showstuned2=60
showstun2=0

hide object 4
dec EnemyHealth(nights)
showstuned2=0
endif

[b]rem, this is my enimys health set in an array[/b]

if EnemyHealth(nights)=1 then killed1(nights)=1

[b]rem this is the result of your death[/b]

if killed1(nights)=1
show object 4
point Object 4, camera position x(0), camera position y(0)-2, camera position z(0)
timekill(nights)=timekill(nights)+1
endif

[b]rem this is the timer upsetting me so much[/b]

if timekill(nights)=100
SC_removeObject nights
hide object nights-[b]rem this is the problem right here[/b]
hide object 4
dec EnemyHealth(nights)
timekill(nights)=0
killed1(nights)=0
endif
endif
NEXT NIGHTS

my signature keeps being erased by a mod So this is my new signature.

Back to top

Profile

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Deleting objects with in an array