Variables acting very strangely - GameCreators Forum

Author

Message

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 17th Apr 2011 16:27 Edited at: 17th Apr 2011 16:31

Link

I've been working on my project, and I've been using DBPro for a couple of years now but I've never seen this ever.

I have this function:

+ Code Snippet

function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
	//Some useful local variables
	local oID as integer : oID=find free object() : //Kinda need this...
	
	//setting up the object
	make object cube oID,r
	position object oID,pos.x,pos.y,pos.z
	rotate object oID,rot.x,rot.y,rot.z
	
	//Putting the object in a group
	//ews_Parent has a very strange value...
	//Not sure why??
	g_o=ews_Parent
	if ews_Parent=EWS_UP
		place object in group oID,EWS_UP
	endif
	if ews_Parent=EWS_DOWN
		place object in group oID,EWS_DOWN
	endif
	if ews_Parent=EWS_RIGHT
		place object in group oID,EWS_RIGHT
	endif
	if ews_Parent=EWS_LEFT
		place object in group oID,EWS_LEFT
	endif
	if ews_Parent=EWS_NONE
		place object in group oID,0
	endif
	if ews_Parent=EWS_DYNAMIC
		place object in group oID,EWS_DYNAMIC
	endif
	//return the object ID instead of index, get that later
endfunction oID

And I call it like this:

+ Code Snippet

//ENUM: EWS_PARENTS
#constant EWS_NONE -1
#constant EWS_UP 1
#constant EWS_DOWN 2
#constant EWS_LEFT 3
#constant EWS_RIGHT 4
#constant EWS_DYNAMIC 5
test=wtld_makeObjectCube(3,VECTOR_ZERO,VECTOR_ZERO,EWS_UP)

The object is created, but the variable ews_Parent usually equals 14872492, even though the value I've passed in was 1(EWS_UP==1).

I'm entirely baffled, any one have ideas why this is happening?

Back to top

Profile PM Email

TheComet

18

Years of Service

User Offline

Joined: 18th Oct 2007

Location: I`m under ur bridge eating ur goatz.

Posted: 17th Apr 2011 17:42

Link

As far as I know, you can't pass constants into a function, they are global everywhere. I haven't tested, but you might want to try:

+ Code Snippet

x=EWS_UP
test=wtld_makeObjectCube(3,VECTOR_ZERO,VECTOR_ZERO,x)

Also, I think you can shorten all of the code that puts the object into a group.

Change the constants to this:

+ Code Snippet

//ENUM: EWS_PARENTS
#constant EWS_NONE 0
#constant EWS_UP 1
#constant EWS_DOWN 2
#constant EWS_LEFT 3
#constant EWS_RIGHT 4
#constant EWS_DYNAMIC 5

And change the grouping code to this:

+ Code Snippet

        //Putting the object in a group
        //ews_Parent has a very strange value...
        //Not sure why??
        g_o=ews_Parent
        place object in group oID,ews_Parent

TheComet

Back to top

Profile PM Email Website

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 17th Apr 2011 20:14

Link

Well constants are supposed to be replaced with their assigned value when the precompiler preps the source file for compilation.

I tried your way of simply putting the constant into a variable and then sending it to the function but it still didn't work.

Then I simplified my code like you suggested(that was its original form, but I was trying to isolate the bug), and it still didn't work so I thought about the order of the parameters in the function.

My parameters are: an integer, a UDT, a UDT, and then an integer.
So I changed to this order: an integer, an integer, a UDT, a UDT.
And it magically works!

Seems the two UDTs corrupt something in the passing of the last integer. Would be considered a bug?

Back to top

Profile PM Email

tiresius

23

Years of Service

User Offline

Joined: 13th Nov 2002

Location: MA USA

Posted: 18th Apr 2011 04:28

Link

What is VECTOR_ZERO ?

A 3D marble platformer using Newton physics.

Back to top

Profile PM Email

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 18th Apr 2011 05:08

Link

It's just a global variable that I use when I want to pass a value of (0,0,0) to a function.

+ Code Snippet

type vector3df
	x as float
	y as float
	z as float
endtype
global VECTOR_ZERO as vector3df
VECTOR_ZERO.x=0 : VECTOR_ZERO.y=0 : VECTOR_ZERO.z=0

Back to top

Profile PM Email

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 18th Apr 2011 23:45

Link

Your code seems to work fine for me. Have you put the constant declarations and the function in different files?

Here's the code I used:

sync on : sync rate 60 :sync

//ENUM: EWS_PARENTS
#constant EWS_NONE -1
#constant EWS_UP 1
#constant EWS_DOWN 2
#constant EWS_LEFT 3
#constant EWS_RIGHT 4
#constant EWS_DYNAMIC 5

type vector3df
        x as float
        y as float
        z as float
endtype
global VECTOR_ZERO as vector3df
VECTOR_ZERO.x=0 : VECTOR_ZERO.y=0 : VECTOR_ZERO.z=0

global check

test=wtld_makeObjectCube(3,VECTOR_ZERO,VECTOR_ZERO,EWS_UP)

repeat
  set cursor 20, 20
  print test, " ", check
  
  sync
until spacekey()

end

function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
        //Some useful local variables
        local oID as integer : oID=find free object() : //Kinda need this...
        
        //setting up the object
        make object cube oID,r
        position object oID,pos.x,pos.y,pos.z
        rotate object oID,rot.x,rot.y,rot.z
        
        //Putting the object in a group
        //ews_Parent has a very strange value...
        //Not sure why??
        g_o=ews_Parent
        if ews_Parent=EWS_UP
                place object in group oID,EWS_UP
        endif
        if ews_Parent=EWS_DOWN
                place object in group oID,EWS_DOWN
        endif
        if ews_Parent=EWS_RIGHT
                place object in group oID,EWS_RIGHT
        endif
        if ews_Parent=EWS_LEFT
                place object in group oID,EWS_LEFT
        endif
        if ews_Parent=EWS_NONE
                place object in group oID,0
        endif
        if ews_Parent=EWS_DYNAMIC
                place object in group oID,EWS_DYNAMIC
        endif
        //return the object ID instead of index, get that later
        
        check = g_o
endfunction oID

+ Code Snippet

sync on : sync rate 60 :sync

//ENUM: EWS_PARENTS
#constant EWS_NONE -1
#constant EWS_UP 1
#constant EWS_DOWN 2
#constant EWS_LEFT 3
#constant EWS_RIGHT 4
#constant EWS_DYNAMIC 5

type vector3df
        x as float
        y as float
        z as float
endtype
global VECTOR_ZERO as vector3df
VECTOR_ZERO.x=0 : VECTOR_ZERO.y=0 : VECTOR_ZERO.z=0



global check

test=wtld_makeObjectCube(3,VECTOR_ZERO,VECTOR_ZERO,EWS_UP)

repeat
  set cursor 20, 20
  print test, " ", check
  
  sync
until spacekey()

end


function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
        //Some useful local variables
        local oID as integer : oID=find free object() : //Kinda need this...
        
        //setting up the object
        make object cube oID,r
        position object oID,pos.x,pos.y,pos.z
        rotate object oID,rot.x,rot.y,rot.z
        
        //Putting the object in a group
        //ews_Parent has a very strange value...
        //Not sure why??
        g_o=ews_Parent
        if ews_Parent=EWS_UP
                place object in group oID,EWS_UP
        endif
        if ews_Parent=EWS_DOWN
                place object in group oID,EWS_DOWN
        endif
        if ews_Parent=EWS_RIGHT
                place object in group oID,EWS_RIGHT
        endif
        if ews_Parent=EWS_LEFT
                place object in group oID,EWS_LEFT
        endif
        if ews_Parent=EWS_NONE
                place object in group oID,0
        endif
        if ews_Parent=EWS_DYNAMIC
                place object in group oID,EWS_DYNAMIC
        endif
        //return the object ID instead of index, get that later
        
        check = g_o
endfunction oID

Back to top

Profile PM Email

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 19th Apr 2011 02:06 Edited at: 19th Apr 2011 02:08

Link

Yes, the constants are declared in a separate source file(along with all the UDTs) and that function is declared in a separate source file.

Back to top

Profile PM Email

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 19th Apr 2011 02:17

Link

That could be your problem but I'm not sure why so hopefully someone else can clarify this for you. I believe globals can only be accessed by functions declared in the same file so perhaps something similar happens to constants.

However, I can't immediately see why that should allow your code to work when the order is changed.

We probably need IanM to look at this thread.

Back to top

Profile PM Email

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 19th Apr 2011 04:03

Link

Quote: "We probably need IanM to look at this thread. "

Preferably.

Quote: "I believe globals can only be accessed by functions declared in the same file so perhaps something similar happens to constants."

That would be news to me.

Back to top

Profile PM Email

WLGfx

18

Years of Service

User Offline

Joined: 1st Nov 2007

Location: NW United Kingdom

Posted: 19th Apr 2011 04:35

Link

I'm thinking that it might be the order the files are added together when compiling. Usually you would expect constants and UDT's to be at the head of the source but DBP (as far as I know) attaches other source files to the end of the main file.

I've noticed that the #include directive isn't required anymore in DBP (in a project anyway) so you cannot order your separate source files. Maybe this is why the defines etc are parsed at the end of the source or somewhere in the middle.

Warning! May contain Nuts!

Back to top

Profile PM Email Website

Indicium

18

Years of Service

User Offline

Joined: 26th May 2008

Location:

Posted: 19th Apr 2011 21:49

Link

Do you not have to GOSUB to the constant definitions?

Back to top

Profile PM

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 20th Apr 2011 00:12

Link

Quote: "Do you not have to GOSUB to the constant definitions?"

No, constants are found by the precompiler and the values that are assigned to them are replaced wherever the constant is found in the source file.

Quote: "I've noticed that the #include directive isn't required anymore in DBP (in a project anyway) so you cannot order your separate source files. Maybe this is why the defines etc are parsed at the end of the source or somewhere in the middle."

I'm using CodeSurge v1.0 and it allows you to set the compile order(however it's pretty buggy) so I tried to put the source file that defines the constants and UDTs as far up the compile chain as I could, but not before the main source file.

Back to top

Profile PM Email

Neuro Fuzzy

19

Years of Service

User Offline

Joined: 11th Jun 2007

Location:

Posted: 22nd Apr 2011 09:57

Link

O_o

I think you should post this in bug reports

Tell me if there's a broken link to images in a thread I post, and I'll fix 'em.

Back to top

Profile PM Email

IanM

Retired Moderator

23

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 22nd Apr 2011 12:08

Link

Ah, I think that I know this bug from long ago.

The problem seems to happen when you pass a UDT as a parameter into a function, and the UDT is defined after the function. But it doesn't happen all of the time - sometimes it works fine, and sometimes it throws out a compiler error instead.

I think that this was one of the reasons for my very specific layout and design of code libraries (linky) - It's so long now that I can't remember exactly.

I've tried to reproduce the problem this time too with the code that GG has posted, but haven't managed it - the best (worst?) I've done is to put the type definition after everything else and get a parameter mismatch compilation error when calling the function.

I suspect what's happening to Dar13 is that not enough stack space is being reserved for the UDT parameter within the function (4 bytes, instead of 12), so that everything defined after it is being shifted left, and that the value he is getting from the integer is actually the third part of the first UDT (the float representation mapped into an integer).

Dar13, if you can locate and send me the .dbm file from your compilation of this program in it's non-working state, I can tell you if that is what is happening or if it's something else.

Get the latest Matrix1Utility plug-ins (20-APR-2011)

Back to top

Profile PM Email Website

Agent

21

Years of Service

User Offline

Joined: 7th Sep 2004

Location: Sydney, Australia

Posted: 22nd Apr 2011 21:38

Link

I've run into this problem in the past, as has one of my padawans. As far as I can tell, you can't pass a UDT to a function. I thought this was an intended restriction, and used alternate techniques. It'd be nice if this turns out to be a bug and gets corrected at some point

Quote: "
Quote: "I believe globals can only be accessed by functions declared in the same file so perhaps something similar happens to constants."
That would be news to me.
"

Just wanted to clarify this one. A global declared in any one source file (main or include) is accessible in any other source file. I have a couple of source files that I routinely include in all of my new projects as I start them. They contain commonly used functions that I've written over the years that I find are useful in every project. Some of them require global definitions to function (as they inter-operate to some extent). Each include has an initialise function that declares the globals needed, and I call each of the initialise functions from my main source, first thing. These globals are accessible by the main source file as well as the functions in which they are declared.

Back to top

Profile PM Email

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 22nd Apr 2011 22:53

Link

Quote: "Dar13, if you can locate and send me the .dbm file from your compilation of this program in it's non-working state, I can tell you if that is what is happening or if it's something else.
"

Email sent.

Quote: "I've run into this problem in the past, as has one of my padawans. As far as I can tell, you can't pass a UDT to a function. I thought this was an intended restriction, and used alternate techniques. It'd be nice if this turns out to be a bug and gets corrected at some point "

As long as I've used DBPro you could pass UDTs in, but not out. Not sure why, but that's how it's been since U5.6(link).

Back to top

Profile PM Email

IanM

Retired Moderator

23

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 23rd Apr 2011 00:17

Link

Quote: "I suspect what's happening to Dar13 is that not enough stack space is being reserved for the UDT parameter within the function"

I was wrong.

It's that the calling code is only passing the first 4 bytes of each register to the stack before the function is called.

Now we know what's happening, but we don't know the circumstances - when I arrange GG's code in the same order as was used to generate the problem in the original code (global, assign, call function, define type, function), it compiles and runs cleanly

sync on : sync rate 60 :sync

//ENUM: EWS_PARENTS
#constant EWS_NONE -1
#constant EWS_UP 1
#constant EWS_DOWN 2
#constant EWS_LEFT 3
#constant EWS_RIGHT 4
#constant EWS_DYNAMIC 5

global VECTOR_ZERO as vector3df
VECTOR_ZERO.x=0 : VECTOR_ZERO.y=0 : VECTOR_ZERO.z=0

global check

test=wtld_makeObjectCube(3,VECTOR_ZERO,VECTOR_ZERO,EWS_UP)

repeat
    set cursor 20, 20
    print test, " ", check
    
    sync
until spacekey()

end

type vector3df
    x as float
    y as float
    z as float
endtype

function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
    //Some useful local variables
    local oID as integer : oID=find free object() : //Kinda need this...
    
    //setting up the object
    make object cube oID,r
    position object oID,pos.x,pos.y,pos.z
    rotate object oID,rot.x,rot.y,rot.z
    
    //Putting the object in a group
    //ews_Parent has a very strange value...
    //Not sure why??
    g_o=ews_Parent
    if ews_Parent=EWS_UP
        place object in group oID,EWS_UP
    endif
    if ews_Parent=EWS_DOWN
        place object in group oID,EWS_DOWN
    endif
    if ews_Parent=EWS_RIGHT
        place object in group oID,EWS_RIGHT
    endif
    if ews_Parent=EWS_LEFT
        place object in group oID,EWS_LEFT
    endif
    if ews_Parent=EWS_NONE
        place object in group oID,0
    endif
    if ews_Parent=EWS_DYNAMIC
        place object in group oID,EWS_DYNAMIC
    endif
    //return the object ID instead of index, get that later
    
    check = g_o
endfunction oID

+ Code Snippet

sync on : sync rate 60 :sync

//ENUM: EWS_PARENTS
#constant EWS_NONE -1
#constant EWS_UP 1
#constant EWS_DOWN 2
#constant EWS_LEFT 3
#constant EWS_RIGHT 4
#constant EWS_DYNAMIC 5

global VECTOR_ZERO as vector3df
VECTOR_ZERO.x=0 : VECTOR_ZERO.y=0 : VECTOR_ZERO.z=0



global check

test=wtld_makeObjectCube(3,VECTOR_ZERO,VECTOR_ZERO,EWS_UP)

repeat
    set cursor 20, 20
    print test, " ", check
    
    sync
until spacekey()

end

type vector3df
    x as float
    y as float
    z as float
endtype


function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
    //Some useful local variables
    local oID as integer : oID=find free object() : //Kinda need this...
    
    //setting up the object
    make object cube oID,r
    position object oID,pos.x,pos.y,pos.z
    rotate object oID,rot.x,rot.y,rot.z
    
    //Putting the object in a group
    //ews_Parent has a very strange value...
    //Not sure why??
    g_o=ews_Parent
    if ews_Parent=EWS_UP
        place object in group oID,EWS_UP
    endif
    if ews_Parent=EWS_DOWN
        place object in group oID,EWS_DOWN
    endif
    if ews_Parent=EWS_RIGHT
        place object in group oID,EWS_RIGHT
    endif
    if ews_Parent=EWS_LEFT
        place object in group oID,EWS_LEFT
    endif
    if ews_Parent=EWS_NONE
        place object in group oID,0
    endif
    if ews_Parent=EWS_DYNAMIC
        place object in group oID,EWS_DYNAMIC
    endif
    //return the object ID instead of index, get that later
    
    check = g_o
endfunction oID

(Relevant sections from Dar13's dbm file - it's the lines starting with '68' that show what parameters are being pushed onto the stack)

35 LINE : global ZERO_VEC as vector3df
    
35 MOV EAX IMM4 , 0
35 MOV MEM4 EAX @ZERO_VEC    ; ASSIGN X TO X   
35 MOV MEM IMM4 @$_SLN_, 35
35 MOV EAX MEM4 @$_ERR_
35 CMP EAX4 0
35 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
   36 LINE : ZERO_VEC.x,0 : ZERO_VEC.y,0 : ZERO_VEC.z,0
    
36 MOV EAX IMM4 , 0
36 PUSH EAX                  ; PUSH TO STACK   
36 MOV EBX IMM4 [5
36 CALL EBX                  ; CALL [dbprocore.dll ,?CastLtoF@@YAKH@Z 
36 POP EBX                   ; POP EBX FROM STACK   
36 MOV MEM4 EAX @$F1         ; ASSIGN EAX TO X   
36 MOV EAX MEM4 @$F1
36 MOV MEM4 EAX @ZERO_VEC    ; ASSIGN X TO X   
36 MOV MEM IMM4 @$_SLN_, 36
36 MOV EAX MEM4 @$_ERR_
36 CMP EAX4 0
36 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
36 MOV EAX IMM4 , 0
36 PUSH EAX                  ; PUSH TO STACK   
36 MOV EBX IMM4 [5
36 CALL EBX                  ; CALL [dbprocore.dll ,?CastLtoF@@YAKH@Z 
36 POP EBX                   ; POP EBX FROM STACK   
36 MOV MEM4 EAX @$F1         ; ASSIGN EAX TO X   
36 MOV EAX MEM4 @$F1
36 MOV ECX IMM4 @ZERO_VEC
36 MOV [ECX+A] EAX4 4        ; ASSIGN X TO X   
36 MOV MEM IMM4 @$_SLN_, 36
36 MOV EAX MEM4 @$_ERR_
36 CMP EAX4 0
36 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
36 MOV EAX IMM4 , 0
36 PUSH EAX                  ; PUSH TO STACK   
36 MOV EBX IMM4 [5
36 CALL EBX                  ; CALL [dbprocore.dll ,?CastLtoF@@YAKH@Z 
36 POP EBX                   ; POP EBX FROM STACK   
36 MOV MEM4 EAX @$F1         ; ASSIGN EAX TO X   
36 MOV EAX MEM4 @$F1
36 MOV ECX IMM4 @ZERO_VEC
36 MOV [ECX+A] EAX4 8        ; ASSIGN X TO X   
36 MOV MEM IMM4 @$_SLN_, 36
36 MOV EAX MEM4 @$_ERR_
36 CMP EAX4 0
36 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
   37 LINE :

67 LINE : 
    
   68 LINE : test,wtld_makeObjectCube(20,VECTOR_ZERO,VECTOR_ZERO,1)
    
    
68 ???                       ; NOT IMPLEMENTED   
68 ???                       ; NOT IMPLEMENTED   
68 MOV EAX IMM4 , 1
68 PUSH EAX                  ; PUSH TO STACK   
68 MOV EAX IMM4 @$E2
68 ADD EAX IMM4 4
68 SUB EAX IMM4 4
68 PUSH [EAX]                ; PUSH UDT TO STACK   
68 MOV EAX IMM4 @$E1
68 ADD EAX IMM4 4
68 SUB EAX IMM4 4
68 PUSH [EAX]                ; PUSH UDT TO STACK   
68 MOV EAX IMM4 , 20
68 PUSH EAX                  ; PUSH TO STACK   
68 CALL MEM $label wtld_makeObjectCube; DIRECT SUBCALL   
68 ADD ESP 16                ; ADD ESP   
68 MOV MEM4 EAX @$L4         ; ASSIGN EAX TO X   
68 MOV MEM IMM4 @$_SLN_, 68
68 MOV EAX MEM4 @$_ERR_
68 CMP EAX4 0
68 JNE $labelend             ; CALL Normal Runtime Error Hook  
68 MOV EAX MEM4 @$L4
68 MOV MEM4 EAX @test        ; ASSIGN X TO X   
68 MOV MEM IMM4 @$_SLN_, 68
68 MOV EAX MEM4 @$_ERR_
68 CMP EAX4 0
68 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
   69 LINE : :`:`:`:`:`:`:`:`

127 LINE : type vector3df
    
   128 LINE : 	x as float
    
   129 LINE : 	y as float
    
   130 LINE : 	z as float
    
   131 LINE : endtype

227 LINE : 
    
   228 LINE : function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
    
228 MOV EBX IMM4 [21
228 CALL EBX                 ; CALL [dbprocore.dll ,?EarlyEnd@@YAXXZ 
228 JMP $labelend            ; DIRECT JUMP   
228 MOV MEM IMM4 @$_SLN_, 228
228 MOV EAX MEM4 @$_ERR_
228 CMP EAX4 0
228 JNE $labelend            ; CALL Normal Runtime Error Hook  
    
228 PUSH EBP                 ; PUSH EBP   
228 MOV EBP ESP              ; MOV EBP ESP   
228 SUB ESP 64               ; SUB ESP   
228 MOV EAX ESP 
228 MOV ECX IMM4 7
228 MOV SIB[EAX:ECX*4],IMM4 , 0
228 LOOP ECX , -9            ; CLEAR STACK   
    
   229 LINE : 	:`:`:`:`:`:`:`:`:`:`:`:`:`:`s
    
   230 LINE : 	local oID as integer : oID,find free object() : :`:`:`:`:`:`:`:`:`:`
    
230 MOV EAX IMM4 , 0
230 MOV [EBP+A] EAX4 -8      ; ASSIGN X TO X   
230 MOV MEM IMM4 @$_SLN_, 230
230 MOV EAX MEM4 @$_ERR_
230 CMP EAX4 0
230 JNE $labelend            ; CALL Normal Runtime Error Hook  
    
    
230 MOV EBX IMM4 [25
230 CALL EBX                 ; CALL [Matrix1Util_19.dll ,FindFreeObject 
230 MOV [EBP+A] EAX4 -12     ; ASSIGN EAX TO X   
230 MOV MEM IMM4 @$_SLN_, 230
230 MOV EAX MEM4 @$_ERR_
230 CMP EAX4 0
230 JNE $labelend            ; CALL Normal Runtime Error Hook  
230 MOV EAX4 [EBP+A] -12
230 MOV [EBP+A] EAX4 -8      ; ASSIGN X TO X   
230 MOV MEM IMM4 @$_SLN_, 230
230 MOV EAX MEM4 @$_ERR_
230 CMP EAX4 0
230 JNE $labelend            ; CALL Normal Runtime Error Hook  
    
   231 LINE : 	
    
   232 LINE : 	:`:`:`:`:`:`:`:`:`:`:`t
    
   233 LINE : 	make object cube oID,r
    
233 MOV EAX4 [EBP+A] 8
233 PUSH EAX                 ; PUSH TO STACK   
233 MOV EBX IMM4 [5
233 CALL EBX                 ; CALL [dbprocore.dll ,?CastLtoF@@YAKH@Z 
233 POP EBX                  ; POP EBX FROM STACK   
233 MOV [EBP+A] EAX4 -20     ; ASSIGN EAX TO X   
233 MOV EAX4 [EBP+A] -20
233 PUSH EAX                 ; PUSH TO STACK   
233 MOV EAX4 [EBP+A] -8
233 PUSH EAX                 ; PUSH TO STACK   
233 MOV EBX IMM4 [26
233 CALL EBX                 ; CALL [DBProBasic3DDebug.dll ,?MakeCube@@YAXHM@Z 
233 POP EBX                  ; POP EBX FROM STACK   
233 POP EBX                  ; POP EBX FROM STACK   
233 MOV MEM IMM4 @$_SLN_, 233
233 MOV EAX MEM4 @$_ERR_
233 CMP EAX4 0
233 JNE $labelend            ; CALL Normal Runtime Error Hook  
    
   234 LINE : 	position object oID,pos.x,pos.y,pos.z
    
234 MOV EAX4 [EBP+A] 20
234 PUSH EAX                 ; PUSH TO STACK   
234 MOV EAX4 [EBP+A] 16
234 PUSH EAX                 ; PUSH TO STACK   
234 MOV EAX4 [EBP+A] 12
234 PUSH EAX                 ; PUSH TO STACK   
234 MOV EAX4 [EBP+A] -8
234 PUSH EAX                 ; PUSH TO STACK   
234 MOV EBX IMM4 [22
234 CALL EBX                 ; CALL [DBProBasic3DDebug.dll ,?Position@@YAXHMMM@Z 
234 POP EBX                  ; POP EBX FROM STACK   
234 POP EBX                  ; POP EBX FROM STACK   
234 POP EBX                  ; POP EBX FROM STACK   
234 POP EBX                  ; POP EBX FROM STACK   
234 MOV MEM IMM4 @$_SLN_, 234
234 MOV EAX MEM4 @$_ERR_
234 CMP EAX4 0
234 JNE $labelend            ; CALL Normal Runtime Error Hook

DEBUG:
STRUCT@integer Overall Size:4
STRUCT@float Overall Size:4
STRUCT@string Overall Size:4
STRUCT@boolean Overall Size:1
STRUCT@byte Overall Size:1
STRUCT@word Overall Size:2
STRUCT@dword Overall Size:4
STRUCT@double float Overall Size:8
STRUCT@double integer Overall Size:8
STRUCT@label Overall Size:4
STRUCT@dabel Overall Size:4
STRUCT@integer array Overall Size:4
STRUCT@float array Overall Size:4
STRUCT@string array Overall Size:4
STRUCT@boolean array Overall Size:4
STRUCT@byte array Overall Size:4
STRUCT@word array Overall Size:4
STRUCT@dword array Overall Size:4
STRUCT@double float array Overall Size:4
STRUCT@double integer array Overall Size:4
STRUCT@anytype non casted Overall Size:4
STRUCT@userdefined var ptr Overall Size:4
STRUCT@userdefined array ptr Overall Size:4

USERSTRUCT@vector3df Overall Size:12
STRUCT@x    TYPE>float    OFFSET>0
STRUCT@y    TYPE>float    OFFSET>4
STRUCT@z    TYPE>float    OFFSET>8

FS@wtld_makeObjectCube Overall Size:60 Parameter Count:5
STRUCT@returnvalue    TYPE>integer    OFFSET>0
STRUCT@r    TYPE>integer    OFFSET>4
STRUCT@pos    TYPE>vector3df    OFFSET>8
STRUCT@rot    TYPE>vector3df    OFFSET>20
STRUCT@ews_Parent    TYPE>integer    OFFSET>32
STRUCT@oID    TYPE>integer    OFFSET>36
STRUCT@$L0    TYPE>integer    OFFSET>40
STRUCT@$L1    TYPE>integer    OFFSET>44
STRUCT@$F0    TYPE>float    OFFSET>48
STRUCT@$F1    TYPE>float    OFFSET>52
STRUCT@$F2    TYPE>float    OFFSET>56

+ Code Snippet

   35 LINE : global ZERO_VEC as vector3df
    
35 MOV EAX IMM4 , 0
35 MOV MEM4 EAX @ZERO_VEC    ; ASSIGN X TO X   
35 MOV MEM IMM4 @$_SLN_, 35
35 MOV EAX MEM4 @$_ERR_
35 CMP EAX4 0
35 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
   36 LINE : ZERO_VEC.x,0 : ZERO_VEC.y,0 : ZERO_VEC.z,0
    
36 MOV EAX IMM4 , 0
36 PUSH EAX                  ; PUSH TO STACK   
36 MOV EBX IMM4 [5
36 CALL EBX                  ; CALL [dbprocore.dll ,?CastLtoF@@YAKH@Z 
36 POP EBX                   ; POP EBX FROM STACK   
36 MOV MEM4 EAX @$F1         ; ASSIGN EAX TO X   
36 MOV EAX MEM4 @$F1
36 MOV MEM4 EAX @ZERO_VEC    ; ASSIGN X TO X   
36 MOV MEM IMM4 @$_SLN_, 36
36 MOV EAX MEM4 @$_ERR_
36 CMP EAX4 0
36 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
36 MOV EAX IMM4 , 0
36 PUSH EAX                  ; PUSH TO STACK   
36 MOV EBX IMM4 [5
36 CALL EBX                  ; CALL [dbprocore.dll ,?CastLtoF@@YAKH@Z 
36 POP EBX                   ; POP EBX FROM STACK   
36 MOV MEM4 EAX @$F1         ; ASSIGN EAX TO X   
36 MOV EAX MEM4 @$F1
36 MOV ECX IMM4 @ZERO_VEC
36 MOV [ECX+A] EAX4 4        ; ASSIGN X TO X   
36 MOV MEM IMM4 @$_SLN_, 36
36 MOV EAX MEM4 @$_ERR_
36 CMP EAX4 0
36 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
36 MOV EAX IMM4 , 0
36 PUSH EAX                  ; PUSH TO STACK   
36 MOV EBX IMM4 [5
36 CALL EBX                  ; CALL [dbprocore.dll ,?CastLtoF@@YAKH@Z 
36 POP EBX                   ; POP EBX FROM STACK   
36 MOV MEM4 EAX @$F1         ; ASSIGN EAX TO X   
36 MOV EAX MEM4 @$F1
36 MOV ECX IMM4 @ZERO_VEC
36 MOV [ECX+A] EAX4 8        ; ASSIGN X TO X   
36 MOV MEM IMM4 @$_SLN_, 36
36 MOV EAX MEM4 @$_ERR_
36 CMP EAX4 0
36 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
   37 LINE : 


   67 LINE : 
    
   68 LINE : test,wtld_makeObjectCube(20,VECTOR_ZERO,VECTOR_ZERO,1)
    
    
68 ???                       ; NOT IMPLEMENTED   
68 ???                       ; NOT IMPLEMENTED   
68 MOV EAX IMM4 , 1
68 PUSH EAX                  ; PUSH TO STACK   
68 MOV EAX IMM4 @$E2
68 ADD EAX IMM4 4
68 SUB EAX IMM4 4
68 PUSH [EAX]                ; PUSH UDT TO STACK   
68 MOV EAX IMM4 @$E1
68 ADD EAX IMM4 4
68 SUB EAX IMM4 4
68 PUSH [EAX]                ; PUSH UDT TO STACK   
68 MOV EAX IMM4 , 20
68 PUSH EAX                  ; PUSH TO STACK   
68 CALL MEM $label wtld_makeObjectCube; DIRECT SUBCALL   
68 ADD ESP 16                ; ADD ESP   
68 MOV MEM4 EAX @$L4         ; ASSIGN EAX TO X   
68 MOV MEM IMM4 @$_SLN_, 68
68 MOV EAX MEM4 @$_ERR_
68 CMP EAX4 0
68 JNE $labelend             ; CALL Normal Runtime Error Hook  
68 MOV EAX MEM4 @$L4
68 MOV MEM4 EAX @test        ; ASSIGN X TO X   
68 MOV MEM IMM4 @$_SLN_, 68
68 MOV EAX MEM4 @$_ERR_
68 CMP EAX4 0
68 JNE $labelend             ; CALL Normal Runtime Error Hook  
    
   69 LINE : :`:`:`:`:`:`:`:`




   127 LINE : type vector3df
    
   128 LINE : 	x as float
    
   129 LINE : 	y as float
    
   130 LINE : 	z as float
    
   131 LINE : endtype



   227 LINE : 
    
   228 LINE : function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
    
228 MOV EBX IMM4 [21
228 CALL EBX                 ; CALL [dbprocore.dll ,?EarlyEnd@@YAXXZ 
228 JMP $labelend            ; DIRECT JUMP   
228 MOV MEM IMM4 @$_SLN_, 228
228 MOV EAX MEM4 @$_ERR_
228 CMP EAX4 0
228 JNE $labelend            ; CALL Normal Runtime Error Hook  
    
228 PUSH EBP                 ; PUSH EBP   
228 MOV EBP ESP              ; MOV EBP ESP   
228 SUB ESP 64               ; SUB ESP   
228 MOV EAX ESP 
228 MOV ECX IMM4 7
228 MOV SIB[EAX:ECX*4],IMM4 , 0
228 LOOP ECX , -9            ; CLEAR STACK   
    
   229 LINE : 	:`:`:`:`:`:`:`:`:`:`:`:`:`:`s
    
   230 LINE : 	local oID as integer : oID,find free object() : :`:`:`:`:`:`:`:`:`:`
    
230 MOV EAX IMM4 , 0
230 MOV [EBP+A] EAX4 -8      ; ASSIGN X TO X   
230 MOV MEM IMM4 @$_SLN_, 230
230 MOV EAX MEM4 @$_ERR_
230 CMP EAX4 0
230 JNE $labelend            ; CALL Normal Runtime Error Hook  
    
    
230 MOV EBX IMM4 [25
230 CALL EBX                 ; CALL [Matrix1Util_19.dll ,FindFreeObject 
230 MOV [EBP+A] EAX4 -12     ; ASSIGN EAX TO X   
230 MOV MEM IMM4 @$_SLN_, 230
230 MOV EAX MEM4 @$_ERR_
230 CMP EAX4 0
230 JNE $labelend            ; CALL Normal Runtime Error Hook  
230 MOV EAX4 [EBP+A] -12
230 MOV [EBP+A] EAX4 -8      ; ASSIGN X TO X   
230 MOV MEM IMM4 @$_SLN_, 230
230 MOV EAX MEM4 @$_ERR_
230 CMP EAX4 0
230 JNE $labelend            ; CALL Normal Runtime Error Hook  
    
   231 LINE : 	
    
   232 LINE : 	:`:`:`:`:`:`:`:`:`:`:`t
    
   233 LINE : 	make object cube oID,r
    
233 MOV EAX4 [EBP+A] 8
233 PUSH EAX                 ; PUSH TO STACK   
233 MOV EBX IMM4 [5
233 CALL EBX                 ; CALL [dbprocore.dll ,?CastLtoF@@YAKH@Z 
233 POP EBX                  ; POP EBX FROM STACK   
233 MOV [EBP+A] EAX4 -20     ; ASSIGN EAX TO X   
233 MOV EAX4 [EBP+A] -20
233 PUSH EAX                 ; PUSH TO STACK   
233 MOV EAX4 [EBP+A] -8
233 PUSH EAX                 ; PUSH TO STACK   
233 MOV EBX IMM4 [26
233 CALL EBX                 ; CALL [DBProBasic3DDebug.dll ,?MakeCube@@YAXHM@Z 
233 POP EBX                  ; POP EBX FROM STACK   
233 POP EBX                  ; POP EBX FROM STACK   
233 MOV MEM IMM4 @$_SLN_, 233
233 MOV EAX MEM4 @$_ERR_
233 CMP EAX4 0
233 JNE $labelend            ; CALL Normal Runtime Error Hook  
    
   234 LINE : 	position object oID,pos.x,pos.y,pos.z
    
234 MOV EAX4 [EBP+A] 20
234 PUSH EAX                 ; PUSH TO STACK   
234 MOV EAX4 [EBP+A] 16
234 PUSH EAX                 ; PUSH TO STACK   
234 MOV EAX4 [EBP+A] 12
234 PUSH EAX                 ; PUSH TO STACK   
234 MOV EAX4 [EBP+A] -8
234 PUSH EAX                 ; PUSH TO STACK   
234 MOV EBX IMM4 [22
234 CALL EBX                 ; CALL [DBProBasic3DDebug.dll ,?Position@@YAXHMMM@Z 
234 POP EBX                  ; POP EBX FROM STACK   
234 POP EBX                  ; POP EBX FROM STACK   
234 POP EBX                  ; POP EBX FROM STACK   
234 POP EBX                  ; POP EBX FROM STACK   
234 MOV MEM IMM4 @$_SLN_, 234
234 MOV EAX MEM4 @$_ERR_
234 CMP EAX4 0
234 JNE $labelend            ; CALL Normal Runtime Error Hook  
    






DEBUG:
STRUCT@integer Overall Size:4
STRUCT@float Overall Size:4
STRUCT@string Overall Size:4
STRUCT@boolean Overall Size:1
STRUCT@byte Overall Size:1
STRUCT@word Overall Size:2
STRUCT@dword Overall Size:4
STRUCT@double float Overall Size:8
STRUCT@double integer Overall Size:8
STRUCT@label Overall Size:4
STRUCT@dabel Overall Size:4
STRUCT@integer array Overall Size:4
STRUCT@float array Overall Size:4
STRUCT@string array Overall Size:4
STRUCT@boolean array Overall Size:4
STRUCT@byte array Overall Size:4
STRUCT@word array Overall Size:4
STRUCT@dword array Overall Size:4
STRUCT@double float array Overall Size:4
STRUCT@double integer array Overall Size:4
STRUCT@anytype non casted Overall Size:4
STRUCT@userdefined var ptr Overall Size:4
STRUCT@userdefined array ptr Overall Size:4

USERSTRUCT@vector3df Overall Size:12
STRUCT@x    TYPE>float    OFFSET>0
STRUCT@y    TYPE>float    OFFSET>4
STRUCT@z    TYPE>float    OFFSET>8




FS@wtld_makeObjectCube Overall Size:60 Parameter Count:5
STRUCT@returnvalue    TYPE>integer    OFFSET>0
STRUCT@r    TYPE>integer    OFFSET>4
STRUCT@pos    TYPE>vector3df    OFFSET>8
STRUCT@rot    TYPE>vector3df    OFFSET>20
STRUCT@ews_Parent    TYPE>integer    OFFSET>32
STRUCT@oID    TYPE>integer    OFFSET>36
STRUCT@$L0    TYPE>integer    OFFSET>40
STRUCT@$L1    TYPE>integer    OFFSET>44
STRUCT@$F0    TYPE>float    OFFSET>48
STRUCT@$F1    TYPE>float    OFFSET>52
STRUCT@$F2    TYPE>float    OFFSET>56

Get the latest Matrix1Utility plug-ins (20-APR-2011)

Back to top

Profile PM Email Website

tiresius

23

Years of Service

User Offline

Joined: 13th Nov 2002

Location: MA USA

Posted: 23rd Apr 2011 03:48

Link

68 LINE : test,wtld_makeObjectCube(20,VECTOR_ZERO,VECTOR_ZERO,1)

What is "test," in that line ?

A 3D marble platformer using Newton physics.

Back to top

Profile PM Email

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 23rd Apr 2011 06:57

Link

I've attached the .dbsource that CodeSurge generates when it compiles my project. Perhaps that would help?

Quote: "68 LINE : test,wtld_makeObjectCube(20,VECTOR_ZERO,VECTOR_ZERO,1)

What is "test," in that line ?"

It's the variable holding the generated object ID from the wtld_makeObjectCube() function.

Back to top

Profile PM Email

Diggsey

20

Years of Service

User Offline

Joined: 24th Apr 2006

Location: On this web page.

Posted: 23rd Apr 2011 13:15 Edited at: 23rd Apr 2011 13:19

Link

You're passing in "VECTOR_ZERO" but the global is called "ZERO_VEC"...

This seems to be uncovering some hidden functionality of DBPro. If you look in the DBM file to see what is being passed in it shows $E1 and $E2, these are defined as the following:

@$E1=40 [STRUCT@userdefined var ptr]
@$E2=44 [STRUCT@userdefined var ptr]

I've never seen a userdefined var ptr before

[b]

Back to top

Profile PM Email Website

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 23rd Apr 2011 13:41

Link

Quote: "Quote: "
Quote: "I believe globals can only be accessed by functions declared in the same file so perhaps something similar happens to constants."
That would be news to me.
"
Just wanted to clarify this one. "

Er, yes. I seem to have muddled myself on this one.

I thought I was following the advice given on the following thread but it seems my memory is playing tricks on me (or I failed to understand the advice first time round - choose whichever explanation you like

- in fact both probably apply

):

declaring globals, etc, in functions and files

Back to top

Profile PM Email

IanM

Retired Moderator

23

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 23rd Apr 2011 14:27

Link

Quote: "You're passing in "VECTOR_ZERO" but the global is called "ZERO_VEC"..."

Sometimes we see what we expect to see because that's what is there. And sometimes we see what we expect to see because we expect it.

Well spotted.

Now I can reproduce the problem:

sync on : sync rate 60 :sync

//ENUM: EWS_PARENTS
#constant EWS_NONE -1
#constant EWS_UP 1
#constant EWS_DOWN 2
#constant EWS_LEFT 3
#constant EWS_RIGHT 4
#constant EWS_DYNAMIC 5

global ZERO_VEC as vector3df
ZERO_VEC.x=0 : ZERO_VEC.y=0 : ZERO_VEC.z=0

global check

` Calling with a default variable called VECTOR_ZERO, rather than ZERO_VEC
test=wtld_makeObjectCube(3,VECTOR_ZERO,VECTOR_ZERO,EWS_UP)

repeat
    set cursor 20, 20
    print test, " ", check
    
    sync
until spacekey()

end

type vector3df
    x as float
    y as float
    z as float
endtype

function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
    //Some useful local variables
    local oID as integer : oID=find free object() : //Kinda need this...
    
    //setting up the object
    make object cube oID,r
    position object oID,pos.x,pos.y,pos.z
    rotate object oID,rot.x,rot.y,rot.z
    
    //Putting the object in a group
    //ews_Parent has a very strange value...
    //Not sure why??
    g_o=ews_Parent
    if ews_Parent=EWS_UP
        place object in group oID,EWS_UP
    endif
    if ews_Parent=EWS_DOWN
        place object in group oID,EWS_DOWN
    endif
    if ews_Parent=EWS_RIGHT
        place object in group oID,EWS_RIGHT
    endif
    if ews_Parent=EWS_LEFT
        place object in group oID,EWS_LEFT
    endif
    if ews_Parent=EWS_NONE
        place object in group oID,0
    endif
    if ews_Parent=EWS_DYNAMIC
        place object in group oID,EWS_DYNAMIC
    endif
    //return the object ID instead of index, get that later
    
    check = g_o
endfunction oID

+ Code Snippet

sync on : sync rate 60 :sync

//ENUM: EWS_PARENTS
#constant EWS_NONE -1
#constant EWS_UP 1
#constant EWS_DOWN 2
#constant EWS_LEFT 3
#constant EWS_RIGHT 4
#constant EWS_DYNAMIC 5

global ZERO_VEC as vector3df
ZERO_VEC.x=0 : ZERO_VEC.y=0 : ZERO_VEC.z=0

global check

` Calling with a default variable called VECTOR_ZERO, rather than ZERO_VEC
test=wtld_makeObjectCube(3,VECTOR_ZERO,VECTOR_ZERO,EWS_UP)

repeat
    set cursor 20, 20
    print test, " ", check
    
    sync
until spacekey()

end

type vector3df
    x as float
    y as float
    z as float
endtype


function wtld_makeObjectCube(r as integer,pos as vector3df,rot as vector3df,ews_Parent as integer)
    //Some useful local variables
    local oID as integer : oID=find free object() : //Kinda need this...
    
    //setting up the object
    make object cube oID,r
    position object oID,pos.x,pos.y,pos.z
    rotate object oID,rot.x,rot.y,rot.z
    
    //Putting the object in a group
    //ews_Parent has a very strange value...
    //Not sure why??
    g_o=ews_Parent
    if ews_Parent=EWS_UP
        place object in group oID,EWS_UP
    endif
    if ews_Parent=EWS_DOWN
        place object in group oID,EWS_DOWN
    endif
    if ews_Parent=EWS_RIGHT
        place object in group oID,EWS_RIGHT
    endif
    if ews_Parent=EWS_LEFT
        place object in group oID,EWS_LEFT
    endif
    if ews_Parent=EWS_NONE
        place object in group oID,0
    endif
    if ews_Parent=EWS_DYNAMIC
        place object in group oID,EWS_DYNAMIC
    endif
    //return the object ID instead of index, get that later
    
    check = g_o
endfunction oID

@Dar13, fix your function call and it'll work right. Make your function call with ZERO_VEC instead of VECTOR_ZERO.

The issue is that the function call is not passing a value of type vector3df (it's passing an integer), and is not raising an error for the incorrect type.

Get the latest Matrix1Utility plug-ins (20-APR-2011)

Back to top

Profile PM Email Website

tiresius

23

Years of Service

User Offline

Joined: 13th Nov 2002

Location: MA USA

Posted: 23rd Apr 2011 15:10

Link

Ha that is awesome.

A 3D marble platformer using Newton physics.

Back to top

Profile PM Email

Diggsey

20

Years of Service

User Offline

Joined: 24th Apr 2006

Location: On this web page.

Posted: 23rd Apr 2011 19:25 Edited at: 23rd Apr 2011 19:27

Link

It does let you do a C++ style reinterpret_cast though

+ Code Snippet

type paddingudt
    padding as double integer
endtype


print int2float(UNNAMED, 0, 0x41CC0000) `0x41CC0000 is 25.5 in floating point format

sync
wait key
end

function int2float(p as paddingudt, to#, from)
endfunction to#

[b]

Back to top

Profile PM Email Website

Dar13

18

Years of Service

User Offline

Joined: 12th May 2008

Location: Microsoft VisualStudio 2010 Professional

Posted: 24th Apr 2011 07:20

Link

@IanM, Diggsey, tiresius, Agent, GG
Thanks for all the help,it works fine now that I'm calling the function correctly. Glad we figured this thing out and also discovered an interesting quirk in DBPro.

Back to top

Profile PM Email

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Variables acting very strangely