While loop not running? - GameCreators Forum

Author

Message

CocaCola

16

Years of Service

User Offline

Joined: 23rd Mar 2010

Location: CocaCola.x CocaCola.y CocaCola.z

Posted: 20th May 2011 22:05

Link

Hello, I am trying to get a while loop to loop through all the object numbers then restart and do it again, to test this I added a Text statement which should be on all the time, considering it restarts, but the text never appears! (The COLLIDED one does when I touch the cube, though)

+ Code Snippet

sync on
sync rate 60
autocam off
backdrop on
make camera 1
color backdrop 1,RGB(0,0,255)
make object cube 1, 20
make object cube 2, 20
position object 2,0,0,40

ObjectAmount = 2
do
    x1 = 1
    x = object position x (1)
    y = object position y (1)
    z = object position z (1)
    
    position camera 1, x, y + 120, z
    point camera 1,x,y,z
    
    if (keystate(200) = 1)
        z = z + 1
    endif
    if (keystate(208) = 1)
        z = z - 1
    endif
    if (keystate(203) = 1)
        x = x - 1
    endif
    if (keystate(205) = 1)
        x = x + 1
    endif
    while x1 <= ObjectNum
            text 20,5,"HI"
            x=x+1
    endwhile
    if (object collision (1, 2))
        text 5,5,"COLLIDED"
    endif
    
    position object 1,x,y,z
    
sync
loop

Always program as if the person maintaining your program is a psychopath that knows where you live

Back to top

Profile PM Email

Jimpo

21

Years of Service

User Offline

Joined: 9th Apr 2005

Location:

Posted: 20th May 2011 22:07

Link

Your loop checks 'x1' but you are only changing 'x' in the loop. It's just a simple typo.

Back to top

Profile PM Email Website

No Time To Code

17

Years of Service

User Offline

Joined: 22nd Dec 2008

Location:

Posted: 20th May 2011 22:13

Link

Also, it looks like ObjectNum is not defined so it equals 0. Since x is never <= 0 the loop won't run.

It is not from the benevolence of the butcher, the brewer, or the baker, that we expect our dinner, but from their regard to their own interest. --Adam Smith

Back to top

Profile PM Email

CocaCola

16

Years of Service

User Offline

Joined: 23rd Mar 2010

Location: CocaCola.x CocaCola.y CocaCola.z

Posted: 20th May 2011 22:48 Edited at: 20th May 2011 22:56

Link

Haha, I can't believe I missed both of those

I'm trying to get collision working, so if my player (object 1) touches another object his position will be reset, but it's just showing a black screen with the new while loop, why?

+ Code Snippet

sync on
sync rate 60
autocam off
backdrop on
make camera 1
color backdrop 1,RGB(0,0,255)
make object cube 1, 20
make object cube 2, 20
make object cube 3, 20
make object cube 4, 20
make object cube 5, 20
position object 2,0,0,40
position object 3,60,0,0
position object 4,20,0,40
position object 5,-60,0,20

ObjectAmount = 5
do
    x1 = 2
    x = object position x (1)
    y = object position y (1)
    z = object position z (1)
    
    position camera 1, x, y + 120, z
    point camera 1,x,y,z
    
    if (keystate(200) = 1)
        z = z + 1
    endif
    if (keystate(208) = 1)
        z = z - 1
    endif
    if (keystate(203) = 1)
        x = x - 1
    endif
    if (keystate(205) = 1)
        x = x + 1
    endif
    while x1 <= ObjectAmount
            if object collision (1, x1)
            x = x
            y = y
            z = z
            endif
    endwhile
    if (object collision (1, 2))
        text 5,5,"COLLIDED"
    endif
    
    position object 1,x,y,z
    
sync
loop

Always program as if the person maintaining your program is a psychopath that knows where you live

Back to top

Profile PM Email

WLGfx

18

Years of Service

User Offline

Joined: 1st Nov 2007

Location: NW United Kingdom

Posted: 21st May 2011 03:32

Link

Still you're not changing the variable x1 in your while loop. And your assigning x, y and z to themselves.

Warning! May contain Nuts!

Back to top

Profile PM Email Website

Wyldhunt

16

Years of Service

User Offline

Joined: 27th Sep 2009

Location: The Dark Side

Posted: 21st May 2011 20:30 Edited at: 21st May 2011 23:38

Link

Try this. I haven't tested it in DBP yet, but you can probably get the idea from it if I made a typo.

sync on
sync rate 60
autocam off
backdrop on
make camera 1
color backdrop 1,RGB(0,0,255)
make object cube 1, 20
make object cube 2, 20
make object cube 3, 20
make object cube 4, 20
make object cube 5, 20
position object 2,0,0,40
position object 3,60,0,0
position object 4,20,0,40
position object 5,-60,0,20

ObjectAmount = 5
do
    x1 = 2
    x = object position x (1)
    y = object position y (1)
    z = object position z (1)
    // These allow us to track where the player will be without needing to check object position again
    newx = x
    newy = y
    newz = z    
    position camera 1, x, y + 120, z
    point camera 1,x,y,z
    
    if (keystate(200) = 1)
        newz = z + 1
    endif
    if (keystate(208) = 1)
        newz = z - 1
    endif
    if (keystate(203) = 1)
        newx = x - 1
    endif
    if (keystate(205) = 1)
        newx = x + 1
    endif
    //x1 will always be 2. Object amount will always be 5. You get stuck in the loop.
    REMSTART
    while x1 <= ObjectAmount
            if object collision (1, x1)
            x = x
            y = y
            z = z
            endif
    endwhile
    REMEND
    FOR x1 to ObjectAmount
       //check collision with a different object every time. Not only object 2.
       if object collision (1, x1)
          //Collision: Reset the values to the old values. This is why we used 2 different sets of variables.
          newx = x
          newy = y
          newz = z
          //No need to make another collision check for this
          text 5,5,"COLLIDED"
       endif
    //inc x1         
    NEXT x1
    //Set postion of object 1 to the new positions
    position object 1,newx,newy,newz
sync

+ Code Snippet

sync on
sync rate 60
autocam off
backdrop on
make camera 1
color backdrop 1,RGB(0,0,255)
make object cube 1, 20
make object cube 2, 20
make object cube 3, 20
make object cube 4, 20
make object cube 5, 20
position object 2,0,0,40
position object 3,60,0,0
position object 4,20,0,40
position object 5,-60,0,20

ObjectAmount = 5
do
    x1 = 2
    x = object position x (1)
    y = object position y (1)
    z = object position z (1)
    // These allow us to track where the player will be without needing to check object position again
    newx = x
    newy = y
    newz = z    
    position camera 1, x, y + 120, z
    point camera 1,x,y,z
    
    if (keystate(200) = 1)
        newz = z + 1
    endif
    if (keystate(208) = 1)
        newz = z - 1
    endif
    if (keystate(203) = 1)
        newx = x - 1
    endif
    if (keystate(205) = 1)
        newx = x + 1
    endif
    //x1 will always be 2. Object amount will always be 5. You get stuck in the loop.
    REMSTART
    while x1 <= ObjectAmount
            if object collision (1, x1)
            x = x
            y = y
            z = z
            endif
    endwhile
    REMEND
    FOR x1 to ObjectAmount
       //check collision with a different object every time. Not only object 2.
       if object collision (1, x1)
          //Collision: Reset the values to the old values. This is why we used 2 different sets of variables.
          newx = x
          newy = y
          newz = z
          //No need to make another collision check for this
          text 5,5,"COLLIDED"
       endif
    //inc x1         
    NEXT x1
    //Set postion of object 1 to the new positions
    position object 1,newx,newy,newz
sync

EDIT:
Fixed a minor typo that I noticed... A couple of times.

Back to top

Profile PM

Sorry your browser is not supported!

DarkBASIC Professional Discussion / While loop not running?