Need Help with Array - GameCreators Forum

Author

Message

Rikukarasuma

15

Years of Service

User Offline

Joined: 15th May 2011

Location: Ireland

Posted: 27th Jun 2011 15:26

Link

Im doing an update of a game I created called shape invaders(or space invaders) and instead of using an array to create the shapes i did it manually which took a lot of time.
This time I decided to make another one with the use of an array and possibly make more than more level and a boss but the I cant get the array to work because of an error which I dont know how to resolve.
Runtime error 7006 object number illegal.
If someone could point me in the right direction my thanks wont go a miss

Space Invaders

+ Code Snippet

Rem Project: Space Invaders V1.1
Rem Created: Wednesday, June 22, 2011

Rem ***** Main Source File *****
Gosub DataSetup
Gosub Space

VarsSetup()

MakeObjects0(LightData)
MakeObjects1(PlayerData)
MakeObjects2(InvaderData)
MakeObjects3(CameraData)
MakeObjects4(BoundaryData)
Do

	PlayerControl()
	ScoreText(ScoreData)
	
Sync
Loop

Functions

Rem ***** Included Source File *****
Function VarsSetup()

Version.char = " Invader Engine V2.0"

EndFunction

Function MakeObjects0(LightData)
	
	Light.ID = 1
	Make Light Light.ID
	Position Light Light.ID,0,0,-200
	Color Light Light.ID,RGB(200,255,0)
	Point Light Light.ID,0,0,150

EndFunction

Function MakeObjects1(PlayerData)

CannonStand.ID = 1
	BarrelLarge.ID = 2
	BarrelMedium.ID = 3
	Make Object Box CannonStand.ID,55,45,8
	Make Object Box BarrelLarge.ID,35,25,16
	Make Object BOx BarrelMedium.ID,15,55,8
	Rotate Object BarrelMedium.ID,95,0,0
	Rotate Object BarrelLarge.ID,95,0,0
	Position Object BarrelLarge.ID,0,0,260
	Position Object BarrelMedium.ID,0,0,230
	Position Object CannonStand.ID,0,0,280
	CannonStand.x = Object Position x(CannonStand.ID)
	CannonStand.y = Object Position y(CannonStand.ID)
	CannonStand.z = Object Position z(CannonStand.ID)
	BarrelMedium.x = Object Position x(BarrelMedium.ID)
	BarrelMedium.y = Object Position y(BarrelMedium.ID)
	BarrelMedium.z = Object Position z(BarrelMedium.ID)
	BarrelLarge.x = Object Position x(BarrelLarge.ID)
	BarrelLarge.y = Object Position y(BarrelLarge.ID)
	BarrelLarge.z = Object Position z(BarrelLarge.ID)
	Set Shadow Shading On CannonStand.ID
	Set Shadow Shading On BarrelLarge.ID
	Set Shadow Shading On BarrelMedium.ID
	Color Object CannonStand.ID,RGB(0,0,255)
	Color Object BarrelLarge.ID,RGB(0,0,255)
	Color Object BarrelMedium.ID,RGB(0,0,255)

EndFunction

Function MakeObjects2(InvaderData)
	
	Alien(x,y).ID = 5
	State = 0
	Repeat 
		Inc Alien(x,y).ID,1
		If Object Exist(Alien(x,y).ID) = 0 Then State = 1
	Until State = 1
	For x = 0 to 6
	For y = 0 to 4
		Alien(x,y).Direct = 1
		Alien(x,y).ID = Ship
		Make Object Box Ship,100,20,6
		Position Object Ship,135-(x*30),125-(y*30),0
	Next y
	Next x
	
EndFunction

Function MakeObjects3(CameraData)

Camera.ID = 1
	Make Camera Camera.ID
	Position Camera Camera.ID,0,-500,-50
	Point Camera Camera.ID,0,0,0
	Camera.x = Camera Position x(Camera.ID)
	Camera.y = Camera Position y(Camera.ID)
	Camera.z = Camera Position z(Camera.ID)

EndFunction

Function MakeObjects4(BoundaryData)
	
	Ground.ID = 4
	Make Object Plain Ground.ID,1000,150,30
	Position Object Ground.ID,0,0,300
	Set Shadow Shading On Ground.ID
	Color Object Ground.ID,RGB(0,125,0)
	
	Background.ID = 5
	Make Object Plain Background.ID,1500,1750,0
	Position Object Background.ID,0,0,-120
	Rotate Object Background.ID,70,0,0
	Color Object Background.ID,RGB(0,0,0)
	Set Shadow Shading On Background.ID
			
EndFunction

Function PlayerControl()

If LeftKey() = 1
		Dec BarrelLarge.x,5
		Dec BarrelMedium.x,5
		Dec CannonStand.x,5
	Endif
	
	If RightKey() = 1
		Inc BarrelLarge.x,5
		Inc BarrelMedium.x,5
		Inc CannonStand.x,5
	Endif
	
	Position Object BarrelLarge.ID,BarrelLarge.x,BarrelLarge.y,BarrelLarge.z
	Position Object BarrelMedium.ID,BarrelMedium.x,BarrelMedium.y,BarrelMedium.z
	Position Object CannonStand.ID,CannonStand.x,CannonStand.y,CannonStand.z

EndFunction

Function ScoreText(ScoreData)

Text 0,0,Version.char

EndFunction

+ Code Snippet

Rem ***** Included Source File *****
Function VarsSetup()

	Version.char = " Invader Engine V2.0"

EndFunction

Function MakeObjects0(LightData)
	
	Light.ID = 1
	Make Light Light.ID
	Position Light Light.ID,0,0,-200
	Color Light Light.ID,RGB(200,255,0)
	Point Light Light.ID,0,0,150

EndFunction

Function MakeObjects1(PlayerData)

	CannonStand.ID = 1
	BarrelLarge.ID = 2
	BarrelMedium.ID = 3
	Make Object Box CannonStand.ID,55,45,8
	Make Object Box BarrelLarge.ID,35,25,16
	Make Object BOx BarrelMedium.ID,15,55,8
	Rotate Object BarrelMedium.ID,95,0,0
	Rotate Object BarrelLarge.ID,95,0,0
	Position Object BarrelLarge.ID,0,0,260
	Position Object BarrelMedium.ID,0,0,230
	Position Object CannonStand.ID,0,0,280
	CannonStand.x = Object Position x(CannonStand.ID)
	CannonStand.y = Object Position y(CannonStand.ID)
	CannonStand.z = Object Position z(CannonStand.ID)
	BarrelMedium.x = Object Position x(BarrelMedium.ID)
	BarrelMedium.y = Object Position y(BarrelMedium.ID)
	BarrelMedium.z = Object Position z(BarrelMedium.ID)
	BarrelLarge.x = Object Position x(BarrelLarge.ID)
	BarrelLarge.y = Object Position y(BarrelLarge.ID)
	BarrelLarge.z = Object Position z(BarrelLarge.ID)
	Set Shadow Shading On CannonStand.ID
	Set Shadow Shading On BarrelLarge.ID
	Set Shadow Shading On BarrelMedium.ID
	Color Object CannonStand.ID,RGB(0,0,255)
	Color Object BarrelLarge.ID,RGB(0,0,255)
	Color Object BarrelMedium.ID,RGB(0,0,255)

EndFunction

Function MakeObjects2(InvaderData)
	
	Alien(x,y).ID = 5
	State = 0
	Repeat 
		Inc Alien(x,y).ID,1
		If Object Exist(Alien(x,y).ID) = 0 Then State = 1
	Until State = 1
	For x = 0 to 6
	For y = 0 to 4
		Alien(x,y).Direct = 1
		Alien(x,y).ID = Ship
		Make Object Box Ship,100,20,6
		Position Object Ship,135-(x*30),125-(y*30),0
	Next y
	Next x
	
EndFunction

Function MakeObjects3(CameraData)

	Camera.ID = 1
	Make Camera Camera.ID
	Position Camera Camera.ID,0,-500,-50
	Point Camera Camera.ID,0,0,0
	Camera.x = Camera Position x(Camera.ID)
	Camera.y = Camera Position y(Camera.ID)
	Camera.z = Camera Position z(Camera.ID)

EndFunction

Function MakeObjects4(BoundaryData)
	
	Ground.ID = 4
	Make Object Plain Ground.ID,1000,150,30
	Position Object Ground.ID,0,0,300
	Set Shadow Shading On Ground.ID
	Color Object Ground.ID,RGB(0,125,0)
	
	Background.ID = 5
	Make Object Plain Background.ID,1500,1750,0
	Position Object Background.ID,0,0,-120
	Rotate Object Background.ID,70,0,0
	Color Object Background.ID,RGB(0,0,0)
	Set Shadow Shading On Background.ID
			
EndFunction

Function PlayerControl()

	If LeftKey() = 1
		Dec BarrelLarge.x,5
		Dec BarrelMedium.x,5
		Dec CannonStand.x,5
	Endif
	
	If RightKey() = 1
		Inc BarrelLarge.x,5
		Inc BarrelMedium.x,5
		Inc CannonStand.x,5
	Endif
	
	Position Object BarrelLarge.ID,BarrelLarge.x,BarrelLarge.y,BarrelLarge.z
	Position Object BarrelMedium.ID,BarrelMedium.x,BarrelMedium.y,BarrelMedium.z
	Position Object CannonStand.ID,CannonStand.x,CannonStand.y,CannonStand.z

EndFunction

Function ScoreText(ScoreData)

	Text 0,0,Version.char

EndFunction

Space

Rem ***** Included Source File *****
DataSetup:

Type BoundaryData
		ID as Integer
	EndType

Type LightData
		x as Float
		y as Float
		z as Float
		ID as Integer
	EndType

Type PlayerData
		x as Float
		y as Float
		z as Float
		ID as Integer
	EndType

Type InvaderData
		x as Float
		y as Float
		z as Float
		ID as Integer
		Direct as Byte
	EndType
	
	Type BulletData
		y as Float
	EndType
	
	Type ScoreData
		y as Float
		x as Float
		z as Float
		Total as Integer
		Char as String
	EndType
	
	Type CameraData
		x as Float
		y as Float
		z as Float
		ID as Integer
	EndType
	
	Global Light as LightData
	Global CannonStand as PlayerData
	Global BarrelLarge as PlayerData
	Global BarrelMedium as PlayerData
	Global Alien as InvaderData
	Dim Alien(6,4) as InvaderData
	Global Bullet as BulletData
	Global Points as ScoreData
	Global Camera as CameraData
	Global Version as ScoreData
	Global Ground as BoundaryData
	Global Background as BoundaryData

Return

Space:

Sync On
	Sync Rate 60
	
	BackDrop Off
	
	AutoCam Off
	
Return

+ Code Snippet

Rem ***** Included Source File *****
DataSetup:

	Type BoundaryData
		ID as Integer
	EndType

	Type LightData
		x as Float
		y as Float
		z as Float
		ID as Integer
	EndType

	Type PlayerData
		x as Float
		y as Float
		z as Float
		ID as Integer
	EndType

	Type InvaderData
		x as Float
		y as Float
		z as Float
		ID as Integer
		Direct as Byte
	EndType
	
	Type BulletData
		y as Float
	EndType
	
	Type ScoreData
		y as Float
		x as Float
		z as Float
		Total as Integer
		Char as String
	EndType
	
	Type CameraData
		x as Float
		y as Float
		z as Float
		ID as Integer
	EndType
	
	Global Light as LightData
	Global CannonStand as PlayerData
	Global BarrelLarge as PlayerData
	Global BarrelMedium as PlayerData
	Global Alien as InvaderData
	Dim Alien(6,4) as InvaderData
	Global Bullet as BulletData
	Global Points as ScoreData
	Global Camera as CameraData
	Global Version as ScoreData
	Global Ground as BoundaryData
	Global Background as BoundaryData

Return

Space:

	Sync On
	Sync Rate 60
	
	BackDrop Off
	
	AutoCam Off
	
Return

Yello http://www.youtube.com/user/Rikukarasuma?feature=mhee

Back to top

Profile PM Email Website

Vitamin

15

Years of Service

User Offline

Joined: 15th Oct 2010

Location:

Posted: 27th Jun 2011 16:46

Link

Hey brah,
When you declare an array, I think that number refers to the number of elements in the array, and not the upper subscript. So it really has 0-5 in the first dimension, and 0-3 in the 2nd. I'm not sure if that's right, but to test it, try one less counter in each of your for...next loops in the MakeObject2 function.
Also, this is totally unrelated, but in your game loop, space invader positions aren't being updated, so the MakeObject2 function might work better in the loop.

Back to top

Profile PM

Rikukarasuma

15

Years of Service

User Offline

Joined: 15th May 2011

Location: Ireland

Posted: 27th Jun 2011 17:00

Link

Hey Vitamin that doesnt seem to be the problem. The same thing is still happening :/
And yeah i always forget to update their positions and then i realise it when i run the program lol

Yello http://www.youtube.com/user/Rikukarasuma?feature=mhee

Back to top

Profile PM Email Website

Vitamin

15

Years of Service

User Offline

Joined: 15th Oct 2010

Location:

Posted: 27th Jun 2011 17:08

Link

Hey brah,
You may have to disregard my first post, LOL...I don't think it has to do with an array out-of-bounds error. I'm not really sure what it is, but maybe it has to do with the fact that you're using floats to refer to elements in the array.

Back to top

Profile PM

Grog Grueslayer

Valued Member

21

Years of Service

User Offline

Joined: 30th May 2005

Playing: Green Hell

Posted: 27th Jun 2011 18:03

Link

It's because Ship=0 and you can't have an object number zero.

+ Code Snippet

Function MakeObjects2(InvaderData)
	
	Alien(x,y).ID = 5
	State = 0
	Repeat 
		Inc Alien(x,y).ID,1
		If Object Exist(Alien(x,y).ID) = 0 Then State = 1
	Until State = 1
	For x = 0 to 6
	For y = 0 to 4
		Alien(x,y).Direct = 1
		Alien(x,y).ID = Ship
		
		` Added to test
		print "Ship = "+str$(Ship)
		sync
		wait key
		
		if Ship>0
		 Make Object Box Ship,100,20,6
		 Position Object Ship,135-(x*30),125-(y*30),0
	   endif
	Next y
	Next x
	
EndFunction

Back to top

Profile PM Email

Rikukarasuma

15

Years of Service

User Offline

Joined: 15th May 2011

Location: Ireland

Posted: 27th Jun 2011 18:39

Link

Thanks for that Grog but it seems if i put anything after the code you fixed for me it still comes up Object number illegal :/

Yello http://www.youtube.com/user/Rikukarasuma?feature=mhee

Back to top

Profile PM Email Website

Vitamin

15

Years of Service

User Offline

Joined: 15th Oct 2010

Location:

Posted: 27th Jun 2011 18:47

Link

This might be another unrelated issue, but when you call the MakeObject functions, you're passing them UDT's instead of instances of the UDT's.

Back to top

Profile PM

IanM

Retired Moderator

23

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 27th Jun 2011 20:47

Link

Ship is not declared as a global, therefore it is a local to the MakeObjects2 function. You haven't assigned anything to it, therefore it will have a value of zero. You use it to set the ID in the Alien array, therefore the Alien array ID will be zero. You use that to create an object, but as you can't have an object id of zero, it crashes.

Now say 'thank you' to Grog, and then correct your code

Get the latest Matrix1Utility plug-ins (20-APR-2011)

Back to top

Profile PM Email Website

Rikukarasuma

15

Years of Service

User Offline

Joined: 15th May 2011

Location: Ireland

Posted: 27th Jun 2011 22:20

Link

I already said thanks to grog but il say it again. thank you grog.

Okay I understand what your saying but even when I correct that error I cant get the Array to work in the way I want it to make 7 aliens across and 5 rows :/

Yello http://www.youtube.com/user/Rikukarasuma?feature=mhee

Back to top

Profile PM Email Website

Grog Grueslayer

Valued Member

21

Years of Service

User Offline

Joined: 30th May 2005

Playing: Green Hell

Posted: 28th Jun 2011 00:43 Edited at: 28th Jun 2011 00:44

Link

@ IanM:

Thanks

@ Rikukarasuma:

Np. That code snip was to show you what was going on (and to teach you how to find errors like that yourself). For the actual fix you just move the setting of the starting object number and finding of the first free object number into the FOR/NEXT for the alien creation.

+ Code Snippet

Function MakeObjects2(InvaderData)
                
        For x = 0 to 6
        For y = 0 to 4
          		 ` Start Alien ID at object number 5
          		 Alien(x,y).ID = 5
          		 ` Find first free object number
          		 Repeat 
                	Inc Alien(x,y).ID,1
          	    Until Object Exist(Alien(x,y).ID) = 0
   
                Alien(x,y).Direct = 1
                ` Make Ship equal Alien ID
                Ship = Alien(x,y).ID
                
                Make Object Box Ship,100,20,6
                Position Object Ship,135-(x*30),125-(y*30),0
        Next y
        Next x
        
EndFunction

Now if you didn't know already IanM made some amazing commands in a plugin called Matrix 1 Utilities Plugin. One of the cool commands is FIND FREE OBJECT() which will do the same as your REPEAT/UNTIL loop to find the free object number (but much faster).

+ Code Snippet

Function MakeObjects2(InvaderData)
                
        For x = 0 to 6
        For y = 0 to 4
          		 ` Find first free object number with IanMs command (between object numbers 6 to 262,144)
          		 Alien(x,y).ID=find free object(6,262144)
                Alien(x,y).Direct = 1
                ` Make Ship equal Alien ID
                Ship = Alien(x,y).ID
                
                Make Object Box Ship,100,20,6
                Position Object Ship,135-(x*30),125-(y*30),0
        Next y
        Next x
        
EndFunction

Just click on IanMs signature to download it.

Edit: Your indentation is all weird... are you using just TAB or TAB with spacebar?

Back to top

Profile PM Email

Rikukarasuma

15

Years of Service

User Offline

Joined: 15th May 2011

Location: Ireland

Posted: 28th Jun 2011 00:57

Link

Thanks a million Grog!

i will try that out right away

okies i will check that out

I do use Tab for my indents

Yello http://www.youtube.com/user/Rikukarasuma?feature=mhee

Back to top

Profile PM Email Website

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Need Help with Array