Weapon shooting problem. Box2D - GameCreators Forum

Author

Message

z i l c h vortex

19

Years of Service

User Offline

Joined: 20th Feb 2007

Location: united kingdom

Posted: 25th Oct 2011 02:37

Link

For some reason when I shoot my weapon and I change between my weapons while im shooting the projectiles stop spawning. Here's the code for my weapon selection

+ Code Snippet

if keystate(2) 
        currweap = 1
    else
    if keystate(3)
        currweap = 2    
    endif
    endif
    
    if mouseclick()
        SHOOT(weap(currweap).radius, weap(currweap).density, weap(currweap).friction, weap(currweap).restitution, weap(currweap).force, weap(currweap).freq, weap(currweap).doc)       
    endif

And here's the code that is the shoot function

FUNCTION SHOOT(radius, density, friction#, restitution#, force#, freq, doc)

if bull(f).active = 0
    if char.shooting = 0
        char.shooting = 1
         
        bull(f).active = 1    
        bull(f).shapeID    = B2CREATECIRCLESHAPE( 0, 0 ,radius ) 
        bull(f).bodyID     = B2CREATEBODY( world, B2BODYTYPE_DYNAMIC(), B2GETBODYPOSITIONX( weap.bodyID ), B2GETBODYPOSITIONY( weap.bodyID ), B2GETBODYANGLE(weap.bodyID), 0, 1 )
        bull(f).fixtureID  = B2CREATEFIXTURE( bull(f).bodyID, bull(f).shapeID, density, friction#, restitution# )  
    
        B2SETBODYISBULLET bull(f).bodyID, 1 
        B2APPLYBODYLINEARIMPULSE bull(f).bodyID,(cos(B2GETBODYANGLE(weap.bodyID)-90)*force#)* multi,(sin(B2GETBODYANGLE(weap.bodyID)-90)*force#)* multi,B2GETBODYPOSITIONX( weap.bodyID ), B2GETBODYPOSITIONY( weap.bodyID )
        if f = 30 then f = 0 
         
    ENDIF
   
    ENDIF
    
    IF char.shooting > 0
        inc char.shooting,1
        if char.shooting = freq
            
            char.shooting = 0
            f = f + 1
        ENDIF
    ENDIF

for i = 0 to 30
        if bull(i).active = 1
            
            B2FINDBODYCONTACTS bull(i).bodyID 
            if doc = 1
                if B2GETCONTACT()
                    fixturea = B2GETCONTACTFIXTUREA()
                    fixtureb = B2GETCONTACTFIXTUREB()
                    bodya    = B2GETFIXTUREBODY(fixturea)
                    bodyb    = B2GETFIXTUREBODY(fixtureb)
                
                if bodya = ground1 or bodyb = ground1
                
                    B2DELETEBODY bull(i).bodyID 
      
                    bull(i).bodyID    = 0
                    bull(i).shapeID   = 0
                    bull(i).fixtureID = 0
                    bull(i).active    = 0
                    bull(i).timer     = 0
                ENDIF
                
                if bodya = ground2 or bodyb = ground2
                
                   B2DELETEBODY bull(i).bodyID

bull(i).bodyID    = 0
                   bull(i).shapeID   = 0
                   bull(i).fixtureID = 0
                   bull(i).active    = 0
                   bull(i).timer     = 0
                ENDIF
            endif
            endif
            
            inc bull(i).timer,1
            
            if bull(i).timer > 100
                B2DELETEBODY bull(i).bodyID

bull(i).bodyID    = 0
                bull(i).shapeID   = 0
                bull(i).fixtureID = 0
                bull(i).active = 0
                bull(i).timer = 0
            ENDIF
                   
            
            
            
            
        ENDIF
    next i
ENDFUNCTION

+ Code Snippet

FUNCTION SHOOT(radius, density, friction#, restitution#, force#, freq, doc)
    

    if bull(f).active = 0
    if char.shooting = 0
        char.shooting = 1
         
        bull(f).active = 1    
        bull(f).shapeID    = B2CREATECIRCLESHAPE( 0, 0 ,radius ) 
        bull(f).bodyID     = B2CREATEBODY( world, B2BODYTYPE_DYNAMIC(), B2GETBODYPOSITIONX( weap.bodyID ), B2GETBODYPOSITIONY( weap.bodyID ), B2GETBODYANGLE(weap.bodyID), 0, 1 )
        bull(f).fixtureID  = B2CREATEFIXTURE( bull(f).bodyID, bull(f).shapeID, density, friction#, restitution# )  
    
        B2SETBODYISBULLET bull(f).bodyID, 1 
        B2APPLYBODYLINEARIMPULSE bull(f).bodyID,(cos(B2GETBODYANGLE(weap.bodyID)-90)*force#)* multi,(sin(B2GETBODYANGLE(weap.bodyID)-90)*force#)* multi,B2GETBODYPOSITIONX( weap.bodyID ), B2GETBODYPOSITIONY( weap.bodyID )
        if f = 30 then f = 0 
         
    ENDIF
   
    ENDIF
    
    IF char.shooting > 0
        inc char.shooting,1
        if char.shooting = freq
            
            char.shooting = 0
            f = f + 1
        ENDIF
    ENDIF    
        

    
    for i = 0 to 30
        if bull(i).active = 1
            
            B2FINDBODYCONTACTS bull(i).bodyID 
            if doc = 1
                if B2GETCONTACT()
                    fixturea = B2GETCONTACTFIXTUREA()
                    fixtureb = B2GETCONTACTFIXTUREB()
                    bodya    = B2GETFIXTUREBODY(fixturea)
                    bodyb    = B2GETFIXTUREBODY(fixtureb)
                
                if bodya = ground1 or bodyb = ground1
                
                    B2DELETEBODY bull(i).bodyID 
      
                    bull(i).bodyID    = 0
                    bull(i).shapeID   = 0
                    bull(i).fixtureID = 0
                    bull(i).active    = 0
                    bull(i).timer     = 0
                ENDIF
                
                if bodya = ground2 or bodyb = ground2
                
                   B2DELETEBODY bull(i).bodyID 

                   bull(i).bodyID    = 0
                   bull(i).shapeID   = 0
                   bull(i).fixtureID = 0
                   bull(i).active    = 0
                   bull(i).timer     = 0
                ENDIF
            endif
            endif
            
            inc bull(i).timer,1
            
            if bull(i).timer > 100
                B2DELETEBODY bull(i).bodyID 

                bull(i).bodyID    = 0
                bull(i).shapeID   = 0
                bull(i).fixtureID = 0
                bull(i).active = 0
                bull(i).timer = 0
            ENDIF
                   
            
            
            
            
        ENDIF
    next i
ENDFUNCTION

It makes no sense why it doesn't work. If you stop shooting then change weapon and start shooting again it works.

life is short but so am i

Back to top

Profile PM Email

basjak

16

Years of Service

User Offline

Joined: 16th Apr 2010

Location: feel like signing up for mars

Posted: 25th Oct 2011 04:14

Link

can you provide the whole loop in the main program

Back to top

Profile PM Email Website

z i l c h vortex

19

Years of Service

User Offline

Joined: 20th Feb 2007

Location: united kingdom

Posted: 26th Oct 2011 01:03

Link

Yeah sure, here it is :-

+ Code Snippet

DO
    B2SETDEBUGDRAW drawShapes, drawJoints, drawAABBs, drawPairs, drawCenters
    
    MOVEMENT()
    
    if keystate(2) 
        currweap = 1
    else
    if keystate(3)
        currweap = 2    
    endif
    endif
    
    if mouseclick()
        SHOOT(weap(currweap).radius, weap(currweap).density, weap(currweap).friction, weap(currweap).restitution, weap(currweap).force, weap(currweap).freq, weap(currweap).doc)       
    endif
            
    B2SETSCREENTRANSFORM -char.PosX#+(SCREEN WIDTH()/2), -char.PosY#+(SCREEN HEIGHT()/2), 1, 0
    
    
    B2STEPWORLD world, 1.0/60.0
    B2DRAWWORLD world, drawDebug

    SYNC
    CLS -1
    
LOOP

life is short but so am i

Back to top

Profile PM Email

baxslash

Valued Member

Bronze Codemaster

19

Years of Service

User Offline

Joined: 26th Dec 2006

Location: Duffield

Posted: 26th Oct 2011 11:37 Edited at: 26th Oct 2011 11:38

Link

My guess is you aren't setting the value of "f" near the start of your SHOOT function so only weapon 0 is updated:

+ Code Snippet

if bull(f).active = 0

Back to top

Profile PM Email

z i l c h vortex

19

Years of Service

User Offline

Joined: 20th Feb 2007

Location: united kingdom

Posted: 27th Oct 2011 02:29

Link

Sorry to say but i'm confused

Would you mind looking at my code and fixing it for me please.

life is short but so am i

Back to top

Profile PM Email

z i l c h vortex

19

Years of Service

User Offline

Joined: 20th Feb 2007

Location: united kingdom

Posted: 29th Oct 2011 02:28

Link

I've had numerous attempts but I still can't find the solution. Would someone mind looking over my code please?

life is short but so am i

Back to top

Profile PM Email

z i l c h vortex

19

Years of Service

User Offline

Joined: 20th Feb 2007

Location: united kingdom

Posted: 2nd Nov 2011 23:39 Edited at: 3rd Nov 2011 01:21

Link

Sorry to post again. But i'm still in need of help, really can't figure this one out :/

EDIT: For some reason if you play with the frequency variables certain values stop the problem from happening.

life is short but so am i

Back to top

Profile PM Email

z i l c h vortex

19

Years of Service

User Offline

Joined: 20th Feb 2007

Location: united kingdom

Posted: 4th Nov 2011 00:51

Link

Problem is fixed noww. Something so simple that it was annoying when i found out the

+ Code Snippet

 if char.shooting = freq

statement needed to be

+ Code Snippet

 if char.shooting > freq

Thank you to everyone that helped.

life is short but so am i

Back to top

Profile PM Email

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Weapon shooting problem. Box2D