Enemies are not spawning in their locations.

Author

Message

vitinho444

14

Years of Service

User Offline

Joined: 12th Oct 2010

Location:

Posted: 15th Jan 2012 13:42

Link

Hey all

I recently got the Enemy1 Struct array working and now i got multiple enemies with the same base.. xD

So.. After the includes i added:

+ Code Snippet

float En1X [10] = { 100, 100, 100, 100, 100, 100, 100, 100, 100, 100};
float En1Y [10] = { 100, 100, 100, 100, 100, 100, 100, 100, 100, 100};

This is the Enemies (array of enemy1) Spawn Positions. Each one for each enemy.

So, you can see that there are 10 values for X and for Y.

So at the LoadEnemy function i got:

+ Code Snippet

void Enemy1::LoadEnemy(int PosID)
{
	
	int rnd = GetFreeSpriteID();
	id = rnd + 200 + dbRnd(EnemyCount + 10);
	dbLoadImage("enemy1.png", id);
	//speed = -0.5 * round; //Just using the speed 0 for testing the spawn position.
	speed = 0;
	score = 100;
	hp = 100;

	spawnX = En1X[PosID]; //Here i got the SpawnX of the array previously created...
	spawnY = En1Y[PosID];

	int reload = PosID;

	
	sizeX = 35;
	sizeY = 10;

	cSpawn = true;
	alive = true;
}

Then in the Spawn i simply got this:

+ Code Snippet

void Enemy1::Spawn()
{
	dbSprite(id, spawnX, spawnY, id);
}

I also have at the Main Function:

+ Code Snippet

for(int n = 0;n<10;n++)
	{
		enemy1[n].LoadEnemy(n);
	}

So basicly this will Load the array and automaticly points that enemy array "id" and checks that ID in the Position arrays..

It should work right?

Well the problem is they are not spawning at that positions.

Here's all the positions:

Enemy1: 100 100
Enemy2: 100 100
Enemy3: 100 100
Enemy4: 100 100
Enemy5: 200 -600
Enemy6: 200 -600
Enemy7: -400 700
Enemy8: 100 100
Enemy9: 100 100
Enemy10: 100 100

So the Enemy5, 6, and 7 are not spawning on their locations..

Why this happens?

Here you have the entire struct of the Enemy1:

+ Code Snippet

struct Enemy1
{
	public:
	void LoadEnemy(int PosID);
	void Spawn();
	void Move(int LastX, int LastY);
	void Update();
	void Reload();
	void DestroyEnemy(int spawwtime);

	bool cSpawn;
	bool alive;


	float speed;
	int hp;
	int spawnX, spawnY;
	int id;
	int x, y, sizeX, sizeY;
	int score;

}enemy1 [10];

/////////////////////////////////////////////////////////
/*
================================================
                  ENEMY 1
================================================
*/
void Enemy1::LoadEnemy(int PosID)
{
	
	int rnd = GetFreeSpriteID();
	id = rnd + 200 + dbRnd(EnemyCount + 10);
	dbLoadImage("enemy1.png", id);
	//speed = -0.5 * round;
	speed = 0;
	score = 100;
	hp = 100;

spawnX = En1X[PosID];
	spawnY = En1Y[PosID];

int reload = PosID;

sizeX = 35;
	sizeY = 10;

cSpawn = true;
	alive = true;
}

void Enemy1::Move(int LastX, int LastY)
{
	PointSprite(id, LastX, LastY);
	dbMoveSprite(id, speed);	
}

void Enemy1::Update()
{
	x = dbSpriteX(id);
	y = dbSpriteY(id);
	if(cSpawn)
	{
		Spawn();
		EnemyCount += 1;

cSpawn = false;
	}

if(!dbSpriteCollision(id, 1))
	{
		Move(player.x + player.SizeX, player.y + player.SizeY);
	}
	else
	{
		//remove player hp
	}
}

void Enemy1::Spawn()
{
	dbSprite(id, spawnX, spawnY, id);
}

void Enemy1::DestroyEnemy(int spawntime)
{
	dbDeleteSprite(id);
}

void Enemy1::Reload()
{
	
}

+ Code Snippet

/////////////////////////////////////////////////////////
/*
================================================
                  ENEMY 1
================================================
*/
void Enemy1::LoadEnemy(int PosID)
{
	
	int rnd = GetFreeSpriteID();
	id = rnd + 200 + dbRnd(EnemyCount + 10);
	dbLoadImage("enemy1.png", id);
	//speed = -0.5 * round;
	speed = 0;
	score = 100;
	hp = 100;

	spawnX = En1X[PosID];
	spawnY = En1Y[PosID];

	int reload = PosID;

	
	sizeX = 35;
	sizeY = 10;

	cSpawn = true;
	alive = true;
}


void Enemy1::Move(int LastX, int LastY)
{
	PointSprite(id, LastX, LastY);
	dbMoveSprite(id, speed);	
}

void Enemy1::Update()
{
	x = dbSpriteX(id);
	y = dbSpriteY(id);
	if(cSpawn)
	{
		Spawn();
		EnemyCount += 1;

		cSpawn = false;
	}

	if(!dbSpriteCollision(id, 1))
	{
		Move(player.x + player.SizeX, player.y + player.SizeY);
	}
	else
	{
		//remove player hp
	}
}

void Enemy1::Spawn()
{
	dbSprite(id, spawnX, spawnY, id);
}

void Enemy1::DestroyEnemy(int spawntime)
{
	dbDeleteSprite(id);
}

void Enemy1::Reload()
{
	
}

C++ Medium 3.5/5
www.oryzhon.com <-- My company's website (W.I.P)

Back to top

Profile PM Email Website

Hawkblood

14

Years of Service

User Offline

Joined: 5th Dec 2009

Location:

Posted: 16th Jan 2012 14:50

Link

Quote: " id = rnd + 200 + dbRnd(EnemyCount + 10);
dbLoadImage("enemy1.png", id);
"

This could be problematic. Your "id" is some random number near the sprite ID you got in the previous function +200....? Why? This could create/fail loading the image without you knowing what the id actually is (you could have overlap).

Also

Quote: "Move(player.x + player.SizeX, player.y + player.SizeY);"

is not going to give you the result you want. The "size" value I posted for you before was to be used if you weren't going to be using sprite collision testing. Take the size values out-- you don't need them and they will cause your enemies to target in front of your player (Right and Down).

Quote: "for(int n = 0;n<10;n++)
{
enemy1[n].LoadEnemy(n);
}"

I this in your loop? If so, put it before your loop.

To answer your original question, I think the problem will be corrected by correcting the code I pointed out first.

The fastest code is the code never written.

Back to top

Profile PM Email Website

vitinho444

14

Years of Service

User Offline

Joined: 12th Oct 2010

Location:

Posted: 16th Jan 2012 15:18

Link

So.. How can i make so the ID wont be the same in some enemies?
That error was causing me some problems.. :S

Ok, i fixed out what you have said and its working

Thanks a lot, you are the man!!!

C++ Medium 3.5/5
www.oryzhon.com <-- My company's website (W.I.P)

Back to top

Profile PM Email Website

Hawkblood

14

Years of Service

User Offline

Joined: 5th Dec 2009

Location:

Posted: 16th Jan 2012 18:21

Link

The whole idea behind "GetFreeSpriteID();" is that it returns a unique ID. That way you don't accedentally use the same ID for two different sprites.

The fastest code is the code never written.

Back to top

Profile PM Email Website

vitinho444

14

Years of Service

User Offline

Joined: 12th Oct 2010

Location:

Posted: 16th Jan 2012 19:06

Link

No thats not the problem acutally...

That function is working right, but i load the enemy and only in the Update (Loop) i spawn them.. So.. Its like:

Load Enemy8574875497854
ID: 5 is free

Load Enemy969879567845854
ID: 5 is free

Then they spawn with the same id, it will add both things to 1...
Thats the error actually..

C++ Medium 3.5/5
www.oryzhon.com <-- My company's website (W.I.P)

Back to top

Profile PM Email Website

Hawkblood

14

Years of Service

User Offline

Joined: 5th Dec 2009

Location:

Posted: 16th Jan 2012 20:57

Link

It looks like you are:

Quote: "void Enemy1::LoadEnemy(int PosID)"

10 times. At least somewhere in your code. This code is unpredictable (because of the random):

Quote: "id = rnd + 200 + dbRnd(EnemyCount + 10);"

and can produce an image id that is the same as another. This will cause your load to fail. It's not actually a problem, but your code is not using unique instances or loads of the same image. I suggest you load the image once and assign it to all your sprites-- this is the more precise way to do it.

So if you change your code:

+ Code Snippet

//somewhere before your LoopGDK()
int EnemyImage=FindFreeImage();//whatever you use to get unique image IDs
dbLoadImage("Enemy1.png",EnemyImage);

and....

+ Code Snippet

void Enemy1::LoadEnemy(int PosID)
{
	id=GetFreeSpriteID();
//****************************************
//	int rnd = GetFreeSpriteID();
//	id = rnd + 200 + dbRnd(EnemyCount + 10);
//	dbLoadImage("enemy1.png", id);
//****************************************
	//speed = -0.5 * round; //Just using the speed 0 for testing the spawn position.
	speed = 0;
	score = 100;
	hp = 100;

	spawnX = En1X[PosID]; //Here i got the SpawnX of the array previously created...
	spawnY = En1Y[PosID];

	int reload = PosID;

	
	sizeX = 35;
	sizeY = 10;

	cSpawn = true;
	alive = true;
}
void Enemy1::Spawn()
{
	dbSprite(id, spawnX, spawnY, EnemyImage);//********* NOTICE THE CHANGE?
}

This will only load the image once (using less memory) and each Enemy will have it's unique sprite ID without the possibility of overlap.
By the way, what does your "GetFreeSpriteID();" look like? I invision it to look like:

+ Code Snippet

int GetFreeSpriteID(void){
  int q;
  for (q=1;q<10000;q++) if (dbSpriteExist(q)==0) break;
  return q;
}

The fastest code is the code never written.

Back to top

Profile PM Email Website

vitinho444

14

Years of Service

User Offline

Joined: 12th Oct 2010

Location:

Posted: 16th Jan 2012 21:22

Link

Actually its:

+ Code Snippet

int GetFreeSpriteID ( void )
{
	int id = 0;
	while ( dbSpriteExist ( ++id ) );
	return id;
}

I tested using the same image id but the enemies position switched to -1, -1... not sure why but when i use what im using now its working good..

Basicly it loads an image to each enemy but that id only belongs to that enemy... How much memory can it use

?

C++ Medium 3.5/5
www.oryzhon.com <-- My company's website (W.I.P)

Back to top

Profile PM Email Website

Hawkblood

14

Years of Service

User Offline

Joined: 5th Dec 2009

Location:

Posted: 16th Jan 2012 21:59

Link

Quote: "How much memory can it use"

It depends on the image size.

I'm not sure what you were doing wrong before, but I know that you can assign the same image to multiple sprites at the same time.

The fastest code is the code never written.

Back to top

Profile PM Email Website

vitinho444

14

Years of Service

User Offline

Joined: 12th Oct 2010

Location:

Posted: 16th Jan 2012 22:06

Link

well.. the image is just... 48x15.. not a full background..

C++ Medium 3.5/5
www.oryzhon.com <-- My company's website (W.I.P)

Back to top

Profile PM Email Website

Hawkblood

14

Years of Service

User Offline

Joined: 5th Dec 2009

Location:

Posted: 16th Jan 2012 22:13

Link

Even if you are just starting out or your games are very small, you should always try to reduce the programs footprint in memory useage and in clock cycles. It will get very messy and clumsy quickly with larger programs.

The fastest code is the code never written.

Back to top

Profile PM Email Website

vitinho444

14

Years of Service

User Offline

Joined: 12th Oct 2010

Location:

Posted: 16th Jan 2012 22:33

Link

true :X xD

Thanks a lot

C++ Medium 3.5/5
www.oryzhon.com <-- My company's website (W.I.P)

Back to top

Profile PM Email Website

Sorry your browser is not supported!

Dark GDK / Enemies are not spawning in their locations.