Crash on Exit After Reading From Array

Author

Message

Sigh

20

Years of Service

User Offline

Joined: 26th Dec 2005

Location: The Big 80s

Posted: 10th Apr 2012 03:38

Link

An odd problem I need another pair of eyes to look at.

I\'ve got a resource index/version control database I\'m trying to implement and the program crashes on exit at seemingly random times. The only item I\'ve been able to successfully look up w/o errors is \"BMN-12\" (see the attached database).

It seems the program successfully loads the entire DB. However, several problems rear their ugly heads when you try to look up a resource. First, if the resource isn\'t found, the program crashes on exit. Second, the DB lookup code returns with failure even if it should find the item in the DB.

Anyone have any ideas about what the problem could be? Note that when I have the program just print out the DB there\'s no crash, even though I don\'t clean up memory before terminating the program.

Thanks for the help.

type Database_Entry
Designator as string
Path as string
Version as string
endtype

type Environment_Variables
Version as string
DatabaseLoaded as boolean
Directory as string
endtype

dim Database() as Database_Entry
global Database

global Environment as Environment_Variables

set display mode 1440, 900, 32

Database_Load()

`Enable for error (use \"BMN-12\" for success)
P$ = Database_Get_Path(\"TBSM-0002\")
print P$

`Enable to print the DB to the screen
`for a = 0 to a

Keep your Hope & Change to yourself, I choose Liberty! Stop by for a chat! [IXE]Nateholio on irc.maxgaming.net:6667 #GarageGames

Back to top

Profile PM

Mage

Valued Member

19

Years of Service

User Offline

Joined: 3rd Feb 2007

Location:

Posted: 10th Apr 2012 04:20

Link

P$ = Database_Get_Path(\"TBSM-0002\")

You are mixing types here. If you are passing a string here then the quotes should be around the entire "thing" being passed to the function.

I'd be surprised if this was intentional.

Back to top

Profile PM

Nateholio

20

Years of Service

User Offline

Joined: 30th Dec 2005

Location: I\'ve Been Everywhere

Posted: 10th Apr 2012 20:53

Link

Thanks for the idea, but those slashes got added by Apollo. My internets has been flaky lately so half the post got cut off. Let's try this again....

type Integer_2
   X as integer
   Y as integer
endtype

type Database_Entry
   Designator as string
   Path as string
   Version as string
endtype

type Display_Resolution
   Resolution as Integer_2
   Depth as byte
endtype
type Display_Entry
   Mode as Display_Resolution
endtype

type Environment_Variables
   Version as string
   DatabaseLoaded as boolean
   Directory as string
endtype

dim Database() as Database_Entry
global Database

dim Display() as Display_Entry
empty array Display()
global Display

global Environment as Environment_Variables

Display_Initialize()
Database_Load()

`Enable for database printout...works flawlessly
`for a = 0 to array count(Database())
`   print Database(a).Designator; " "; Database(a).Path; " "; Database(a).Version
`next a

`Enable for flawless database lookup
`print Database_Get_Path("BMN-12")
`print Database_Get_Version("BMN-12")

`Enable for error and crash when there should be success
`print Database_Get_Path("CBSM-0000")

`Enable for error and crash when only error code should be returned to caller
print Database_Get_Path("BSM-0000")

wait key

end

rem ------------------------------------------------------------------------------------------------------------------------------------------------------------------
rem ------------------------------
rem | Database Manager Functions |
rem ------------------------------
function Database_Get_Designator(Dsg$)
   if not Environment.DatabaseLoaded
      if Database_Load() < 0
         exitfunction "/-1"
      endif
   endif
   array index to top Database()
   while array index valid(Database())
      if Database().Path = Dsg$
         Path$ = Database().Designator
         exitfunction Path$
      endif
      next array index Database()
   endwhile
endfunction ""

function Database_Get_Path(Dsg$)
   if not Environment.DatabaseLoaded
      if Database_Load() < 0
         exitfunction "/-1"
      endif
   endif
   array index to top Database()
   while array index valid(Database())
      if Database().Designator = Dsg$
         Path$ = Database().Path
         exitfunction Path$
      endif
      next array index Database()
   endwhile
endfunction ""

function Database_Get_Version(Dsg$)
   if not Environment.DatabaseLoaded
      if Database_Load() < 0
         exitfunction "/-1"
      endif
   endif
   array index to top Database()
   while array index valid(Database())
      if Database().Designator = Dsg$
         Path$ = Database().Version
         exitfunction Path$
      endif
      next array index Database()
   endwhile
endfunction ""

function Database_Load()
   Block = File_Load("C:\K96\Database.K96")
   if Block < 0
      exitfunction -1
   else
      Word$ = ""
      i = 0
      for a = 0 to get memblock size(Block) - 1
         Byte$ = chr$(memblock byte(Block, a))
         select i
            case 2
               if Byte$ = ";"
                  Database().Version = Word$
                  Word$ = ""
                  i = 0
               else
                  Word$ = Word$ + Byte$
               endif
            endcase
            case 1
               if Byte$ = ","
                  Database().Path = Word$
                  Word$ = ""
                  i = 2
               else
                  Word$ = Word$ + Byte$
               endif
            endcase
            case 0
               if Byte$ = ":"
                  if Word$ = "DBEnd"
                     Environment.DatabaseLoaded = 1
                     delete memblock Block
                     exitfunction 1
                  else
                     array insert at bottom Database()
                     Database().Designator = Word$
                     Word$ = ""
                     i = 1
                  endif
               else
                  Word$ = Word$ + Byte$
               endif
            endcase
         endselect
      next a
      Environment.DatabaseLoaded = 1
      delete memblock Block
   endif
endfunction 1

rem ------------------------------------------------------------------------------------------------------------------------------------------------------------------
rem -----------------------------
rem | Display Manager Functions |
rem -----------------------------
function Display_Initialize()
rem Builds a list of available display modes
   array insert at bottom Display()
   Display().Mode.Resolution.X = 0
   Display().Mode.Resolution.Y = 0
   Display().Mode.Depth = 0
   empty checklist
   perform checklist for display modes
   for a = 1 to checklist quantity()
      array insert at bottom Display()
      Display().Mode.Resolution.X = checklist value a(a)
      Display().Mode.Resolution.Y = checklist value b(a)
      Display().Mode.Depth = checklist value c(a)
   next a
   array index to top Display()
   while array index valid(Display())
      if Display().Mode.Resolution.X >= Display(0).Mode.Resolution.X
         if Display().Mode.Resolution.Y >= Display(0).Mode.Resolution.Y
            if Display().Mode.Depth >= Display(0).Mode.Depth
               Display(0).Mode.Resolution.X = Display().Mode.Resolution.X
               Display(0).Mode.Resolution.Y = Display().Mode.Resolution.Y
               Display(0).Mode.Depth = Display().Mode.Depth
            endif
         endif
      endif
      next array index Display()
   endwhile
   if Display(0).Mode.Resolution.X = 0
      end
   endif
   if Display(0).Mode.Resolution.Y = 0
      end
   endif
   if Display(0).Mode.Depth = 0
      end
   endif
   set display mode Display(0).Mode.Resolution.X, Display(0).Mode.Resolution.Y, Display(0).Mode.Depth
endfunction

rem ------------------------------------------------------------------------------------------------------------------------------------------------------------------
rem ----------------------------
rem | File Manager Functions |
rem ----------------------------
function File_Get_Free_ID()
    for a = 1 to 32
        if not file open(a)
            exitfunction a
        endif
    next
endfunction 0

function File_Load(File$)
   File = File_Open_For_Read(File$)
   if File > 0
      make memblock from file 1, File
      close file File
      exitfunction 1
   endif
endfunction -1

function File_Open_For_Read(File$)
   Fil = File_Get_Free_ID()
   if Fil = 0
      `Error_Write("File Manager-->File_Open_For_Read-->Error=No free file ID to open " + File$)
      exitfunction -1
   endif
   if not file exist(File$)
      `Error_Write("File Manager-->File_Open_For_Read-->Error=File " + File$ + " does not exist")
      exitfunction -2
   endif
   open to read Fil, File$
   `Error_Write("File Manager-->File_Open_For_Read-->Error=File " + File$ + " opened for read")
endfunction Fil

+ Code Snippet

type Integer_2
   X as integer
   Y as integer
endtype

type Database_Entry
   Designator as string
   Path as string
   Version as string
endtype

type Display_Resolution
   Resolution as Integer_2
   Depth as byte
endtype
type Display_Entry
   Mode as Display_Resolution
endtype

type Environment_Variables
   Version as string
   DatabaseLoaded as boolean
   Directory as string
endtype

dim Database() as Database_Entry
global Database

dim Display() as Display_Entry
empty array Display()
global Display

global Environment as Environment_Variables


Display_Initialize()
Database_Load()

`Enable for database printout...works flawlessly
`for a = 0 to array count(Database())
`   print Database(a).Designator; " "; Database(a).Path; " "; Database(a).Version
`next a

`Enable for flawless database lookup
`print Database_Get_Path("BMN-12")
`print Database_Get_Version("BMN-12")

`Enable for error and crash when there should be success
`print Database_Get_Path("CBSM-0000")

`Enable for error and crash when only error code should be returned to caller
print Database_Get_Path("BSM-0000")

wait key

end


rem ------------------------------------------------------------------------------------------------------------------------------------------------------------------
rem ------------------------------
rem | Database Manager Functions |
rem ------------------------------
function Database_Get_Designator(Dsg$)
   if not Environment.DatabaseLoaded
      if Database_Load() < 0
         exitfunction "/-1"
      endif
   endif
   array index to top Database()
   while array index valid(Database())
      if Database().Path = Dsg$
         Path$ = Database().Designator
         exitfunction Path$
      endif
      next array index Database()
   endwhile
endfunction ""

function Database_Get_Path(Dsg$)
   if not Environment.DatabaseLoaded
      if Database_Load() < 0
         exitfunction "/-1"
      endif
   endif
   array index to top Database()
   while array index valid(Database())
      if Database().Designator = Dsg$
         Path$ = Database().Path
         exitfunction Path$
      endif
      next array index Database()
   endwhile
endfunction ""

function Database_Get_Version(Dsg$)
   if not Environment.DatabaseLoaded
      if Database_Load() < 0
         exitfunction "/-1"
      endif
   endif
   array index to top Database()
   while array index valid(Database())
      if Database().Designator = Dsg$
         Path$ = Database().Version
         exitfunction Path$
      endif
      next array index Database()
   endwhile
endfunction ""

function Database_Load()
   Block = File_Load("C:\K96\Database.K96")
   if Block < 0
      exitfunction -1
   else
      Word$ = ""
      i = 0
      for a = 0 to get memblock size(Block) - 1
         Byte$ = chr$(memblock byte(Block, a))
         select i
            case 2
               if Byte$ = ";"
                  Database().Version = Word$
                  Word$ = ""
                  i = 0
               else
                  Word$ = Word$ + Byte$
               endif
            endcase
            case 1
               if Byte$ = ","
                  Database().Path = Word$
                  Word$ = ""
                  i = 2
               else
                  Word$ = Word$ + Byte$
               endif
            endcase
            case 0
               if Byte$ = ":"
                  if Word$ = "DBEnd"
                     Environment.DatabaseLoaded = 1
                     delete memblock Block
                     exitfunction 1
                  else
                     array insert at bottom Database()
                     Database().Designator = Word$
                     Word$ = ""
                     i = 1
                  endif
               else
                  Word$ = Word$ + Byte$
               endif
            endcase
         endselect
      next a
      Environment.DatabaseLoaded = 1
      delete memblock Block
   endif
endfunction 1


rem ------------------------------------------------------------------------------------------------------------------------------------------------------------------
rem -----------------------------
rem | Display Manager Functions |
rem -----------------------------
function Display_Initialize()
rem Builds a list of available display modes
   array insert at bottom Display()
   Display().Mode.Resolution.X = 0
   Display().Mode.Resolution.Y = 0
   Display().Mode.Depth = 0
   empty checklist
   perform checklist for display modes
   for a = 1 to checklist quantity()
      array insert at bottom Display()
      Display().Mode.Resolution.X = checklist value a(a)
      Display().Mode.Resolution.Y = checklist value b(a)
      Display().Mode.Depth = checklist value c(a)
   next a
   array index to top Display()
   while array index valid(Display())
      if Display().Mode.Resolution.X >= Display(0).Mode.Resolution.X
         if Display().Mode.Resolution.Y >= Display(0).Mode.Resolution.Y
            if Display().Mode.Depth >= Display(0).Mode.Depth
               Display(0).Mode.Resolution.X = Display().Mode.Resolution.X
               Display(0).Mode.Resolution.Y = Display().Mode.Resolution.Y
               Display(0).Mode.Depth = Display().Mode.Depth
            endif
         endif
      endif
      next array index Display()
   endwhile
   if Display(0).Mode.Resolution.X = 0
      end
   endif
   if Display(0).Mode.Resolution.Y = 0
      end
   endif
   if Display(0).Mode.Depth = 0
      end
   endif
   set display mode Display(0).Mode.Resolution.X, Display(0).Mode.Resolution.Y, Display(0).Mode.Depth
endfunction


rem ------------------------------------------------------------------------------------------------------------------------------------------------------------------
rem ----------------------------
rem | File Manager Functions |
rem ----------------------------
function File_Get_Free_ID()
    for a = 1 to 32
        if not file open(a)
            exitfunction a
        endif
    next
endfunction 0

function File_Load(File$)
   File = File_Open_For_Read(File$)
   if File > 0
      make memblock from file 1, File
      close file File
      exitfunction 1
   endif
endfunction -1

function File_Open_For_Read(File$)
   Fil = File_Get_Free_ID()
   if Fil = 0
      `Error_Write("File Manager-->File_Open_For_Read-->Error=No free file ID to open " + File$)
      exitfunction -1
   endif
   if not file exist(File$)
      `Error_Write("File Manager-->File_Open_For_Read-->Error=File " + File$ + " does not exist")
      exitfunction -2
   endif
   open to read Fil, File$
   `Error_Write("File Manager-->File_Open_For_Read-->Error=File " + File$ + " opened for read")
endfunction Fil

In Development: K96 - Combat Simulation

Back to top

Profile PM Email

Sigh

20

Years of Service

User Offline

Joined: 26th Dec 2005

Location: The Big 80s

Posted: 10th Apr 2012 23:34

Link

I've tried changing the while loops to for loops yet no change. I've also tried doing a lookup of a non-existent DB entry from the main program and no errors occurred. It seems the Database_Get_ function causes some internal error, when an entry doesn't exist in the DB, that doesn't manifest itself until the program ends.
I wouldn't care too much about this if I knew the DB would always be correct, but the whole point of the DB is to see what assets need to be pulled from the server and installed/updated.

Keep your Hope & Change to yourself, I choose Liberty! Stop by for a chat! [IXE]Nateholio on irc.maxgaming.net:6667 #GarageGames

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 10th Apr 2012 23:58

Link

If I recall correctly there's a bug in DBPro affecting returned strings from functions and looking at your code I think that could be the problem. It's something to do with returning literal strings.

Ah! Here's the link:

problems returning empty strings

You may be OK if you return a string variable, e.g.

+ Code Snippet

  myResult$ = ""
endfunction myResult$

Obviously you'll need to make a few other related chnges to your code.

Back to top

Profile PM Email

Sigh

20

Years of Service

User Offline

Joined: 26th Dec 2005

Location: The Big 80s

Posted: 11th Apr 2012 00:24

Link

Ahhh, thanks GG! Works great now. As usual, you da man. I was starting to figure it might be some sort of problem with DBP...I've ran into several before.

Keep your Hope & Change to yourself, I choose Liberty! Stop by for a chat! [IXE]Nateholio on irc.maxgaming.net:6667 #GarageGames

Back to top

Profile PM

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Crash on Exit After Reading From Array