Tier 2 vectors of classes problem

Author

Message

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 22nd May 2012 20:03

Link

Hey there.

I am having some troubles with vector of classes..

To be exact, when using .push_back, there's called constructor of my class and just after it an destructor, making it almost instantly delete what it has created. Here's what do I mean:

+ Code Snippet

class Event{
    public:
        int sprite_id;
        int image_id;
        Event(int imgid, int x, int y) {
            image_id = imgid;
            sprite_id = agk::CreateSprite(image_id);
        }
        ~Event() {
            agk::DeleteImage(image_id);
            agk::DeleteSprite(sprite_id);
        }

        void somefunction() {
            //do nothing
        }
};

// main code:
std::vector<Event> main_event;
main_event.push_back(Event(agk::LoadImage("abc.png"),1,1));
// ^^^^^ ERROR ^^^^
main_event[0].somefunction();

Any way to fix this?

Thanks.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Paul Johnston

TGC Developer

21

Years of Service

User Offline

Joined: 16th Nov 2002

Location: United Kingdom

Posted: 22nd May 2012 20:15

Link

You could try

+ Code Snippet

std::vector<Event*> main_event;
main_event.push_back(new Event(agk::LoadImage("abc.png"),1,1));
main_event[0]->somefunction();

But you'll have to remember to delete the new objects when you remove them from the vector.

Back to top

Profile PM Email

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 22nd May 2012 20:19

Link

It kind of works, but it still crashes on release mode on startup.
Yet no idea why.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

polomint

12

Years of Service

User Offline

Joined: 3rd Apr 2012

Location: Lancashire, United Kingdom

Posted: 22nd May 2012 20:22

Link

I hate to interrupt this thread, but I've never used vectors in C++. What are they, and why would I use them? Are there certain uses that are made easier by using vectors?

Thanks,

Blackberry App Development & ZX Spectrum Game Development.

Back to top

Profile PM Email Website

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 22nd May 2012 20:25

Link

Quote: "I hate to interrupt this thread, but I've never used vectors in C++. What are they, and why would I use them? Are there certain uses that are made easier by using vectors?

Thanks, "

They are useful when you need unknown amount of objects.
Useful when user is for example creating objects on the screen, then you have vector of those objects. Vectors are just as tables, but with
unlimited size.

Just google it

Yup. Keeping up my problem.

Quote: "It kind of works, but it still crashes on release mode on startup.
Yet no idea why."

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

polomint

12

Years of Service

User Offline

Joined: 3rd Apr 2012

Location: Lancashire, United Kingdom

Posted: 22nd May 2012 20:32

Link

Thanks, found a decent description here >> http://www.cplusplus.com/reference/stl/vector/

Blackberry App Development & ZX Spectrum Game Development.

Back to top

Profile PM Email Website

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 22nd May 2012 20:42

Link

I know that it crashes just after constructor now. It doesn't reach destructor it seems.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 22nd May 2012 21:11

Link

Try this:

+ Code Snippet

        UINT sprite_id;
        UINT image_id;
        Event(UINT imgid, int x, int y) {
            image_id = imgid;
            sprite_id = agk::CreateSprite(image_id);
        }

It's possible that the compiler is being uber-picky about type, 'int' is not the same as 'UINT', which is what LoadImage and CreateSprite return and what CreateSprite looks for as an input type.

Internally, an int and a UINT are stored somewhat differently. The int type will have the highest order bit as a sign bit. UINT does not.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 22nd May 2012 21:57 Edited at: 22nd May 2012 21:58

Link

Bad news, it still crashes.

Maybe more code will help?

Full class:

event.h

+ Code Snippet

#ifndef EVENT_H
#define EVENT_H


#include "agk.h"
using namespace AGK;

class Event{
private:
	int x, y;
	UINT imgid;
	UINT cycle_image[12];
	int moving;
	int dist;
public:
	UINT sprite_id;

	Event(int img_id, int pnumber, int x1, int y1);
	~Event();
};

#endif

event.cpp

#include "event.h"
#include "template.h"

Event::Event(int img_id, int pnumber, int x1, int y1)
{
	x = x1;
	y = y1;
	imgid = img_id;
	int n = 0;
	switch(pnumber)
	{
		case 1:
			n = 0;
			break;
		case 2:
			n = 3;
			break;
		case 3:
			n = 6;
			break;
		case 4:
			n = 9;
			break;
		case 5:
			n = 48;
			break;
		case 6:
			n = 51;
			break;
		case 7:
			n = 54;
			break;
		case 8:
			n = 57;
			break;
	}
	int m = 0;
	for(int y2=0; y2<4; y2++)
	{
		for(int x2=0; x2<3; x2++)
		{
			cycle_image[m] = agk::LoadSubImage(imgid,agk::Str(n+1));
			n++;
			m++;
		}
		n+=9;
	}
	moving = 0;
	dist = 0;
	sprite_id = agk::CreateSprite(cycle_image[7]);
	agk::SetSpriteDepth(sprite_id,8);
	agk::SetSpritePosition(sprite_id,x*16-4,y*16-16);
	agk::SetSpriteSnap(sprite_id,1);

for(int n=0; n<12; n++)
	{
		agk::AddSpriteAnimationFrame(sprite_id,cycle_image[n]);
		if(n == 2 || n == 5 || n == 8 || n == 11)
			agk::AddSpriteAnimationFrame(sprite_id,cycle_image[n-1]);
	}
	agk::SetSpriteFrame(sprite_id,7);
}
Event::~Event()
{
	agk::DeleteSprite(sprite_id);
	agk::DeleteImage(imgid);
	for(int n=0; n<12; n++)
		agk::DeleteImage(cycle_image[n]);
}

+ Code Snippet

#include "event.h"
#include "template.h"

Event::Event(int img_id, int pnumber, int x1, int y1)
{
	x = x1;
	y = y1;
	imgid = img_id;
	int n = 0;
	switch(pnumber)
	{
		case 1:
			n = 0;
			break;
		case 2:
			n = 3;
			break;
		case 3:
			n = 6;
			break;
		case 4:
			n = 9;
			break;
		case 5:
			n = 48;
			break;
		case 6:
			n = 51;
			break;
		case 7:
			n = 54;
			break;
		case 8:
			n = 57;
			break;
	}
	int m = 0;
	for(int y2=0; y2<4; y2++)
	{
		for(int x2=0; x2<3; x2++)
		{
			cycle_image[m] = agk::LoadSubImage(imgid,agk::Str(n+1));
			n++;
			m++;
		}
		n+=9;
	}
	moving = 0;
	dist = 0;
	sprite_id = agk::CreateSprite(cycle_image[7]);
	agk::SetSpriteDepth(sprite_id,8);
	agk::SetSpritePosition(sprite_id,x*16-4,y*16-16);
	agk::SetSpriteSnap(sprite_id,1);

	for(int n=0; n<12; n++)
	{
		agk::AddSpriteAnimationFrame(sprite_id,cycle_image[n]);
		if(n == 2 || n == 5 || n == 8 || n == 11)
			agk::AddSpriteAnimationFrame(sprite_id,cycle_image[n-1]);
	}
	agk::SetSpriteFrame(sprite_id,7);
}
Event::~Event()
{
	agk::DeleteSprite(sprite_id);
	agk::DeleteImage(imgid);
	for(int n=0; n<12; n++)
		agk::DeleteImage(cycle_image[n]);
}

inside template.h

+ Code Snippet

std::vector<Event*> map_event;

Inside void CreateEntities called by template.cpp

+ Code Snippet

agk::OpenToRead(1, first_name);
		agk::ReadLine(1);
		int x1 = agk::Val(agk::ReadLine(1));
		agk::ReadLine(1);
		int y1 = agk::Val(agk::ReadLine(1));
		agk::ReadLine(1);
		char file_to_open[512];
		for(int n=0; n<512; n++)
			file_to_open[n] = NULL;
		sprintf(file_to_open,"%s",agk::ReadLine(1));
		agk::ReadLine(1);
		int pnumber = agk::Val(agk::ReadLine(1));
		char* cr_dir = agk::GetCurrentDir();
		agk::SetCurrentDir("");
		agk::SetCurrentDir("media/charset");
		int imgnmb = agk::LoadImage(file_to_open);
		App.map_event.push_back(new Event(imgnmb,pnumber,x1,y1));
		agk::SetCurrentDir("");
		agk::SetCurrentDir(cr_dir);
		agk::CloseFile(1);

As you can see, there's App.map_event.push_back.

I'll add that I have another class, almost the same as event.cpp and it doesn't crash, so it's 100% that it's something wrong with the vector.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 22nd May 2012 22:06

Link

You probably need to change your constructor definition:

+ Code Snippet

Event(UINT img_id, int pnumber, int x1, int y1)

And this

+ Code Snippet

UINT imgnmb = agk::LoadImage(file_to_open);

Being completely consistent in types is very important in Tier2 (C++) programming. Tier1 (Basic) is much more forgiving.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 22nd May 2012 22:10

Link

Nope. Still won't work. Have I mentioned it runs all fine under debug mode?

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 22nd May 2012 22:49

Link

First, I am assuming you are working in Windows and using MS Visual C++ (probably Express?).

Are you able to determine where in the constructor it is dying?

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 22nd May 2012 23:04

Link

Quote: "First, I am assuming you are working in Windows and using MS Visual C++ (probably Express?)."

Yes.

Quote: "Are you able to determine where in the constructor it is dying?

"

Nowhere. I doesn't even die at the end. It dies after the constructor, but before new line (after push_back)

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 22nd May 2012 23:36

Link

Are you sure it is getting out of the constructor without errors?

This code should have a check to make sure a valid value is returned:

+ Code Snippet

cycle_image[m] = agk::LoadSubImage(imgid,agk::Str(n+1));

Just in case your image file does not exist where it is looking for it.

I'm also curious about the file name. It has no extension and consists only of a number between 1 and 69.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 22nd May 2012 23:49 Edited at: 22nd May 2012 23:58

Link

Quote: "I'm also curious about the file name. It has no extension and consists only of a number between 1 and 69."

Yeah, that's how my subimages look like.

+ Code Snippet

1:0:0:24:32
2:24:0:24:32
3:48:0:24:32
4:72:0:24:32
5:96:0:24:32
6:120:0:24:32
7:144:0:24:32
8:168:0:24:32
9:192:0:24:32
10:216:0:24:32
11:240:0:24:32
and so on

Quote: "Just in case your image file does not exist where it is looking for it."

Checked. Everything's valid.

@NEWS

It crashes somewhere in this loop:

+ Code Snippet

for(int y=0; y<map_h; y++)
	{
		for(int x=0; x<map_w; x++)
		{
			if(map[0][y][x] > 0)
			{
				map_sprite[0][y][x] = agk::CreateSprite(sheet_subimage[map[0][y][x]]);
				agk::SetSpritePosition(map_sprite[0][y][x],x*16,y*16);
				agk::SetSpriteSnap(map_sprite[0][y][x],1);
			}
			if(map[1][y][x] > 0)
			{
				map_sprite[1][y][x] = agk::CreateSprite(sheet_subimage[map[1][y][x]]);
				agk::SetSpritePosition(map_sprite[1][y][x],x*16,y*16);
				agk::SetSpriteSnap(map_sprite[1][y][x],1);
			}
		}
	}

which is after push_back. So it's not vector?

@NEWS

I was wrong, it crashes as I said.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 00:10

Link

By any chance, is the directory entered for Configuration Properties->General->Output Directory different between your Debug and Release configurations? If so, the release version might not be able to find your images.

Specifically with regard to checking values, what happens if you add a check that shows you the value returned in this line when built with the release configuration:

+ Code Snippet

UINT imgnmb = agk::LoadImage(file_to_open);

What are the dimensions of the parent image? Some discussion seems to indicate that it should be powers of two along each side if you are going to use texture atlases.

I've not worked with SubImages, only with the custom font files (which use an image atlas), I'm just going on basic programming stuff.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 00:20 Edited at: 23rd May 2012 00:21

Link

Quote: "By any chance, is the directory entered for Configuration Properties->General->Output Directory different between your Debug and Release configurations? If so, the release version might not be able to find your images.
"

They're the same.

Quote: "Specifically with regard to checking values, what happens if you add a check that shows you the value returned in this line when built with the release configuration:"

It returns 10495.

Quote: "What are the dimensions of the parent image? Some discussion seems to indicate that it should be powers of two along each side if you are going to use texture atlases."

288x256

But as I said before, I have another working sprite that uses this image..

I'll try to size it up to 512x512 and see if it works.

@EDIT

Changed to 512x512. Still won't work.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 00:42

Link

I'm pretty stumped.

If you want to zip up your project and send it to me, I'll see what I can do. And I absolutely won't share it or use it in any way for myself. Promise.

Cheers,
Ancient Lady

Back to top

Profile PM

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 23rd May 2012 01:25

Link

I'm probably talking cobblers, but should it be:

for(int x=0; x<map_w; x++)

actually be:

for(int x=0; x<(map_w -1); x++)

because you are incrementing x possibly beyond the array bounds.

-- Jim

Back to top

Profile PM Website

3d point in space

14

Years of Service

User Offline

Joined: 30th Jun 2009

Location: Idaho

Posted: 23rd May 2012 06:30 Edited at: 23rd May 2012 07:58

Link

i think you have to cast it as a template if your using a class, because I don't think you can do that with classes only structs.

I forgot the syntax to cast it though. I think its <template
> or somthing like that.

another thing you can do is use a struct outside the class then inside the class i would use the struct. Do a google search on template class vectors,

Ok this is not the problem I read further. Down the post some how you are going off the vector so I would set a default width and hieght of the vector then right data inside. I useually do this so that all the row and collumns of the vector are same width-height-depth. Therefore eliminating using push_back of vectors. I usually get errors using vectors in your format.

Developer of Space Chips, pianobasic, zipzapzoom, and vet pinball apps.
Developed the tiled map engine seen on the showcase.
Veterian for the military.

Back to top

Profile PM Email Website

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 15:17

Link

Quote: "I'm probably talking cobblers, but should it be:

for(int x=0; x<map_w; x++)

actually be:

for(int x=0; x<(map_w -1); x++)

because you are incrementing x possibly beyond the array bounds."

x<map_w will actually reach to map_w-1 only.

Quote: "Ok this is not the problem I read further. Down the post some how you are going off the vector so I would set a default width and hieght of the vector then right data inside. I useually do this so that all the row and collumns of the vector are same width-height-depth. Therefore eliminating using push_back of vectors. I usually get errors using vectors in your format."

Problem is that I have to create my events dynamically, so there cannot be fixed vector size.

Quote: "If you want to zip up your project and send it to me, I'll see what I can do. And I absolutely won't share it or use it in any way for myself. Promise."

I guess that I will have to do that if there is no other solution.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 15:40 Edited at: 23rd May 2012 15:40

Link

I don't promise that I can solve it. But having the whole project lets me look at it more closely.

Once, way back in my beginnings, I sat in the help office and helped all the other students who couldn't get their programs (on punch cards) working. And I've learned a few things since then.

If you send it (using the email link below my post), I'll see what I can do for you. It will need to include all your graphics as well (which I will protect).

Cheers,
Ancient Lady

Back to top

Profile PM

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 23rd May 2012 15:53

Link

Quote: "x<map_w will actually reach to map_w-1 only. "

I don't think so. If x is smaller than map_w the loop increments it, and you then use that value. Is the map 0-based or 1-based?

-- Jim

Back to top

Profile PM Website

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 15:57 Edited at: 23rd May 2012 16:00

Link

In C++, all arrays are zero based. Eg. "int xyz[10];" is indexed from 0 to 9 exactly. Unlike Tier1 where "dim xyz[10]" allows indices from 0 to 10.

In a C++ if loop, it stops when the indicated condition ("x<map_w") is no longer true and does not execute the contents of the loop.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 15:58 Edited at: 23rd May 2012 16:05

Link

Quote: "Is the map 0-based or 1-based?"

Not sure what do you mean here.

@EDIT

Worth of adding:

It still crashes on push_back. Even if I make my class' constructor and destructor empty.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

3d point in space

14

Years of Service

User Offline

Joined: 30th Jun 2009

Location: Idaho

Posted: 23rd May 2012 16:09

Link

0 base starts at 0 while 1 base starts at 1.
must be a school project if you can't use static vectors. Your teacher knows way more then mine. He just wanted the program too work.

Developer of Space Chips, pianobasic, zipzapzoom, and vet pinball apps.
Developed the tiled map engine seen on the showcase.
Veterian for the military.

Back to top

Profile PM Email Website

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 16:11

Link

Quote: "0 base starts at 0 while 1 base starts at 1."

Oh, well, it starts at 0.

Quote: "must be a school project if you can't use static vectors."

I can, but I don't want. (And it's not a school project)
I don't want to do that because I am going to have undefined amount of elements inside my vector, and that's because the user does some changes manually.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 16:17

Link

Quote: "It still crashes on push_back. Even if I make my class' constructor and destructor empty."

Just for giggles, try this:

+ Code Snippet

Event* newEvnt;
newEvnt = new Event(imgnmb,pnumber,x1,y1);
if (!newEvnt) {<big major oops>}
App.map_event.push_back(newEvnt);

Let's make sure that something is actually getting created.

Although, in theory, the push_back should be okay with a null value. It just wants a pointer type value.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 16:24

Link

Ancient Lady, tested and I see that newEvnt is created.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 16:33

Link

Okay. I'm just looking for things based on what I can see.

Cheers,
Ancient Lady

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 16:35

Link

Okay. Will you show more of your template.h file?

I just got suspicious of this line:

+ Code Snippet

App.map_event.push_back(new Event(imgnmb,pnumber,x1,y1));

I'd like to see the full context of where map_event is defined.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 16:58

Link

Template.h:

+ Code Snippet

#ifndef _H_APP
#define _H_APP

// Link to AGK libraries
#include "agk.h"
#include <vector>
#include "player.h"
#include "event.h"

// Global values for the app
class app
{
	public:

		// main vars
		int map_sprite[2][100][100];
		int map[3][100][100];
		int map_id;
		char *w_pos;
		int w_init;
		player *main_player;
		std::vector<Event*> map_event;

	public:

		// constructor
		app() { memset ( this, 0, sizeof(app)); }

		// main app functions
		void Begin( void );
		void Loop( void );
		void End( void );

		void MenuInit( void );
		void MenuLoop( void );
		void MenuEnd( void );

		void GameInit( void );
		void GameLoop( void );
		void GameEnd( void );
};

extern app App;

#endif

// Allow us to use the LoadImage function name
#ifdef LoadImage
 #undef LoadImage
#endif

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 17:26

Link

Okay, it looks good. I'm going to try a couple of tests on a simple project and see what I can come up with.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 17:36

Link

Sure, thanks

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 18:35

Link

Okay, starting from basic template:
template.h:

#ifndef _H_APP
#define _H_APP

// Link to AGK libraries
#include "agk.h"
#include <vector>

class player {
private:
   char pname[512];
public:
   player(char* aname) {strcpy(pname,aname);}
   ~player() {};
};

class Event {
private:
   int my_val;
   char my_str[512];
   UINT my_sprite;
public:
   Event(int val)
   {
      // store the value
      my_val=val;

// create a sprite
      my_sprite = agk::CreateSprite((UINT)0);
      agk::SetSpriteSize(my_sprite,(float)my_val,(float)my_val);

// position on display
      agk::SetSpritePosition(my_sprite,(float)my_val,(float)(my_val*2));
      agk::SetSpriteVisible(my_sprite,1);
   }
   ~Event()
   {
      if (agk::GetSpriteExists(my_sprite)) {agk::DeleteSprite(my_sprite);}
   }

const char* showMe()
   {
      sprintf(my_str,"My value is %d",my_val);
      return (const char*)my_str;
   }
};

// Global values for the app
class app
{
   public:

// main vars
      int map_sprite[2][100][100];
      int map[3][100][100];
      int map_id;
      char *w_pos;
      int w_init;
      player *main_player;
      std::vector<Event*> my_vec;

public:

// constructor
      app() { memset ( this, 0, sizeof(app)); }

// main app functions
      void Begin( void );
      void Loop( void );
      void End( void );
};

extern app App;

#endif

// Allow us to use the LoadImage function name
#ifdef LoadImage
 #undef LoadImage
#endif

+ Code Snippet

#ifndef _H_APP
#define _H_APP

// Link to AGK libraries
#include "agk.h"
#include <vector>

class player {
private:
   char pname[512];
public:
   player(char* aname) {strcpy(pname,aname);}
   ~player() {};
};

class Event {
private:
   int my_val;
   char my_str[512];
   UINT my_sprite;
public:
   Event(int val)
   {
      // store the value
      my_val=val;

      // create a sprite
      my_sprite = agk::CreateSprite((UINT)0);
      agk::SetSpriteSize(my_sprite,(float)my_val,(float)my_val);

      // position on display
      agk::SetSpritePosition(my_sprite,(float)my_val,(float)(my_val*2));
      agk::SetSpriteVisible(my_sprite,1);
   }
   ~Event()
   {
      if (agk::GetSpriteExists(my_sprite)) {agk::DeleteSprite(my_sprite);}
   }

   const char* showMe()
   {
      sprintf(my_str,"My value is %d",my_val);
      return (const char*)my_str;
   }
};

// Global values for the app
class app
{
   public:

      // main vars
      int map_sprite[2][100][100];
      int map[3][100][100];
      int map_id;
      char *w_pos;
      int w_init;
      player *main_player;
      std::vector<Event*> my_vec;

   public:

      // constructor
      app() { memset ( this, 0, sizeof(app)); }

      // main app functions
      void Begin( void );
      void Loop( void );
      void End( void );
};

extern app App;

#endif

// Allow us to use the LoadImage function name
#ifdef LoadImage
 #undef LoadImage
#endif

template.cpp:

// Includes, namespace and prototypes
#include "template.h"
using namespace AGK;
app App;

// globals
char a_string[1024];

// Begin app, called once at the start
void app::Begin( void )
{
   int cnt_start;
   int cnt_end;

// get the initial length
   cnt_start = (int)App.my_vec.size();

// add some things
   my_vec.push_back(new Event(10));
   my_vec.push_back(new Event(15));

// get the final length
   cnt_end = (int)my_vec.size();

// show what we did
   sprintf(a_string,"Started with %d\nFinished with %d\n",cnt_start,cnt_end);
}

// Main loop, called every frame
void app::Loop ( void )
{
   std::vector<Event*>::iterator my_vec_it;
   Event* mi;

// print information on screen
   agk::Print(a_string);
   agk::Print("These are the elements:");

// show the values
   for (my_vec_it=my_vec.begin(); my_vec_it<my_vec.end(); my_vec_it++)
   {
      mi = *my_vec_it;
      agk::Print(mi->showMe());
   }

agk::Sync ( );
}

// Called when the app ends
void app::End ( void )
{
   // clean up
   my_vec.clear();
}

+ Code Snippet

// Includes, namespace and prototypes
#include "template.h"
using namespace AGK;
app App;

// globals
char a_string[1024];

// Begin app, called once at the start
void app::Begin( void )
{
   int cnt_start;
   int cnt_end;

   // get the initial length
   cnt_start = (int)App.my_vec.size();

   // add some things
   my_vec.push_back(new Event(10));
   my_vec.push_back(new Event(15));

   // get the final length
   cnt_end = (int)my_vec.size();

   // show what we did
   sprintf(a_string,"Started with %d\nFinished with %d\n",cnt_start,cnt_end);
}

// Main loop, called every frame
void app::Loop ( void )
{
   std::vector<Event*>::iterator my_vec_it;
   Event* mi;

   // print information on screen
   agk::Print(a_string);
   agk::Print("These are the elements:");

   // show the values
   for (my_vec_it=my_vec.begin(); my_vec_it<my_vec.end(); my_vec_it++)
   {
      mi = *my_vec_it;
      agk::Print(mi->showMe());
   }

   agk::Sync ( );
}

// Called when the app ends
void app::End ( void )
{
   // clean up
   my_vec.clear();
}

Based on this and what I've seen of your code. I don't see why you are having a problem.

Note that I didn't use 'App.my_vec', just 'my_vec'. There is no need to specify the global App object for your 'map_event' vector. Because 'my_vec' and 'map_event' are attributes of the app class, they exist within any instantiation of it.

I have been assuming that all the setup code you initially showed in template.cpp is in the 'app::Begin' function.

Cheers,
Ancient Lady

Back to top

Profile PM

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 18:43

Link

Quote: "Note that I didn't use 'App.my_vec', just 'my_vec'. There is no need to specify the global App object for your 'map_event' vector. Because 'my_vec' and 'map_event' are attributes of the app class, they exist within any instantiation of it.

I have been assuming that all the setup code you initially showed in template.cpp is in the 'app::Begin' function."

Well, actually some code I've showed was from
void CreateEntities(void)

that's why I have to use App.

What's important is - I have also placed push_back inside app::Begin to check if it crashes, and it does..

I must analyse some of your code.

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 18:58

Link

I've used your code Ancient Lady and it crashes.. Uh..

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Paul Johnston

TGC Developer

21

Years of Service

User Offline

Joined: 16th Nov 2002

Location: United Kingdom

Posted: 23rd May 2012 19:01

Link

Could it be

+ Code Snippet

memset ( this, 0, sizeof(app));

in the app constructor clearing out something in the vector variable that it doesn't like?

Back to top

Profile PM Email

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 23rd May 2012 19:04 Edited at: 23rd May 2012 19:05

Link

Paul Johnston, you're some sort of god?

It works now!

Thanks so much

!

Thanks to you too Ancient Lady

Follow me on twitter! @MotionStruct

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 19:13

Link

+ Code Snippet

memset ( this, 0, sizeof(app));

This is part of the standard template and shouldn't cause a problem. And doesn't cause a problem as far as I can see.

I forgot to remove one 'App.' in the code I posted, but it still worked when I built it with that code in.

The program I posted worked fine without a crash in a Release build.

I just tried a Debug build and it crashed. And it showed up a bunch of link warnings.

Okay. Let's go see why this is happening.

Cheers,
Ancient Lady

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 20:35 Edited at: 23rd May 2012 21:34

Link

Edit: I discovered and fixed the issue (see other post)

Cheers,
Ancient Lady

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 20:43 Edited at: 23rd May 2012 21:33

Link

Edit: Never mind

Cheers,
Ancient Lady

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 23rd May 2012 21:07

Link

Ignore my posts (should they show up) with the attachment.

I just saw Kamac's response to Paul (which I somehow missed when I posted right after).

I removed the default 'app' constructor behavior and all problems disappeared.

Strange code to put as default in a template?

Cheers,
Ancient Lady

Back to top

Profile PM

Neuro Fuzzy

16

Years of Service

User Offline

Joined: 11th Jun 2007

Location:

Posted: 23rd May 2012 21:17

Link

Just posting a tip: it's bad practice to delete a passed in image like you're doing in your original snippet

+ Code Snippet

class Event{
    public:
        int sprite_id;
        int image_id;
        Event(int imgid, int x, int y) {
            image_id = imgid;
            sprite_id = agk::CreateSprite(image_id);
        }
        ~Event() {
            agk::DeleteImage(image_id);
            agk::DeleteSprite(sprite_id);
        }

        void somefunction() {
            //do nothing
        }
};

because then something like this would crash:

+ Code Snippet

int img=agk::LoadImage(...);
{
    Event a=Event(img,0,0);
}
agk::DeleteSprite(img);

even though it looks fine. (because it deletes img twice)

If you're using it by saying 'main_event.push_back(new Event(agk::LoadImage("abc.png"),1,1));' then maybe you should shorten the constructor to 'Event(const char *image, int x, int y)', so you can just create 'new Event("abc.png",1,1)'.

Back to top

Profile PM Email

Sorry your browser is not supported!

AppGameKit Classic Chat / Tier 2 vectors of classes problem