Array out of bounds? I don't see it.

Author

Message

Ace of Springs

14

Years of Service

User Offline

Joined: 10th Jan 2012

Location: Cambodia

Posted: 3rd Jun 2012 09:03

Link

+ Code Snippet

dim iinventory(30) as integer

                      for x = 0 to 29
  PROBLEM LINE -->      if iinventory(x) > 0
                          `paste images here
                        endif
                      next x

Have also tried

+ Code Snippet

                   for x = 1 to 30
  PROBLEM LINE -->   if iinventory(x) > 0
                      `paste images here
                     endif
                   next x

Back to top

Profile PM Email Website

zeroSlave

17

Years of Service

User Offline

Joined: 13th Jun 2009

Location: Springfield

Posted: 3rd Jun 2012 09:09 Edited at: 3rd Jun 2012 09:12

Link

That shouldn't be causing you an issue. Where in your code are you dimming your array?

This would work too:

+ Code Snippet

dim iinventory(30) as integer

for x = 0 to 30
   if iinventory(x) > 0
      paste images here
   endif
next x

since Dim iinventory(30) would go from iinventory(0) to iinventory(30)

Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid.

Back to top

Profile PM Email

Ace of Springs

14

Years of Service

User Offline

Joined: 10th Jan 2012

Location: Cambodia

Posted: 3rd Jun 2012 09:11 Edited at: 3rd Jun 2012 09:14

Link

I dim the array at the top of the code outside of all functions and loops, but am trying to access array within a function.

Here is entire function if it helps:

Function checkToolbar()
   if mbutton(953,1010,720,768) = 1 then num=1
   if mbutton(870,934,720,768) = 1 then num=2
   if mbutton(7,80,720,768) = 1 then num=3

SELECT num
     CASE 1:
        paste image 130,0,718
     ENDCASE
     CASE 2:
        paste image 131,0,718
        if mouseclick() = 1
          if infoscreen = 0
            infoscreen = 1
            wait 200
          else
            infoscreen = 0
            wait 200
          endif
        endif
     ENDCASE
     CASE 3:
        paste image 132,0,718
        if mouseclick() = 1
          if invenscreen = 0
            invenscreen = 1
            wait 200
          else
            invenscreen = 0
            wait 200
          endif
        endif
     ENDCASE
     CASE DEFAULT:
        paste image 129,0,718
     ENDCASE
   ENDSELECT

if infoscreen = 1
    paste image 133,100,100,100
    controls = 0
   endif
   if invenscreen = 1
    paste image 134,5,100,100
    controls = 0
    for x = 0 to 29
     if iinventory(x) > 0
       `paste image iinventory(x),10,10
     endif
    next x
   endif
   if infoscreen = 0 and invenscreen = 0 then controls = 1
 ENDFUNCTION

+ Code Snippet

 Function checkToolbar()
   if mbutton(953,1010,720,768) = 1 then num=1
   if mbutton(870,934,720,768) = 1 then num=2
   if mbutton(7,80,720,768) = 1 then num=3

   SELECT num
     CASE 1:
        paste image 130,0,718
     ENDCASE
     CASE 2:
        paste image 131,0,718
        if mouseclick() = 1
          if infoscreen = 0
            infoscreen = 1
            wait 200
          else
            infoscreen = 0
            wait 200
          endif
        endif
     ENDCASE
     CASE 3:
        paste image 132,0,718
        if mouseclick() = 1
          if invenscreen = 0
            invenscreen = 1
            wait 200
          else
            invenscreen = 0
            wait 200
          endif
        endif
     ENDCASE
     CASE DEFAULT:
        paste image 129,0,718
     ENDCASE
   ENDSELECT

   if infoscreen = 1
    paste image 133,100,100,100
    controls = 0
   endif
   if invenscreen = 1
    paste image 134,5,100,100
    controls = 0
    for x = 0 to 29
     if iinventory(x) > 0
       `paste image iinventory(x),10,10
     endif
    next x
   endif
   if infoscreen = 0 and invenscreen = 0 then controls = 1
 ENDFUNCTION

Back to top

Profile PM Email Website

zeroSlave

17

Years of Service

User Offline

Joined: 13th Jun 2009

Location: Springfield

Posted: 3rd Jun 2012 09:17

Link

Hmm... Does this snippet work for you?:

+ Code Snippet

dim iinventory(30) as integer

sync on
sync rate 60
set display mode 800, 600, 32

do
    accessArrayAndPrint()
    sync
loop

end

function accessArrayAndPrint()
    set cursor 0,0
    for x = 0 to 30
        if iinventory(x) = 0
            print x
        endif
    next x
endfunction

Is it possible that the array names are different in your source? Are you undimming it anywhere?

Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid.

Back to top

Profile PM Email

Ace of Springs

14

Years of Service

User Offline

Joined: 10th Jan 2012

Location: Cambodia

Posted: 3rd Jun 2012 09:25

Link

that snippet does work. double checked names are the same and no undimming anywhere. Even re-wrote the code again just in case i missed something and still get same error. Runtime 118 - Array does not exist or subscript is out of bounds. It just doesn't make any sense.

Back to top

Profile PM Email Website

Ace of Springs

14

Years of Service

User Offline

Joined: 10th Jan 2012

Location: Cambodia

Posted: 3rd Jun 2012 09:30

Link

Okay, it is definately some sort of global issue. I just tried to dim the array inside the function and it works fine. Then I tried to dim it immediately before the function and it does not work. Any idea why this may be?

Back to top

Profile PM Email Website

zeroSlave

17

Years of Service

User Offline

Joined: 13th Jun 2009

Location: Springfield

Posted: 3rd Jun 2012 09:48 Edited at: 3rd Jun 2012 09:48

Link

I'm not sure.

It shouldn't work right before the function since that line would not ever be processed. Maybe try putting the dim just before the main loop's initialization? Are you using multiple source files, perhaps?

Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid.

Back to top

Profile PM Email

Ace of Springs

14

Years of Service

User Offline

Joined: 10th Jan 2012

Location: Cambodia

Posted: 3rd Jun 2012 09:53 Edited at: 3rd Jun 2012 09:58

Link

Quote: "would not ever be processed"

that got me thinking. It was most definately in a spot that you would think would not process. Didn't really think about it because I have all this other stuff there:

+ Code Snippet

global mainmenu= 1
global infoscreen = 0
global invenscreen = 0
global purchasebox = 0
global market = 1
global gold = 0 as integer
global breadon = 0
global confbox = 0
global item$
global buyamt
global itemnum as integer

`DECLARE OBJECT TYPE
TYPE object
  objnum as integer
  objtext as string
  xpos as float
  ypos as float
  zpos as float
  texture as integer
  xrot as float
  yrot as float
  zrot as float
  sctype as integer
  target as integer
  wtime as integer
  name as string
  chat as boolean
ENDTYPE

TYPE location
  x as integer
  y as integer
  z as integer
  xp as integer
  yp as integer
  zp as integer
ENDTYPE

that process just fine. But moved the dim code to right before the main loop in that level function and it seems to work fine now. It is also an acceptable location for me so I can continue on. Not sure why it works with globals and declaring types but not arrays. Anyway, problem solved. I much appreciate the help sir. Also am using multiple source files and alot of jumping around in the code so it gets confusing sometimes

Back to top

Profile PM Email Website

zeroSlave

17

Years of Service

User Offline

Joined: 13th Jun 2009

Location: Springfield

Posted: 3rd Jun 2012 10:09

Link

You could always put a VariableInitFunction() in each included source file that gets called before the game starts. That might help, and could be a little more oraganized as well.

#include inventory
#include stats
#include enemyAI

inventoryInit()
statsInit()
enemyInit()

do
do stuff
loop

end

function inventoryInit()
global this
global that
dim this()
dim that()
endfunction

etc.

Anyway, glad it's working!

Everybody is a genius. But if you judge a fish by its ability to climb a tree, it will live its whole life believing that it is stupid.

Back to top

Profile PM Email

Diggsey

20

Years of Service

User Offline

Joined: 24th Apr 2006

Location: On this web page.

Posted: 3rd Jun 2012 17:44

Link

The code has to actually run through the "dim" command before you try to access the array, or the array will be uninitialised.

[b]

Back to top

Profile PM Email Website

Fallout

23

Years of Service

User Offline

Joined: 1st Sep 2002

Location: Basingstoke, England

Posted: 3rd Jun 2012 22:41

Link

+1 to what Diggsey said. Arrays in dbp aren't magic things picked up by the compiler and initialised before the code runs. Think of them as just normal lines of code that need to be run through for them to come into existence.

This would not work:

+ Code Snippet

do
  MyFunction()
loop

dim Bob(10)

function MyFunction()
   for i=1 to 10
      print bob(i)
   next i
endfunction

... as Bob would never be reached so never initialised. Bob needs to be defined before the loop begins.

It'd be more helpful if DBP reported the array as not existing, but it doesn't!

Back to top

Profile PM

Ace of Springs

14

Years of Service

User Offline

Joined: 10th Jan 2012

Location: Cambodia

Posted: 3rd Jun 2012 23:23

Link

Yea, I understand how they work now. I just assumed they would be picked up in the same way standard global variables are. Learn something new everyday

Back to top

Profile PM Email Website

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Array out of bounds? I don't see it.