what am i doing wrong , please please help

Author

Message

haliop

User Banned

Posted: 3rd Apr 2013 17:46

    // setup
    disc = 0
    
    // in loop 
    // discription button
    if GetVirtualButtonExists(2) = 1
        if GetVirtualButtonPressed(2) = 1
            if discOn = 0 then discOn = 1
            else if discOn = 1 then discOn = 0

        endif
    endif

    // activating discription on or off
    if discOn = 1
        if GetTextVisible(2) = 0 then SetTextVisible(2,1)
    endif
    if discOn = 0
        if GetTextVisible(2) = 1 then SetTextVisible(2,0)
    endif

as i understand using this method discOn should be 1 or 0 even if i still press the virtual button.

but for some reason the text flickers for one sec then dissapears..

why is that?

http://forum.thegamecreators.com/?m=forum_view&t=198467&b=22

Back to top

Profile

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 3rd Apr 2013 17:59

Link

I have discovered that in Tier 1, the GetVirtualButtonPressed will sometimes return 1 for longer than expected.

First, are you doing a Sync() call at least once after the description display toggle?

Next, try putting this line after the "else if discOn = 1 then discOn = 0" one:
while GetVirtualButtonPressed(2) = 1: Sync(): endwhile

(or break it up into three lines)

This should make sure that you only 'catch' one press every cycle.

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Van B

Moderator

22

Years of Service

User Offline

Joined: 8th Oct 2002

Location: Sunnyvale

Posted: 3rd Apr 2013 18:03

Link

I think it'll be because the virtual button is registering the press for several frames, rather than just one. So if you have a delay, or a reset for the button press, then you would have more control. Like:

// setup
disc = 0

// in loop
// discription button
if GetVirtualButtonExists(2) = 1
if GetVirtualButtonPressed(2) = 1
if PRESSING=0
if discOn = 0 then discOn = 1
else if discOn = 1 then discOn = 0
PRESSING=1
endif
else
PRESSING=0
endif
endif

So if the button isn't pressed, PRESSING will be 0 - as soon as you press the button, PRESSING will be 1, and stay at 1 while you press it.
If you need a lot of buttons, maybe worth having a PRESSING array, and make it a standard.

Ohh, and quick tip - to change discOn between 1 and 0, just do this:

discOn=1-discOn

I got a fever, and the only prescription, is more memes.

Back to top

Profile PM Email

haliop

User Banned

Posted: 3rd Apr 2013 18:16

Link

yes there is a sync() after... ofcourse there is

still i didnot understand what to do ...
can someone write it in

+ Code Snippet

?

and thanks for the quick response! this just show what a great community AppGameKit have.

http://forum.thegamecreators.com/?m=forum_view&t=198467&b=22

Back to top

Profile

haliop

User Banned

Posted: 3rd Apr 2013 18:18

Link

and i just need this button to work like this :/

http://forum.thegamecreators.com/?m=forum_view&t=198467&b=22

Back to top

Profile

haliop

User Banned

Posted: 3rd Apr 2013 18:19

Link

i got about 20 buttons overall all work great but only this one have a boolean op in it.. to show or not to show the text.. i just cant figure out what to do ... sorry if this seems stupid or something.

http://forum.thegamecreators.com/?m=forum_view&t=198467&b=22

Back to top

Profile

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 3rd Apr 2013 18:26

Link

This will make sure that you don't get multiple frame hits on the button when you don't want to:

+ Code Snippet

    // discription button
    if GetVirtualButtonExists(2) = 1
        if GetVirtualButtonPressed(2) = 1
            if discOn = 0 then discOn = 1
            else if discOn = 1 then discOn = 0
            // check until the button stops registering pressed
            while GetVirtualButtonPressed(2) = 1
                Sync()
            endwhile
        endif
    endif

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

haliop

User Banned

Posted: 3rd Apr 2013 18:51

Link

this dosent work ...

+ Code Snippet

    if discOn = 1
        if GetTextVisible(2) = 0 then SetTextVisible(2,1)
    endif
    if discOn = 0
        if GetTextVisible(2) = 1 then SetTextVisible(2,0)
    endif
    // discription button
    if GetVirtualButtonExists(2) = 1
        if GetVirtualButtonPressed(2) = 1
            if discOn = 0 then discOn = 1
            else if discOn = 1 then discOn = 0
             while GetVirtualButtonPressed(2) = 1
                Sync()
            endwhile
        endif
    endif

http://forum.thegamecreators.com/?m=forum_view&t=198467&b=22

Back to top

Profile

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 3rd Apr 2013 19:18

Link

What do you mean by "it doesn't work"? What behavior are you seeing?

The first time you showed the code, you had the 'if discOn = 1' set of code after the other.

Also you can replace that bit with one line:

+ Code Snippet

if GetTextVisible(2) != discOn then SetTextVisible(2,discOn)

In fact, you can can replace a lot:

+ Code Snippet

// setup outside of loop
// assumes that you have already created Text(2)
discOn = 0
SetTextVisible(2,0)

// inside main loop
    // discription button
    if GetVirtualButtonExists(2) = 1
        if GetVirtualButtonPressed(2) = 1
           // flip the value of discOn
           discOn = Mod(discOn+1,2)

           // update the display of discription
           if GetTextVisible(2) != discOn then SetTextVisible(2,discOn)

           // make sure that we don't have extended button press
           while GetVirtualButtonPressed(2) = 1 : Sync() : endwhile
        endif
    endif

Are you sure that the discOn variable isn't being set anywhere else?

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 3rd Apr 2013 19:51

Link

by the way, i think this:

if discOn = 0 then discOn = 1
else if discOn = 1 then discOn = 0

=

discOn = 1 - discOn

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 3rd Apr 2013 20:17

Link

Quote: "discOn = 1 - discOn"

Yup, that is much better than my suggestion of

Quote: "discOn = Mod(discOn+1,2)"

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

haliop

User Banned

Posted: 3rd Apr 2013 23:06

Link

+ Code Snippet

  // discription buttonif GetVirtualButtonExists(2) = 1
    if GetVirtualButtonExists(2) = 1
        if GetVirtualButtonPressed(2) = 1
           // flip the value of discOn
           discOn = 1 - discOn

           // update the display of discription
           SetTextVisible(2,discOn)

           // make s
        endif
    endif

works like a charm! ty

http://forum.thegamecreators.com/?m=forum_view&t=198467&b=22

Back to top

Profile

Marl

13

Years of Service

User Offline

Joined: 19th Nov 2011

Location: Bradford, UK

Posted: 4th Apr 2013 19:41

Link

If your only using discOn to flag the text change, you could change;

+ Code Snippet

// flip the value of discOn
           discOn = 1 - discOn

           // update the display of discription
           SetTextVisible(2,discOn)

to;

+ Code Snippet

// flip the Text Visibility
SetTextVisible(2,1-getTextVisible(2))

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 4th Apr 2013 22:24

Link

That works, but it adds an extra function call, which will take many more machine cycles than the simple math function.

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Sorry your browser is not supported!

AppGameKit Classic Chat / what am i doing wrong , please please help