Passing lights to a shader? Can anyone figure out what's wrong with this code?

Author

Message

mnemonic

19

Years of Service

User Offline

Joined: 14th Jan 2007

Location: Sweden

Posted: 3rd May 2013 14:41 Edited at: 3rd May 2013 14:45

Link

,,,or at least help me see some bad syntax,, I've been staring mad at this.

here is the code:

+ Code Snippet

element = Get Object Effect(1,-1)

null = make vector4(1)

set vector4 1,ambientR,ambientG,ambientB,0
set effect constant vector 1,"AmbientColor",1

for i = 0 to 7
       set vector4 1,light position x(i),light position y(i),light position z(i),light range(i)
       set effect constant vector element "LightPos",i,1
       
       set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0
       set effect constant vector element "LightColor",i,1
NEXT i

null  = delete vector4(1)

release effect pointer

the above code is a write-off from the help file of dark shader.

It won't compile the compiler complains about this line:

+ Code Snippet

set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0

saying: "Parameter for 'SET VECTOR4' do not match 'VectorResult, X, Y, Z, W"

BEST!

www.memblockgames.com

Back to top

Profile PM Email Website

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 3rd May 2013 18:55

Link

You need to declare the arrays lightred(), etc - and also to give them some values (ambientR etc need values too). That Help file code is incomplete.

One further point to note: for shader use the color values probably need to be in the range 0 to 1 not 0 to 255.

Back to top

Profile PM Email

mnemonic

19

Years of Service

User Offline

Joined: 14th Jan 2007

Location: Sweden

Posted: 5th May 2013 23:24

Link

Thanks, I have done what you said, but my object is still black. I must be doing something wrong. This shader requires light according to the description in dark shader, so passing lights to it sounds like a good idea

does the code part for passing the lights need to be in the main loop?

www.memblockgames.com

Back to top

Profile PM Email Website

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 6th May 2013 00:47

Link

Could you post both the shader and dba code you're using? I'll then take a quick look at it. Sounds like a simple error somewhere.

Back to top

Profile PM Email

James H

19

Years of Service

User Offline

Joined: 21st Apr 2007

Location: St Helens

Posted: 6th May 2013 01:31 Edited at: 6th May 2013 02:12

Link

Quote: "It won't compile the compiler complains about this line:

+ Code Snippet

set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0

saying: "Parameter for 'SET VECTOR4' do not match 'VectorResult, X, Y, Z, W""

Odd, I just put that specific line into the IDE and hit F4 - compiles fine. Perhaps the upgrade you have installed is different to me - I seem to recall at some stage updates including a number of shader related commands that I think were FPSC specific(maybe for lightmapping that was previously only available buy purchasing Dark Lights?), either way I`m more than sure that at one point in DBP`s life there was a change in shader related commands of some sort.
I do recall having an issue with that particular code in the past on more than one occasion along with a small number of other items that were easily corrected from other project exports from DS, sometimes in dbp code sometimes in shader code. I think you should look into updates aswell as post the full code for DBP`s wonderfull green wizard to take a look at

edit doh!

my page didnt fully load so didnt see other posts - do your best to ignore me!
edit2 weird - i put that line in alone yet compiler never threw out error for not having declared array or told me no such function...Oo

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 6th May 2013 13:07

Link

Sounds like you are using an old update. I'm using U77RC7 which gives the compile error (as it should).

Back to top

Profile PM Email

James H

19

Years of Service

User Offline

Joined: 21st Apr 2007

Location: St Helens

Posted: 6th May 2013 14:22

Link

o dear, call it a bad night, I use a program called Always On Top to keep certain windows always on top while I play kingdoms of camelot, last night it was running and the IDE(Indigo) was hiding the window that Indigo uses to inform me of any errors, left my machine on overnight and retried this just now(yes am lazy git) only spotting now that the little window was hidden away

Back to top

Profile PM

mnemonic

19

Years of Service

User Offline

Joined: 14th Jan 2007

Location: Sweden

Posted: 6th May 2013 15:34

Link

Quote: "Could you post both the shader and dba code you're using? I'll then take a quick look at it. Sounds like a simple error somewhere."

Here they are:

The db code:

sync on
sync rate 60

load object "cube.dbo",1
set object light 1,1
autocam off
load effect "Normal mapping.dbs",1,0
set object effect 1,1

dim lightred(7)
dim lightgreen(7)
dim lightblue(7)

for u = 0 to 7
        lightred(u) = 0.3
        lightgreen(u) = 0.3
        lightblue(u) = 0.3
    NEXT u

make light 1
make light 2
make light 3
make light 4
make light 5
make light 6
make light 7

color light 1,67,67,67
color light 2,67,67,67
color light 3,67,67,67
color light 4,67,67,67
color light 5,67,67,67
color light 6,67,67,67
color light 7,67,67,67

position light 1,10,10,10
position light 2,20,20,20
position light 3,30,30,30
position light 4,40,40,40
position light 5,50,50,50
position light 6,60,60,60
position light 7,70,70,70

set directional light 1,0,0,-10
set directional light 2,0,0,-10
set directional light 3,0,0,-10
set directional light 4,0,0,-10
set directional light 5,0,0,-10
set directional light 6,0,0,-10
set directional light 7,0,0,-10

set light range 1,5
set light range 2,5
set light range 3,5
set light range 4,5
set light range 5,5
set light range 6,5
set light range 7,5

ambientR as float
ambientG as float
ambientB as float

ambientR = 0.2
ambientG = 0.2
ambientB = 0.2

element = Get Object Effect(1,-1)

null = make vector4(1)

set vector4 1,ambientR,ambientG,ambientB,0
    set effect constant vector 1,"AmbientColor",1

for i = 0 to 7
       set vector4 1,light position x(i),light position y(i),light position z(i),light range(i)
       set effect constant vector element "LightPos",i,1
      
       set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0
       set effect constant vector element "LightColor",i,1
    next i

null  = delete vector4(1)

release effect pointer
do

rotate object  1, object angle x(1)+1.00,object angle y(1)+1,object angle z(1)+1.00
    sync   
LOOP

+ Code Snippet

sync on
sync rate 60

load object "cube.dbo",1
set object light 1,1
autocam off
load effect "Normal mapping.dbs",1,0
set object effect 1,1

dim lightred(7)
dim lightgreen(7)
dim lightblue(7)


    for u = 0 to 7
        lightred(u) = 0.3
        lightgreen(u) = 0.3
        lightblue(u) = 0.3
    NEXT u
    

make light 1
make light 2
make light 3
make light 4
make light 5
make light 6
make light 7

color light 1,67,67,67
color light 2,67,67,67
color light 3,67,67,67
color light 4,67,67,67
color light 5,67,67,67
color light 6,67,67,67
color light 7,67,67,67

position light 1,10,10,10
position light 2,20,20,20
position light 3,30,30,30
position light 4,40,40,40
position light 5,50,50,50
position light 6,60,60,60
position light 7,70,70,70

set directional light 1,0,0,-10
set directional light 2,0,0,-10
set directional light 3,0,0,-10
set directional light 4,0,0,-10
set directional light 5,0,0,-10
set directional light 6,0,0,-10
set directional light 7,0,0,-10

set light range 1,5
set light range 2,5
set light range 3,5
set light range 4,5
set light range 5,5
set light range 6,5
set light range 7,5


ambientR as float
ambientG as float
ambientB as float

ambientR = 0.2
ambientG = 0.2
ambientB = 0.2

element = Get Object Effect(1,-1)

    null = make vector4(1)

    set vector4 1,ambientR,ambientG,ambientB,0
    set effect constant vector 1,"AmbientColor",1

    for i = 0 to 7
       set vector4 1,light position x(i),light position y(i),light position z(i),light range(i)
       set effect constant vector element "LightPos",i,1
      
       set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0
       set effect constant vector element "LightColor",i,1
    next i

    null  = delete vector4(1)

    release effect pointer
do

    
    rotate object  1, object angle x(1)+1.00,object angle y(1)+1,object angle z(1)+1.00
    sync   
LOOP

and the shader code:

string Description = "This shader uses preview lights to produce per pixel normal mapped lighting. This shader requires lights.";
string Thumbnail = "Normal Mapping.png";

//--------------
//Untweakables
//--------------
float4x4 WorldViewProj : WorldViewProjection;
float4x4 World : World;
float4x4 WorldT : WorldTranspose;
float4x4 WorldIT : WorldInverseTranspose;

float4 LightPos[8] : LIGHTPOSITION;
float3 LightColor[8] : LIGHTCOLOR;
float3 AmbientColor : AMBIENTCOLOR;

float3 eyepos : CameraPosition;
float time : TIME;

//--------------
//Tweakables
//--------------

float SpecularPower1 
<
	string UIWidget = "slider";
	float UIMax = 30;
	float UIMin = 1;
> = 1.000000;

texture BaseTex
<
	string ResourceName = "f_b_01_D.dds";
>;

sampler diffuse_smp = sampler_state 
{
	Texture = <BaseTex>;
	MinFilter = Anisotropic;
	MagFilter = Linear;
	MipFilter = Linear;
	AddressU = Wrap;
	AddressV = Wrap;
};

texture NormalMap
<
	string ResourceName = "f_b_01_N.dds";
>;

sampler normalmap_smp = sampler_state 
{
	Texture = <NormalMap>;
	MinFilter = Linear;
	MagFilter = Linear;
	MipFilter = Linear;
	AddressU = Wrap;
	AddressV = Wrap;
};

struct app_in
{
	float4 pos : POSITION;
	float3 normal : NORMAL0;
	float3 tangent : TANGENT0;
	float3 binormal : BINORMAL0;
	float2 uv : TEXCOORD0;
};

struct vs_out
{
	float4 pos : POSITION;
	float2 uv : TEXCOORD0;
	float3 normal : TEXCOORD1;
	float3 tangent : TEXCOORD2;
	float3 binormal : TEXCOORD3;
	float4 wpos : TEXCOORD4;
};

vs_out VS( app_in IN )
{
	vs_out OUT;
	
	float4 pos = mul( IN.pos, WorldViewProj );
	OUT.pos = pos;
	OUT.wpos = mul( IN.pos, World );
	OUT.uv = IN.uv;
	float3 normal = normalize(mul(IN.normal.xyz,(float3x3)World ));
	float3 tangent = normalize(mul(IN.tangent.xyz,(float3x3)World ));
	float3 binormal = normalize(mul(IN.binormal.xyz,(float3x3)World ));
	
	//smooth out the tangents and binormals with the normals
	float3 b = normalize(cross( normal,tangent ));
	b *= sign(dot(b,binormal));
	
	float3 t = normalize(cross( normal,b ));
	t *= sign(dot(t,tangent));
	
	float3 t2 = normalize(cross( normal,binormal ));
	t2 *= sign(dot(t2,tangent));
	
	float3 b2 = normalize(cross( normal,t2 ));
	b2 *= sign(dot(b2,binormal));
	
	//pass normal, tangent, and binormal to pixel shader
	OUT.normal = normal;
	OUT.tangent = normalize((t+t2)*0.5);
	OUT.binormal = normalize((b+b2)*0.5);
	
	return OUT;
}

float luminance ( float3 rgb )
{
	return rgb.r*0.3 + rgb.g*0.59 + rgb.b*0.11;
}

float4 PS( vs_out IN, uniform int numLights ) : COLOR
{
	float3 color = AmbientColor;
	
	float3 n = normalize(IN.normal);
	float3 t = normalize(IN.tangent);
	float3 b = normalize(IN.binormal);
	
	//build transpose matrix
	float3x3 TangentSpace = {t,b,n};
	TangentSpace = transpose(TangentSpace);
	
	n = normalize(tex2D(normalmap_smp, IN.uv)*2 - 1);
	
	float3 e = normalize(eyepos - IN.wpos);
	float eyeDist = length(eyepos - IN.wpos);
	
	e = mul(e,TangentSpace);
	
	float4 texColor = tex2D( diffuse_smp, IN.uv );
	
	//cycle through all lights, number depending on technique chosen
	for ( int i = 0; i < numLights; i++ )
	{
		float range = LightPos[i].w;
		
		if ( range > 0 )
		{
			float3 l = (LightPos[i].xyz - IN.wpos.xyz);
			l = mul(l,TangentSpace);
			
			//calculate attenuation
			float dist = length(l);
			float att = saturate((range-dist) / range);
			
			//calculate diffuse lighting
			l = normalize(l);
			float diffuse = saturate(dot(n,l));
			
			//caculate specular lighting
			float3 h = normalize(l+e);
			float spec = pow( saturate(dot(n,h)), SpecularPower1 )*(1-pow(1-diffuse,10));
			
			//add to final color
			color += (diffuse * att * LightColor[i]) + (spec * att * LightColor[i] * smoothstep(0.3,0.6,luminance(texColor.xyz)));
		}
	}
	
	return float4(color,1.0) * texColor;
}

//choose the technique corresponding to the number of lights in your application
technique PerPixelLighting
{
	pass p0
	{
		VertexShader = compile vs_2_0 VS( );
		PixelShader = compile ps_2_0 PS( 0 );
	}
}

technique DBLight1
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 1 );
	}
}

technique DBLight2
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 2 );
	}
}

technique DBLight3
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 3 );
	}
}

technique DBLight4
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 4 );
	}
}

technique DBLight5
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 5 );
	}
}

technique DBLight6
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 6 );
	}
}

technique DBLight7
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 7 );
	}
}

technique DBLight8
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 8 );
	}
}

+ Code Snippet

string Description = "This shader uses preview lights to produce per pixel normal mapped lighting. This shader requires lights.";
string Thumbnail = "Normal Mapping.png";

//--------------
//Untweakables
//--------------
float4x4 WorldViewProj : WorldViewProjection;
float4x4 World : World;
float4x4 WorldT : WorldTranspose;
float4x4 WorldIT : WorldInverseTranspose;

float4 LightPos[8] : LIGHTPOSITION;
float3 LightColor[8] : LIGHTCOLOR;
float3 AmbientColor : AMBIENTCOLOR;

float3 eyepos : CameraPosition;
float time : TIME;

//--------------
//Tweakables
//--------------

float SpecularPower1 
<
	string UIWidget = "slider";
	float UIMax = 30;
	float UIMin = 1;
> = 1.000000;

texture BaseTex
<
	string ResourceName = "f_b_01_D.dds";
>;

sampler diffuse_smp = sampler_state 
{
	Texture = <BaseTex>;
	MinFilter = Anisotropic;
	MagFilter = Linear;
	MipFilter = Linear;
	AddressU = Wrap;
	AddressV = Wrap;
};

texture NormalMap
<
	string ResourceName = "f_b_01_N.dds";
>;

sampler normalmap_smp = sampler_state 
{
	Texture = <NormalMap>;
	MinFilter = Linear;
	MagFilter = Linear;
	MipFilter = Linear;
	AddressU = Wrap;
	AddressV = Wrap;
};

struct app_in
{
	float4 pos : POSITION;
	float3 normal : NORMAL0;
	float3 tangent : TANGENT0;
	float3 binormal : BINORMAL0;
	float2 uv : TEXCOORD0;
};

struct vs_out
{
	float4 pos : POSITION;
	float2 uv : TEXCOORD0;
	float3 normal : TEXCOORD1;
	float3 tangent : TEXCOORD2;
	float3 binormal : TEXCOORD3;
	float4 wpos : TEXCOORD4;
};

vs_out VS( app_in IN )
{
	vs_out OUT;
	
	float4 pos = mul( IN.pos, WorldViewProj );
	OUT.pos = pos;
	OUT.wpos = mul( IN.pos, World );
	OUT.uv = IN.uv;
	float3 normal = normalize(mul(IN.normal.xyz,(float3x3)World ));
	float3 tangent = normalize(mul(IN.tangent.xyz,(float3x3)World ));
	float3 binormal = normalize(mul(IN.binormal.xyz,(float3x3)World ));
	
	//smooth out the tangents and binormals with the normals
	float3 b = normalize(cross( normal,tangent ));
	b *= sign(dot(b,binormal));
	
	float3 t = normalize(cross( normal,b ));
	t *= sign(dot(t,tangent));
	
	float3 t2 = normalize(cross( normal,binormal ));
	t2 *= sign(dot(t2,tangent));
	
	float3 b2 = normalize(cross( normal,t2 ));
	b2 *= sign(dot(b2,binormal));
	
	//pass normal, tangent, and binormal to pixel shader
	OUT.normal = normal;
	OUT.tangent = normalize((t+t2)*0.5);
	OUT.binormal = normalize((b+b2)*0.5);
	
	return OUT;
}

float luminance ( float3 rgb )
{
	return rgb.r*0.3 + rgb.g*0.59 + rgb.b*0.11;
}

float4 PS( vs_out IN, uniform int numLights ) : COLOR
{
	float3 color = AmbientColor;
	
	float3 n = normalize(IN.normal);
	float3 t = normalize(IN.tangent);
	float3 b = normalize(IN.binormal);
	
	//build transpose matrix
	float3x3 TangentSpace = {t,b,n};
	TangentSpace = transpose(TangentSpace);
	
	n = normalize(tex2D(normalmap_smp, IN.uv)*2 - 1);
	
	float3 e = normalize(eyepos - IN.wpos);
	float eyeDist = length(eyepos - IN.wpos);
	
	e = mul(e,TangentSpace);
	
	float4 texColor = tex2D( diffuse_smp, IN.uv );
	
	//cycle through all lights, number depending on technique chosen
	for ( int i = 0; i < numLights; i++ )
	{
		float range = LightPos[i].w;
		
		if ( range > 0 )
		{
			float3 l = (LightPos[i].xyz - IN.wpos.xyz);
			l = mul(l,TangentSpace);
			
			//calculate attenuation
			float dist = length(l);
			float att = saturate((range-dist) / range);
			
			//calculate diffuse lighting
			l = normalize(l);
			float diffuse = saturate(dot(n,l));
			
			//caculate specular lighting
			float3 h = normalize(l+e);
			float spec = pow( saturate(dot(n,h)), SpecularPower1 )*(1-pow(1-diffuse,10));
			
			//add to final color
			color += (diffuse * att * LightColor[i]) + (spec * att * LightColor[i] * smoothstep(0.3,0.6,luminance(texColor.xyz)));
		}
	}
	
	return float4(color,1.0) * texColor;
}

//choose the technique corresponding to the number of lights in your application
technique PerPixelLighting
{
	pass p0
	{
		VertexShader = compile vs_2_0 VS( );
		PixelShader = compile ps_2_0 PS( 0 );
	}
}

technique DBLight1
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 1 );
	}
}

technique DBLight2
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 2 );
	}
}

technique DBLight3
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 3 );
	}
}

technique DBLight4
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 4 );
	}
}

technique DBLight5
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 5 );
	}
}

technique DBLight6
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 6 );
	}
}

technique DBLight7
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 7 );
	}
}

technique DBLight8
{
	pass p0
	{
		VertexShader = compile vs_1_1 VS( );
		PixelShader = compile ps_2_a PS( 8 );
	}
}

I'm pretty new to shaders so I do not fully master them and therefore I donnot quite understand what I'm doing here (A programmers worst nightmare) so I'm happy and thankful for all the help I can get

www.memblockgames.com

Back to top

Profile PM Email Website

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 6th May 2013 17:02

Link

Quote: "I'm pretty new to shaders so I do not fully master them and therefore I donnot quite understand what I'm doing here "

No problem. We were all in that state once.

Thanks for the code - I'll check it out and report back later.

Back to top

Profile PM Email

James H

19

Years of Service

User Offline

Joined: 21st Apr 2007

Location: St Helens

Posted: 6th May 2013 18:06 Edited at: 6th May 2013 18:59

Link

In a vague attempt to redeem my idiocy;
You need a diffuse texture in texture stage 0, a normal texture in texture stage 1 - without textures you will get just black cube
You need to set the effect technique to DBLight8 to see the lights
All your lights are positioned in a straight line inside the cubes boundaries with same range(not a large enough range) and the same color so you wont see much the way they are currently setup
I could be wrong but setting DB lights as directional won`t affect the shader lights type, think that part needs to be in the shader
Although you did declare arrays for light colour - they are currently not floats which they need to be as GG said values are between 0.0 and 1.0

This is by no means a good example(especially as i havent coloured spheres that mark the light positions very well as light 0 is in use, prob better to hide light 0 and create an 8th db light - Im sure you can do this) but will give you an idea of how things work, use the same shader code you already have and just find a normal and diffuse texture to use;

`main template
`untitled.dba
`======================
sync on
sync rate 60

load object "cube.dbo",1
set object light 1,1
autocam off
load effect "Normal mapping.dbs",1,0
set object effect 1,1
load image "leather_D.dds",1
load image "leather_N.dds",2
texture object 1,0,1
texture object 1,1,2
set effect technique 1,"DBLight8"
dim lightred(7) as float
dim lightgreen(7) as float
dim lightblue(7) as float

for u = 0 to 7
		if u>0 then make light u
        lightred(u) = rnd(255)/255.0
        lightgreen(u) = rnd(255)/255.0
        lightblue(u) = rnd(255)/255.0
		  make object sphere u+10,10
		  set object diffuse u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
		  set object ambient u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
		  set object emissive u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
    NEXT u

position light 0,rnd(100)-150,rnd(100)+50,rnd(100)+50
position light 1,rnd(100)-150,rnd(100)+50,rnd(100)+50
position light 2,rnd(100)+50,rnd(100)-150,rnd(100)+50
position light 3,rnd(100)+50,rnd(100)+50,rnd(100)-150
position light 4,rnd(100)-150,rnd(100)-150,rnd(100)+50
position light 5,rnd(100)-50,rnd(100)-150,rnd(100)+50
position light 6,rnd(100)+50,rnd(100)-150,rnd(100)-150
position light 7,rnd(100)+50,rnd(100)+50,rnd(100)+50

set light range 1,50000
set light range 2,500
set light range 3,100
set light range 4,5000
set light range 5,5000
set light range 6,5000
set light range 7,5000

ambientR as float
ambientG as float
ambientB as float

ambientR = 0.25
ambientG = 0.25
ambientB = 0.25

element = Get Object Effect(1,-1)

null = make vector4(1)

set vector4 1,ambientR,ambientG,ambientB,0
    set effect constant vector 1,"AmbientColor",1

for i = 0 to 7
		
		position object i+10,light position x(i),light position y(i),light position z(i)
       set vector4 1,light position x(i),light position y(i),light position z(i),light range(i)
       set effect constant vector element "LightPos",i,1
      
       set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0
       set effect constant vector element "LightColor",i,1
    next i

null  = delete vector4(1)

release effect pointer

zz=camera position z()
do
    position camera 0,0,0
	 yrotate camera camera angle y()+mousemovex()
	 move camera zz
    rotate object  1, object angle x(1)+1.00,object angle y(1)+1,object angle z(1)+1.00
    sync   
LOOP

+ Code Snippet

`main template
`untitled.dba
`======================
sync on
sync rate 60

load object "cube.dbo",1
set object light 1,1
autocam off
load effect "Normal mapping.dbs",1,0
set object effect 1,1
load image "leather_D.dds",1
load image "leather_N.dds",2
texture object 1,0,1
texture object 1,1,2
set effect technique 1,"DBLight8"
dim lightred(7) as float
dim lightgreen(7) as float
dim lightblue(7) as float


    for u = 0 to 7
		if u>0 then make light u
        lightred(u) = rnd(255)/255.0
        lightgreen(u) = rnd(255)/255.0
        lightblue(u) = rnd(255)/255.0
		  make object sphere u+10,10
		  set object diffuse u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
		  set object ambient u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
		  set object emissive u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
    NEXT u
    




position light 0,rnd(100)-150,rnd(100)+50,rnd(100)+50
position light 1,rnd(100)-150,rnd(100)+50,rnd(100)+50
position light 2,rnd(100)+50,rnd(100)-150,rnd(100)+50
position light 3,rnd(100)+50,rnd(100)+50,rnd(100)-150
position light 4,rnd(100)-150,rnd(100)-150,rnd(100)+50
position light 5,rnd(100)-50,rnd(100)-150,rnd(100)+50
position light 6,rnd(100)+50,rnd(100)-150,rnd(100)-150
position light 7,rnd(100)+50,rnd(100)+50,rnd(100)+50


set light range 1,50000
set light range 2,500
set light range 3,100
set light range 4,5000
set light range 5,5000
set light range 6,5000
set light range 7,5000


ambientR as float
ambientG as float
ambientB as float

ambientR = 0.25
ambientG = 0.25
ambientB = 0.25

element = Get Object Effect(1,-1)

    null = make vector4(1)

    set vector4 1,ambientR,ambientG,ambientB,0
    set effect constant vector 1,"AmbientColor",1

    for i = 0 to 7
		
		position object i+10,light position x(i),light position y(i),light position z(i)
       set vector4 1,light position x(i),light position y(i),light position z(i),light range(i)
       set effect constant vector element "LightPos",i,1
      
       set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0
       set effect constant vector element "LightColor",i,1
    next i

    null  = delete vector4(1)

    release effect pointer

	 zz=camera position z()
do
    position camera 0,0,0
	 yrotate camera camera angle y()+mousemovex()
	 move camera zz
    rotate object  1, object angle x(1)+1.00,object angle y(1)+1,object angle z(1)+1.00
    sync   
LOOP

Edit; In fact there is plenty wrong with my code(ambient instead of ambience for example!!) - suggest you wait on better example from GG though my earlier points are definately worth noting

Edit2; The following is much better, it uses just 6 lights to show clearer more obvious results and is easier to read;

`main template
`untitled.dba
`======================
sync on
sync rate 60
autocam off
load object "cube.dbo",1

load image "leather_D.dds",1
load image "leather_N.dds",2
load effect "Normal mapping.dbs",1,0

set effect technique 1,"DBLight6"
set object effect 1,1
texture object 1,0,1
texture object 1,1,2

dim lightred(5) as float
dim lightgreen(5) as float
dim lightblue(5) as float

lightred(0) = 1.0
lightgreen(0) = 0.0
lightblue(0) = 0.0
lightred(1) = 0.0
lightgreen(1) = 1.0
lightblue(1) = 0.0
lightred(2) = 0.0
lightgreen(2) = 0.0
lightblue(2) = 1.0
lightred(3) = 1.0
lightgreen(3) = 1.0
lightblue(3) = 0.0
lightred(4) = 0.0
lightgreen(4) = 1.0
lightblue(4) = 1.0
lightred(5) = 1.0
lightgreen(5) = 0.0
lightblue(5) = 1.0

for u = 0 to 5
	if u>0 then make light u
	  make object sphere u+10,10
	  set object diffuse u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
	  set object ambience u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
	  set object emissive u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
next u

position light 0,-100,0,0
position light 1,100,0,0
position light 2,0,-100,0
position light 3,0,100,0
position light 4,0,0,-100
position light 5,0,0,100

set light range 1,500
set light range 2,500
set light range 3,500
set light range 4,500
set light range 5,500
set ambient light 100

ambientR as float
ambientG as float
ambientB as float

ambientR = 0.25
ambientG = 0.25
ambientB = 0.25

element = Get Object Effect(1,-1)
null = make vector4(1)
set vector4 1,ambientR,ambientG,ambientB,0
set effect constant vector 1,"AmbientColor",1
for i = 0 to 5
	position object i+10,light position x(i),light position y(i),light position z(i)

set vector4 1,light position x(i),light position y(i),light position z(i),light range(i)
   set effect constant vector element "LightPos",i,1
      
   set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0
   set effect constant vector element "LightColor",i,1
next i

null  = delete vector4(1)

release effect pointer

do
    position camera 0,0,0
	 yrotate camera camera angle y()+mousemovex()
	 xrotate camera camera angle x()+mousemovey()
	 move camera -300

sync   
LOOP

+ Code Snippet

`main template
`untitled.dba
`======================
sync on
sync rate 60
autocam off
load object "cube.dbo",1

load image "leather_D.dds",1
load image "leather_N.dds",2
load effect "Normal mapping.dbs",1,0

set effect technique 1,"DBLight6"
set object effect 1,1
texture object 1,0,1
texture object 1,1,2

dim lightred(5) as float
dim lightgreen(5) as float
dim lightblue(5) as float

lightred(0) = 1.0
lightgreen(0) = 0.0
lightblue(0) = 0.0
lightred(1) = 0.0
lightgreen(1) = 1.0
lightblue(1) = 0.0
lightred(2) = 0.0
lightgreen(2) = 0.0
lightblue(2) = 1.0
lightred(3) = 1.0
lightgreen(3) = 1.0
lightblue(3) = 0.0
lightred(4) = 0.0
lightgreen(4) = 1.0
lightblue(4) = 1.0
lightred(5) = 1.0
lightgreen(5) = 0.0
lightblue(5) = 1.0

for u = 0 to 5
	if u>0 then make light u
	  make object sphere u+10,10
	  set object diffuse u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
	  set object ambience u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
	  set object emissive u+10,rgb(lightred(u)*255,lightgreen(u)*255,lightblue(u)*255)
next u

position light 0,-100,0,0
position light 1,100,0,0
position light 2,0,-100,0
position light 3,0,100,0
position light 4,0,0,-100
position light 5,0,0,100

set light range 1,500
set light range 2,500
set light range 3,500
set light range 4,500
set light range 5,500
set ambient light 100

ambientR as float
ambientG as float
ambientB as float

ambientR = 0.25
ambientG = 0.25
ambientB = 0.25

element = Get Object Effect(1,-1)
null = make vector4(1)
set vector4 1,ambientR,ambientG,ambientB,0
set effect constant vector 1,"AmbientColor",1
for i = 0 to 5
	position object i+10,light position x(i),light position y(i),light position z(i)

	set vector4 1,light position x(i),light position y(i),light position z(i),light range(i)
   set effect constant vector element "LightPos",i,1
      
   set vector4 1,lightred(i),lightgreen(i),lightblue(i),1.0
   set effect constant vector element "LightColor",i,1
next i

null  = delete vector4(1)

release effect pointer

do
    position camera 0,0,0
	 yrotate camera camera angle y()+mousemovex()
	 xrotate camera camera angle x()+mousemovey()
	 move camera -300

    sync   
LOOP

Back to top

Profile PM

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 7th May 2013 00:09

Link

Quote: "In a vague attempt to redeem my idiocy"

You have.

Back to top

Profile PM Email

James H

19

Years of Service

User Offline

Joined: 21st Apr 2007

Location: St Helens

Posted: 7th May 2013 01:31

Link

Phew!

Back to top

Profile PM

mnemonic

19

Years of Service

User Offline

Joined: 14th Jan 2007

Location: Sweden

Posted: 7th May 2013 11:45

Link

Cool! Now I've got a cool shaded object on my screen!

But I have some questions:

QUESTION 1:
Why do I have to load the textures in the code? When they already seem to be defined in the shader code?

+ Code Snippet

texture BaseTex
<
	string ResourceName = "f_b_01_D.dds";
>;

texture NormalMap
<
	string ResourceName = "f_b_01_N.dds";
>;

QUESTION 2:

You have created spheres as emitters for the lights in the db code you provided. Is this necessary to acctualy 'see' the scene lights?

www.memblockgames.com

Back to top

Profile PM Email Website

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 7th May 2013 12:59

Link

Quote: "Why do I have to load the textures in the code? When they already seem to be defined in the shader code?"

You don't have to. You can use this

+ Code Snippet

load effect "Normal mapping.dbs",1,1

instead of

+ Code Snippet

load effect "Normal mapping.dbs",1,0

The final flag tells DBPro whether or not to use the model's textures or the ones in the shader. Indeed the Help file tells you this - just (

). Don't forget to check them now and then.

Quote: "You have created spheres as emitters for the lights in the db code you provided. Is this necessary to acctualy 'see' the scene lights?"

No. That was obviously just a device to make it crystal clear what was going on. In fact a positional light should logically have an object associated with it - e.g. a table lamp, car headlight, a fire, etc. But you don't actually need it - you could just have the light mysteriously emanating from an invisible point in the scene.

Back to top

Profile PM Email

nachwaal3ab

13

Years of Service

User Offline

Joined: 7th May 2013

Location:

Posted: 7th May 2013 16:10

Link

Could you post both the shader and dba code you're using? I'll then take a quick look at it. Sounds like a simple error somewhere.

[URL="http://nachwa.com"]العاب ماهر[/URL]
[URL="http://nachwa.com"]hguhf[/URL]

Back to top

Profile PM Website

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Passing lights to a shader? Can anyone figure out what's wrong with this code?