Would someone please Proof this - GameCreators Forum

Author

Message

alynneswoff

12

Years of Service

User Offline

Joined: 24th Sep 2013

Location:

Posted: 7th Oct 2013 19:39

Link

I have reasd over and over and over and cant find the reson why the loop at the bottom is out of place and besides that the collsion boxes dont work. we were given a little bit of code and told to elaborate.

Back to top

Profile PM

Rudolpho

20

Years of Service

User Offline

Joined: 28th Dec 2005

Location: Sweden

Posted: 7th Oct 2013 22:06

Link

What is this if I may ask?
There are a bunch of for loops around the section tagged "CONTROL INPUT" that are invalid (even the compiler picks up on this). The syntax for a for loop is:
FOR variable = <startValue> TO <stopValue> [STEP <stepValue>]

The variable must be just that, a single variable. The parts withing <> brackets are expressions, that is anything from a numeric constant to a variable to an expression like a + 12.5 / (4 * int(myVar# * 0.2)).
The part within square brackets is optional; if omitted the default step value is +1, which means that for each loop cycle the variable is increased by one. For that reason it should also be clear to see that it must be a variable - the value of a constant or an expression cannot be changed in any sensible way

There may be other errors as well, I don't have time to check that right now but I can return to look at it later if no-one else beats me to it.

"Why do programmers get Halloween and Christmas mixed up?"

+ Code Snippet

Because Oct(31) = Dec(25)

Back to top

Profile PM Email Website

Battoad

AGK Developer

19

Years of Service

User Offline

Joined: 12th Feb 2007

Location: A Dark Place

Posted: 7th Oct 2013 22:11 Edited at: 7th Oct 2013 22:18

Link

You get a loop error because of an uncompleted If ....Endif just after REM CONTROL INPUT

There is not an Endif after next t

+ Code Snippet

  if Spacekey()=1 and MyAcceleration# = 0.0 : rem Make sure I've fully landed before I can jump again
      P1Y# = P1Y# - Gravity# : rem Look below me
      position object 1, P1X#,P1Y#,P1Z# : rem Feel below me
      for t+7 = 6 to 12

         if object collision(1,t+7)>0 : rem If feel a solid object below me
            MyAcceleration# = MyPower : rem Prepare to jump!
            play sound 6
         endif
    next t

Your next piece of similar code also ends with "end" instead of endif.

+ Code Snippet

if Spacekey()=1 and MyAcceleration# = 0.0 : rem Make sure I've fully landed before I can jump again
      P1Y# = P1Y# - Gravity# : rem Look below me
      position object 1, P1X#,P1Y#,P1Z# : rem Feel below me
for a+80 = 6 to 12

         if object collision(1,a+80)>0 : rem If feel a solid object below me
            MyAcceleration# = MyPower : rem Prepare to jump!
            play sound 6
         endif
      next t

end

Back to top

Profile PM Email Website

Phaelax

DBPro Master

23

Years of Service

User Offline

Joined: 16th Apr 2003

Location: Metropia

Posted: 8th Oct 2013 05:14 Edited at: 8th Oct 2013 05:19

Link

Indent your code properly and you should find nesting errors very easily.

What is this suppose to do? Is the code missing something?

+ Code Snippet

if P1Y# = P1Y# + Gravity# :
    endif

And what is this?

+ Code Snippet

for t+7 = 6 to 12

That's an invalid statement and you've done it multiple times. Oh I just noticed Rudolpho pointed this one out.

This code will now compile, assuming the corrections I made are what you originally intended. I had to change your variable Step s Hit to StepHit because the forum was flagging it as a bad word.

rem Steps
for t = 0 to 5
    make object box t+7,50,10,50
    position object t+7,0,5+(t*20),100+(t*100)
    color object t+7,rgb(100,200,100)
    make object collision box t+7,-25,-5,-25,25,5,25,0
next t

rem platforms--------------------------------------------------------------------------------------------------------------------------------
for p = 0 to 7
    make object box p+102,50,10,50
    position object p+102,100,10+(p*20),-100+(p*100)
    color object p+102,rgb(0,0,100)
    make object collision box p+102,-25,-5,-25,25,5,25,0
    set object collision on p+102
next p

for a = 0 to 5
    make object box a+80,50,10,50
    position object a+80,200,5+(a*20),100+(a*100)
    color object a+80,rgb(100,0,0)
    make object collision box a+80,-25,-5,-25,25,5,25,0
next a

rem Fruits
NumberOfFruits = 20
FruitColor = 0

for t = 1 to NumberOfFruits
    make object sphere t + NumberOfFruits ,50
    texture object t + NumberOfFruits ,120
    position object t + NumberOfFruits ,Rnd(1900)-950,30,Rnd(1900)-950
    make object collision box t + NumberOfFruits ,-25,-25,-25,25,25,25,0
next t

rem Super Fruit
make object sphere 100,100
texture object 100,100
position object 100 ,0,180,725
make object collision box 100,-50,-50,-50,50,50,50,0

REM LOAD MODELS
REM SET COLLISIONS
REM SET CAMERA
REM SOUND EFFECTS
play sound 3
REM SPECIAL EFFECTS
REM REFRESH SCREEN
sync

REM *** MAIN SECTION LOOP
do
    if scancode()=0 then exit
loop

do
    REM SPECIAL EFFECTS
    REM OBJECT ORIENTATIONS
    P1X# = object position X(1)
    P1Y# = object position Y(1)
    P1Z# = object position Z(1)
    A1X = object angle X(1)
    A1Y = object angle Y(1)
    A1Z = object angle Z(1)
    
    REM CAMERA ORIENTATIONS
    cpX# = camera position X()
    cpY# = camera position Y()
    cpZ# = camera position Z()
    caX# = camera angle X()
    caY# = camera angle Y()
    caZ# = camera angle Z()
    
    REM LIVE SCREEN DISPLAY
    ink rgb(255,255,255),0 : set text size 16 : set text to bold : set text transparent
    center text 320,420,"USE ARROW KEYS TO MOVE   |   PRESS SPACE BAR TO JUMP"
    center text 320,440,"PRESS 'Q' TO QUIT"
    set cursor 0,0
    print "Seconds Left: ";(MyTimer/60)+1
    Rem at 60 frames a second, every timer countdown is 1/60th of a second,
    Rem so this will display the time left as whole seconds
    set cursor 0,20
    print "SCORE: ";MyScore

REM CONTROL INPUT
    if Spacekey()=1 and MyAcceleration# = 0.0
        P1Y# = P1Y# - Gravity#
        position object 1, P1X#,P1Y#,P1Z#
        for t = 6 to 12 : ` FIXED
            if object collision(1,t+7) > 0
                MyAcceleration# = MyPower
                play sound 6
            endif
        next t
    endif : ` MISSING
    
    if Spacekey()=1 and MyAcceleration# = 0.0
        P1Y# = P1Y# - Gravity#
        position object 1, P1X#,P1Y#,P1Z#

for t = 6 to 12 : ` FIXED
            if object collision(1,p+102)>0
                MyAcceleration# = MyPower
                play sound 6
            endif
        next t
    endif
    
    if Spacekey()=1 and MyAcceleration# = 0.0
        P1Y# = P1Y# - Gravity#
        position object 1, P1X#,P1Y#,P1Z#
        for a = 6 to 12 : ` FIXED
            if object collision(1,a+80) > 0
                MyAcceleration# = MyPower
                play sound 6
            endif
        next t
    endif
    
    
    
        
    `--------------------------------------------------------------------------------------------------------------------------------------------------
    ` NOT NEEDED
    if P1Y# = P1Y# + Gravity# :
    endif
    
    if Upkey()=1 then move object 1,MySpeed
    if Downkey()=1 then move object 1,0-MySpeed
    if Leftkey()=1 then A1Y = wrapvalue(A1Y-(MySpeed/3))
    if Rightkey()=1 then A1Y = wrapvalue(A1Y+(MySpeed/3))

if Inkey$()="q"
        for x = 1 to 100
            if object exist(x) = 1 then delete object x
        next x
        backdrop off
        gosub EndSection
    endif
    
    
    REM TRANSFORM OBJECTS
    REM MOVE OBJECTS
    Yrotate object 1,A1Y

REM CHECK FOR COLLISION
    rem Now that I've moved, record the new position
    P1Xcol# = object position X(1)
    P1Zcol# = object position Z(1)
    
    
    Rem Arena Collision - Keep the player inside the walls
    if P1Xcol#<-975 then P1Xcol#=-975
    if P1Zcol#<-975 then P1Zcol#=-975
    if P1Xcol#>975 then P1Xcol#=975
    if P1Zcol#>975 then P1Zcol#=975

Rem Steps Collision
    StepHit = 0
    for CheckStep = 7 to 12
        if object collision(1,CheckStep)>0
            StepHit = StepHit + 1
        endif
    next t

Rem Reset Collision Positions
    if StepHit > 0
        position object 1, P1X#,P1Y#,P1Z#
    else
        position object 1, P1Xcol#,P1Y#,P1Zcol#
        P1X# = P1Xcol# : P1Z# = P1Zcol#
    endif

A1Y# = object angle Y(1)
    
    
    
    Rem Gravity Effects
    if MyAcceleration# = 0.0
        EmptySpace = 0 : ObjectsChecked = 0
        for CheckObject = 6 to 12
            if object collision(1,CheckObject) > 0
                P1Y# = P1Y# - Gravity#
                position object 1, P1X#,P1Y#,P1Z#
                if object collision(1,CheckObject) = 0
                    EmptySpace = EmptySpace + 1
                endif
                P1Y# = P1Y# + Gravity#
                position object 1, P1X#,P1Y#,P1Z#
            else
                EmptySpace = EmptySpace + 1
            endif
            ObjectsChecked = ObjectsChecked + 1
        next CheckObject
        if EmptySpace = ObjectsChecked
            MyAcceleration# = MyAcceleration# - Gravity#
        endif
    endif

if MyAcceleration# <> 0.0
        P1Y# = P1Y# + MyAcceleration#
        position object 1, P1X#,P1Y#,P1Z#
        EmptySpace = 0 : ObjectsChecked = 0
        for CheckObject = 6 to 12
            if object collision(1,CheckObject) > 0
                P1Y# = P1Y# - MyAcceleration#
                position object 1, P1X#,P1Y#,P1Z#
                MyAcceleration# = 0.0
            else
                EmptySpace = EmptySpace + 1
            endif
            ObjectsChecked = ObjectsChecked + 1
        next CheckObject
        if EmptySpace = ObjectsChecked
            MyAcceleration# = MyAcceleration# - Gravity#
        endif
    endif

Rem Sphere Collision
    for t = 1 to NumberOfFruits
        if Object collision(1,t + NumberOfFruits) > 0
            hide object (t + NumberOfFruits)
            position object (t + NumberOfFruits),0,999,0
            play sound 4
            MyScore = MyScore + 100
        endIf
    next t
    
    If Object collision(1,100) > 0
        play sound 5
        Hide object 100
        position object 100, 0,999,0
        MyScore = MyScore + 1000
    endIf
      
      
      
    REM MOVE CAMERA
    cpZ# = Newzvalue(P1Z#,A1Y-180,200)
    cpX# = Newxvalue(P1X#,A1Y-180,200)
    if cpX#<-999 then cpX#=-999
    if cpZ#<-999 then cpZ#=-999
    if cpX#>999  then cpX#=999
    if cpZ#>999  then cpZ#=999
    Position camera cpX#,P1Y#+65,cpZ#
    Point camera P1X#,P1Y#+35,P1Z#

REM REFRESH SCREEN
    sync

rem Check Timer
    if MyTimer = 0
        for x = 1 to 200
            if object exist(x) = 1 then delete object x
        next x
        backdrop off
        gosub EndSection
    endif
    
    if MyTimer > 0 then MyTimer = MyTimer - 1
    
    ` REMOVED 'ENDIF' FROM HERE

loop

EndSection:
RETURN

+ Code Snippet

rem Steps
for t = 0 to 5
    make object box t+7,50,10,50
    position object t+7,0,5+(t*20),100+(t*100)
    color object t+7,rgb(100,200,100)
    make object collision box t+7,-25,-5,-25,25,5,25,0
next t


rem platforms--------------------------------------------------------------------------------------------------------------------------------
for p = 0 to 7
    make object box p+102,50,10,50
    position object p+102,100,10+(p*20),-100+(p*100)
    color object p+102,rgb(0,0,100)
    make object collision box p+102,-25,-5,-25,25,5,25,0
    set object collision on p+102
next p

for a = 0 to 5
    make object box a+80,50,10,50
    position object a+80,200,5+(a*20),100+(a*100)
    color object a+80,rgb(100,0,0)
    make object collision box a+80,-25,-5,-25,25,5,25,0
next a


rem Fruits
NumberOfFruits = 20
FruitColor = 0

for t = 1 to NumberOfFruits
    make object sphere t + NumberOfFruits ,50
    texture object t + NumberOfFruits ,120
    position object t + NumberOfFruits ,Rnd(1900)-950,30,Rnd(1900)-950
    make object collision box t + NumberOfFruits ,-25,-25,-25,25,25,25,0
next t


rem Super Fruit
make object sphere 100,100
texture object 100,100
position object 100 ,0,180,725
make object collision box 100,-50,-50,-50,50,50,50,0


REM LOAD MODELS
REM SET COLLISIONS
REM SET CAMERA
REM SOUND EFFECTS
play sound 3
REM SPECIAL EFFECTS
REM REFRESH SCREEN
sync

REM *** MAIN SECTION LOOP
do
    if scancode()=0 then exit
loop



do
    REM SPECIAL EFFECTS
    REM OBJECT ORIENTATIONS
    P1X# = object position X(1)
    P1Y# = object position Y(1)
    P1Z# = object position Z(1)
    A1X = object angle X(1)
    A1Y = object angle Y(1)
    A1Z = object angle Z(1)
    
    REM CAMERA ORIENTATIONS
    cpX# = camera position X()
    cpY# = camera position Y()
    cpZ# = camera position Z()
    caX# = camera angle X()
    caY# = camera angle Y()
    caZ# = camera angle Z()
    
    REM LIVE SCREEN DISPLAY
    ink rgb(255,255,255),0 : set text size 16 : set text to bold : set text transparent
    center text 320,420,"USE ARROW KEYS TO MOVE   |   PRESS SPACE BAR TO JUMP"
    center text 320,440,"PRESS 'Q' TO QUIT"
    set cursor 0,0
    print "Seconds Left: ";(MyTimer/60)+1
    Rem at 60 frames a second, every timer countdown is 1/60th of a second,
    Rem so this will display the time left as whole seconds
    set cursor 0,20
    print "SCORE: ";MyScore



    REM CONTROL INPUT
    if Spacekey()=1 and MyAcceleration# = 0.0
        P1Y# = P1Y# - Gravity#
        position object 1, P1X#,P1Y#,P1Z#
        for t = 6 to 12 : ` FIXED
            if object collision(1,t+7) > 0
                MyAcceleration# = MyPower
                play sound 6
            endif
        next t
    endif : ` MISSING
    
    if Spacekey()=1 and MyAcceleration# = 0.0
        P1Y# = P1Y# - Gravity#
        position object 1, P1X#,P1Y#,P1Z#

        for t = 6 to 12 : ` FIXED
            if object collision(1,p+102)>0
                MyAcceleration# = MyPower
                play sound 6
            endif
        next t
    endif
    
    if Spacekey()=1 and MyAcceleration# = 0.0
        P1Y# = P1Y# - Gravity#
        position object 1, P1X#,P1Y#,P1Z#
        for a = 6 to 12 : ` FIXED
            if object collision(1,a+80) > 0
                MyAcceleration# = MyPower
                play sound 6
            endif
        next t
    endif
    
    
    
        
    `--------------------------------------------------------------------------------------------------------------------------------------------------
    ` NOT NEEDED
    if P1Y# = P1Y# + Gravity# :
    endif
    
    if Upkey()=1 then move object 1,MySpeed
    if Downkey()=1 then move object 1,0-MySpeed
    if Leftkey()=1 then A1Y = wrapvalue(A1Y-(MySpeed/3))
    if Rightkey()=1 then A1Y = wrapvalue(A1Y+(MySpeed/3))

    if Inkey$()="q"
        for x = 1 to 100
            if object exist(x) = 1 then delete object x
        next x
        backdrop off
        gosub EndSection
    endif
    
    
    REM TRANSFORM OBJECTS
    REM MOVE OBJECTS
    Yrotate object 1,A1Y


    REM CHECK FOR COLLISION
    rem Now that I've moved, record the new position
    P1Xcol# = object position X(1)
    P1Zcol# = object position Z(1)
    
    
    Rem Arena Collision - Keep the player inside the walls
    if P1Xcol#<-975 then P1Xcol#=-975
    if P1Zcol#<-975 then P1Zcol#=-975
    if P1Xcol#>975 then P1Xcol#=975
    if P1Zcol#>975 then P1Zcol#=975



    Rem Steps Collision
    StepHit = 0
    for CheckStep = 7 to 12
        if object collision(1,CheckStep)>0
            StepHit = StepHit + 1
        endif
    next t




    Rem Reset Collision Positions
    if StepHit > 0
        position object 1, P1X#,P1Y#,P1Z#
    else
        position object 1, P1Xcol#,P1Y#,P1Zcol#
        P1X# = P1Xcol# : P1Z# = P1Zcol#
    endif

    A1Y# = object angle Y(1)
    
    
    
    Rem Gravity Effects
    if MyAcceleration# = 0.0
        EmptySpace = 0 : ObjectsChecked = 0
        for CheckObject = 6 to 12
            if object collision(1,CheckObject) > 0
                P1Y# = P1Y# - Gravity#
                position object 1, P1X#,P1Y#,P1Z#
                if object collision(1,CheckObject) = 0
                    EmptySpace = EmptySpace + 1
                endif
                P1Y# = P1Y# + Gravity#
                position object 1, P1X#,P1Y#,P1Z#
            else
                EmptySpace = EmptySpace + 1
            endif
            ObjectsChecked = ObjectsChecked + 1
        next CheckObject
        if EmptySpace = ObjectsChecked
            MyAcceleration# = MyAcceleration# - Gravity#
        endif
    endif


    if MyAcceleration# <> 0.0
        P1Y# = P1Y# + MyAcceleration#
        position object 1, P1X#,P1Y#,P1Z#
        EmptySpace = 0 : ObjectsChecked = 0
        for CheckObject = 6 to 12
            if object collision(1,CheckObject) > 0
                P1Y# = P1Y# - MyAcceleration#
                position object 1, P1X#,P1Y#,P1Z#
                MyAcceleration# = 0.0
            else
                EmptySpace = EmptySpace + 1
            endif
            ObjectsChecked = ObjectsChecked + 1
        next CheckObject
        if EmptySpace = ObjectsChecked
            MyAcceleration# = MyAcceleration# - Gravity#
        endif
    endif
    

      

    Rem Sphere Collision
    for t = 1 to NumberOfFruits
        if Object collision(1,t + NumberOfFruits) > 0
            hide object (t + NumberOfFruits)
            position object (t + NumberOfFruits),0,999,0
            play sound 4
            MyScore = MyScore + 100
        endIf
    next t
    
    If Object collision(1,100) > 0
        play sound 5
        Hide object 100
        position object 100, 0,999,0
        MyScore = MyScore + 1000
    endIf
      
      
      
    REM MOVE CAMERA
    cpZ# = Newzvalue(P1Z#,A1Y-180,200)
    cpX# = Newxvalue(P1X#,A1Y-180,200)
    if cpX#<-999 then cpX#=-999
    if cpZ#<-999 then cpZ#=-999
    if cpX#>999  then cpX#=999
    if cpZ#>999  then cpZ#=999
    Position camera cpX#,P1Y#+65,cpZ#
    Point camera P1X#,P1Y#+35,P1Z#

    REM REFRESH SCREEN
    sync


    rem Check Timer
    if MyTimer = 0
        for x = 1 to 200
            if object exist(x) = 1 then delete object x
        next x
        backdrop off
        gosub EndSection
    endif
    
    if MyTimer > 0 then MyTimer = MyTimer - 1
    
    ` REMOVED 'ENDIF' FROM HERE

loop


EndSection:
RETURN

http://zimnox.com

Back to top

Profile PM Email Website

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Would someone please Proof this