Help with making a for loop for walls

Author

Message

Dark Basic Pro Enthusiast

12

Years of Service

User Offline

Joined: 8th Nov 2013

Location:

Posted: 6th Mar 2014 17:01

Link

Hey I am working on a game and making walls that are taking up too much lines of code and I need a way to make a for loop for the walls but do not know how to....Help Please?

autocam on
sync on
sync rate 30
color backdrop rgb(255,102,0)
`11111111111
make object box 45,445,220,0
position object 45,-60,0,311
color object 45,rgb(0,255,0)
texture object 45,100
rem east wall
`222222222222
make object box 46,615,220,5
position object 46,162,0,2
color object 46,rgb(0,255,0)
yrotate object 46,90
texture object 46,100
rem top wall
`33333333333333
make object box 47,445,615,5
position object 47,-60,110,0
rotate object 47,90,0,0
color object 47,rgb(0,200,0)
texture object 47,100
rem south wall
`11111111111111x
make object box 48,445,220,0
position object 48,-60,0,-308
color object 48,rgb(0,255,0)
texture object 48,100
rem west wall
`2222222222222x
make object box 49,615,220,5
position object 49,-280,0,0
color object 49,rgb(0,255,0)
yrotate object 49,90
texture object 49,100
rem floor wall
`3333333333333333x
make object box 50,445,615,5
position object 50,-60,-110,0
rotate object 50,90,0,0
color object 50,rgb(0,200,0)
texture object 50,100
rem runway
make object box 51,1380,400,0
rotate object 51,90,0,0
position object 51,406,-110,-501
rem runway
make object box 92,1380,400,0
rotate object 92,90,0,0
position object 92,406,-110,-501
REM LVL 2 WALLS
rem north wall
`111111111111111
make object box 52,445,220,0
position object 52,-60,0,311-1010
color object 52,rgb(0,255,0)
texture object 52,100
rem east wall
`2222222222222222222
make object box 53,615,220,5
position object 53,162,0,2-1010
color object 53,rgb(0,255,0)
yrotate object 53,90
texture object 53,100
rem top wall
`333333333333333333
make object box 54,445,615,5
position object 54,-60,110,-1010
rotate object 54,90,0,0
color object 54,rgb(0,200,0)
texture object 54,100
rem south wall
`111111111111111111x
make object box 55,445,220,0
position object 55,-60,0,-308-1010
color object 55,rgb(0,255,0)
texture object 55,100
rem west wall
`2222222222222x
make object box 56,615,220,5
position object 56,-280,0,-1010
color object 56,rgb(0,255,0)
yrotate object 56,90
texture object 56,100
rem floor wall
`3333333333333x
make object box 57,445,615,5
position object 57,-60,-110,-1010
rotate object 57,90,0,0
color object 57,rgb(0,200,0)
texture object 57,100
rem lvl 3
`111111111111111
make object box 58,445,220,0
position object 58,-60+935,0,311-1010
color object 58,rgb(0,255,0)
texture object 58,100
rem east wall
`2222222222222
make object box 59,615,220,5
position object 59,162+935,0,2-1010
color object 59,rgb(0,255,0)
yrotate object 59,90
texture object 59,100
rem top wall
`333333333333
make object box 60,445,615,5
position object 60,-60+935,110,-1010
rotate object 60,90,0,0
color object 60,rgb(0,200,0)
texture object 60,100
rem south wall
`111111111111111x
make object box 61,445,220,0
position object 61,-60+935,0,-308-1010
color object 61,rgb(0,255,0)
texture object 61,100
rem west wall
`222222222222222x
make object box 62,615,220,5
position object 62,-280+935,0,-1010
color object 62,rgb(0,255,0)
yrotate object 62,90
texture object 62,100
rem floor wall
`3333333333333x
make object box 63,445,615,5
position object 63,-60+935,-110,-1010
rotate object 63,90,0,0
color object 63,rgb(0,200,0)
texture object 63,100
rem lvl 4
`111111111111111111
make object box 64,445,220,0
position object 64,-60+935,0,311
color object 64,rgb(0,255,0)
texture object 64,100
rem east wall
`222222222222222
make object box 87,615,220,5
position object 87,162+935,0,2
color object 87,rgb(0,255,0)
yrotate object 87,90
texture object 87,100
rem top wall
`3333333333333333
make object box 88,445,615,5
position object 88,-60+935,110,0
rotate object 88,90,0,0
color object 88,rgb(0,200,0)
texture object 88,100
rem south wall
`11111111111111111x
make object box 89,445,220,0
position object 89,-60+935,0,-308
color object 89,rgb(0,255,0)
texture object 89,100
rem west wall
`2222222222222222x
make object box 90,615,220,5
position object 90,-280+935,0,0
color object 90,rgb(0,255,0)
yrotate object 90,90
texture object 90,100
rem floor wall
`333333333333333333x
make object box 91,445,615,5
position object 91,-60+935,-110,0
rotate object 91,90,0,0
color object 91,rgb(0,200,0)
texture object 91,100
LVL1SECTION:

cls 0 : backdrop on

make object cube 1,30
position object 1,-60,-80,100
color object 1,rgb(0,255,0)
sync
do
   P1X# = object position X(1)
   P1Y# = object position Y(1)
   P1Z# = object position Z(1)
   A1X = object angle X(1)
   A1Y = object angle Y(1)
   A1Z = object angle Z(1)
   cpX# = camera position X()
   cpY# = camera position Y()
   cpZ# = camera position Z()
   caX# = camera angle X()
   caY# = camera angle Y()
   caZ# = camera angle Z()
   cpZ# = Newzvalue(P1Z#,A1Y-180,200)
   cpX# = Newxvalue(P1X#,A1Y-180,200)
   Position camera cpX#,P1Y#+65,cpZ#
   Point camera P1X#,P1Y#+35,P1Z#
   if Upkey()=1 then move object 1,10
   if downkey()=1 then move object 1,-10
   if Leftkey()=1 then A1Y = wrapvalue(A1Y-5)
   if Rightkey()=1 then A1Y = wrapvalue(A1Y+5)
   If SHiftkey()=1 then move object up 1,10
   If controlkey()=1 then move object up 1,-10
   sync
   yrotate object 1,A1Y

+ Code Snippet

autocam on
sync on
sync rate 30
color backdrop rgb(255,102,0)
`11111111111
make object box 45,445,220,0
position object 45,-60,0,311
color object 45,rgb(0,255,0)
texture object 45,100
rem east wall
`222222222222
make object box 46,615,220,5
position object 46,162,0,2
color object 46,rgb(0,255,0)
yrotate object 46,90
texture object 46,100
rem top wall
`33333333333333
make object box 47,445,615,5
position object 47,-60,110,0
rotate object 47,90,0,0
color object 47,rgb(0,200,0)
texture object 47,100
rem south wall
`11111111111111x
make object box 48,445,220,0
position object 48,-60,0,-308
color object 48,rgb(0,255,0)
texture object 48,100
rem west wall
`2222222222222x
make object box 49,615,220,5
position object 49,-280,0,0
color object 49,rgb(0,255,0)
yrotate object 49,90
texture object 49,100
rem floor wall
`3333333333333333x
make object box 50,445,615,5
position object 50,-60,-110,0
rotate object 50,90,0,0
color object 50,rgb(0,200,0)
texture object 50,100
rem runway
make object box 51,1380,400,0
rotate object 51,90,0,0
position object 51,406,-110,-501
rem runway
make object box 92,1380,400,0
rotate object 92,90,0,0
position object 92,406,-110,-501
REM LVL 2 WALLS
rem north wall
`111111111111111
make object box 52,445,220,0
position object 52,-60,0,311-1010
color object 52,rgb(0,255,0)
texture object 52,100
rem east wall
`2222222222222222222
make object box 53,615,220,5
position object 53,162,0,2-1010
color object 53,rgb(0,255,0)
yrotate object 53,90
texture object 53,100
rem top wall
`333333333333333333
make object box 54,445,615,5
position object 54,-60,110,-1010
rotate object 54,90,0,0
color object 54,rgb(0,200,0)
texture object 54,100
rem south wall
`111111111111111111x
make object box 55,445,220,0
position object 55,-60,0,-308-1010
color object 55,rgb(0,255,0)
texture object 55,100
rem west wall
`2222222222222x
make object box 56,615,220,5
position object 56,-280,0,-1010
color object 56,rgb(0,255,0)
yrotate object 56,90
texture object 56,100
rem floor wall
`3333333333333x
make object box 57,445,615,5
position object 57,-60,-110,-1010
rotate object 57,90,0,0
color object 57,rgb(0,200,0)
texture object 57,100
rem lvl 3
`111111111111111
make object box 58,445,220,0
position object 58,-60+935,0,311-1010
color object 58,rgb(0,255,0)
texture object 58,100
rem east wall
`2222222222222
make object box 59,615,220,5
position object 59,162+935,0,2-1010
color object 59,rgb(0,255,0)
yrotate object 59,90
texture object 59,100
rem top wall
`333333333333
make object box 60,445,615,5
position object 60,-60+935,110,-1010
rotate object 60,90,0,0
color object 60,rgb(0,200,0)
texture object 60,100
rem south wall
`111111111111111x
make object box 61,445,220,0
position object 61,-60+935,0,-308-1010
color object 61,rgb(0,255,0)
texture object 61,100
rem west wall
`222222222222222x
make object box 62,615,220,5
position object 62,-280+935,0,-1010
color object 62,rgb(0,255,0)
yrotate object 62,90
texture object 62,100
rem floor wall
`3333333333333x
make object box 63,445,615,5
position object 63,-60+935,-110,-1010
rotate object 63,90,0,0
color object 63,rgb(0,200,0)
texture object 63,100
rem lvl 4
`111111111111111111
make object box 64,445,220,0
position object 64,-60+935,0,311
color object 64,rgb(0,255,0)
texture object 64,100
rem east wall
`222222222222222
make object box 87,615,220,5
position object 87,162+935,0,2
color object 87,rgb(0,255,0)
yrotate object 87,90
texture object 87,100
rem top wall
`3333333333333333
make object box 88,445,615,5
position object 88,-60+935,110,0
rotate object 88,90,0,0
color object 88,rgb(0,200,0)
texture object 88,100
rem south wall
`11111111111111111x
make object box 89,445,220,0
position object 89,-60+935,0,-308
color object 89,rgb(0,255,0)
texture object 89,100
rem west wall
`2222222222222222x
make object box 90,615,220,5
position object 90,-280+935,0,0
color object 90,rgb(0,255,0)
yrotate object 90,90
texture object 90,100
rem floor wall
`333333333333333333x
make object box 91,445,615,5
position object 91,-60+935,-110,0
rotate object 91,90,0,0
color object 91,rgb(0,200,0)
texture object 91,100
LVL1SECTION:

cls 0 : backdrop on

make object cube 1,30
position object 1,-60,-80,100
color object 1,rgb(0,255,0)
sync
do
   P1X# = object position X(1)
   P1Y# = object position Y(1)
   P1Z# = object position Z(1)
   A1X = object angle X(1)
   A1Y = object angle Y(1)
   A1Z = object angle Z(1)
   cpX# = camera position X()
   cpY# = camera position Y()
   cpZ# = camera position Z()
   caX# = camera angle X()
   caY# = camera angle Y()
   caZ# = camera angle Z()
   cpZ# = Newzvalue(P1Z#,A1Y-180,200)
   cpX# = Newxvalue(P1X#,A1Y-180,200)
   Position camera cpX#,P1Y#+65,cpZ#
   Point camera P1X#,P1Y#+35,P1Z#
   if Upkey()=1 then move object 1,10
   if downkey()=1 then move object 1,-10
   if Leftkey()=1 then A1Y = wrapvalue(A1Y-5)
   if Rightkey()=1 then A1Y = wrapvalue(A1Y+5)
   If SHiftkey()=1 then move object up 1,10
   If controlkey()=1 then move object up 1,-10
   sync
   yrotate object 1,A1Y

the loop is so you can move around and see stuff please help

Back to top

Profile PM

ShellfishGames

13

Years of Service

User Offline

Joined: 6th Feb 2013

Location:

Posted: 6th Mar 2014 18:05

Link

Well, you just have to find out what's equal for all created boxes and where exactly the differences are.
Generally you're giving each of your objects similar properties - position, rotation, color and texture. So one way to make the whole code a lot more readable would be to create a function handling the wall generation after taking the standard values as parameter, sort of like this:

+ Code Snippet

function makeWall(ID, xsize, ysize, zsize, xp, yp, zp, color)
    make object box ID, xsize, ysize, zsize
    position object ID, xp, yp, zp
    color object ID, color
    set object texture ID, 100 `as most objects get this texture, we can just assume this is the default value
endfunction

Putting this below your code you could then add the boxes like this:

+ Code Snippet

green = rgb(0,255,0)
makeWall(45, 445,220,0, -60,0,311, green)
makeWall(46, 615,220,5, 162,0,2, green)
makeWall(47, 445,615,5, -60,110,0, rgb(0,200,0))
...

instead of

+ Code Snippet

`11111111111
make object box 45,445,220,0
position object 45,-60,0,311
color object 45,rgb(0,255,0)
texture object 45,100
rem east wall
`222222222222
make object box 46,615,220,5
position object 46,162,0,2
color object 46,rgb(0,255,0)
yrotate object 46,90
texture object 46,100
rem top wall
`33333333333333
make object box 47,445,615,5
position object 47,-60,110,0
rotate object 47,90,0,0
color object 47,rgb(0,200,0)
texture object 47,100
...

Still not a for loop, but already way easier to read and work with.

Generally you're right, a for loop would be nice in this place. However, this is kind of problematic given that your boxes seem to be placed relatively arbitrarily and you can't just create a formula to calculate the size, position and color of each object based on its ID. Hence a for loop would first require an array containing the individual size, position and color data for each of your objects. This however means that you would have to start by filling an array with these values - given the scope of your project, it's probably the easiest and most efficient solution to just use the function method as demonstrated above.

For bigger projects, you would probably use an editor to place and size all the objects manually, the editor would then write the values to a file and your game would read this file (possibly using a for loop) and create the walls based on the values stored there.

Also, this is a relatively simple example of how to create a group of objects directly with a for loop, by making the parameters (in this case position and rotation) depend on the loop variable:

+ Code Snippet

sync on : sync rate 60 : sync

objects = 100
for o = 1 to objects
    t# = o*17.0
    make object cube o, 1
    position object o, 6*sin(t#), 1.2*o, 6*cos(t#)
    rotate object o, 0.7*t#, 0.5*t#, 0
next

position camera 0, 80, -50
point camera 0, 50, 0

do
    control camera using arrowkeys 0, 1.0, 1.0
    sync
loop

(the numeric values within the for loop are pretty arbitrary and merely there to make the thing look a little more interesting)

Back to top

Profile PM Email Website

Dark Basic Pro Enthusiast

12

Years of Service

User Offline

Joined: 8th Nov 2013

Location:

Posted: 7th Mar 2014 17:10

Link

Thank you this is easily understandable and this will help me in the future for making functions because I didn't understand the functions very well thank you

Back to top

Profile PM

Sorry your browser is not supported!

DarkBASIC Professional Discussion / Help with making a for loop for walls