Simple Sum - One negative, one positive

Author

Message

BatVink

Moderator

21

Years of Service

User Offline

Joined: 4th Apr 2003

Location: Gods own County, UK

Posted: 29th Mar 2016 21:12

Link

I am making a simple check to see if value a is negative while value b is positive, or vice versa. Is there any better way than this...

if (a < 0 and b > 0) or (a > 0 and b < 0)
// do something

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Quidquid latine dictum sit, altum sonatur
TutCity is being rebuilt

Back to top

Profile PM Email

Paronamixxe

AGK Bronze Backer

12

Years of Service

User Offline

Joined: 10th Feb 2012

Location: Sweden

Posted: 29th Mar 2016 21:28 Edited at: 29th Mar 2016 21:29

Link

I don't know if it's better, but maybe...

+ Code Snippet

If ( ( a / Abs ( a ) ) + ( b / Abs ( b ) ) ) = 0 Then // do something

Might be something? At the very least it only checks one equation.

cheers

Back to top

Profile PM Email

Matty H

15

Years of Service

User Offline

Joined: 7th Oct 2008

Location: England

Posted: 29th Mar 2016 21:38

Link

if you multiply a negative number with a positive number then the answer will always be negative. Two positives or two negatives multiplied are always positive .

Back to top

Profile PM Email

BatVink

Moderator

21

Years of Service

User Offline

Joined: 4th Apr 2003

Location: Gods own County, UK

Posted: 30th Mar 2016 08:31

Link

Thanks

I think Matty's solution is the most efficient, and it is one of those moments...why didn't I think of that?

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Quidquid latine dictum sit, altum sonatur
TutCity is being rebuilt

Back to top

Profile PM Email

nickele upgraded

10

Years of Service

User Offline

Joined: 20th Dec 2013

Location: Birthplace of Democracy

Posted: 30th Mar 2016 09:08

Link

Sorry for interrupting , but if we use something like:
if ((a && b) >> 31) then **do something**
wouldn't it be a little bit faster (because of the bitwise operation)?
That's because if a,b are integers, then the expression logically ANDs the two values and takes the most significant bit (shifting 31 times to right).
If a,b have different signs, the result is always 1.

Back to top

Profile PM

nickele upgraded

10

Years of Service

User Offline

Joined: 20th Dec 2013

Location: Birthplace of Democracy

Posted: 30th Mar 2016 09:11

Link

Apologies for the inaccuracy.
I meant something like:
if ((a * b) >> 31)
Apologies again.

Back to top

Profile PM

baxslash

Valued Member

Bronze Codemaster

17

Years of Service

User Offline

Joined: 26th Dec 2006

Location: Duffield

Posted: 30th Mar 2016 11:47

Link

if a*b<0 should be fast enough most of the time... unless this is being used thousands of times per loop is it worth worrying about?

Using AppGameKit V2 Tier 1

Back to top

Profile PM Email

BatVink

Moderator

21

Years of Service

User Offline

Joined: 4th Apr 2003

Location: Gods own County, UK

Posted: 30th Mar 2016 13:12

Link

Quote: "unless this is being used thousands of times per loop is it worth worrying about?"

valid point

I'm aiming at very low specced devices (think fruit-desert based devices

) and trying to keep to 60FPS as it is a reaction based app.
But I'm always keen to find efficient ways to do things.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Quidquid latine dictum sit, altum sonatur
TutCity is being rebuilt

Back to top

Profile PM Email