Need Help for SetSpritePositionByOffset

Author

Message

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 13:39

Link

Hi.

in my code when I wrote SetSpritePositionByOffset() above of the below code, my character can't move.

+ Code Snippet


        Byvelocity# = Byvelocity# + Byspeed#
	SetSpritePositionByOffset(Boss.spr,Boss.x,Byvelocity#) //Move Boss

//========================= Fit Boss Y Position
	Boss.x = GetSpriteXByOffset(Boss.spr)
	B_feetPos# = GetSpriteYByOffset(Boss.spr) + (B_Heigh#/2.0)
	if B_feetPos# >= GetSpriteY(ground[1])
		BIsGround = 1
		Byspeed# = 0
		Byvelocity# = GetSpriteY(ground[1]) - (B_Heigh#/2.0)
	else
		BIsGround = 0 
		Byspeed# = Byspeed# + grav#
	endif
//========================= END

but when I wrote SetSpritePositionByOffset() down of the below code, my character can move.

+ Code Snippet

//========================= Fit Boss Y Position
	Boss.x = GetSpriteXByOffset(Boss.spr)
	B_feetPos# = GetSpriteYByOffset(Boss.spr) + (B_Heigh#/2.0)
	if B_feetPos# >= GetSpriteY(ground[1])
		BIsGround = 1
		Byspeed# = 0
		Byvelocity# = GetSpriteY(ground[1]) - (B_Heigh#/2.0)
	else
		BIsGround = 0 
		Byspeed# = Byspeed# + grav#
	endif

        Byvelocity# = Byvelocity# + Byspeed#
	SetSpritePositionByOffset(Boss.spr,Boss.x,Byvelocity#) //Move Boss
//========================= END

anyone know why do this happen?

Thanks.

Back to top

Profile PM

BatVink

Moderator

21

Years of Service

User Offline

Joined: 4th Apr 2003

Location: Gods own County, UK

Posted: 12th Jul 2016 13:45

Link

I'm guessing this is in a function and Byvelocity# or BySpeed# or both are local variables, reset to 0 each time.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Quidquid latine dictum sit, altum sonatur
TutCity is being rebuilt

Back to top

Profile PM Email

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 13:50 Edited at: 12th Jul 2016 14:10

Link

Quote: "I'm guessing this is in a function and Byvelocity# or BySpeed# or both are local variables, reset to 0 each time."

Thanks for reply.

Byvelocity# and BySpeed# are global variables. and at the first they values are :

global Byspeed# = 0.0
global Byvelocity# = 83.5

I define these variables outside of do -- loop. but for test I set values to 0 in do--loop for each time.

Back to top

Profile PM

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 18:43

Link

any idea?

Back to top

Profile PM

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 12th Jul 2016 18:50

Link

i am confused why u don't add this to the x,y value in your struct,
you are using Boss.x but not Boss.y, looks odd.
SetSpritePositionByOffset(Boss.spr,Boss.x,Byvelocity#) //Move Boss

AGK (Steam) V2.0.19 : Windows 10 Pro 64 Bit : AMD (16.3.2) Radeon R7 265 : Mac mini OS X 10.10 (Yosemite)

Back to top

Profile PM Email

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 18:59 Edited at: 12th Jul 2016 19:01

Link

already I find this code for move sprite without physics.

this complete code is here:

+ Code Snippet


global Bxspeed# = 0.3
global Byspeed# = 0.0
global Byvelocity# = 83.5
global B_Heigh#
global B_feetPos#

B_Heigh# = GetSpriteHeight(Boss.spr)

do

//========================= Fit Boss Y Position
	Boss.x = GetSpriteXByOffset(Boss.spr)
	B_feetPos# = GetSpriteYByOffset(Boss.spr) + (B_Heigh#/2.0)
	if B_feetPos# >= GetSpriteY(ground[1])
		BIsGround = 1
		Byspeed# = 0
		Byvelocity# = GetSpriteY(ground[1]) - (B_Heigh#/2.0)
	else
		BIsGround = 0
		Byspeed# = Byspeed# + grav#
	endif
//========================= END

Byvelocity# = Byvelocity# + Byspeed#
SetSpritePositionByOffset(Boss.spr,Boss.x,Byvelocity#) //Move Boss

  sync()
  
loop

do you have better idea?

I define all variables as global but seem working as local.

Back to top

Profile PM

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 19:58 Edited at: 12th Jul 2016 20:36

Link

mycharacter position is correct before comment below code, but it can't move.

+ Code Snippet

	Boss.x = GetSpriteXByOffset(Boss.spr)
	B_feetPos# = GetSpriteYByOffset(Boss.spr) + (B_Heigh#/2.0)
	if B_feetPos# >= GetSpriteY(ground[1])
		BIsGround = 1
		Byspeed# = 0
		Byvelocity# = GetSpriteY(ground[1]) - (B_Heigh#/2.0)
	else
		BIsGround = 0
		Byspeed# = Byspeed# + grav#
	endif

like this picture :

but when I comment above code character poistion is not correct, but it can move.

like this picture :

above code work very well for Player and Enemy but won't work for Buss.but I don't know what happened.

Back to top

Profile PM

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 12th Jul 2016 21:00

Link

try at top #option_explicit
cheack values with print(Byvelocity#) or put them in debugger.
you can also use print("i am here") and print("now here") in your if then condition.

AGK (Steam) V2.0.19 : Windows 10 Pro 64 Bit : AMD (16.3.2) Radeon R7 265 : Mac mini OS X 10.10 (Yosemite)

Back to top

Profile PM Email

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 21:08

Link

Quote: "try at top #option_explicit"

what is this command?

Quote: "cheack values with print(Byvelocity#) or put them in debugger.
you can also use print("i am here") and print("now here") in your if then condition."

already I print all variable and check them.Byvelocity# work correctly but Boss.x won't change when I try to Print it. I tried everything I could think of.

Back to top

Profile PM

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 12th Jul 2016 21:21 Edited at: 12th Jul 2016 21:27

Link

is your Boss.x as float in type?
now saw where you change it.
#option_explicit prevent unwanted auto var declaration at any place

your code show only
Boss.x = GetSpriteXByOffset(
SetSpritePositionByOffset(,Boss.x,)
that is for me 1=1

AGK (Steam) V2.0.19 : Windows 10 Pro 64 Bit : AMD (16.3.2) Radeon R7 265 : Mac mini OS X 10.10 (Yosemite)

Back to top

Profile PM Email

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 21:30 Edited at: 12th Jul 2016 21:46

Link

Quote: "is your Boss.x as float in type?"

yes it is float in type.

I think Problem is relate to below code and you right that 1=1 :

+ Code Snippet

	Boss.x = GetSpriteXByOffset(Boss.spr)
	SetSpritePositionByOffset(Boss.spr,Boss.x,Byvelocity#)

Thanks Markus.

if there is any Problem I ask here.

Back to top

Profile PM

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 22:03 Edited at: 12th Jul 2016 22:08

Link

use above post code, work correctly for Player and Enemy but when I remove this line GetSpriteXByOffset(Boss.spr), Boss character can be move to direction but make change Boss.x position to 0. while i set Boss.x Position to 80 in CreateBoss() Command.

CreateBoss() :

+ Code Snippet

Function CreateBoss()
	//Load Images
	SetFolder("\media\images\boss")
	for a = 1 to 4
		BImageName$ = "anim" + str(a) + ".png"
		if GetImageExists(BossImg[a]) = 0 then BossImg[a] = LoadImage(BImageName$)		
	next a
	//Create Sprite
	if GetSpriteExists(EmptySpr) = 1
		if GetSpriteExists(Boss.spr) = 0 
			Boss.spr = CloneSprite(EmptySpr)
			SetSPriteVisible(Boss.spr,1)
			SetSpriteSize(Boss.spr,11.71875,-1)
			SetSpriteOffset(Boss.spr,GetSpriteWidth(Boss.spr)/2,GetSpriteHeight(Boss.spr)/2)
			SetSpritePositionByOffset(Boss.spr,80,72.5)
			SetSpriteImage(Boss.spr,BossImg[1])
			SetSpriteAnimation(Boss.spr,150,200,6)
			PlaySprite(Boss.spr,10,1,1,6)
	endif
		endif
EndFunction

Back to top

Profile PM

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 12th Jul 2016 22:05 Edited at: 12th Jul 2016 22:26

Link

I fix it with with wrote below line code above to Fit Boss Y Position.

+ Code Snippet

Boss.x = GetSpriteXByOffset(Boss.spr)

I'd be happy if there is not a new problem.

Back to top

Profile PM

Markus

Valued Member

20

Years of Service

User Offline

Joined: 10th Apr 2004

Location: Germany

Posted: 12th Jul 2016 22:47 Edited at: 12th Jul 2016 22:50

Link

its maybe better if u remove this x,y in boss type because u have this position in the sprite.
or make and use a
function setbossxy(ref boss as tboss)
SetSpritePositionByOffset(boss.spr,boss.x,boss.y)

function getbossxy(ref boss as tboss)
boss.x=...
boss.y=...

AGK (Steam) V2.0.20 : Windows 10 Pro 64 Bit : AMD (16.3.2) Radeon R7 265 : Mac mini OS X 10.10 (Yosemite)

Back to top

Profile PM Email

Behdadsoft

15

Years of Service

User Offline

Joined: 7th Apr 2009

Location: Tehran-Iran

Posted: 13th Jul 2016 06:23

Link

Thanks Markus for your help.

if there is any problem I ask here.

Back to top

Profile PM

Sorry your browser is not supported!

AppGameKit Classic Chat / Need Help for SetSpritePositionByOffset