Trying to make a clicker game, the game slows down severly (i am talking like 8-10 FPS) slow when the numbers get even as high as 1000

Author

Message

Thugnificent

7

Years of Service

User Offline

Joined: 16th Aug 2016

Location:

Posted: 17th Aug 2016 13:03 Edited at: 17th Aug 2016 13:10

Link

Hey guys, i am totally new to game making. I've been trying to make a game clicker one. So far i have the basics down and have prototype programmed the basics.

THe problem i am facing is as the numbers get a bit higher the FPS drops to a crawl. I think i am programming way too inefficiently. Is this an engine limitation and perhaps should i pick another language to code in altogether? Or is there any magical option i am missing in AppGameKit?

I am clicking on the main button and the counter increases by 1. I can litereally see a 10FPS drop when i get to 50 or higher count. This keeps on happening until the total FPS are dropeed down to below 10 FPS. THe CPU consumption of the application is also shooting through the roof.

My code can be seen below, i would highly appreciate any help.

// Project: Clicker 
// Created: 2016-08-16

// show all errors
SetErrorMode(2)

// set window properties
SetWindowTitle( "Clicker" )
SetWindowSize( 1024, 768, 0 )

// set display properties
SetVirtualResolution( 1024, 768 )
SetOrientationAllowed( 1, 1, 1, 1 )
setvsync(0)

games = 1
clickdamage = 1
autodamage   = 0
clickupgrades = 0
clickupgradecost = 20

autoclickupgrades = 0
autoclickupgradecost = 50

startTime as float
startTime = timer()

clickbtn = createsprite(loadimage("bluerec.png"))
setspritesize(clickbtn, 100, 30)
setspriteposition(clickbtn, 50, 200)

do
    gosub clicked
    gosub upgradeclick
    gosub autoclicker1
   
		 
		if Timer() > startTime + 1
        games = games + autodamage
        ResetTimer()
		endif
	    
	print("Total games " + str(games))
    print("Total click damage " + str(clickdamage))
    print("Total autodamage " + str(autodamage))
    print("Total autoclickupgradecost " + str(autoclickupgradecost))
    print("Total autoclick upgrades " + str(autoclickupgrades))
    print(screenFPS())
    
    Sync()
loop

clicked:
	if getpointerpressed() = 0
		if getspritehittest(clickbtn, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
		games = games + clickdamage
		endif
		endif
	Return

upgradeclick:
		if games >= 5
			clkupgrdbtn = createsprite(loadimage("redrec.png"))
			setspritesize(clkupgrdbtn, 100, 30)
			setspriteposition(clkupgrdbtn, 50, 300)
			if getpointerpressed() = 0
				if getspritehittest(clkupgrdbtn, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
					if games >= clickupgradecost
						games = games - clickupgradecost
						clickupgradecost = (clickupgradecost + clickupgrades) * 1.15
						clickdamage = clickdamage + 1
						clickupgrades = clickupgrades + 1
					endif
				endif
			endif
		endif
Return

autoclicker1:
	if games >= 50
		autodmg = createsprite(loadimage("yellowrec.png"))
		setspritesize(autodmg, 100, 30)
		setspriteposition(autodmg, 50, 400)
	
	if getpointerpressed() = 0
		if getspritehittest(autodmg, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
			if games >= autoclickupgradecost	
			games = games - autoclickupgradecost
			autoclickupgradecost = (autoclickupgrades + autoclickupgradecost) * 1.15	
			autoclickupgrades = autoclickupgrades + 1
			autodamage = autodamage + 1
			
			
		endif
		endif
		endif
		endif
	Return
	
Return

+ Code Snippet

// Project: Clicker 
// Created: 2016-08-16

// show all errors
SetErrorMode(2)

// set window properties
SetWindowTitle( "Clicker" )
SetWindowSize( 1024, 768, 0 )

// set display properties
SetVirtualResolution( 1024, 768 )
SetOrientationAllowed( 1, 1, 1, 1 )
setvsync(0)

games = 1
clickdamage = 1
autodamage   = 0
clickupgrades = 0
clickupgradecost = 20

autoclickupgrades = 0
autoclickupgradecost = 50

startTime as float
startTime = timer()


clickbtn = createsprite(loadimage("bluerec.png"))
setspritesize(clickbtn, 100, 30)
setspriteposition(clickbtn, 50, 200)



do
    gosub clicked
    gosub upgradeclick
    gosub autoclicker1
   
		 
		if Timer() > startTime + 1
        games = games + autodamage
        ResetTimer()
		endif
	    
	print("Total games " + str(games))
    print("Total click damage " + str(clickdamage))
    print("Total autodamage " + str(autodamage))
    print("Total autoclickupgradecost " + str(autoclickupgradecost))
    print("Total autoclick upgrades " + str(autoclickupgrades))
    print(screenFPS())
    
    Sync()
loop

clicked:
	if getpointerpressed() = 0
		if getspritehittest(clickbtn, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
		games = games + clickdamage
		endif
		endif
	Return

upgradeclick:
		if games >= 5
			clkupgrdbtn = createsprite(loadimage("redrec.png"))
			setspritesize(clkupgrdbtn, 100, 30)
			setspriteposition(clkupgrdbtn, 50, 300)
			if getpointerpressed() = 0
				if getspritehittest(clkupgrdbtn, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
					if games >= clickupgradecost
						games = games - clickupgradecost
						clickupgradecost = (clickupgradecost + clickupgrades) * 1.15
						clickdamage = clickdamage + 1
						clickupgrades = clickupgrades + 1
					endif
				endif
			endif
		endif
Return

autoclicker1:
	if games >= 50
		autodmg = createsprite(loadimage("yellowrec.png"))
		setspritesize(autodmg, 100, 30)
		setspriteposition(autodmg, 50, 400)
	
	if getpointerpressed() = 0
		if getspritehittest(autodmg, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
			if games >= autoclickupgradecost	
			games = games - autoclickupgradecost
			autoclickupgradecost = (autoclickupgrades + autoclickupgradecost) * 1.15	
			autoclickupgrades = autoclickupgrades + 1
			autodamage = autodamage + 1
			
			
		endif
		endif
		endif
		endif
	Return
	
Return

Back to top

Profile PM

Thugnificent

7

Years of Service

User Offline

Joined: 16th Aug 2016

Location:

Posted: 17th Aug 2016 13:26 Edited at: 17th Aug 2016 14:10

Link

Ok did some google'ing around. Seems i have put the load images in the do loop and this sort of makes a memory leak.

Commenting out everything except the counter didn't make the FPS crawl after 50 clicks.

I think i have to load the sprites out of the do loop, anyone know an idea to load one sprite after a variable is at a certain number or above?

+ Code Snippet

if games >= 5
            clkupgrdbtn = createsprite(loadimage("redrec.png"))
            setspritesize(clkupgrdbtn, 100, 30)
            setspriteposition(clkupgrdbtn, 50, 300)

Can the above code be done without puttig it in the main Do Loop?

EDIT: Ok been messing around with the code. Had to put it inside the do loop, or perhaps a function. Seems like putting just the foo = 0 and foo = 1 made the do loop stop loading the sprites in every cycle. THis is pretty awesome man and very smart. Thanks!!!!!

Back to top

Profile PM

PSY

Developer

7

Years of Service

User Offline

Joined: 3rd Jul 2016

Location: Laniakea Supercluster

Posted: 17th Aug 2016 13:33 Edited at: 17th Aug 2016 13:37

Link

you're right,

the lag is caused by the sprites being created over and over again in the main loop as soon as 'games' reaches the threshhold of 50.

+ Code Snippet

if games >= 5 and foo=0
            foo=1
            clkupgrdbtn = createsprite(loadimage("redrec.png"))
            setspritesize(clkupgrdbtn, 100, 30)
            setspriteposition(clkupgrdbtn, 50, 300)

Also, you may want to get rid of those gosubs and replace them with functions.
Rule #1: Gosub = Gosuck

Back to top

Profile PM Website

Thugnificent

7

Years of Service

User Offline

Joined: 16th Aug 2016

Location:

Posted: 17th Aug 2016 14:07

Link

Thank you so much Psy. I am just starting out in programming and i really really appreciate you guys' help. You guys are pretty awesome.

Back to program, i put the above code outside the Do Loop and it doesn't work. The sprite does not appear.

Also what is foo?

Secondly how can i use functions in this language? just simply define functions as

+ Code Snippet

function functionname ()
        function text here
endfunction

and to call the function is it same as other languages.

+ Code Snippet

functionname()

Back to top

Profile PM

PSY

Developer

7

Years of Service

User Offline

Joined: 3rd Jul 2016

Location: Laniakea Supercluster

Posted: 17th Aug 2016 14:29 Edited at: 17th Aug 2016 14:38

Link

foo is just a variable holding a value which is set to 1 once a condition is reached.

when the sprite is created for the first time, foo is set to 1 to ensure the sprite will not be created again.

If you are using the same variable in multiple functions, you either have to declare the variable as global or pass it to a function with functionname(variable1, variable2...)

I improved the code, should work now:

// Project: Clicker 
// Created: 2016-08-16
 
// show all errors
SetErrorMode(2)
 
// set window properties
SetWindowTitle( "Clicker" )
SetWindowSize( 1024, 768, 0 )
 
// set display properties
SetVirtualResolution( 1024, 768 )
SetOrientationAllowed( 1, 1, 1, 1 )
setvsync(0)
 
global clickbtn, clickdamage, games, autodamage, clickupgrades, clickupgradecose, autoclickupgrades, autoclickupgradecost, foo1, foo2, clkupgrdbtn, autodmg

foo1 = 0
foo2 = 0
games = 1
clickdamage = 1
autodamage   = 0
clickupgrades = 0
clickupgradecost = 20
 
autoclickupgrades = 0
autoclickupgradecost = 50
 
startTime as float
startTime = timer()
 
 
clickbtn = createsprite(loadimage("bluerec.png"))
setspritesize(clickbtn, 100, 30)
setspriteposition(clickbtn, 50, 200)
 
 
 
do
    clicked()
    upgradeclick()
    autoclicker1()
       
          
    if Timer() > startTime + 1
		games = games + autodamage
		startTime = timer()
	endif
         
    print("Total games " + str(games))
    print("Total click damage " + str(clickdamage))
    print("Total autodamage " + str(autodamage))
    print("Total autoclickupgradecost " + str(autoclickupgradecost))
    print("Total autoclick upgrades " + str(autoclickupgrades))
    print(screenFPS())
     
    Sync()
loop
 
 
 
 
 
function clicked()
    if getpointerpressed() = 0
        if getspritehittest(clickbtn, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
			games = games + clickdamage
        endif
	endif
endfunction
    
 
function upgradeclick()
if games >= 5
	if foo1=0
		foo1=1
		clkupgrdbtn = createsprite(loadimage("redrec.png"))
		setspritesize(clkupgrdbtn, 100, 30)
		setspriteposition(clkupgrdbtn, 50, 300)
	endif	
    if getpointerpressed() = 0
		if getspritehittest(clkupgrdbtn, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
			if games >= clickupgradecost
				games = games - clickupgradecost
				clickupgradecost = (clickupgradecost + clickupgrades) * 1.15
                clickdamage = clickdamage + 1
                clickupgrades = clickupgrades + 1
			endif
		endif
	endif
endif
endfunction

function autoclicker1()
    if games >= 50
		if foo2=0
			foo2=1
			autodmg = createsprite(loadimage("yellowrec.png"))
			setspritesize(autodmg, 100, 30)
			setspriteposition(autodmg, 50, 400)
		endif	
		if getpointerpressed() = 0
			if getspritehittest(autodmg, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
				if games >= autoclickupgradecost 
					games = games - autoclickupgradecost
					autoclickupgradecost = (autoclickupgrades + autoclickupgradecost) * 1.15    
					autoclickupgrades = autoclickupgrades + 1
					autodamage = autodamage + 1
				endif
			endif
		endif
	endif
endfunction

+ Code Snippet

// Project: Clicker 
// Created: 2016-08-16
 
// show all errors
SetErrorMode(2)
 
// set window properties
SetWindowTitle( "Clicker" )
SetWindowSize( 1024, 768, 0 )
 
// set display properties
SetVirtualResolution( 1024, 768 )
SetOrientationAllowed( 1, 1, 1, 1 )
setvsync(0)
 
global clickbtn, clickdamage, games, autodamage, clickupgrades, clickupgradecose, autoclickupgrades, autoclickupgradecost, foo1, foo2, clkupgrdbtn, autodmg

foo1 = 0
foo2 = 0
games = 1
clickdamage = 1
autodamage   = 0
clickupgrades = 0
clickupgradecost = 20
 
autoclickupgrades = 0
autoclickupgradecost = 50
 
startTime as float
startTime = timer()
 
 
clickbtn = createsprite(loadimage("bluerec.png"))
setspritesize(clickbtn, 100, 30)
setspriteposition(clickbtn, 50, 200)
 
 
 
do
    clicked()
    upgradeclick()
    autoclicker1()
       
          
    if Timer() > startTime + 1
		games = games + autodamage
		startTime = timer()
	endif
         
    print("Total games " + str(games))
    print("Total click damage " + str(clickdamage))
    print("Total autodamage " + str(autodamage))
    print("Total autoclickupgradecost " + str(autoclickupgradecost))
    print("Total autoclick upgrades " + str(autoclickupgrades))
    print(screenFPS())
     
    Sync()
loop
 
 
 
 
 
function clicked()
    if getpointerpressed() = 0
        if getspritehittest(clickbtn, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
			games = games + clickdamage
        endif
	endif
endfunction
    
 
function upgradeclick()
if games >= 5
	if foo1=0
		foo1=1
		clkupgrdbtn = createsprite(loadimage("redrec.png"))
		setspritesize(clkupgrdbtn, 100, 30)
		setspriteposition(clkupgrdbtn, 50, 300)
	endif	
    if getpointerpressed() = 0
		if getspritehittest(clkupgrdbtn, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
			if games >= clickupgradecost
				games = games - clickupgradecost
				clickupgradecost = (clickupgradecost + clickupgrades) * 1.15
                clickdamage = clickdamage + 1
                clickupgrades = clickupgrades + 1
			endif
		endif
	endif
endif
endfunction

 
function autoclicker1()
    if games >= 50
		if foo2=0
			foo2=1
			autodmg = createsprite(loadimage("yellowrec.png"))
			setspritesize(autodmg, 100, 30)
			setspriteposition(autodmg, 50, 400)
		endif	
		if getpointerpressed() = 0
			if getspritehittest(autodmg, getpointerx(), getpointery()) = 1 and GetRawMouseLeftPressed() = 1
				if games >= autoclickupgradecost 
					games = games - autoclickupgradecost
					autoclickupgradecost = (autoclickupgrades + autoclickupgradecost) * 1.15    
					autoclickupgrades = autoclickupgrades + 1
					autodamage = autodamage + 1
				endif
			endif
		endif
	endif
endfunction

(edit) fixed a bug

Back to top

Profile PM Website

Thugnificent

7

Years of Service

User Offline

Joined: 16th Aug 2016

Location:

Posted: 17th Aug 2016 14:46

Link

OMG Thank you so much!!!!!!! You're the best!

Awesome, it works like a charm and no slow downs. I got to learn a lot from you bro, much appreciated!

Back to top

Profile PM

PSY

Developer

7

Years of Service

User Offline

Joined: 3rd Jul 2016

Location: Laniakea Supercluster

Posted: 17th Aug 2016 14:47 Edited at: 17th Aug 2016 15:14

Link

Don't mention it, you're welcome

(edit)

+ Code Snippet

if getpointerpressed() = 0

is not necessary, as you check for the mouse click anyway

// Project: Clicker 
// Created: 2016-08-16
 
// show all errors
SetErrorMode(2)
 
// set window properties
SetWindowTitle( "Clicker" )
SetWindowSize( 1024, 768, 0 )
 
// set display properties
SetVirtualResolution( 1024, 768 )
SetOrientationAllowed( 1, 1, 1, 1 )
setvsync(0)
 
global clickbtn, clickdamage, games, autodamage, clickupgrades, clickupgradecose, autoclickupgrades, autoclickupgradecost, foo1, foo2, clkupgrdbtn, autodmg

foo1 = 0
foo2 = 0
games = 1
clickdamage = 1
autodamage   = 0
clickupgrades = 0
clickupgradecost = 20
 
autoclickupgrades = 0
autoclickupgradecost = 50
 
startTime as float
startTime = timer()
 
 
clickbtn = createsprite(loadimage("bluerec.png"))
setspritesize(clickbtn, 100, 30)
setspriteposition(clickbtn, 50, 200)
 
 
 
do
    clicked()
    upgradeclick()
    autoclicker1()
       
          
    if Timer() > startTime + 1
		games = games + autodamage
		startTime = timer()
	endif
         
    print("Total games " + str(games))
    print("Total click damage " + str(clickdamage))
    print("Total autodamage " + str(autodamage))
    print("Total autoclickupgradecost " + str(autoclickupgradecost))
    print("Total autoclick upgrades " + str(autoclickupgrades))
    print(screenFPS())
     
    Sync()
loop

function clicked()
	if GetRawMouseLeftPressed() = 1 and getspritehittest(clickbtn, getpointerx(), getpointery()) = 1
		games = games + clickdamage
	endif
endfunction
    
 
function upgradeclick()
if games >= 5
	if foo1=0
		foo1=1
		clkupgrdbtn = createsprite(loadimage("redrec.png"))
		setspritesize(clkupgrdbtn, 100, 30)
		setspriteposition(clkupgrdbtn, 50, 300)
	endif	
	if GetRawMouseLeftPressed() = 1 and getspritehittest(clkupgrdbtn, getpointerx(), getpointery()) = 1
		if games >= clickupgradecost
			games = games - clickupgradecost
			clickupgradecost = (clickupgradecost + clickupgrades) * 1.15
			clickdamage = clickdamage + 1
            clickupgrades = clickupgrades + 1
		endif
	endif
endif
endfunction

function autoclicker1()
    if games >= 50
		if foo2=0
			foo2=1
			autodmg = createsprite(loadimage("yellowrec.png"))
			setspritesize(autodmg, 100, 30)
			setspriteposition(autodmg, 50, 400)
		endif	
		if GetRawMouseLeftPressed() = 1 and getspritehittest(autodmg, getpointerx(), getpointery()) = 1
			if games >= autoclickupgradecost 
				games = games - autoclickupgradecost
				autoclickupgradecost = (autoclickupgrades + autoclickupgradecost) * 1.15    
				autoclickupgrades = autoclickupgrades + 1
				autodamage = autodamage + 1
			endif
		endif
	endif
endfunction

+ Code Snippet

// Project: Clicker 
// Created: 2016-08-16
 
// show all errors
SetErrorMode(2)
 
// set window properties
SetWindowTitle( "Clicker" )
SetWindowSize( 1024, 768, 0 )
 
// set display properties
SetVirtualResolution( 1024, 768 )
SetOrientationAllowed( 1, 1, 1, 1 )
setvsync(0)
 
global clickbtn, clickdamage, games, autodamage, clickupgrades, clickupgradecose, autoclickupgrades, autoclickupgradecost, foo1, foo2, clkupgrdbtn, autodmg

foo1 = 0
foo2 = 0
games = 1
clickdamage = 1
autodamage   = 0
clickupgrades = 0
clickupgradecost = 20
 
autoclickupgrades = 0
autoclickupgradecost = 50
 
startTime as float
startTime = timer()
 
 
clickbtn = createsprite(loadimage("bluerec.png"))
setspritesize(clickbtn, 100, 30)
setspriteposition(clickbtn, 50, 200)
 
 
 
do
    clicked()
    upgradeclick()
    autoclicker1()
       
          
    if Timer() > startTime + 1
		games = games + autodamage
		startTime = timer()
	endif
         
    print("Total games " + str(games))
    print("Total click damage " + str(clickdamage))
    print("Total autodamage " + str(autodamage))
    print("Total autoclickupgradecost " + str(autoclickupgradecost))
    print("Total autoclick upgrades " + str(autoclickupgrades))
    print(screenFPS())
     
    Sync()
loop
 
 
 

function clicked()
	if GetRawMouseLeftPressed() = 1 and getspritehittest(clickbtn, getpointerx(), getpointery()) = 1
		games = games + clickdamage
	endif
endfunction
    
 
function upgradeclick()
if games >= 5
	if foo1=0
		foo1=1
		clkupgrdbtn = createsprite(loadimage("redrec.png"))
		setspritesize(clkupgrdbtn, 100, 30)
		setspriteposition(clkupgrdbtn, 50, 300)
	endif	
	if GetRawMouseLeftPressed() = 1 and getspritehittest(clkupgrdbtn, getpointerx(), getpointery()) = 1
		if games >= clickupgradecost
			games = games - clickupgradecost
			clickupgradecost = (clickupgradecost + clickupgrades) * 1.15
			clickdamage = clickdamage + 1
            clickupgrades = clickupgrades + 1
		endif
	endif
endif
endfunction

 
function autoclicker1()
    if games >= 50
		if foo2=0
			foo2=1
			autodmg = createsprite(loadimage("yellowrec.png"))
			setspritesize(autodmg, 100, 30)
			setspriteposition(autodmg, 50, 400)
		endif	
		if GetRawMouseLeftPressed() = 1 and getspritehittest(autodmg, getpointerx(), getpointery()) = 1
			if games >= autoclickupgradecost 
				games = games - autoclickupgradecost
				autoclickupgradecost = (autoclickupgrades + autoclickupgradecost) * 1.15    
				autoclickupgrades = autoclickupgrades + 1
				autodamage = autodamage + 1
			endif
		endif
	endif
endfunction

Back to top

Profile PM Website

damothegreat

User Banned

Posted: 14th Oct 2016 17:33

Link

Hello

In your main loop - you have a gosub to autoclicker - inside this function - you have a createsprite.

"CreateSprite" in the main loop will eventually cause a hog of the PC

My best advise, is to declare all createsprites outside the main game loop

Damian

Back to top

Profile

Sorry your browser is not supported!

Newcomers AppGameKit Corner / Trying to make a clicker game, the game slows down severly (i am talking like 8-10 FPS) slow when the numbers get even as high as 1000