Best Programming Practices in AGK2

Author

Message

zxretrosoft

AGK Developer

9

Years of Service

User Offline

Joined: 10th Dec 2014

Location: Prague, Czech Republic

Posted: 26th Nov 2016 17:45 Edited at: 26th Nov 2016 18:10

Link

Hello friends,
I have a modest question

I am trying to make a shooter. But that's beside the point. I'd like to try for the best code. I would like to learn 'best practices' in AGK2.

E.g. the movement of the ship.

This is output:

And this is my source code. (I do not believe this is the right way in AGK2, it should go better...) Please, could be anyone advise me a better solution?

// show all errors
SetErrorMode(2)

// set window properties
SetWindowTitle(" Area 51 ")
SetWindowSize(1024,768,0)

// set display properties
SetVirtualResolution(1024,768)
SetDisplayAspect(4.0/3.0)
SetOrientationAllowed(0,0,1,1)
SetWindowAllowResize(1)
SetSyncRate(60,0)
SetScissor(0,0,0,0)

// deklarace
Global x#,y#,speed#
Global s1,s2,h1,h2

h1=1:h2=10
speed#=3.1
x#=50:y#=300

// ship
For i=1 To 17
	CreateSprite(i,LoadImage("ship"+Str(i)+".png"))
	SetSpriteVisible(i,0)
	SetSpriteDepth(i,20)
Next i
SetSpriteVisible(1,1)

// main loop
Do

// pohyb X
	If GetRawKeyState(39) And x#<900
		x#=x#+speed#
	ElseIf GetRawKeyState(37) And x#>0
		x#=x#-speed#
	EndIf
	
	// pohyb Y
	If GetRawKeyState(40) And y#<665
		y#=y#+speed#
		Inc s1
	ElseIf GetRawKeyState(38) And y#>10
		y#=y#-speed#
		Inc s2
	Else
		s1=0:s2=0
		If h1>1 Then Dec h1
		If h2>9 Then Dec h2
	EndIf
	
	// řízení naklápění lodi
	// dolů
	If s1>1
		Inc h1
		s1=0
		If h1>9 Then h1=9
		If h2>9 Then Dec h2
	EndIf

If h1>1
		For i=2 To 9
			SetSpriteVisible(i,0)
		Next i
		SetSpriteVisible(h1,1)
	EndIf

// nahoru
	If s2>1 And h2<17
		Inc h2
		s2=0
	EndIf

If h2>9
		For i=10 To 17
			SetSpriteVisible(i,0)
		Next i
		SetSpriteVisible(h2,1)
	EndIf

// ship
	For i=1 To 17
		SetSpritePosition(i,x#,y#)
	Next i

Print( ScreenFPS() )
	Sync()
Loop

+ Code Snippet

// show all errors
SetErrorMode(2)

// set window properties
SetWindowTitle(" Area 51 ")
SetWindowSize(1024,768,0)

// set display properties
SetVirtualResolution(1024,768)
SetDisplayAspect(4.0/3.0)
SetOrientationAllowed(0,0,1,1)
SetWindowAllowResize(1)
SetSyncRate(60,0)
SetScissor(0,0,0,0)

// deklarace
Global x#,y#,speed#
Global s1,s2,h1,h2

h1=1:h2=10
speed#=3.1
x#=50:y#=300


// ship
For i=1 To 17
	CreateSprite(i,LoadImage("ship"+Str(i)+".png"))
	SetSpriteVisible(i,0)
	SetSpriteDepth(i,20)
Next i
SetSpriteVisible(1,1)


// main loop
Do

	// pohyb X
	If GetRawKeyState(39) And x#<900
		x#=x#+speed#
	ElseIf GetRawKeyState(37) And x#>0
		x#=x#-speed#
	EndIf
	
	// pohyb Y
	If GetRawKeyState(40) And y#<665
		y#=y#+speed#
		Inc s1
	ElseIf GetRawKeyState(38) And y#>10
		y#=y#-speed#
		Inc s2
	Else
		s1=0:s2=0
		If h1>1 Then Dec h1
		If h2>9 Then Dec h2
	EndIf
	
	// řízení naklápění lodi
	// dolů
	If s1>1
		Inc h1
		s1=0
		If h1>9 Then h1=9
		If h2>9 Then Dec h2
	EndIf

	If h1>1
		For i=2 To 9
			SetSpriteVisible(i,0)
		Next i
		SetSpriteVisible(h1,1)
	EndIf

	// nahoru
	If s2>1 And h2<17
		Inc h2
		s2=0
	EndIf

	If h2>9
		For i=10 To 17
			SetSpriteVisible(i,0)
		Next i
		SetSpriteVisible(h2,1)
	EndIf


	// ship
	For i=1 To 17
		SetSpritePosition(i,x#,y#)
	Next i


	Print( ScreenFPS() )
	Sync()
Loop

I am sorry for poor English

Back to top

Profile PM Email Website

zxretrosoft

AGK Developer

9

Years of Service

User Offline

Joined: 10th Dec 2014

Location: Prague, Czech Republic

Posted: 28th Nov 2016 10:37

Link

OK, I bought The Official App Game Kit Tutorial Guide, so I will study

I am sorry for poor English

Back to top

Profile PM Email Website

Cybermind

Valued Member

21

Years of Service

User Offline

Joined: 28th Nov 2002

Location: Denmark

Posted: 28th Nov 2016 10:38 Edited at: 28th Nov 2016 10:42

Link

Hello

Some of you comments are not in english, it makes it harder to read :-P

It seems like you don't use a timer to restrict your movement. Depending on what computer it runs on, the FPS might change and then it might change how fast or slow your ship moves.

Try changing SetSyncRate(60,0) to SetSyncRate(30,0), if that changes how fast or slow your ship moves, then you have a problem.

Here is a very small example of timer restricted movement.

EDIT: Using timer restricted movement ties how often movement can update to the internal timer instead of the framerate. The framerate can change depending on the computer, the timer can not. As long as the computer can update the frame faster than what you set the timer restriction to, it should run the same on different computers that reach this minimum.

+ Code Snippet

Do

      timer_stored = GetMilliseconds()

      If GetRawKeyState(39) and arrow_key_right_timer < timer_stored
             arrow_key_right_timer = timer_stored + 40 //find a value that suits your game
             //do move stuff
      endif

Loop

13/0

Back to top

Profile PM Website

zxretrosoft

AGK Developer

9

Years of Service

User Offline

Joined: 10th Dec 2014

Location: Prague, Czech Republic

Posted: 28th Nov 2016 11:05 Edited at: 28th Nov 2016 11:06

Link

I'm very sorry for my terrible English, I will try to improve

Yes, if I set SetSyncRate(30,0), then ship is slower (cca 50%).
Thank you very much, I try it!

I am sorry for poor English

Back to top

Profile PM Email Website

Cybermind

Valued Member

21

Years of Service

User Offline

Joined: 28th Nov 2002

Location: Denmark

Posted: 28th Nov 2016 13:24

Link

Your English is good enough to understand clearly what you are saying

No problem there

It is stuff like this -> "deklarace" and "řízení naklápění lodi" that I do not understand

13/0

Back to top

Profile PM Website

damothegreat

User Banned

Posted: 28th Nov 2016 13:29 Edited at: 28th Nov 2016 13:34

Link

Your code looks good to me.

I would in all honesty in your main DO LOOP, is have functions only in order.
i.e

setupdisplay()
setupvariables()
initialiseship()

// main loop
Do
 
     checkkeypresses()
    
     moveship()

displayship()
    Sync()
Loop

function setupdisplay()
// show all errors
SetErrorMode(2)
 
// set window properties
SetWindowTitle(" Area 51 ")
SetWindowSize(1024,768,0)
 
// set display properties
SetVirtualResolution(1024,768)
SetDisplayAspect(4.0/3.0)
SetOrientationAllowed(0,0,1,1)
SetWindowAllowResize(1)
SetSyncRate(60,0)
SetScissor(0,0,0,0)
 endfunction

function setupvariables()
// deklarace
Global x#,y#,speed#
Global s1,s2,h1,h2
 
h1=1:h2=10
speed#=3.1
x#=50:y#=300
 endfunction

function initialiseship()

// ship
For i=1 To 17
    CreateSprite(i,LoadImage("ship"+Str(i)+".png"))
    SetSpriteVisible(i,0)
    SetSpriteDepth(i,20)
Next i
SetSpriteVisible(1,1)
 
endfunction

function checkkeypresses()

// pohyb X
    If GetRawKeyState(39) And x#<900
        x#=x#+speed#
    ElseIf GetRawKeyState(37) And x#>0
        x#=x#-speed#
    EndIf
     
    // pohyb Y
    If GetRawKeyState(40) And y#<665
        y#=y#+speed#
        Inc s1
    ElseIf GetRawKeyState(38) And y#>10
        y#=y#-speed#
        Inc s2
    Else
        s1=0:s2=0
        If h1>1 Then Dec h1
        If h2>9 Then Dec h2
    EndIf
    
endfunction

function moveship()
    // řízení naklápění lodi
    // dolů
    If s1>1
        Inc h1
        s1=0
        If h1>9 Then h1=9
        If h2>9 Then Dec h2
    EndIf
 
    If h1>1
        For i=2 To 9
            SetSpriteVisible(i,0)
        Next i
        SetSpriteVisible(h1,1)
    EndIf
 
    // nahoru
    If s2>1 And h2<17
        Inc h2
        s2=0
    EndIf
 
    If h2>9
        For i=10 To 17
            SetSpriteVisible(i,0)
        Next i
        SetSpriteVisible(h2,1)
    EndIf
 
endfunction

function displayship()
    // ship
    For i=1 To 17
        SetSpritePosition(i,x#,y#)
    Next i
 
endfunction

+ Code Snippet


setupdisplay()
setupvariables()
initialiseship()


 
// main loop
Do
 
     checkkeypresses()
    
     moveship()

     displayship()
    Sync()
Loop

function setupdisplay()
// show all errors
SetErrorMode(2)
 
// set window properties
SetWindowTitle(" Area 51 ")
SetWindowSize(1024,768,0)
 
// set display properties
SetVirtualResolution(1024,768)
SetDisplayAspect(4.0/3.0)
SetOrientationAllowed(0,0,1,1)
SetWindowAllowResize(1)
SetSyncRate(60,0)
SetScissor(0,0,0,0)
 endfunction


function setupvariables()
// deklarace
Global x#,y#,speed#
Global s1,s2,h1,h2
 
h1=1:h2=10
speed#=3.1
x#=50:y#=300
 endfunction

function initialiseship()



 
// ship
For i=1 To 17
    CreateSprite(i,LoadImage("ship"+Str(i)+".png"))
    SetSpriteVisible(i,0)
    SetSpriteDepth(i,20)
Next i
SetSpriteVisible(1,1)
 
endfunction

function checkkeypresses()

    // pohyb X
    If GetRawKeyState(39) And x#<900
        x#=x#+speed#
    ElseIf GetRawKeyState(37) And x#>0
        x#=x#-speed#
    EndIf
     
    // pohyb Y
    If GetRawKeyState(40) And y#<665
        y#=y#+speed#
        Inc s1
    ElseIf GetRawKeyState(38) And y#>10
        y#=y#-speed#
        Inc s2
    Else
        s1=0:s2=0
        If h1>1 Then Dec h1
        If h2>9 Then Dec h2
    EndIf
    
endfunction

function moveship()
    // řízení naklápění lodi
    // dolů
    If s1>1
        Inc h1
        s1=0
        If h1>9 Then h1=9
        If h2>9 Then Dec h2
    EndIf
 
    If h1>1
        For i=2 To 9
            SetSpriteVisible(i,0)
        Next i
        SetSpriteVisible(h1,1)
    EndIf
 
    // nahoru
    If s2>1 And h2<17
        Inc h2
        s2=0
    EndIf
 
    If h2>9
        For i=10 To 17
            SetSpriteVisible(i,0)
        Next i
        SetSpriteVisible(h2,1)
    EndIf
 
endfunction

function displayship()
    // ship
    For i=1 To 17
        SetSpritePosition(i,x#,y#)
    Next i
 
endfunction

Something along those lines,

This to me is personal choice, much cleaner and easier to find and read code

Damo

Using Tier 1 AppGameKit V2
Started coding with AMOS
Anything is possible if put mind to it

Back to top

Profile

zxretrosoft

AGK Developer

9

Years of Service

User Offline

Joined: 10th Dec 2014

Location: Prague, Czech Republic

Posted: 29th Nov 2016 07:21