Could not add sound file - No Free ID Found

Author

Message

GH69

6

Years of Service

User Offline

Joined: 9th Nov 2018

Location:

Posted: 17th Nov 2018 15:10

Link

Hi all
I'm getting the above error in my shoot 'em up type project that I've been working on for a few day, and it's driving me to distraction.

I have a #constant, lasersnd, set up loaded with a wav file "laser.wav" from one of the example projects.

+ Code Snippet

#constant lasersnd=LoadSound("laser.wav")

This is passed to a "create bullet" function, when the fire button is pressed and a 'bullet' fired. Works great until somewhere around 220 - 260 bullets have been fired, then the game crashes with the error in the title.

+ Code Snippet

createshot(lasersnd,1,player.x,player.y-20,player.x,player.y-500,laserspd,laser,laserimg)

+ Code Snippet

function createshot(sound,p,x#,y#,dx#,dy#,spd,weapon,image)
	inc numshots
	if p=1 then inc shotsfired
	tempshot as shot
	tempshot.sp=CreateSprite(image)
	tempshot.image=image
	tempshot.x=x#
	tempshot.y=y#
	tempshot.dx=getmovex(x#,y#,dx#,dy#,spd)
	tempshot.dy=getmovey(x#,y#,dx#,dy#,spd)
	tempshot.speed=spd
	tempshot.exists=1
	tempshot.weapon=weapon
	tempshot.damage=1
	tempshot.playershot=p
	projectiles.insert(tempshot)
	if sound>0 then playsound(sound) 
endfunction

The help states that the sound instance is deleted when the sound has finished playing, so I am at a loss as to why it would appear to be running out of IDs. Should I be deleting/cleaning up sounds somewhere?
The only other sound in the game is an explosion sound, which also suffered from the same error but only once and has never done it again.

Any advice would be much appreciated.

Back to top

Profile PM

JLMoondog

Moderator

15

Years of Service

User Offline

Joined: 18th Jan 2009

Location: Paradox

Posted: 17th Nov 2018 18:42

Link

Are you only loading the sound once or do you have t inside the game loop?

Back to top

Profile PM Email Website

GH69

6

Years of Service

User Offline

Joined: 9th Nov 2018

Location:

Posted: 17th Nov 2018 20:05

Link

The sound is only loaded once to the constant outside of the main loop.

Back to top

Profile PM

JLMoondog

Moderator

15

Years of Service

User Offline

Joined: 18th Jan 2009

Location: Paradox

Posted: 17th Nov 2018 20:20

Link

Try changing it from a #constant, to a global variable.

Back to top

Profile PM Email Website

GH69

6

Years of Service

User Offline

Joined: 9th Nov 2018

Location:

Posted: 17th Nov 2018 20:45

Link

That gives me a compilation error of "Variable default value must be an integer literal or constant"

I have however just tried a different approach. I set lasersnd as an array and loaded the sound into position 1.
Just completed approx. 1500 shots fired and no crash so seems like it might be fixed. Interestingly at 1500 or so it crashed again with the same error for the 'explosion' sound I handled in the same way so I'm guessing that had just hit the mid 200s too (an appalling hit rate on my part

). I'll change that to use an array of sounds too.
Actually is a nicer approach as I can dispense with the Case statement I was going to use to play the relevant sound and just use the weapon variable passed to my function as the sound array index.

Thanks

Graham

Back to top

Profile PM

blink0k

Moderator

11

Years of Service

User Offline

Joined: 22nd Feb 2013

Location: the land of oz

Posted: 17th Nov 2018 21:32

Link

It is important to remember that AppGameKit will "paste" that value into the code when it is referenced so when compiled;

createshot(lasersnd,1,player.x,player.y-20,player.x,player.y-500,laserspd,laser,laserimg)
will look like;

createshot(LoadSound("laser.wav"),player.x,player.y-20,player.x,player.y-500,laserspd,laser,laserimg)

So every time you reference createshot() that sound will be loaded

Back to top

Profile PM

PartTimeCoder

AGK Tool Maker

9

Years of Service

User Offline

Joined: 9th Mar 2015

Location: London UK

Posted: 18th Nov 2018 09:43 Edited at: 18th Nov 2018 09:47

Link

This post has been marked by the post author as the answer.

Quote: "That gives me a compilation error of "Variable default value must be an integer literal or constant""

global variables must be defined like so

+ Code Snippet

// first, define the variable
Global lasersnd as string

// second, assign a value to the variable
lasersnd = "laser.wav"

//or you can use ":" to do all this on one line 
Global lasersnd as string : lasersnd = "laser.wav"

but as mentioned above you are loading the sound each time you fire a shot, this will consume all available id's and memory.... eventually!

this is how you should use the variable

+ Code Snippet


// define the variable as integer
Global lasersnd as integer

// load the sound into the var
lasersnd = LoadSound("laser.wav")

now in your trigger function you use the variable of the already loaded sound over and over without any problems.

Back to top

Profile PM

GH69

6

Years of Service

User Offline

Joined: 9th Nov 2018

Location:

Posted: 18th Nov 2018 16:16 Edited at: 18th Nov 2018 16:16

Link

Cheers for the help guys.

So by swapping to using an array of weapon sounds I inadvertently hit the right way of defining my variable.

Thanks again.

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers AppGameKit Corner / [SOLVED] Could not add sound file - No Free ID Found