Function problem - Have to return a value...

Author

Message

Hayer

20

Years of Service

User Offline

Joined: 4th Nov 2005

Location: Norway

Posted: 18th Aug 2007 11:39

Link

Hi!
This is my round function

+ Code Snippet

function Round(RoundX as float)
y as float
z as float
x = 45.49
y = int(x)
z = x - y
if z >= 0.5
x = ceil (x)
else
x = floor (x)
endif
endfunction

This is how i try to call it

+ Code Snippet

test as float
test = 1234.54
test = Round(test)
print test
test = 123.44
test = Round(test)
print test

But the compiler says that the function MUST return a value if used in an expression...

any help?

Spread your games!
http://forum.thegamecreators.com/?m=forum_view&t=108800&b=5

Back to top

Profile PM Email Website

paul5147

20

Years of Service

User Offline

Joined: 11th Jan 2006

Location: Hot & Sunny

Posted: 18th Aug 2007 11:58

Link

add the variable you want to return to the "endfuction" command
eg. "endfunction x" will return the value "x"

Back to top

Profile PM

Mr Kohlenstoff

20

Years of Service

User Offline

Joined: 7th Jun 2006

Location: Germany

Posted: 18th Aug 2007 13:01

Link

I'm not sure what your function is supposed to do.. but when you call it the way you do ("something = Round(test)") then the function also has to return a value of course... otherwise this function call wouldn't have any sense.
I edited your function, how it might work maybe, just try it.

I think the local x-variable should also be a float? And then it's returned... but however.

+ Code Snippet

function Round(RoundX as float)
   x as float
   y as float
   z as float
   x = 45.49
   y = int(x)
   z = x - y
   if z >= 0.5
      x = ceil (x)
   else
      x = floor (x)
   endif
endfunction x

Visit the DBPro - Speed up your game-Thread. http://forum.thegamecreators.com/?m=forum_view&t=88661&b=1

Back to top

Profile PM Email

jason p sage

19

Years of Service

User Offline

Joined: 10th Jun 2007

Location: Ellington, CT USA

Posted: 20th Aug 2007 20:43

Link

haha - cool rounding trick there.

http://www.jasonpetersage.com/?PAGE=jpsmain&SECTION=IRONINFANTRY

Back to top

Profile PM Email Website

NA170425

User Deleted

Posted: 20th Aug 2007 22:23

Link

You guys are making it too hard.

+ Code Snippet

function Round(RoundX as float)

  RoundX = int(RoundX + 0.5)

endfunction RoundX

Quote: "Quote: "he probably thought you meant you thought"
NOO!! MY BRAIN IT EXPL

"

Back to top

Profile PM Email Website

IanM

Retired Moderator

23

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 21st Aug 2007 00:01

Link

Maybe - I haven't tested Mr K's function, but I know yours isn't correct. Put a negative number into your function and it won't work correctly (minus 2 becomes minus 1).

You need to do this:

+ Code Snippet

function Round(F as float)
   local I as integer
   if F < 0.0
      V = F - 0.5
   else
      V = F + 0.5
   endif
endfunction V

Note, there's an implicit INT() in there - it's not necessary to call the function itself.

Utility plugins collection and
http://www.matrix1.demon.co.uk for older plug-ins and example code

Back to top

Profile PM Email Website

Ric

21

Years of Service

User Offline

Joined: 11th Jul 2004

Location: object position x

Posted: 21st Aug 2007 00:42

Link

Shouldn't that be local 'V' as integer - I'm assuming it's a typo, unless it's doing something very mysterious.

Back to top

Profile PM Email Website

Zotoaster

21

Years of Service

User Offline

Joined: 20th Dec 2004

Location: Scotland

Posted: 21st Aug 2007 00:52

Link

OR!

I = F - 0.5
and
I = F + 0.5

"It's like floating a boat on a liquid that I don't know, but I'm quite happy to drink it if I'm thirsty enough" - Me being a good programmer but sucking at computers

Back to top

Profile PM Email

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 21st Aug 2007 00:56 Edited at: 21st Aug 2007 00:58

Link

Quote: "Shouldn't that be local 'V' as integer "

Why? The default type IS integer - and variables in functions are also local by default. Problems only arise if V is declared as an unsuitable global somewhere else.

Perhaps the question should be: what is the "local I as integer" for? [Edit - I see that's what you meant. Oops!

]

Back to top

Profile PM Email

IanM

Retired Moderator

23

Years of Service

User Offline

Joined: 11th Sep 2002

Location: In my moon base

Posted: 21st Aug 2007 01:37

Link

Yeah, it's a typo - I meant to change the V's to I's. There's no real reason for declaring the variable in there either. It's a 'just in case' that I try to follow to avoid trashing my globals, but seeing as I always name my globals appropriately ... It's a good habit anyway.

Utility plugins collection and
http://www.matrix1.demon.co.uk for older plug-ins and example code

Back to top

Profile PM Email Website

Green Gandalf

VIP Member

21

Years of Service

User Offline

Joined: 3rd Jan 2005

Playing: Malevolence:Sword of Ahkranox, Skyrim, Civ6.

Posted: 21st Aug 2007 02:02

Link

Quote: "It's a good habit anyway."

Very true.

Back to top

Profile PM Email

sp3ng

20

Years of Service

User Offline

Joined: 15th Jan 2006

Location:

Posted: 25th Aug 2007 03:26

Link

@hayer: also is there a reason why your enter the variable RoundX into the function but do not use it anywhere (only using x, and assigning a value in function to that!)