Number match logic problem HELP PLZ!!!! :)

Author

Message

Daniel TGC

Retired Moderator

17

Years of Service

User Offline

Joined: 19th Feb 2007

Location: TGC

Posted: 31st Jul 2014 03:41

Link

Hi guys,

It's 1:28 am, and I've got an issue with a program that's going to bug me all night if I don't solve it.

The goal is simple, randomly chose 1 number, then 10 more. take the first and detect which of the 10 is a match or the closest match to the first number. I'm trying to do it as simply as possible without any arrays, and only basic logic. Been going over this with another guy and neither of us can work out why the program isn't working. We're both likely doing something really stupid so if anyone else can shine a light on it I'd be very greatful.

The code is:

//select random number, this is the number we compare to the rest
lucky = random( 0, 100 )

//generate random numbers
rnd1 = random( 0, 100 )
rnd2 = random( 0, 100 )
rnd3 = random( 0, 100 )
rnd4 = random( 0, 100 )
rnd5 = random( 0, 100 )
rnd6 = random( 0, 100 )
rnd7 = random( 0, 100 )
rnd8 = random( 0, 100 )
rnd9 = random( 0, 100 )
rnd10 = random( 0, 100 )

//We want the shortest number distence between lucky and the test number.
//To test this, we check to see if the first random number is greater than lucky, if it is then we calculate test so it generates a positive value, otherwise we calculate it in reverse
If rnd1 > lucky
    test1 = rnd1 - lucky
Else
    test1 = lucky - rnd1
EndIf
//This is repeated for all the numbers.
If rnd2 > lucky
    test2 = rnd2 - lucky
Else
    test2 = lucky - rnd2
EndIf

If rnd3 > lucky
    test3 = rnd3 - lucky
Else
    test3 = lucky - rnd3
EndIf

If rnd4 > lucky
    test4 = rnd4 - lucky
Else
    test4 = lucky - rnd4
EndIf

If rnd5 > lucky
    test5 = rnd5 - lucky
Else
    test5 = lucky - rnd5
EndIf

If rnd6 > lucky
    test6 = rnd6 - lucky
Else
    test6 = lucky - rnd6
EndIf

If rnd7 > lucky
    test7 = rnd7 - lucky
Else
    test7 = lucky - rnd7
EndIf

If rnd8 > lucky
    test8 = rnd8 - lucky
Else
    test8 = lucky - rnd8
EndIf

If rnd9 > lucky
    test9 = rnd9 - lucky
Else
    test9 = lucky - rnd9
EndIf

If rnd10 > lucky
    test10 = rnd10 - lucky
Else
    test10 = lucky - rnd10
EndIf

//Now we need the smallest number, we assume first that 1 is the closest match, then proceed to test the rest.
result = 1

//here we say, if test is larger than test2 then test2 holds the shortest distence between lucky and that random number. Otherwse result remains at one, if test one is bigger we set the result
//to 2, and then repeat the process for the remaining numbers.
if test1 > test2 then result = 2
if test2 > test3 then result = 3
if test3 > test4 then result = 4
if test4 > test5 then result = 5
if test5 > test6 then result = 6
if test6 > test7 then result = 7
if test7 > test8 then result = 8
if test8 > test9 then result = 9
if test9 > test10 then result = 10

//this just displays the generated results.
Do

print( "This is the lucky number: " + str( lucky ) )
    print( "The following are guesses by the computer!" )
    print( "1. " + str( rnd1 ) + " test value " + str( test1 ) )
    print( "2. " + str( rnd2 ) + " test value " +  str( test2 ) )
    print( "3. " + str( rnd3 ) + " test value " +  str( test3 ) )
    print( "4. " + str( rnd4 ) + " test value " +  str( test4 ) )
    print( "5. " + str( rnd5 ) + " test value " +  str( test5 ) )
    print( "6. " + str( rnd6 ) + " test value " +  str( test6 ) )
    print( "7. " + str( rnd7 ) + " test value " +  str( test7 ) )
    print( "8. " + str( rnd8 ) + " test value " +  str( test8 ) )
    print( "9. " + str( rnd9 ) + " test value " +  str( test9 ) )
    print( "10. " + str( rnd10 ) + " test value " +  str( test10 ) )
    print( "This is the closest guess by the computer." )
    print( result )

Sync()
Loop

+ Code Snippet

//select random number, this is the number we compare to the rest
lucky = random( 0, 100 )

//generate random numbers
rnd1 = random( 0, 100 )
rnd2 = random( 0, 100 )
rnd3 = random( 0, 100 )
rnd4 = random( 0, 100 )
rnd5 = random( 0, 100 )
rnd6 = random( 0, 100 )
rnd7 = random( 0, 100 )
rnd8 = random( 0, 100 )
rnd9 = random( 0, 100 )
rnd10 = random( 0, 100 )

//We want the shortest number distence between lucky and the test number.
//To test this, we check to see if the first random number is greater than lucky, if it is then we calculate test so it generates a positive value, otherwise we calculate it in reverse
If rnd1 > lucky
    test1 = rnd1 - lucky
Else
    test1 = lucky - rnd1
EndIf
//This is repeated for all the numbers.
If rnd2 > lucky
    test2 = rnd2 - lucky
Else
    test2 = lucky - rnd2
EndIf

If rnd3 > lucky
    test3 = rnd3 - lucky
Else
    test3 = lucky - rnd3
EndIf

If rnd4 > lucky
    test4 = rnd4 - lucky
Else
    test4 = lucky - rnd4
EndIf

If rnd5 > lucky
    test5 = rnd5 - lucky
Else
    test5 = lucky - rnd5
EndIf

If rnd6 > lucky
    test6 = rnd6 - lucky
Else
    test6 = lucky - rnd6
EndIf

If rnd7 > lucky
    test7 = rnd7 - lucky
Else
    test7 = lucky - rnd7
EndIf

If rnd8 > lucky
    test8 = rnd8 - lucky
Else
    test8 = lucky - rnd8
EndIf

If rnd9 > lucky
    test9 = rnd9 - lucky
Else
    test9 = lucky - rnd9
EndIf

If rnd10 > lucky
    test10 = rnd10 - lucky
Else
    test10 = lucky - rnd10
EndIf

//Now we need the smallest number, we assume first that 1 is the closest match, then proceed to test the rest.
result = 1

//here we say, if test is larger than test2 then test2 holds the shortest distence between lucky and that random number. Otherwse result remains at one, if test one is bigger we set the result
//to 2, and then repeat the process for the remaining numbers.
if test1 > test2 then result = 2
if test2 > test3 then result = 3
if test3 > test4 then result = 4
if test4 > test5 then result = 5
if test5 > test6 then result = 6
if test6 > test7 then result = 7
if test7 > test8 then result = 8
if test8 > test9 then result = 9
if test9 > test10 then result = 10

//this just displays the generated results.
Do

    print( "This is the lucky number: " + str( lucky ) )
    print( "The following are guesses by the computer!" )
    print( "1. " + str( rnd1 ) + " test value " + str( test1 ) )
    print( "2. " + str( rnd2 ) + " test value " +  str( test2 ) )
    print( "3. " + str( rnd3 ) + " test value " +  str( test3 ) )
    print( "4. " + str( rnd4 ) + " test value " +  str( test4 ) )
    print( "5. " + str( rnd5 ) + " test value " +  str( test5 ) )
    print( "6. " + str( rnd6 ) + " test value " +  str( test6 ) )
    print( "7. " + str( rnd7 ) + " test value " +  str( test7 ) )
    print( "8. " + str( rnd8 ) + " test value " +  str( test8 ) )
    print( "9. " + str( rnd9 ) + " test value " +  str( test9 ) )
    print( "10. " + str( rnd10 ) + " test value " +  str( test10 ) )
    print( "This is the closest guess by the computer." )
    print( result )

Sync()
Loop

Back to top

Profile PM Email Website

fog

20

Years of Service

User Offline

Joined: 5th Oct 2003

Location: Newcastle, England

Posted: 31st Jul 2014 04:06

Link

Simplify these bits:

+ Code Snippet

If rnd1 > lucky
    test1 = rnd1 - lucky
Else
    test1 = lucky - rnd1
EndIf

becomes

+ Code Snippet

test1 = abs ( rnd1 - lucky )

And your later logic checks are all wrong. You need to store the smallest gap and compare against that. (I've also changed the logic a bit as checking for a lower value makes more sense in this case)

+ Code Snippet

result = 1
smallestGap = test1

//here we say, if test is larger than test2 then test2 holds the shortest distence between lucky and that random number. Otherwse result remains at one, if test one is bigger we set the result
//to 2, and then repeat the process for the remaining numbers.
if test2 < smallestGap then result = 2 : smallestGap = test2
if test3 < smallestGap then result = 3 : smallestGap = test3
if test4 < smallestGap then result = 4 : smallestGap = test4
if test5 < smallestGap then result = 5 : smallestGap = test5
if test6 < smallestGap then result = 6 : smallestGap = test6
if test7 < smallestGap then result = 7 : smallestGap = test7
if test8 < smallestGap then result = 8 : smallestGap = test8
if test9 < smallestGap then result = 9 : smallestGap = test9
if test10 < smallestGap then result = 10 : smallestGap = test10

Back to top

Profile PM Email Website

easter bunny

11

Years of Service

User Offline

Joined: 20th Nov 2012

Playing: Dota 2

Posted: 31st Jul 2014 04:54 Edited at: 31st Jul 2014 05:02

Link

Quote: " I'm trying to do it as simply as possible without any arrays, and only basic logic"

Doing it with arrays is the simplest way of doing it.... You could easily do it recursively if you use arrays, cut it down to about 20 lines then.

Here is my untested way of doing it with arrays:

+ Code Snippet

dim randoms[10]
global first

global smallestDifferenceIndex
global smallestDifferenceSoFar
smallestDifferenceSoFar=101


first=random(1,100)

for k=1 to 10
 randoms[k]=random(1,100)
next

for k=1 to 10
 if diff(randoms[k],first)<smallestDifferenceSoFar
   smallestDifferenceSoFar=diff(randoms[k],first)
   smallestDifferenceIndex=k
 endif
next


//smallestDifferenceIndex now contains the index of randoms which is the smallest difference between itself and the variable first



function diff(i1,i2)
 ret=i1-i2
 if ret<0 then ret=-ret
endfunction ret

The code is horribly messy and spaghetti-ish, but all you really need to do it rename the variables, comment it and modularise it a bit more

Audacia Games - Latest WIP - AUTOMAYTE 2.1, AppGameKit one click deploy to Android
"When you've finished 90% of your game, you only have 90% left"

Back to top

Profile PM Email

Daniel TGC

Retired Moderator

17

Years of Service

User Offline

Joined: 19th Feb 2007

Location: TGC

Posted: 31st Jul 2014 05:43 Edited at: 31st Jul 2014 05:53

Link

@easter

This is part of an early education example, we're trying to write this as a logic exercise before students learn anything about arrays, functions, subroutines. Basic identifiers only, basic logic only. Thanks though your example is great, we just can't use it this early.

Back to top

Profile PM Email Website

Daniel TGC

Retired Moderator

17

Years of Service

User Offline

Joined: 19th Feb 2007

Location: TGC

Posted: 31st Jul 2014 05:51

Link

@fog

Your logic is exactly the same as ours, I'm afraid you're just adding an unnecessary identifier into the mix. Also you can't use colons after an if statement. Tried your code, it performed in exactly the same way as our original code did.

We hit upon the abs originally, it was removed as part of the troubleshooting process because it outputs to float, and we're using pure integer. It shouldn't make a difference, but at this point we're trying anything!!

Thanks for the suggestions though

Back to top

Profile PM Email Website

easter bunny

11

Years of Service

User Offline

Joined: 20th Nov 2012

Playing: Dota 2

Posted: 31st Jul 2014 06:55

Link

Could you just do it the same way as mine, but expand each for/next loop out into 10 separate statements, and instead of the diff function, use the same logic each time?

Audacia Games - Latest WIP - AUTOMAYTE 2.1, AppGameKit one click deploy to Android
"When you've finished 90% of your game, you only have 90% left"

Back to top

Profile PM Email

swissolo

14

Years of Service

User Offline

Joined: 9th Jan 2010

Location:

Posted: 31st Jul 2014 08:10

Link

I get the feeling this post isn't of any help to you, but if it's this difficult for you perhaps it's not the best example for true beginners

Do you have to use this specific example?

Back to top

Profile PM

Hockeykid

DBPro Tool Maker

16

Years of Service

User Offline

Joined: 26th Sep 2007

Location:

Posted: 31st Jul 2014 08:30 Edited at: 31st Jul 2014 08:31

Link

Replace this section:

+ Code Snippet

if test1 > test2 then result = 2
if test2 > test3 then result = 3
if test3 > test4 then result = 4
if test4 > test5 then result = 5
if test5 > test6 then result = 6
if test6 > test7 then result = 7
if test7 > test8 then result = 8
if test8 > test9 then result = 9
if test9 > test10 then result = 10

with this:

if test1 <= test2 and test1 <= test3 and test1 <= test4 and test1 <= test5 and test1 <= test6 and test1 <= test7 and test1 <= test8 and test1 <= test9 and test1 <= test10 then result = 1
if test2 <= test1 and test2 <= test3 and test2 <= test4 and test2 <= test5 and test2 <= test6 and test2 <= test7 and test2 <= test8 and test2 <= test9 and test2 <= test10 then result = 2
if test3 <= test1 and test3 <= test2 and test3 <= test4 and test3 <= test5 and test3 <= test6 and test3 <= test7 and test3 <= test8 and test3 <= test9 and test3 <= test10 then result = 3
if test4 <= test1 and test4 <= test2 and test4 <= test3 and test4 <= test5 and test4 <= test6 and test4 <= test7 and test4 <= test8 and test4 <= test9 and test4 <= test10 then result = 4
if test5 <= test1 and test5 <= test2 and test5 <= test3 and test5 <= test4 and test5 <= test6 and test5 <= test7 and test5 <= test8 and test5 <= test9 and test5 <= test10 then result = 5
if test6 <= test1 and test6 <= test2 and test6 <= test3 and test6 <= test4 and test6 <= test5 and test6 <= test7 and test6 <= test8 and test6 <= test9 and test6 <= test10 then result = 6
if test7 <= test1 and test7 <= test2 and test7 <= test3 and test7 <= test4 and test7 <= test5 and test7 <= test6 and test7 <= test8 and test7 <= test9 and test7 <= test10 then result = 7
if test8 <= test1 and test8 <= test2 and test8 <= test3 and test8 <= test4 and test8 <= test5 and test8 <= test6 and test8 <= test7 and test8 <= test9 and test8 <= test10 then result = 8
if test9 <= test1 and test9 <= test2 and test9 <= test3 and test9 <= test4 and test9 <= test5 and test9 <= test6 and test9 <= test7 and test9 <= test8 and test9 <= test10 then result = 9
if test10 <= test1 and test10 <= test2 and test10 <= test3 and test10 <= test4 and test10 <= test5 and test10 <= test6 and test10 <= test7 and test10 <= test8 and test10 <= test9 then result = 10

+ Code Snippet

if test1 <= test2 and test1 <= test3 and test1 <= test4 and test1 <= test5 and test1 <= test6 and test1 <= test7 and test1 <= test8 and test1 <= test9 and test1 <= test10 then result = 1
if test2 <= test1 and test2 <= test3 and test2 <= test4 and test2 <= test5 and test2 <= test6 and test2 <= test7 and test2 <= test8 and test2 <= test9 and test2 <= test10 then result = 2
if test3 <= test1 and test3 <= test2 and test3 <= test4 and test3 <= test5 and test3 <= test6 and test3 <= test7 and test3 <= test8 and test3 <= test9 and test3 <= test10 then result = 3
if test4 <= test1 and test4 <= test2 and test4 <= test3 and test4 <= test5 and test4 <= test6 and test4 <= test7 and test4 <= test8 and test4 <= test9 and test4 <= test10 then result = 4
if test5 <= test1 and test5 <= test2 and test5 <= test3 and test5 <= test4 and test5 <= test6 and test5 <= test7 and test5 <= test8 and test5 <= test9 and test5 <= test10 then result = 5
if test6 <= test1 and test6 <= test2 and test6 <= test3 and test6 <= test4 and test6 <= test5 and test6 <= test7 and test6 <= test8 and test6 <= test9 and test6 <= test10 then result = 6
if test7 <= test1 and test7 <= test2 and test7 <= test3 and test7 <= test4 and test7 <= test5 and test7 <= test6 and test7 <= test8 and test7 <= test9 and test7 <= test10 then result = 7
if test8 <= test1 and test8 <= test2 and test8 <= test3 and test8 <= test4 and test8 <= test5 and test8 <= test6 and test8 <= test7 and test8 <= test9 and test8 <= test10 then result = 8
if test9 <= test1 and test9 <= test2 and test9 <= test3 and test9 <= test4 and test9 <= test5 and test9 <= test6 and test9 <= test7 and test9 <= test8 and test9 <= test10 then result = 9
if test10 <= test1 and test10 <= test2 and test10 <= test3 and test10 <= test4 and test10 <= test5 and test10 <= test6 and test10 <= test7 and test10 <= test8 and test10 <= test9 then result = 10

The issue is this:

if test1 > test2 then result = 2
if test2 > test3 then result = 3

Your automatically assuming that if test1 is greater than test2 then test3 must also be greater than test1. This isn't always true since your values are completely random.

The solution I posted above is a bit messy, there are probably some other solutions you could use that don't utilize arrays (possibly ones that use Repeat Loops), however since this is a beginners tutorial I figured you would want the most basic approach.

Hope this helps.

Sean

Back to top

Profile PM Email

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 31st Jul 2014 10:50

Link

To be honest, I wouldn't use that example for teaching unless you wanted to show how ghastly life can be without loops, list and arrays. If I did use it I wouldn't have eleven numbers - four should be adequate. As it is, looking at that horrible code would put me off programming for ever!

According to the help files, ABS uses integers, not floats.

-- Jim - When is there going to be a release?

Back to top

Profile PM Website

Impetus73

12

Years of Service

User Offline

Joined: 28th Aug 2011

Location: Volda, Norway

Posted: 31st Jul 2014 11:17

Link

Amen, to JimHawkins.

----------------
AGK programmer
Did Amiga / AMOS programming in the 90's.

Back to top

Profile PM Email

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 31st Jul 2014 13:35

Link

There's a fundamental error in the code, anyway, so not a brilliant example.

To find the closest, as others have said, you have to keep the value of the difference. Let's call it Gap.

Gap MUST be instantiated to an impossibly big number:

Gap = 500

Then, for each value, where varxyz is one of your variables:

if ABS(lucky - varxyz) < gap
gap = ABS(lucky - varxyz)
best = varxyz
endif

If you don't give Gap an out-of-range starting point it may well be zero, in which case you'll never get a hit. Because the maximum RANDOM(0,100) will return, at least one of the values will trigger.

Obviously, this code does not cater for more than one value matching the criterion. If you wanted to handle that, then it would be a good introduction to lists - but that would take two passes!

-- Jim - When is there going to be a release?

Back to top

Profile PM Website

Daniel TGC

Retired Moderator

17

Years of Service

User Offline

Joined: 19th Feb 2007

Location: TGC

Posted: 31st Jul 2014 14:06 Edited at: 31st Jul 2014 14:06

Link

Thanks JimHawkins, that solved the approach. You're right I should have been working with the distance value rather than the raw values. E-Mail me at daniel@dcforeman.co.uk and I'll send you a $10 TGC voucher as a thanks.

//select random number, this is the number we compare to the rest
lucky = random( 0, 100 )

//generate random numbers
rnd1 = random( 0, 100 )
rnd2 = random( 0, 100 )
rnd3 = random( 0, 100 )
rnd4 = random( 0, 100 )
rnd5 = random( 0, 100 )
rnd6 = random( 0, 100 )
rnd7 = random( 0, 100 )
rnd8 = random( 0, 100 )
rnd9 = random( 0, 100 )
rnd10 = random( 0, 100 )

value_distence = 100

if abs( lucky - rnd1 ) < value_distence
    value_distence = abs( lucky - rnd1 )
    result = 1
endif

if abs( lucky - rnd2 ) < value_distence
    value_distence = abs( lucky - rnd2 )
    result = 2
endif

if abs( lucky - rnd3 ) < value_distence
    value_distence = abs( lucky - rnd3 )
    result = 3
endif

if abs( lucky - rnd4 ) < value_distence
    value_distence = abs( lucky - rnd4 )
    result = 4
endif

if abs( lucky - rnd5 ) < value_distence
    value_distence = abs( lucky - rnd5 )
    result = 5
endif

if abs( lucky - rnd6 ) < value_distence
    value_distence = abs( lucky - rnd6 )
    result = 6
endif

if abs( lucky - rnd7 ) < value_distence
    value_distence = abs( lucky - rnd7 )
    result = 7
endif

if abs( lucky - rnd8 ) < value_distence
    value_distence = abs( lucky - rnd8 )
    result = 8
endif

if abs( lucky - rnd9 ) < value_distence
    value_distence = abs( lucky - rnd9 )
    result = 9
endif

if abs( lucky - rnd10 ) < value_distence
    value_distence = abs( lucky - rnd10 )
    result = 10
endif

//this just displays the generated results.
Do

print( "This is the lucky number: " + str( lucky ) )
    print( "The following are guesses by the computer!" )
    print( "1. " + str( rnd1 ) )
    print( "2. " + str( rnd2 ) )
    print( "3. " + str( rnd3 ) )
    print( "4. " + str( rnd4 ) )
    print( "5. " + str( rnd5 ) )
    print( "6. " + str( rnd6 ) )
    print( "7. " + str( rnd7 ) )
    print( "8. " + str( rnd8 ) )
    print( "9. " + str( rnd9 ) )
    print( "10. " + str( rnd10 ) )
    print( "This is the closest guess by the computer." )
    print( result )

Sync()
Loop

+ Code Snippet

//select random number, this is the number we compare to the rest
lucky = random( 0, 100 )

//generate random numbers
rnd1 = random( 0, 100 )
rnd2 = random( 0, 100 )
rnd3 = random( 0, 100 )
rnd4 = random( 0, 100 )
rnd5 = random( 0, 100 )
rnd6 = random( 0, 100 )
rnd7 = random( 0, 100 )
rnd8 = random( 0, 100 )
rnd9 = random( 0, 100 )
rnd10 = random( 0, 100 )

value_distence = 100

if abs( lucky - rnd1 ) < value_distence
    value_distence = abs( lucky - rnd1 )
    result = 1
endif

if abs( lucky - rnd2 ) < value_distence
    value_distence = abs( lucky - rnd2 )
    result = 2
endif

if abs( lucky - rnd3 ) < value_distence
    value_distence = abs( lucky - rnd3 )
    result = 3
endif

if abs( lucky - rnd4 ) < value_distence
    value_distence = abs( lucky - rnd4 )
    result = 4
endif

if abs( lucky - rnd5 ) < value_distence
    value_distence = abs( lucky - rnd5 )
    result = 5
endif

if abs( lucky - rnd6 ) < value_distence
    value_distence = abs( lucky - rnd6 )
    result = 6
endif

if abs( lucky - rnd7 ) < value_distence
    value_distence = abs( lucky - rnd7 )
    result = 7
endif

if abs( lucky - rnd8 ) < value_distence
    value_distence = abs( lucky - rnd8 )
    result = 8
endif

if abs( lucky - rnd9 ) < value_distence
    value_distence = abs( lucky - rnd9 )
    result = 9
endif

if abs( lucky - rnd10 ) < value_distence
    value_distence = abs( lucky - rnd10 )
    result = 10
endif

//this just displays the generated results.
Do

    print( "This is the lucky number: " + str( lucky ) )
    print( "The following are guesses by the computer!" )
    print( "1. " + str( rnd1 ) )
    print( "2. " + str( rnd2 ) )
    print( "3. " + str( rnd3 ) )
    print( "4. " + str( rnd4 ) )
    print( "5. " + str( rnd5 ) )
    print( "6. " + str( rnd6 ) )
    print( "7. " + str( rnd7 ) )
    print( "8. " + str( rnd8 ) )
    print( "9. " + str( rnd9 ) )
    print( "10. " + str( rnd10 ) )
    print( "This is the closest guess by the computer." )
    print( result )

Sync()
Loop

Back to top

Profile PM Email Website

fog

20

Years of Service

User Offline

Joined: 5th Oct 2003

Location: Newcastle, England

Posted: 31st Jul 2014 14:09 Edited at: 31st Jul 2014 14:12

Link

@Daniel
I use native AppGameKit so wasn't aware of the colon on a THEN line thing sorry. Changed it to a IF/ENDIF block and it works fine here so don't know why it doesn't for you.

Quote: "If you don't give Gap an out-of-range starting point it may well be zero, in which case you'll never get a hit. Because the maximum RANDOM(0,100) will return, at least one of the values will trigger."

The code I posted does give the gap an initial value and Daniel said it doesn't work (he also said the logic was the same as his which it clearly isn't lol!)

Back to top

Profile PM Email Website

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 31st Jul 2014 16:21

Link

@fog - Sorry, but you don't explicitly set the value to something impossibly large (smallestGap should be at least 101 to start).

Daniel's code is still slightly (but not necessarily) wrong, because it sets the initial distance value to 100. This should be at least 101, since AppGameKit Random() returns from-to values, whereas most Random functions return the ceiling - 1.

You don't actually need an array to do this more elegantly, but you do need a loop. See how tight you can make it, girls! Of course, the loop could simply be the AppGameKit "do - loop" itself, in which case a FOR loop would not be needed.

For teaching I think that you need to focus on only one issue at a time. I'm not quite sure what this lesson is about. Strangely enough, it may turn out to be the usefulness of ABS() since ABS(x-y) is the same as ABS(y-x).

-- Jim - When is there going to be a release?

Back to top

Profile PM Website

fog

20

Years of Service

User Offline

Joined: 5th Oct 2003

Location: Newcastle, England

Posted: 31st Jul 2014 16:56

Link

Quote: "@fog - Sorry, but you don't explicitly set the value to something impossibly large (smallestGap should be at least 101 to start)."

It doesn't need to be set to something "impossibly large". I've set it to be equal to test1 which is the amount rnd1 is out by. It works fine

Quote: "For teaching I think that you need to focus on only one issue at a time."

For teaching I think it's a pretty horrible example, but then again, I'm not a teacher

Back to top

Profile PM Email Website

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 31st Jul 2014 17:01

Link

Fair enough, but it would be better to set it to (say) maxint because then it's not dependent on the later code?

-- Jim - When is there going to be a release?

Back to top

Profile PM Website

fog

20

Years of Service

User Offline

Joined: 5th Oct 2003

Location: Newcastle, England

Posted: 31st Jul 2014 18:11

Link

Quote: "Fair enough, but it would be better to set it to (say) maxint because then it's not dependent on the later code?"

Based on the new code yes.

My reply was to the original code and initialising the value to be test1 in that means you have to do one less logic check later.

In the real world we'd both use arrays, but even if you did it this way without arrays, it's quicker to use a simple function to replace all the 10 logic checks.

It really depends on how simple, readable, optimised, extendable etc you want the code

Back to top

Profile PM Email Website

easter bunny

11

Years of Service

User Offline

Joined: 20th Nov 2012

Playing: Dota 2

Posted: 1st Aug 2014 01:06

Link

Quote: "(smallestGap should be at least 101 to start)."

exactly what my code had

Audacia Games - Latest WIP - AUTOMAYTE 2.1, AppGameKit one click deploy to Android
"When you've finished 90% of your game, you only have 90% left"

Back to top

Profile PM Email

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 1st Aug 2014 01:38

Link

Indeed you did, bunny, but you used a loop, which was cheating!

-- Jim - When is there going to be a release?

Back to top

Profile PM Website

easter bunny

11

Years of Service

User Offline

Joined: 20th Nov 2012

Playing: Dota 2

Posted: 1st Aug 2014 09:36

Link

Quote: "Indeed you did, bunny, but you used a loop, which was cheating!
"

Ahh, but then I suggested expanding my loops out, even if I was too lazy to do it

Quote: "Could you just do it the same way as mine, but expand each for/next loop out into 10 separate statements, and instead of the diff function, use the diff logic each time?"

Even if I did have no idea what ABS was

Audacia Games - Latest WIP - AUTOMAYTE 2.1, AppGameKit one click deploy to Android
"When you've finished 90% of your game, you only have 90% left"

Back to top

Profile PM Email

Sorry your browser is not supported!

AppGameKit Classic Chat / Number match logic problem HELP PLZ!!!! :)