Am I doing something wrong? - GameCreators Forum

Author

Message

Dexus 136

16

Years of Service

User Offline

Joined: 8th Mar 2009

Location:

Posted: 9th Mar 2009 03:22

Link

I am trying to get this correct and I don't know how to do it. The way this is supposed to work is that when you push the space bar ten times it kills the enemy, but instead it keeps doing it as only one.
Here's the code -

+ Code Snippet

set display mode 400,300,16
cls
load sound "clapping.wav",1
load sound "shoot.wav",2
load sound "alarm.wav",3
set sound volume 3,60
attack:
loop sound 3
x=10
center text 200,50,"Push the Spacebar to attack!"
center text 200,150,">:O"
do
if spacekey()=1
play sound 2
x=x-1
endif
if x=0 then goto defeat
loop

defeat:
cls
stop sound 3
play sound 1
center text 200,50,"Good Job! You beat it!"
center text 200,150,"XP"
center text 200,200,"Play Again? [Y/N]"
do
	if inkey$()="y"
		cls
		goto attack
	endif
	if inkey$()="n" then goto ends
loop

ends:
cls
center text 200,150,"Thanks for playing!"
sleep 2000
cls
end

Attachments

Login to view attachments

Back to top

Profile PM Website

Gosub

17

Years of Service

User Offline

Joined: 23rd Sep 2007

Location:

Posted: 9th Mar 2009 15:37

Link

Well I think this is more or less like your original game, hopefully you'll be able to relate the changes i've made back to your original work.

+ Code Snippet

sync on
sync rate 0
time=1000
x=10
do
cls
dec time,1
center text 200,50,"Push the Spacebar to attack!"
if spacekey()=1 then x=x-1
set cursor 20,30
print "Enemies:";x
if x<0 
cls
center text 200,50,"you win"
endif
if time<500 and x>5
cls
center text 200,50,"you loose"
endif
sync
loop

Back to top

Profile PM

Caleb1994

16

Years of Service

User Offline

Joined: 10th Oct 2008

Location: The Internet you idiot!

Posted: 9th Mar 2009 15:44 Edited at: 9th Mar 2009 15:47

Link

thats because there isn't a switch.

when you press the spacebar it runs the code many many many times a second (if you want to see then put Text 0,0,Str$(Screen fps()) in there) so its doing it ten times just very very fast what you need to do is in the if for the spacebar check if a variable.... lets call it hold is =1 if not then do your code. in you code set it to one and have another if saying if spacekey()=0 then hold=0 see? lol i hope that makes sense

Other guy(don't remember yuour name):

he is still going to have the imidiate effect like he did before.

Both of you:

one word....

INDENTION

hahhahaha

Back to top

Profile PM Website

Gosub

17

Years of Service

User Offline

Joined: 23rd Sep 2007

Location:

Posted: 9th Mar 2009 16:38

Link

Quote: "he is still going to have the imidiate effect like he did before."

No he isn't, look at my code above Shreck.

Back to top

Profile PM

Ashingda 27

17

Years of Service

User Offline

Joined: 15th Feb 2008

Location:

Posted: 9th Mar 2009 17:23 Edited at: 9th Mar 2009 17:26

Link

Caleb's right, you'll need some kind of switch.

This example uses a flag variable when checking the SpaceKey. The variable is "KeyPress" by default it's Zero. When Space is pressed it makes a check, if it's Zero then proceed(subtract Life), then right after "KeyPress" is flaged = 1. The next time it loops around, "KeyPress" is 1 so it does nothing. When you let off Space then "KeyPress" returns to 0.

sync on
sync rate 0

gosub Innitialize

REM **********************************************************************
REM * Main Loop                                                          *
REM **********************************************************************
do

gosub Game

sync: cls
loop

REM **********************************************************************
REM * Innitialize                                                        *
REM **********************************************************************
Innitialize:
	Life = 10
return

REM **********************************************************************
REM * Game                                                               *
REM **********************************************************************
Game:
	gosub KeyHandler	
	gosub DrawText
return

REM **********************************************************************
REM * KeyHandler                                                         *
REM **********************************************************************
KeyHandler:

REM Checks for Space
	if spacekey() = 1
		if KeyPress = 0 then Life = Life - 1
		KeyPress = 1
		else
		KeyPress = 0
	endif

return

REM **********************************************************************
REM * DrawText                                                           *
REM **********************************************************************
DrawText:
	text 270,200,"Enemy Life: " + str$(Life)
return

+ Code Snippet

sync on
sync rate 0

gosub Innitialize


REM **********************************************************************
REM * Main Loop                                                          *
REM **********************************************************************
do

	gosub Game

	sync: cls
loop



REM **********************************************************************
REM * Innitialize                                                        *
REM **********************************************************************
Innitialize:
	Life = 10
return



REM **********************************************************************
REM * Game                                                               *
REM **********************************************************************
Game:
	gosub KeyHandler	
	gosub DrawText
return



REM **********************************************************************
REM * KeyHandler                                                         *
REM **********************************************************************
KeyHandler:

	REM Checks for Space
	if spacekey() = 1
		if KeyPress = 0 then Life = Life - 1
		KeyPress = 1
		else
		KeyPress = 0
	endif

return



REM **********************************************************************
REM * DrawText                                                           *
REM **********************************************************************
DrawText:
	text 270,200,"Enemy Life: " + str$(Life)
return

Back to top

Profile PM Email

Caleb1994

16

Years of Service

User Offline

Joined: 10th Oct 2008

Location: The Internet you idiot!

Posted: 9th Mar 2009 17:36

Link

good example LOL the only example I could think of was essentialy what you did but in my head it sounded to much like l his LOL I didn't want to give him codehe can just plug into his code but good job ashinga

Back to top

Profile PM Website

BN2 Productions

21

Years of Service

User Offline

Joined: 22nd Jan 2004

Location:

Posted: 9th Mar 2009 17:44

Link

If you are feeling lazy, you can also use a:

Repeat
Until spacekey()=0

Less finesse but still effective.

Great Quote:
"Time...LINE??? Time isn't made out of lines...it is made out of circles. That is why clocks are round!" -Caboose

Back to top

Profile PM

Quirkyjim

16

Years of Service

User Offline

Joined: 18th Oct 2008

Location: At my computer

Posted: 9th Mar 2009 22:33

Link

Aren't you able to use pressed like with the mouse?

+ Code Snippet

if spacekey() = 3 (or whatever) then dec x

~QJ

Back to top

Profile PM Email

BN2 Productions

21

Years of Service

User Offline

Joined: 22nd Jan 2004

Location:

Posted: 10th Mar 2009 03:40

Link

Yeah, but the problem is that if you don't have something that will stop it from happening AGAIN on the same mouseclick, then it will seem immediate.

Great Quote:
"Time...LINE??? Time isn't made out of lines...it is made out of circles. That is why clocks are round!" -Caboose

Back to top

Profile PM

Gosub

17

Years of Service

User Offline

Joined: 23rd Sep 2007

Location:

Posted: 10th Mar 2009 12:23

Link

You're telling me this doesn't work?

+ Code Snippet

sync on
sync rate 0
time=1000
x=10
do
cls
dec time,1
center text 200,50,"Push the Spacebar to attack!"
if spacekey()=1 then x=x-1
set cursor 20,30
print "Enemies:";x
if x<0 
cls
center text 200,50,"you win"
endif
if time<500 and x>5
cls
center text 200,50,"you loose"
endif
sync
loop

Back to top

Profile PM

Ashingda 27

17

Years of Service

User Offline

Joined: 15th Feb 2008

Location:

Posted: 10th Mar 2009 16:45 Edited at: 10th Mar 2009 16:45

Link

@Gosub
If you hold onto Space then the Enemy just keep on droping. When you tap on Space the Enemy will drop 2-4 points at a time. If your computer is fast enought one tap on Space will drop all 10 points on the Enemy.

Back to top

Profile PM Email

Caleb1994

16

Years of Service

User Offline

Joined: 10th Oct 2008

Location: The Internet you idiot!

Posted: 10th Mar 2009 17:29 Edited at: 10th Mar 2009 17:39

Link

when you press the space bar it checks if its pressed then subtracts the enemylife then it goes on to the next loop. does it again(if you didn't let go of the spacekey) and so if you hold it it won't stop doing it lol.

+ Code Snippet

sync on
sync rate 0

do

   if spacekey() then print "Space"

sync
loop

try that just hold down space and see what happens

+ Code Snippet

sync on
sync rate 0

do

   if spacekey() and hold=0 then print "See it won't print anymore" : Hold=1
   if spacekey()=0 then hold=0

sync
loop

now try that.

Back to top

Profile PM Website

Dexus 136

16

Years of Service

User Offline

Joined: 8th Mar 2009

Location:

Posted: 10th Mar 2009 23:21

Link

Thanks Caleb1994 and Ashingda 27! I believe you guys explained what really went wrong with what I did the best. ( Caleb1994: I will try to get some indents in more of my coding next time ^-^ )
So you guys are saying that I don't have anything from keeping it to loop right back to where the space key is flagged? Would either changing the sync rate or putting in a sleep command work out in there?

Back to top

Profile PM Website

That1Smart Guy

16

Years of Service

User Offline

Joined: 26th Feb 2009

Location: Somewhere...... yep

Posted: 11th Mar 2009 01:01

Link

no this should be ur loop:

+ Code Snippet

do
if spacekey()=1 and spaceflag=0
     dec x
     play sound 2
     spaceflag=1
endif
if spacekey()=0 then spaceflag=0
if x=0 hen goto defeat
loop

i made that off memory so dont be surprised if i overlooked something obvious

Back to top

Profile PM Email

Dexus 136

16

Years of Service

User Offline

Joined: 8th Mar 2009

Location:

Posted: 11th Mar 2009 01:03

Link

After working with the codes you guys provided and adding a few extras. I pulled together an actually fun game.
Check for yourselves

cls : sync on : sync rate 0

`*** Instructions ***
text 50,50,"Welcome"; wait 1000
text 50,70,"To "Attack""; wait 1000
text 50,90,"Push the SpaceBar"; wait key
wait 500 ; cls

`First Level Setup
Level = 1
Hitr = 98

Begin:
gosub Innitialize

`*** Main Loop ***
do

gosub Game

dec Time,1

if Elife = 0
		 wait 500
		cls
		  text 50,50,"You Win!"
		 wait 2000
		cls
		  text 50,50,"Next Level!"
		 wait 2000
			inc Level,1
		 	dec Hitr,2
		goto begin
	endif

if Time < 0 or Plife = 0
		 wait 500
		cls
		  text 50,50,"You lost!"
		  text 50,70,"Thanks for playing"
		 wait 5000
		end
	endif

sync: cls
loop

`*** Innitialize ***
Innitialize:
cls

`Readys the player
	  text 50,50,"GET READY!"
	 wait 1500
	cls
	  text 50,50,"FIGHT!"
	 wait 1000
	cls

Time = 1800
	`Player life
	Plife = 100
	`Enemy life
	Elife = 100
return

`*** Game ***
Game:
	gosub KeyHandler
	gosub LevelHandler
	gosub DrawText
return

`*** KeyHandler ***
KeyHandler:

`Checks for Space
	if spacekey() = 1
		if KeyPress = 0 then Elife = Elife - 1
		KeyPress = 1
		else
		KeyPress = 0
	endif

return

`*** LevelHandler ***
LevelHandler:

if Level = Level
		Eattack = rnd(100)
		if Eattack > Hitr then Plife = Plife - 1
	endif

return

`*** DrawText ***
DrawText:
	text 50,50,"Enemy Life: " + str$(Elife)
	text 50,70,"Your Life: " + str$(Plife)
	text 50,90,"Time: " + str$(Time)
return

+ Code Snippet

cls : sync on : sync rate 0

`*** Instructions ***
text 50,50,"Welcome"; wait 1000
text 50,70,"To "Attack""; wait 1000
text 50,90,"Push the SpaceBar"; wait key
wait 500 ; cls

`First Level Setup
Level = 1
Hitr = 98

Begin:
gosub Innitialize

`*** Main Loop ***
do

	gosub Game

	dec Time,1

	if Elife = 0
		 wait 500
		cls
		  text 50,50,"You Win!"
		 wait 2000
		cls
		  text 50,50,"Next Level!"
		 wait 2000
			inc Level,1
		 	dec Hitr,2
		goto begin
	endif

	if Time < 0 or Plife = 0
		 wait 500
		cls
		  text 50,50,"You lost!"
		  text 50,70,"Thanks for playing"
		 wait 5000
		end
	endif

	sync: cls
loop

`*** Innitialize ***
Innitialize:
cls

	`Readys the player
	  text 50,50,"GET READY!"
	 wait 1500
	cls
	  text 50,50,"FIGHT!"
	 wait 1000
	cls

	Time = 1800
	`Player life
	Plife = 100
	`Enemy life
	Elife = 100
return

`*** Game ***
Game:
	gosub KeyHandler
	gosub LevelHandler
	gosub DrawText
return

`*** KeyHandler ***
KeyHandler:

	`Checks for Space
	if spacekey() = 1
		if KeyPress = 0 then Elife = Elife - 1
		KeyPress = 1
		else
		KeyPress = 0
	endif

return

`*** LevelHandler ***
LevelHandler:

	if Level = Level
		Eattack = rnd(100)
		if Eattack > Hitr then Plife = Plife - 1
	endif

return

`*** DrawText ***
DrawText:
	text 50,50,"Enemy Life: " + str$(Elife)
	text 50,70,"Your Life: " + str$(Plife)
	text 50,90,"Time: " + str$(Time)
return

Back to top

Profile PM Website

Dexus 136

16

Years of Service

User Offline

Joined: 8th Mar 2009

Location:

Posted: 11th Mar 2009 01:06

Link

I just started to work on the media files for it, so the final product shouldn't take too long.

Back to top

Profile PM Website

Caleb1994

16

Years of Service

User Offline

Joined: 10th Oct 2008

Location: The Internet you idiot!

Posted: 11th Mar 2009 02:02

Link

good job keep up the good work! Yay Indention

hahaha

Back to top

Profile PM Website

Ashingda 27

17

Years of Service

User Offline

Joined: 15th Feb 2008

Location:

Posted: 11th Mar 2009 02:03

Link

Wow suprisingly that was really fun, gave me a good laugh!

Back to top

Profile PM Email

Dexus 136

16

Years of Service

User Offline

Joined: 8th Mar 2009

Location:

Posted: 15th Mar 2009 06:16

Link

well I am stuck on media to do for this, but I did manage to make a working Health bar system. I am having trouble making a time bar though; it just wont appear for some reason!
anyway here's the game with the health bars and the messed up time bar

` * Title  : Attack the Guy V1.2
` * Author : Dexus 136
` * Date   : 3 - 14 - 09
cls : sync on : sync rate 0

`*** Instructions ***
text 50,50,"Welcome"; wait 1000
text 50,70,"You will be fighting!"; wait 1000
text 50,90,"To 'Attack' push the SpaceBar"; wait key
wait 500 ; cls

`First Level Setup
Level = 1
Hitr = 98

Begin:
gosub Innitialize

`*** Main Loop ***
do

gosub Game

if Elife = 0
       wait 500
      cls
        text 50,50,"You Win!"
       wait 2000
      cls
        text 50,50,"Next Level!"
       wait 2000
         inc Level,1
          dec Hitr,2
      goto begin
   endif

if Time < 0 or Plife = 0
       wait 500
      cls
        text 50,50,"You lost!"
        text 50,70,"Thanks for playing"
       wait 5000
      end
   endif

sync: cls
loop

`*** Innitialize ***
Innitialize:
cls

`Readys the player
     text 50,50,"GET READY!"
    wait 1500
   cls
     text 50,50,"FIGHT!"
    wait 1500
   cls

`Time
   Time = 1500
      left3 = 160
      top3 = 93
      right3 = (left3+150)
      bottom3 = (top3+10)
   `Player life
   Plife = 100
      left1 = 160
      top1 = 73
      right1 = (left1+100)
      bottom1 = (top1+10)

`Enemy life
   Elife = 100
      left2 = 160
      top2 = 53
      right2 = (left2+100)
      bottom2 = (top2+10)
return

`*** Game ***
Game:
   gosub KeyHandler
   gosub LevelHandler
   gosub TimeHandler
   gosub BarHandler
   gosub DrawText
return

`*** KeyHandler ***
KeyHandler:

`Checks for Space
   if spacekey() = 1
      if KeyPress = 0
         dec Elife, 1
         dec right2, 1
      endif
      KeyPress = 1
      else
      KeyPress = 0
   endif

return

`*** LevelHandler ***
LevelHandler:

if Level = Level
      Eattack = rnd(100)
      if Eattack > Hitr
         dec Plife, 1
         dec right1, 1
      endif
   endif

return

`*** TimeHandler ***
TimeHandler:

dec Time,1
   TimeP = (Time/100)
   right3 = (TimeP*10)
`The time bar doesn't appear for reasons unkown
return
`*** BarHandler ***
BarHandler:

`Player
   ink rgb(0,255,0),0
   box left1, top1, right1, bottom1
`Enemy
   ink rgb(255,0,0),0
   box left2, top2, right2, bottom2
`Time
   ink rgb(0,0,255),0
   box left3, top3, right3, bottom3

return
`*** DrawText ***
DrawText:
   ink rgb(255,255,255),0
   text 50,50,"Enemy Life: " + str$(Elife)
   text 50,70,"Your Life: " + str$(Plife)
   text 50,90,"Time: " + str$(TimeP)
return

+ Code Snippet

` * Title  : Attack the Guy V1.2
` * Author : Dexus 136
` * Date   : 3 - 14 - 09
cls : sync on : sync rate 0

`*** Instructions ***
text 50,50,"Welcome"; wait 1000
text 50,70,"You will be fighting!"; wait 1000
text 50,90,"To 'Attack' push the SpaceBar"; wait key
wait 500 ; cls

`First Level Setup
Level = 1
Hitr = 98

Begin:
gosub Innitialize

`*** Main Loop ***
do

   gosub Game

   if Elife = 0
       wait 500
      cls
        text 50,50,"You Win!"
       wait 2000
      cls
        text 50,50,"Next Level!"
       wait 2000
         inc Level,1
          dec Hitr,2
      goto begin
   endif

   if Time < 0 or Plife = 0
       wait 500
      cls
        text 50,50,"You lost!"
        text 50,70,"Thanks for playing"
       wait 5000
      end
   endif

   sync: cls
loop

`*** Innitialize ***
Innitialize:
cls

   `Readys the player
     text 50,50,"GET READY!"
    wait 1500
   cls
     text 50,50,"FIGHT!"
    wait 1500
   cls

   `Time
   Time = 1500
      left3 = 160
      top3 = 93
      right3 = (left3+150)
      bottom3 = (top3+10)
   `Player life
   Plife = 100
      left1 = 160
      top1 = 73
      right1 = (left1+100)
      bottom1 = (top1+10)

   `Enemy life
   Elife = 100
      left2 = 160
      top2 = 53
      right2 = (left2+100)
      bottom2 = (top2+10)
return

`*** Game ***
Game:
   gosub KeyHandler
   gosub LevelHandler
   gosub TimeHandler
   gosub BarHandler
   gosub DrawText
return

`*** KeyHandler ***
KeyHandler:

   `Checks for Space
   if spacekey() = 1
      if KeyPress = 0
         dec Elife, 1
         dec right2, 1
      endif
      KeyPress = 1
      else
      KeyPress = 0
   endif

return

`*** LevelHandler ***
LevelHandler:

   if Level = Level
      Eattack = rnd(100)
      if Eattack > Hitr
         dec Plife, 1
         dec right1, 1
      endif
   endif

return

`*** TimeHandler ***
TimeHandler:

   dec Time,1
   TimeP = (Time/100)
   right3 = (TimeP*10)
`The time bar doesn't appear for reasons unkown
return
`*** BarHandler ***
BarHandler:

`Player
   ink rgb(0,255,0),0
   box left1, top1, right1, bottom1
`Enemy
   ink rgb(255,0,0),0
   box left2, top2, right2, bottom2
`Time
   ink rgb(0,0,255),0
   box left3, top3, right3, bottom3

return
`*** DrawText ***
DrawText:
   ink rgb(255,255,255),0
   text 50,50,"Enemy Life: " + str$(Elife)
   text 50,70,"Your Life: " + str$(Plife)
   text 50,90,"Time: " + str$(TimeP)
return

I'll be back on tomorrow. I gotta go to bed.

Back to top

Profile PM Website

Sorry your browser is not supported!

DarkBASIC Discussion / Am I doing something wrong?

Attachments