TheComet this is what I had in mind for the unfilled box

Author

Message

Brazos

22

Years of Service

User Offline

Joined: 7th Apr 2003

Location:

Posted: 7th Jun 2009 03:06 Edited at: 7th Jun 2009 03:43

Link

Thanks for the unfilled box code that you wrote. The following code shows a small sample of what I intended to do with it. If you or anyone sees any way of improving or shortening the code, please let me know. I'm eager to learn new techniques.

rem draw unfilled box
rem by TheComet
rem variation by Brazos

rem setup screen
sync on
sync rate 60
backdrop on
color backdrop 0
show mouse
rem make example image
for t=1 to 200
ink rgb(rnd(255),rnd(255),rnd(255)),0
dot rnd(100),rnd(100)
next t

rem get example image (1) and make dummy image (2)

get image 1,0,0,100,100
get image 2,0,0,100,100

rem main loop
click=0
do

paste image 1,200,200
   paste image 2,-1,-1

rem check if mouse is pressed
   if mouseclick()=1

rem set start positions
      if click=0
         startx=mousex()
         starty=mousey()
         click=1
      endif

rem get end positions
      endx=mousex()
      endy=mousey()

rem draw box
      empty_box(startx,starty,endx,endy,50,50,255)

rem get image from unfilled box area
      rem making sure to keep get image command in range
      rem with flags
      if startx>0 and startx<endx and starty>0 and starty<endy then get image 2,startx,starty,endx,endy

if endx>0 and endx<startx and endy>0 and endy<starty then get image 2,endx,endy,startx,starty

if startx>0 and startx<endx and starty>0 and starty>endy then get image 2,startx,endy,endx,starty

if endx>0 and endx<startx and endy>0 and endy>starty then get image 2,endx,starty,startx,endy

else
      click=0
   endif

rem refresh screen
   sync

rem end of main loop
loop

rem Functions ------------------------------------------------------------

function empty_box(x1,y1,x2,y2,r,g,b)

rem set ink colour
   ink rgb(r,g,b),0

rem draw box
   line x1,y1,x2,y1
   line x2,y1,x2,y2
   line x2,y2,x1,y2
   line x1,y2,x1,y1

rem print how big the box is
   cx=(x1+x2)/2
   cy=(y2+2)
   text 0,464,str$(x2-x1)+"*"+str$(y2-y1)

endfunction

+ Code Snippet

rem draw unfilled box
rem by TheComet
rem variation by Brazos

rem setup screen
sync on
sync rate 60
backdrop on
color backdrop 0
show mouse
rem make example image
for t=1 to 200
ink rgb(rnd(255),rnd(255),rnd(255)),0
dot rnd(100),rnd(100)
next t

rem get example image (1) and make dummy image (2)

get image 1,0,0,100,100
get image 2,0,0,100,100

rem main loop
click=0
do

   paste image 1,200,200
   paste image 2,-1,-1

   rem check if mouse is pressed
   if mouseclick()=1

      rem set start positions
      if click=0
         startx=mousex()
         starty=mousey()
         click=1
      endif

      rem get end positions
      endx=mousex()
      endy=mousey()

      rem draw box
      empty_box(startx,starty,endx,endy,50,50,255)

      rem get image from unfilled box area
      rem making sure to keep get image command in range
      rem with flags
      if startx>0 and startx<endx and starty>0 and starty<endy then get image 2,startx,starty,endx,endy

      if endx>0 and endx<startx and endy>0 and endy<starty then get image 2,endx,endy,startx,starty

      if startx>0 and startx<endx and starty>0 and starty>endy then get image 2,startx,endy,endx,starty

      if endx>0 and endx<startx and endy>0 and endy>starty then get image 2,endx,starty,startx,endy

   else
      click=0
   endif

   rem refresh screen
   sync

rem end of main loop
loop

rem Functions ------------------------------------------------------------

function empty_box(x1,y1,x2,y2,r,g,b)

   rem set ink colour
   ink rgb(r,g,b),0

   rem draw box
   line x1,y1,x2,y1
   line x2,y1,x2,y2
   line x2,y2,x1,y2
   line x1,y2,x1,y1

   rem print how big the box is
   cx=(x1+x2)/2
   cy=(y2+2)
   text 0,464,str$(x2-x1)+"*"+str$(y2-y1)

endfunction

Sorry for starting new thread, if I wasn't supposed to. I wanted TheComet to be sure and see this.

Back to top

Profile PM

Libervurto

18

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 7th Jun 2009 05:51

Link

I have a couple of suggestions...
Instead of that "click" flag you could do this:

+ Code Snippet

oldclick = newclick
newclick = mouseclick()

if newclick > oldclick
  startx = mousex()
  starty = mousey()
endif

Play around with that snippet and you'll see how it works. It would take out a few lines and make your code a bit simpler.

You're checking whether the start position is "less" than the end, that's clever but how about taking that further:

+ Code Snippet

if startx < endx
  ax=startx : bx=endx
else
  ax=endx : bx=startx
endif

Do the same with y and grab the image ax,ay,bx,by.
As for checking they are on screen; you could look at it as checking how far away from the middle they are If abs(320-startx) < 320.

Using lines to draw the box is slow, use boxes instead (same co-ords).

Enough for one evening I think

There is an eight letter word. You can insert a letter into it or remove a letter from it without changing its meaning. Answer

Back to top

Profile PM Email

Brazos

22

Years of Service

User Offline

Joined: 7th Apr 2003

Location:

Posted: 7th Jun 2009 07:33 Edited at: 7th Jun 2009 07:57

Link

I tried your first code and when I make my second selection the start position of the box goes back to the first selection start position. I may have not used the snippet as I should have.

I think I understand your second code snippet.

When I changed the line command to box I lost the left and bottom lines of the select box.

Back to top

Profile PM

TheComet

17

Years of Service

User Offline

Joined: 18th Oct 2007

Location: I`m under ur bridge eating ur goatz.

Posted: 7th Jun 2009 13:32 Edited at: 7th Jun 2009 13:32

Link

That was cool, Brazos!

I'm glad you made something out of that code.

Quote: "Using lines to draw the box is slow, use boxes instead (same co-ords)."

I did some tests in speed, and here are the results:

+ Code Snippet

boxes : 390 ms = 10000 times
lines : 4987 ms = 10000 times

I drew the empty box with lines 10000 times and checked how long it took, and then did the same with boxes. As you can see, lines are almost 13 times slower than boxes, so use boxes.

Here is the new function:

+ Code Snippet

function empty_box(x1,y1,x2,y2,r,g,b)

   rem set ink colour
   ink rgb(r,g,b),0

   rem make sure x1 and y1 are always smaller than x2 and y2
   if x1>x2 then x3=x1:x1=x2:x2=x3
   if y1>y2 then y3=y1:y1=y2:y2=y3

   rem draw box
   box x1,y1-1,x2,y1
   box x2,y1,x2+1,y2
   box x1,y2,x2,y2+1
   box x1-1,y1,x1,y2

   rem print how big the box is
   cx=(x1+x2)/2
   cy=(y2+2)
   text 0,464,str$(x2-x1)+"*"+str$(y2-y1)

endfunction

TheComet

Make the path of your enemies easier with Waypoint Pro!

Back to top

Profile PM Email Website

Caleb1994

16

Years of Service

User Offline

Joined: 10th Oct 2008

Location: The Internet you idiot!

Posted: 8th Jun 2009 00:03

Link

THANKS! i dindn't know it was that big of a difference but i used it in my WinGUI functions and it cut the update time in half!!!!!

New Site! Check it out \/

Back to top

Profile PM Website

Libervurto

18

Years of Service

User Offline

Joined: 30th Jun 2006

Location: On Toast

Posted: 8th Jun 2009 03:45 Edited at: 8th Jun 2009 03:46

Link

@Comet
As a general tip, try to avoid using numbers in your variable names, they work fine but they make code harder to follow as it looks like there are values in there when there aren't. Stick to letters and you can instantly see you are dealing with variables.

@Bravos

Quote: "I tried your first code and when I make my second selection the start position of the box goes back to the first selection start position."

Do you mean second selection as in the end point?
Or as in the second time you use the whole routine?
Supply the code please.

There is an eight letter word. You can insert a letter into it or remove a letter from it without changing its meaning. Answer

Back to top

Profile PM Email

Sorry your browser is not supported!

DarkBASIC Discussion / TheComet this is what I had in mind for the unfilled box