Save and load data problem - GameCreators Forum

Author

Message

Doveyy04

12

Years of Service

User Offline

Joined: 30th Apr 2012

Location:

Posted: 17th Dec 2012 22:04

Link

When I implemented the read and write commands into my program and then run it the program crashed at the point of saving the integers and strings saying windows explorer has stopped working. I had 3 integers and 2 strings writing to my txt file. When I run the program again everything worked fine, writing and reading but then when I added another 20 integers and 50 strings to the write part of the program the program crashed again at the writing point, only this time no matter how many times I run the program it crashes at the same point. Is there a limit to how many integers and strings you can get your program to read and write? Thanks for any help

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 17th Dec 2012 22:23

Link

There are no limits to the file read/write.

It would help to see the code you are using for the reading and writing.

And what version of AppGameKit are you using?

And are you working in Tier 1 (AGK IDE) or Tier 2 (MS Visual Studio)?

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Doveyy04

12

Years of Service

User Offline

Joined: 30th Apr 2012

Location:

Posted: 17th Dec 2012 23:00

Link

I'm using tier 1 basic and I'm using the same code as listed in the example program's . A=readinteger (1). Writeinteger (1,a) etc. I am still using the trial version of agk basic also, does that make a difference? .

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 18th Dec 2012 03:44

Link

It is not impossible that the file operations are limited in the trial version.

But, seeing your code might make it easier to see if there is some issue with how you are reading and writing. Not necessarily all of the code, but the code related to the writing and to whatever function you are using to handle it.

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Doveyy04

12

Years of Service

User Offline

Joined: 30th Apr 2012

Location:

Posted: 18th Dec 2012 16:09

Link

Ok I will post my code when I get on laptop later. How do I do this? I gather I have to copy n paste a section of my code to the screen but how do I hide it behind a link like people do so my post doesn't automatically fill up with my code

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 18th Dec 2012 18:13

Link

You use the 'code' buttons at the top of the Post Forum Message input to wrap your code in '

+ Code Snippet

..

' tags so that it is closed until someone clicks on it and then it opens up.

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Doveyy04

12

Years of Service

User Offline

Joined: 30th Apr 2012

Location:

Posted: 18th Dec 2012 19:47 Edited at: 18th Dec 2012 19:54

Link

_mainmenu:

OpenToWrite ( 1, "dovey.txt", 0 )

WriteInteger ( 1, teamengper )
writeinteger ( 1, teamengrel )
writeinteger ( 1, teamengwor )

WriteInteger ( 1, teamdrv1spe )
writeinteger ( 1, teamdrv1exp )
writeinteger ( 1, teamdrv1ovr )
WriteInteger ( 1, teamdrv1tys )
writeinteger ( 1, teamdrv1wet )
writeinteger ( 1, teamdrv1att )
WriteInteger ( 1, teamdrv1mor )
writeinteger ( 1, teamdriver1wag )
writeinteger ( 1, teamdriver1cwins )
WriteInteger ( 1, teamdriver1titles )

WriteInteger ( 1, teamdrv2spe )
writeinteger ( 1, teamdrv2exp )
writeinteger ( 1, teamdrv2ovr )
WriteInteger ( 1, teamdrv2tys )
writeinteger ( 1, teamdrv2wet )
writeinteger ( 1, teamdrv2att )
WriteInteger ( 1, teamdrv2mor )
writeinteger ( 1, teamdriver2wag )
writeinteger ( 1, teamdriver2cwins )
WriteInteger ( 1, teamdriver2titles )

writeinteger ( 1, trainerdaysleft )
writeinteger ( 1, mechanicdaysleft )
writeinteger ( 1, designerdaysleft )
writeinteger ( 1, pitcrewskill )

writeinteger ( 1, trainersstafflevel )
writeinteger ( 1, mechanicsstafflevel )
writeinteger ( 1, designerstafflevel )
writeinteger ( 1, developkers )
writeinteger ( 1, money )

writeinteger ( 1, exrelskill )
writeinteger ( 1, surelskill )
writeinteger ( 1, trrelskill )
writeinteger ( 1, bsrelskill )
writeinteger ( 1, afb )
writeinteger ( 1, designerdaysleft )
writeinteger ( 1, mechanicdaysleft )
writeinteger ( 1, trainerdaysleft )

WriteString ( 1, teamname$ )
WriteString ( 1, teamengine$ )

WriteString ( 1, teamdriver1$ )
WriteString ( 1, teamdriver1nat$ )
WriteString ( 1, teamdriver2$ )
WriteString ( 1, teamdriver2nat$ )

writestring ( 1, driver1name$ )
writestring ( 1, driver2name$ )
writestring ( 1, driver3name$ )
writestring ( 1, driver4name$ )
writestring ( 1, driver5name$ )
writestring ( 1, driver6name$ )
writestring ( 1, driver7name$ )
writestring ( 1, driver8name$ )
writestring ( 1, driver9name$ )
writestring ( 1, driver10name$ )
writestring ( 1, driver11name$ )
writestring ( 1, driver12name$ )
writestring ( 1, driver13name$ )
writestring ( 1, driver14name$ )
writestring ( 1, driver15name$ )
writestring ( 1, driver16name$ )
writestring ( 1, driver17name$ )
writestring ( 1, driver18name$ )
writestring ( 1, driver19name$ )
writestring ( 1, driver20name$ )
writestring ( 1, driver21name$ )
writestring ( 1, driver22name$ )
writestring ( 1, driver23name$ )
writestring ( 1, driver24name$ )
writestring ( 1, driver25name$ )
writestring ( 1, driver26name$ )

writestring ( 1, driver1team$ )
writestring ( 1, driver2team$ )
writestring ( 1, driver3team$ )
writestring ( 1, driver4team$ )
writestring ( 1, driver5team$ )
writestring ( 1, driver6team$ )
writestring ( 1, driver7team$ )
writestring ( 1, driver8team$ )
writestring ( 1, driver9team$ )
writestring ( 1, driver10team$ )
writestring ( 1, driver11team$ )
writestring ( 1, driver12team$ )
writestring ( 1, driver13team$ )
writestring ( 1, driver14team$ )
writestring ( 1, driver15team$ )
writestring ( 1, driver16team$ )
writestring ( 1, driver17team$ )
writestring ( 1, driver18team$ )
writestring ( 1, driver19team$ )
writestring ( 1, driver20team$ )
writestring ( 1, driver21team$ )
writestring ( 1, driver22team$ )
writestring ( 1, driver23team$ )
writestring ( 1, driver24team$ )
writestring ( 1, driver25team$ )
writestring ( 1, driver26team$ )

writestring ( 1, team1name$ )
writestring ( 1, team2name$ )
writestring ( 1, team3name$ )
writestring ( 1, team4name$ )
writestring ( 1, team5name$ )
writestring ( 1, team6name$ )
writestring ( 1, team7name$ )
writestring ( 1, team8name$ )
writestring ( 1, team9name$ )
writestring ( 1, team10name$ )
writestring ( 1, team11name$ )
writestring ( 1, team12name$ )
writestring ( 1, team13name$ )

writestring ( 1, winner1name$)
writestring ( 1, winner2name$)
writestring ( 1, winner3name$)
writestring ( 1, winner4name$)
writestring ( 1, winner5name$)
writestring ( 1, winner6name$)
writestring ( 1, winner7name$)
writestring ( 1, winner8name$)
writestring ( 1, winner9name$)
writestring ( 1, winner10name$)
writestring ( 1, winner11name$)
writestring ( 1, winner12name$)
writestring ( 1, winner13name$)
writestring ( 1, winner14name$)
writestring ( 1, winner15name$)
writestring ( 1, winner16name$)

CloseFile ( 1 )

+ Code Snippet


_mainmenu:

OpenToWrite ( 1, "dovey.txt", 0 )


WriteInteger ( 1, teamengper )
writeinteger ( 1, teamengrel )
writeinteger ( 1, teamengwor )

WriteInteger ( 1, teamdrv1spe )
writeinteger ( 1, teamdrv1exp )
writeinteger ( 1, teamdrv1ovr )
WriteInteger ( 1, teamdrv1tys )
writeinteger ( 1, teamdrv1wet )
writeinteger ( 1, teamdrv1att )
WriteInteger ( 1, teamdrv1mor )
writeinteger ( 1, teamdriver1wag )
writeinteger ( 1, teamdriver1cwins )
WriteInteger ( 1, teamdriver1titles )

WriteInteger ( 1, teamdrv2spe )
writeinteger ( 1, teamdrv2exp )
writeinteger ( 1, teamdrv2ovr )
WriteInteger ( 1, teamdrv2tys )
writeinteger ( 1, teamdrv2wet )
writeinteger ( 1, teamdrv2att )
WriteInteger ( 1, teamdrv2mor )
writeinteger ( 1, teamdriver2wag )
writeinteger ( 1, teamdriver2cwins )
WriteInteger ( 1, teamdriver2titles )

writeinteger ( 1, trainerdaysleft )
writeinteger ( 1, mechanicdaysleft )
writeinteger ( 1, designerdaysleft )
writeinteger ( 1, pitcrewskill )

writeinteger ( 1, trainersstafflevel )
writeinteger ( 1, mechanicsstafflevel )
writeinteger ( 1, designerstafflevel )
writeinteger ( 1, developkers )
writeinteger ( 1, money )

writeinteger ( 1, exrelskill )
writeinteger ( 1, surelskill )
writeinteger ( 1, trrelskill )
writeinteger ( 1, bsrelskill )
writeinteger ( 1, afb )
writeinteger ( 1, designerdaysleft )
writeinteger ( 1, mechanicdaysleft )
writeinteger ( 1, trainerdaysleft )



WriteString ( 1, teamname$ )
WriteString ( 1, teamengine$ )

WriteString ( 1, teamdriver1$ )
WriteString ( 1, teamdriver1nat$ )
WriteString ( 1, teamdriver2$ )
WriteString ( 1, teamdriver2nat$ )

writestring ( 1, driver1name$ )
writestring ( 1, driver2name$ )
writestring ( 1, driver3name$ )
writestring ( 1, driver4name$ )
writestring ( 1, driver5name$ )
writestring ( 1, driver6name$ )
writestring ( 1, driver7name$ )
writestring ( 1, driver8name$ )
writestring ( 1, driver9name$ )
writestring ( 1, driver10name$ )
writestring ( 1, driver11name$ )
writestring ( 1, driver12name$ )
writestring ( 1, driver13name$ )
writestring ( 1, driver14name$ )
writestring ( 1, driver15name$ )
writestring ( 1, driver16name$ )
writestring ( 1, driver17name$ )
writestring ( 1, driver18name$ )
writestring ( 1, driver19name$ )
writestring ( 1, driver20name$ )
writestring ( 1, driver21name$ )
writestring ( 1, driver22name$ )
writestring ( 1, driver23name$ )
writestring ( 1, driver24name$ )
writestring ( 1, driver25name$ )
writestring ( 1, driver26name$ )

writestring ( 1, driver1team$ )
writestring ( 1, driver2team$ )
writestring ( 1, driver3team$ )
writestring ( 1, driver4team$ )
writestring ( 1, driver5team$ )
writestring ( 1, driver6team$ )
writestring ( 1, driver7team$ )
writestring ( 1, driver8team$ )
writestring ( 1, driver9team$ )
writestring ( 1, driver10team$ )
writestring ( 1, driver11team$ )
writestring ( 1, driver12team$ )
writestring ( 1, driver13team$ )
writestring ( 1, driver14team$ )
writestring ( 1, driver15team$ )
writestring ( 1, driver16team$ )
writestring ( 1, driver17team$ )
writestring ( 1, driver18team$ )
writestring ( 1, driver19team$ )
writestring ( 1, driver20team$ )
writestring ( 1, driver21team$ )
writestring ( 1, driver22team$ )
writestring ( 1, driver23team$ )
writestring ( 1, driver24team$ )
writestring ( 1, driver25team$ )
writestring ( 1, driver26team$ )

writestring ( 1, team1name$ )
writestring ( 1, team2name$ )
writestring ( 1, team3name$ )
writestring ( 1, team4name$ )
writestring ( 1, team5name$ )
writestring ( 1, team6name$ )
writestring ( 1, team7name$ )
writestring ( 1, team8name$ )
writestring ( 1, team9name$ )
writestring ( 1, team10name$ )
writestring ( 1, team11name$ )
writestring ( 1, team12name$ )
writestring ( 1, team13name$ )

writestring ( 1, winner1name$)
writestring ( 1, winner2name$)
writestring ( 1, winner3name$)
writestring ( 1, winner4name$)
writestring ( 1, winner5name$)
writestring ( 1, winner6name$)
writestring ( 1, winner7name$)
writestring ( 1, winner8name$)
writestring ( 1, winner9name$)
writestring ( 1, winner10name$)
writestring ( 1, winner11name$)
writestring ( 1, winner12name$)
writestring ( 1, winner13name$)
writestring ( 1, winner14name$)
writestring ( 1, winner15name$)
writestring ( 1, winner16name$)

CloseFile ( 1 )

thats the writing part

_dove3:

opentoread (1, "dovey.txt")

teamengper=readinteger (1)
teamengrel=readinteger (1)
teamengwor=readinteger (1)
teamdrv1spe=readinteger (1)
teamdrv1exp=readinteger (1)
teamdrv1ovr=readinteger (1)
teamdrv1tys=readinteger (1)
teamdrv1wet=readinteger (1)
teamdrv1att=readinteger (1)
teamdrv1mor=readinteger (1)
teamdriver1wag=readinteger (1)
teamdriver1cwins=readinteger (1)
teamdriver1titles=readinteger (1)

teamdrv2spe=readinteger (1)
teamdrv2exp=readinteger (1)
teamdrv2ovr=readinteger (1)
teamdrv2tys=readinteger (1)
teamdrv2wet=readinteger (1)
teamdrv2att=readinteger (1)
teamdrv2mor=readinteger (1)
teamdriver2wag=readinteger (1)
teamdriver2cwins=readinteger (1)
teamdriver2titles=readinteger (1)

trainerdaysleft=readinteger (1)
mechanicdaysleft=readinteger (1)
designerdaysleft=readinteger (1)
pitcrewskill=readinteger (1)

trainersstafflevel=readinteger (1)
mechanicsstafflevel=readinteger (1)
designerstafflevel=readinteger (1)
developkers=readinteger (1)
money=readinteger (1)

exrelskill=readinteger (1)
surelskill=readinteger (1)
trrelskill=readinteger (1)
bsrelskill=readinteger (1)
afb=readinteger (1)
designerdaysleft=readinteger (1)
mechanicdaysleft=readinteger (1)
trainerdaysleft=readinteger (1)

teamname$=readstring (1)
teamengine$=readstring (1)

teamdriver1$=readstring (1)
teamdriver1nat$=readstring (1)
teamdriver2$=readstring (1)
teamdriver2nat$=readstring (1)

driver1name$=readstring (1)
driver2name$=readstring (1)
driver3name$=readstring (1)
driver4name$=readstring (1)
driver5name$=readstring (1)
driver6name$=readstring (1)
driver7name$=readstring (1)
driver8name$=readstring (1)
driver9name$=readstring (1)
driver10name$=readstring (1)
driver11name$=readstring (1)
driver12name$=readstring (1)
driver13name$=readstring (1)
driver14name$=readstring (1)
driver15name$=readstring (1)
driver16name$=readstring (1)
driver17name$=readstring (1)
driver18name$=readstring (1)
driver19name$=readstring (1)
driver20name$=readstring (1)
driver21name$=readstring (1)
driver22name$=readstring (1)
driver23name$=readstring (1)
driver24name$=readstring (1)
driver25name$=readstring (1)
driver26name$=readstring (1)

driver1team$=readstring (1)
driver2team$=readstring (1)
driver3team$=readstring (1)
driver4team$=readstring (1)
driver5team$=readstring (1)
driver6team$=readstring (1)
driver7team$=readstring (1)
driver8team$=readstring (1)
driver9team$=readstring (1)
driver10team$=readstring (1)
driver11team$=readstring (1)
driver12team$=readstring (1)
driver13team$=readstring (1)
driver14team$=readstring (1)
driver15team$=readstring (1)
driver16team$=readstring (1)
driver17team$=readstring (1)
driver18team$=readstring (1)
driver19team$=readstring (1)
driver20team$=readstring (1)
driver21team$=readstring (1)
driver22team$=readstring (1)
driver23team$=readstring (1)
driver24team$=readstring (1)
driver25team$=readstring (1)
driver26team$=readstring (1)

team1name$=readstring (1)
team2name$=readstring (1)
team3name$=readstring (1)
team4name$=readstring (1)
team5name$=readstring (1)
team6name$=readstring (1)
team7name$=readstring (1)
team8name$=readstring (1)
team9name$=readstring (1)
team10name$=readstring (1)
team11name$=readstring (1)
team12name$=readstring (1)
team13name$=readstring (1)

winner1name$=readstring (1)
winner2name$=readstring (1)
winner3name$=readstring (1)
winner4name$=readstring (1)
winner5name$=readstring (1)
winner6name$=readstring (1)
winner7name$=readstring (1)
winner8name$=readstring (1)
winner9name$=readstring (1)
winner10name$=readstring (1)
winner11name$=readstring (1)
winner12name$=readstring (1)
winner13name$=readstring (1)
winner14name$=readstring (1)
winner15name$=readstring (1)
winner16name$=readstring (1)

closefile (1)

+ Code Snippet


_dove3:

opentoread (1, "dovey.txt")

teamengper=readinteger (1)
teamengrel=readinteger (1)
teamengwor=readinteger (1)
teamdrv1spe=readinteger (1)
teamdrv1exp=readinteger (1)
teamdrv1ovr=readinteger (1)
teamdrv1tys=readinteger (1)
teamdrv1wet=readinteger (1)
teamdrv1att=readinteger (1)
teamdrv1mor=readinteger (1)
teamdriver1wag=readinteger (1)
teamdriver1cwins=readinteger (1)
teamdriver1titles=readinteger (1)

teamdrv2spe=readinteger (1)
teamdrv2exp=readinteger (1)
teamdrv2ovr=readinteger (1)
teamdrv2tys=readinteger (1)
teamdrv2wet=readinteger (1)
teamdrv2att=readinteger (1)
teamdrv2mor=readinteger (1)
teamdriver2wag=readinteger (1)
teamdriver2cwins=readinteger (1)
teamdriver2titles=readinteger (1)

trainerdaysleft=readinteger (1)
mechanicdaysleft=readinteger (1)
designerdaysleft=readinteger (1)
pitcrewskill=readinteger (1)

trainersstafflevel=readinteger (1)
mechanicsstafflevel=readinteger (1)
designerstafflevel=readinteger (1)
developkers=readinteger (1)
money=readinteger (1)

exrelskill=readinteger (1)
surelskill=readinteger (1)
trrelskill=readinteger (1)
bsrelskill=readinteger (1)
afb=readinteger (1)
designerdaysleft=readinteger (1)
mechanicdaysleft=readinteger (1)
trainerdaysleft=readinteger (1)






teamname$=readstring (1)
teamengine$=readstring (1)

teamdriver1$=readstring (1)
teamdriver1nat$=readstring (1)
teamdriver2$=readstring (1)
teamdriver2nat$=readstring (1)

driver1name$=readstring (1)
driver2name$=readstring (1)
driver3name$=readstring (1)
driver4name$=readstring (1)
driver5name$=readstring (1)
driver6name$=readstring (1)
driver7name$=readstring (1)
driver8name$=readstring (1)
driver9name$=readstring (1)
driver10name$=readstring (1)
driver11name$=readstring (1)
driver12name$=readstring (1)
driver13name$=readstring (1)
driver14name$=readstring (1)
driver15name$=readstring (1)
driver16name$=readstring (1)
driver17name$=readstring (1)
driver18name$=readstring (1)
driver19name$=readstring (1)
driver20name$=readstring (1)
driver21name$=readstring (1)
driver22name$=readstring (1)
driver23name$=readstring (1)
driver24name$=readstring (1)
driver25name$=readstring (1)
driver26name$=readstring (1)

driver1team$=readstring (1)
driver2team$=readstring (1)
driver3team$=readstring (1)
driver4team$=readstring (1)
driver5team$=readstring (1)
driver6team$=readstring (1)
driver7team$=readstring (1)
driver8team$=readstring (1)
driver9team$=readstring (1)
driver10team$=readstring (1)
driver11team$=readstring (1)
driver12team$=readstring (1)
driver13team$=readstring (1)
driver14team$=readstring (1)
driver15team$=readstring (1)
driver16team$=readstring (1)
driver17team$=readstring (1)
driver18team$=readstring (1)
driver19team$=readstring (1)
driver20team$=readstring (1)
driver21team$=readstring (1)
driver22team$=readstring (1)
driver23team$=readstring (1)
driver24team$=readstring (1)
driver25team$=readstring (1)
driver26team$=readstring (1)

team1name$=readstring (1)
team2name$=readstring (1)
team3name$=readstring (1)
team4name$=readstring (1)
team5name$=readstring (1)
team6name$=readstring (1)
team7name$=readstring (1)
team8name$=readstring (1)
team9name$=readstring (1)
team10name$=readstring (1)
team11name$=readstring (1)
team12name$=readstring (1)
team13name$=readstring (1)

winner1name$=readstring (1)
winner2name$=readstring (1)
winner3name$=readstring (1)
winner4name$=readstring (1)
winner5name$=readstring (1)
winner6name$=readstring (1)
winner7name$=readstring (1)
winner8name$=readstring (1)
winner9name$=readstring (1)
winner10name$=readstring (1)
winner11name$=readstring (1)
winner12name$=readstring (1)
winner13name$=readstring (1)
winner14name$=readstring (1)
winner15name$=readstring (1)
winner16name$=readstring (1)




closefile (1)

and thats the reading

Back to top

Profile PM

shadey

14

Years of Service

User Offline

Joined: 25th Jan 2010

Location:

Posted: 18th Dec 2012 20:14 Edited at: 18th Dec 2012 20:15

Link

you may wanna look into using arrays or even types... and use a small loop! just for the sake of shortening the code!

Hail to the king, baby!

Back to top

Profile PM Website

Doveyy04

12

Years of Service

User Offline

Joined: 30th Apr 2012

Location:

Posted: 18th Dec 2012 20:21

Link

what i have noticed is that if i get my program to go through the read commands (as per 2nd code snippet above) first and then go through the write commands (as per 1st code snippet above) next then everything seems ok, its only when the program goes through the write commands first that it crashes with mygame.exe has stopped working. But i need both options to work as i want my program to have a new game option where as u start off from stratch set up your name etc and then write to file at various points of game, and then i want my program to have a load game option where u continue from the last point in your game by reading to file and then writing at various points

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 18th Dec 2012 20:32

Link

I don't see returns at the end of either of your segments.

Since you are using labels (_mainmenu: and _dove3

I am assuming that they are executed with gosub calls.

If you don't have a return at the end your stack could be getting corrupted and/or you aren't actually executing things in the order you expect them to be.

Also, definitely use arrays and loops instead of single variables for all of the things you are writing/reading. Maintaining the code you have posted is going to be a nightmare for you in the long run.

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Doveyy04

12

Years of Service

User Offline

Joined: 30th Apr 2012

Location:

Posted: 18th Dec 2012 20:45

Link

i use them labels as i have goto's. they are not as a gosub, although i have some gosubs elsewhere i also use return in them. My program all works fine, i have tested many many times its just this problem with writing!!!. Is it because i am not using arrays that my program is crashing ...although as ive just said the program all works fine when i run the program read first then write

Back to top

Profile PM

Hodgey

14

Years of Service

User Offline

Joined: 10th Oct 2009

Location: Australia

Posted: 18th Dec 2012 20:47 Edited at: 18th Dec 2012 21:11

Link

There's no end of file checking either. Not sure what AppGameKit does when you try to read past the end of a file, presumably a runtime error would occur.

Edit: we might need to see how you use your gotos. Gotos are notorious for creating spaghetti code and being very hard to debug which is why, in most circumstances, it's highly discouraged.

Back to top

Profile PM Email

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 18th Dec 2012 21:30

Link

I didn't say it wouldn't work. But it looked like you might be using gosub calls, so I was offering something that might be an issue.

Hodgey is right. It is hard to figure out what the problem is with just those two bits of code.

While the goto command exists, it does make spaghetti code a possibility and that can cause problems, especially when trying to debug. I've had a lot of experience dealing with code done with lots of goto calls (not mine, other peoples) and it is very hard to follow the flow.

If, by chance, you should happen to do a goto call into the middle of a subroutine block or use one to leave a subroutine block, you run the risk of really messing up the execution stack.

Not knowing the order of your gosub and goto calls, and where the read and write groups are occuring, it is hard to figure out where the issue is.

I've not heard of anyone having an issue reading/writing files. In my app it creates a new options file and the reads it. Since the player can change the options at any time, the file gets completely rewritten regularly. And I've not run into any issue.

In general, it is much safer to do things in functions instead of gosub structures (using globals or passing in variables).

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Doveyy04

12

Years of Service

User Offline

Joined: 30th Apr 2012

Location:

Posted: 18th Dec 2012 21:34

Link

CreateSprite ( 1, LoadImage ( "picture.jpg" ) )

LoadImage ( 1, "newgame.png" )
LoadImage ( 2, "loadgame.png" )
LoadImage ( 3, "helpguide.png" )
LoadImage ( 4, "options.png" )
LoadImage ( 5, "credits.png" )
loadimage ( 6, "mainheader.png")

CreateSprite ( 2, 1 )
CreateSprite ( 3, 2 )
CreateSprite ( 4, 3 )
CreateSprite ( 5, 4 )
CreateSprite ( 6, 5 )
createsprite ( 7, 6 )

SetSpritePosition ( 2, 130, 80 )
SetSpritePosition ( 3, 130, 128 )
SetSpritePosition ( 4, 130, 176 )
SetSpritePosition ( 5, 130, 224 )
SetSpritePosition ( 6, 130, 272 )
setspriteposition ( 7, 30, 10 )

sprite=0

do

if ( GetPointerPressed ( ) = 1 )
        sprite = GetSpriteHit ( GetPointerX ( ), GetPointerY ( ) )

endif
if sprite>1 and sprite<7 then playsound (click)
if sprite>1 and sprite<7 then gosub _flashsprite

if sprite=2 then goto _newgame
if sprite=3 then goto _loadgame
if sprite=4 then goto _helpguide
if sprite=5 then goto _options
if sprite=6 then goto _credits

Sync ( )
loop

_flashsprite:

setspritecoloralpha (sprite,100)
sync ()
sleep (100)
setspritecoloralpha (sprite,255)
sync()
sleep (100)

return

_loadgame:

opentoread (1, "dovey.txt")

+ Code Snippet


CreateSprite ( 1, LoadImage ( "picture.jpg" ) )



LoadImage ( 1, "newgame.png" )
LoadImage ( 2, "loadgame.png" )
LoadImage ( 3, "helpguide.png" )
LoadImage ( 4, "options.png" )
LoadImage ( 5, "credits.png" )
loadimage ( 6, "mainheader.png")


CreateSprite ( 2, 1 )
CreateSprite ( 3, 2 )
CreateSprite ( 4, 3 )
CreateSprite ( 5, 4 )
CreateSprite ( 6, 5 )
createsprite ( 7, 6 )


SetSpritePosition ( 2, 130, 80 )
SetSpritePosition ( 3, 130, 128 )
SetSpritePosition ( 4, 130, 176 )
SetSpritePosition ( 5, 130, 224 )
SetSpritePosition ( 6, 130, 272 )
setspriteposition ( 7, 30, 10 )

sprite=0

do


    
    if ( GetPointerPressed ( ) = 1 )
        sprite = GetSpriteHit ( GetPointerX ( ), GetPointerY ( ) )

    endif
if sprite>1 and sprite<7 then playsound (click)
if sprite>1 and sprite<7 then gosub _flashsprite


if sprite=2 then goto _newgame
if sprite=3 then goto _loadgame
if sprite=4 then goto _helpguide
if sprite=5 then goto _options
if sprite=6 then goto _credits

    Sync ( )
loop

_flashsprite:

setspritecoloralpha (sprite,100)
sync ()
sleep (100)
setspritecoloralpha (sprite,255)
sync()
sleep (100)

return

_loadgame:

opentoread (1, "dovey.txt")

my gotos are just like that, going from one screen to the next with the odd gosub just to flash the sprite when clicked etc. Well it seems that my program works fine when i read first so what i may have to do is when i click on new game get the program to read as it would if i was loading the game but then reset all the integers and strings to how it should be when you start a new game and then write the integers and strings, that way the program always reads before it writes

Back to top

Profile PM

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 18th Dec 2012 21:44

Link

Do you have a blank file named dovey.txt in your media directory?

If so, just create one with the values you want for initial values for a fresh game and read it at the start.

When you write the file it is NOT going into the application's media directory, it is going into the appropriate sandbox location for the platform it is running on. In the case of Windows, it is in your Documents\AGK\<yourappname>\media directory.

Subsequent reads of the file will be from the sandboxed location and NOT from the application's media directory. Once a file of the same name is written to, your app will never read it from the original media directory.

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

Hodgey

14

Years of Service

User Offline

Joined: 10th Oct 2009

Location: Australia

Posted: 18th Dec 2012 21:56 Edited at: 18th Dec 2012 21:57

Link

What happens after all of the writing to the file? It might not necessarily be writing to the file that's the problem, but what happens afterwards.

At this stage, I highly recommend removing all gotos from your program and replacing them with gosubs or functions.

Back to top

Profile PM Email

JimHawkins

14

Years of Service

User Offline

Joined: 26th Jul 2009

Location: Hull - UK

Posted: 18th Dec 2012 22:56

Link

I agree with AL and Hodgey. Goto should be used only in extreme circumstances (like errors in recursive descent compilers). You have to be very certain of your stack state if you jump out of a function. Most modern compilers don't let you do that.

You can reduce the nightmare by using functions for newgame etc.

I think it's important to use if and else rather than just if blocks, because, for example, you say:

if x = 1 then x = 3
if x = 3 then WoW!!

you have changed something that you are testing in the same code sequence.

Better still to use case statements with numeric values. They are faster, and usually optimised by the compiler.

-- Jim DO IT FASTER, EASIER AND BETTER WITH AppGameKit FOR PASCAL

Back to top

Profile PM Website

DVader

20

Years of Service

User Offline

Joined: 28th Jan 2004

Location:

Posted: 19th Dec 2012 02:06

Link

I would rewrite it.

+ Code Snippet

dim dovey$[10]
`add data to array
`dovey$[1]=teamengper etc...
opentowrite(1,"dovey.txt",0)
for n=1 to 10
    for data=0 to 1
        write$=dovey$[n,data]
        Writestring (1, write$)
    next data
next n
CloseFile(1)

That would save all the data into an array, and allow easy loading. You could also loop the data entry with some extra work, rather than adding it manually. It all depends on how much data you will be adding. With as much as you are using, I would consider splitting a string to get your data rather than using separate variables.

Back to top

Profile PM Website

Doveyy04

12

Years of Service

User Offline

Joined: 30th Apr 2012

Location:

Posted: 19th Dec 2012 11:51

Link

Thanks for the help guys, I will learn arrays and use them in my program. I don't think there is nothing going on after the writing to cause the problem happens before it gets to close file as the data hasnt been writing when i run the program again that I do know. My program does seem to work fine with all the gotos but then I havnt compiled it yet just run it in windows so maybe it won't work then. I don't have a dovey.txt file in my media file as I was looking for it and wondered why it wasn't in my project files so how do I create a txt file in my project media folder with the data I want for a fresh game?

Back to top

Profile PM

DVader

20

Years of Service

User Offline

Joined: 28th Jan 2004

Location:

Posted: 19th Dec 2012 15:04

Link

You would create it yourself. I used dovey as you used it in your example. The code I posted should create a text file called dovey.txt. I haven't put any data in though, it was just an example (Running it as is will save no data).

You will locate the file in your documents folder, under AppGameKit, then your project name. Inside the media folder in there, it should have generated a new txt file called dovey.txt. Until you add data though, it will be blank.

Back to top

Profile PM Website

Sorry your browser is not supported!

AppGameKit Classic Chat / Save and load data problem