Strange Sprite BUG : Sprite 12 doesnt exist

Author

Message

xGEKKOx

AGK Master

15

Years of Service

User Offline

Joined: 7th Dec 2008

Location: Italy

Posted: 24th Jan 2013 04:15 Edited at: 24th Jan 2013 04:35

Link

TIER 2 - XCode 4.5 - AppGameKit 1076
It's very strange...

void InizializzaFuochi(){
    Fire[0].cy = 0;
    Fire[0].vel = 2;
    Fire[0].frame = 1;
    Fire[0].anim = 0;
    Fire[0].oy = Opzioni[0].device_height - 100;
    Fire[0].conto = 200;
    Fire[0].id_sp = CreaSprite("fu1", "fverde", 0, Fire[0].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[0].id_sp, 100, 100, 9);
    
    Fire[1].cy = 0;
    Fire[1].vel = 3;
    Fire[1].frame = 1;
    Fire[1].anim = 0;
    Fire[1].oy = Opzioni[0].device_height - 200;
    Fire[1].conto = 200;
    Fire[1].id_sp = CreaSprite("fu2", "fblu", (Opzioni[0].device_width / 2) - (Opzioni[0].device_width / 3) + 50, Fire[1].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[1].id_sp, 100, 100, 9);
    
    Fire[2].cy = 0;
    Fire[2].vel = 2;
    Fire[2].frame = 1;
    Fire[2].anim = 0;
    Fire[2].oy = Opzioni[0].device_height - 100;
    Fire[2].conto = 200;
    Fire[2].id_sp = CreaSprite("fu3", "fviola", (Opzioni[0].device_width / 2) - 100, Fire[2].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[2].id_sp, 100, 100, 9);
    
    Fire[3].cy = 0;
    Fire[3].vel = 3;
    Fire[3].frame = 1;
    Fire[3].anim = 0;
    Fire[3].oy = Opzioni[0].device_height - 200;
    Fire[3].conto = 200;
    Fire[3].id_sp = CreaSprite("fu4", "fblu", Opzioni[0].device_width - (Opzioni[0].device_width / 3) - 75, Fire[3].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[3].id_sp, 100, 100, 9);
    
    Fire[4].cy = 0;
    Fire[4].vel = 2;
    Fire[4].frame = 1;
    Fire[4].anim = 0;
    Fire[4].oy = Opzioni[0].device_height - 100;
    Fire[4].conto = 200;
    Fire[4].id_sp = CreaSprite("fu5", "fverde", Opzioni[0].device_width - 200, Fire[4].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[4].id_sp, 100, 100, 9);
}

+ Code Snippet

void InizializzaFuochi(){
    Fire[0].cy = 0;
    Fire[0].vel = 2;
    Fire[0].frame = 1;
    Fire[0].anim = 0;
    Fire[0].oy = Opzioni[0].device_height - 100;
    Fire[0].conto = 200;
    Fire[0].id_sp = CreaSprite("fu1", "fverde", 0, Fire[0].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[0].id_sp, 100, 100, 9);
    
    Fire[1].cy = 0;
    Fire[1].vel = 3;
    Fire[1].frame = 1;
    Fire[1].anim = 0;
    Fire[1].oy = Opzioni[0].device_height - 200;
    Fire[1].conto = 200;
    Fire[1].id_sp = CreaSprite("fu2", "fblu", (Opzioni[0].device_width / 2) - (Opzioni[0].device_width / 3) + 50, Fire[1].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[1].id_sp, 100, 100, 9);
    
    Fire[2].cy = 0;
    Fire[2].vel = 2;
    Fire[2].frame = 1;
    Fire[2].anim = 0;
    Fire[2].oy = Opzioni[0].device_height - 100;
    Fire[2].conto = 200;
    Fire[2].id_sp = CreaSprite("fu3", "fviola", (Opzioni[0].device_width / 2) - 100, Fire[2].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[2].id_sp, 100, 100, 9);
    
    Fire[3].cy = 0;
    Fire[3].vel = 3;
    Fire[3].frame = 1;
    Fire[3].anim = 0;
    Fire[3].oy = Opzioni[0].device_height - 200;
    Fire[3].conto = 200;
    Fire[3].id_sp = CreaSprite("fu4", "fblu", Opzioni[0].device_width - (Opzioni[0].device_width / 3) - 75, Fire[3].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[3].id_sp, 100, 100, 9);
    
    Fire[4].cy = 0;
    Fire[4].vel = 2;
    Fire[4].frame = 1;
    Fire[4].anim = 0;
    Fire[4].oy = Opzioni[0].device_height - 100;
    Fire[4].conto = 200;
    Fire[4].id_sp = CreaSprite("fu5", "fverde", Opzioni[0].device_width - 200, Fire[4].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[4].id_sp, 100, 100, 9);
}

This is my 5 sprites for the fireworks when the slot do a big win.
The 1st sprite get stucked at the same position.
The 2nd sprite ID is always 12, even if i change the position in the code so where to create it.
The others work as expected.

When CreaSprite (in english CreateSprite) return the ID, it is not 12, but the real ID so 10120 (for example)

I don't understand why later in the animation update it get 12!!!!
I'm going crazy!!!
Why 12??????

//Fuochi D'Artificio
    if(_fuochi){
        for(int w = 0; w < Fire.size(); w++){
            printf("F : %i - Frame : %i - Conto : %i - Co2 : %i\n", Fire[w].id_sp, Fire[w].frame, Fire[w].conto, Fire[w].cy);
            //Posizione fuochi d'artificio
            if(Fire[w].anim == 0){
                //Imposta Animazione e Frame
                if(Fire[w].frame == 1){
                    Fire[w].frame = 2;
                } else if(Fire[w].frame == 2){
                    Fire[w].frame = 1;
                }
                if(Fire[w].cy < Fire[w].conto){
                    Fire[w].cy += 2;
                    int g = Fire[w].oy - Fire[w].cy;
                    agk::SetSpriteY(Fire[w].id_sp, g);
                } else {
                    Fire[w].anim = 1;
                }
            }
            
            if(Fire[w].anim == 1){
                if(fps % 5 == 0){
                    Fire[w].frame++;
                    if(Fire[w].frame > 9){
                        agk::SetSpriteY(Fire[w].id_sp, Fire[w].oy);
                        Fire[w].anim = 0;
                        Fire[w].frame = 1;
                        Fire[w].cy = 0;
                    }
                }
            }
            agk::SetSpriteFrame(Fire[w].id_sp, Fire[w].frame);
            agk::SetSpriteVisible(Fire[w].id_sp, 1);
        }
    }

+ Code Snippet

//Fuochi D'Artificio
    if(_fuochi){
        for(int w = 0; w < Fire.size(); w++){
            printf("F : %i - Frame : %i - Conto : %i - Co2 : %i\n", Fire[w].id_sp, Fire[w].frame, Fire[w].conto, Fire[w].cy);
            //Posizione fuochi d'artificio
            if(Fire[w].anim == 0){
                //Imposta Animazione e Frame
                if(Fire[w].frame == 1){
                    Fire[w].frame = 2;
                } else if(Fire[w].frame == 2){
                    Fire[w].frame = 1;
                }
                if(Fire[w].cy < Fire[w].conto){
                    Fire[w].cy += 2;
                    int g = Fire[w].oy - Fire[w].cy;
                    agk::SetSpriteY(Fire[w].id_sp, g);
                } else {
                    Fire[w].anim = 1;
                }
            }
            
            if(Fire[w].anim == 1){
                if(fps % 5 == 0){
                    Fire[w].frame++;
                    if(Fire[w].frame > 9){
                        agk::SetSpriteY(Fire[w].id_sp, Fire[w].oy);
                        Fire[w].anim = 0;
                        Fire[w].frame = 1;
                        Fire[w].cy = 0;
                    }
                }
            }
            agk::SetSpriteFrame(Fire[w].id_sp, Fire[w].frame);
            agk::SetSpriteVisible(Fire[w].id_sp, 1);
        }
    }

Anyone encountered this problem?

In the while i'm testing other solutions...

Long life to Steve!

Back to top

Profile PM Website

kamac

13

Years of Service

User Offline

Joined: 30th Nov 2010

Location: Poland

Posted: 24th Jan 2013 07:44

Link

Could you perhaps show us your Fire's class/struct?
I'd also like to see whether Fire is a table or other object (vector perhaps?). So, if you can, please show how you initialize Fire aswell.

Also, I guess that the 2nd snippet occurs on loop, many times, whereas initializing fire happens once. It could be that something else's changing their values.

Two possible options:
a) Something else changes their values
b) Something's wrong with your class and you need to make a list/table/vector of pointers

Follow me on twitter! @MotionStruct
Motion Struct blog

Back to top

Profile PM Email

tornado

19

Years of Service

User Offline

Joined: 21st Jul 2005

Location:

Posted: 24th Jan 2013 08:54

Link

xGEKKOX, take a closer look at [w] value: if it goes out of bounds set in structure (eg [6] while you have max of [5] in declaration), it will return the wrong value but not null. Just a suggestion.

Back to top

Profile PM Email Website

Hodgey

15

Years of Service

User Offline

Joined: 10th Oct 2009

Location: Australia

Posted: 24th Jan 2013 09:08

Link

I think he's using the array class so he should be safe with w < Fire.size().

What comes after your animation code?

Back to top

Profile PM Email

xGEKKOx

AGK Master

15

Years of Service

User Offline

Joined: 7th Dec 2008

Location: Italy

Posted: 24th Jan 2013 15:48

Link

The first firework only explode, the second never come out (the one with 12), the others work normally as...
They come up from the ground, reach the count when they need to explode and explode well.

The array is a vector:
struct _Fire { int id_sp; int oy; int conto; int cy; int fr; int anim; int vel; };
vector <_Fire> Fire(5);

The strange thing, is that the fireworks only worked 3/100 times, doing nothing!!!!

Long life to Steve!

Back to top

Profile PM Website

xGEKKOx

AGK Master

15

Years of Service

User Offline

Joined: 7th Dec 2008

Location: Italy

Posted: 24th Jan 2013 16:16

Link

Oh my god, if i launch the fireworks immediately, they work.
If i initialize them after the slot init and the other sprite init, they don't work.
Investigating...

Long life to Steve!

Back to top

Profile PM Website

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 24th Jan 2013 16:56

Link

Can you show the CreaSprite function?

This might help with knowing how the sprite is being created.

Also, you are using integer values as the Y value passed into SetSpriteY. That function takes a float value for the Y value. This may or may not be having an undesired effect.

And some questions about the following code:

+ Code Snippet

            if(Fire[w].anim == 0){
                //Imposta Animazione e Frame
                if(Fire[w].frame == 1){
                    Fire[w].frame = 2;
                } else if(Fire[w].frame == 2){
                    Fire[w].frame = 1;
                }
                if(Fire[w].cy < Fire[w].conto){
                    Fire[w].cy += 2;
                    int g = Fire[w].oy - Fire[w].cy;
                    agk::SetSpriteY(Fire[w].id_sp, g);
                } else {
                    Fire[w].anim = 1;
                }
            }
            
            if(Fire[w].anim == 1){
                if(fps % 5 == 0){
                    Fire[w].frame++;
                    if(Fire[w].frame > 9){
                        agk::SetSpriteY(Fire[w].id_sp, Fire[w].oy);
                        Fire[w].anim = 0;
                        Fire[w].frame = 1;
                        Fire[w].cy = 0;
                    }
                }
            }

It is possible that both of the following will evaluate to true "if(Fire[w].anim == 0)" and "if(Fire[w].anim == 1)" in the same for loop iteration. This might happen because the anim value is set to one if this test fails "if(Fire[w].cy < Fire[w].conto)".

And, how are you setting the variable 'fps' used in this test "if(fps % 5 == 0)"? Frames Per Second is a floating point value as returned by ScreenFPS and used in SetSyncRate. The way you are using the variable makes it an integer. Assuming that is what you meant, try putting parenthesis around 'fps % 5' to make sure it is being parsed correctly.

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

xGEKKOx

AGK Master

15

Years of Service

User Offline

Joined: 7th Dec 2008

Location: Italy

Posted: 24th Jan 2013 19:49

Link

I will post all in few minutes, cause now i changed something and now happen another thing ahaaha...
Thx for the help Lady.

Long life to Steve!

Back to top

Profile PM Website

xGEKKOx

AGK Master

15

Years of Service

User Offline

Joined: 7th Dec 2008

Location: Italy

Posted: 24th Jan 2013 20:07

Link

This is part of my Manager

int CreaSprite(string nome_sprite, string nome_immagine, float x, float y, float size_x, float size_y, int z_index, int stato){
    int _temp_id = DammiSpriteId(nome_sprite); 
    int _img_id = DammiImmagineId(nome_immagine);
    int _ris = _temp_id;
    if(_temp_id == -1){
        _Sprites data;
        data.id_sprite = agk::CreateSprite(_img_id);
        _ris = data.id_sprite;
        data.nome_sprite = nome_sprite;
        //agk::SetSpriteUVBorder(data.id_sprite, border);
        agk::SetSpritePosition(data.id_sprite, x, y);
        agk::SetSpriteDepth(data.id_sprite, z_index);
        agk::SetSpriteVisible(data.id_sprite, stato);
        agk::SetSpriteSize(data.id_sprite, size_x, size_y);
        Sprites.push_back(data);
    } else {
        agk::SetSpriteImage (_temp_id, _img_id);
        //agk::SetSpriteUVBorder(_temp_id, border);
        agk::SetSpritePosition(_temp_id, x, y);
        agk::SetSpriteDepth(_temp_id, z_index);
        agk::SetSpriteVisible(_temp_id, stato);
        agk::SetSpriteSize(_temp_id, size_x, size_y);
    }
    //printf("Sprite : %i - Nome : %s\n", _ris, nome_sprite.c_str());
    return _ris; 
}

+ Code Snippet

int CreaSprite(string nome_sprite, string nome_immagine, float x, float y, float size_x, float size_y, int z_index, int stato){
    int _temp_id = DammiSpriteId(nome_sprite); 
    int _img_id = DammiImmagineId(nome_immagine);
    int _ris = _temp_id;
    if(_temp_id == -1){
        _Sprites data;
        data.id_sprite = agk::CreateSprite(_img_id);
        _ris = data.id_sprite;
        data.nome_sprite = nome_sprite;
        //agk::SetSpriteUVBorder(data.id_sprite, border);
        agk::SetSpritePosition(data.id_sprite, x, y);
        agk::SetSpriteDepth(data.id_sprite, z_index);
        agk::SetSpriteVisible(data.id_sprite, stato);
        agk::SetSpriteSize(data.id_sprite, size_x, size_y);
        Sprites.push_back(data);
    } else {
        agk::SetSpriteImage (_temp_id, _img_id);
        //agk::SetSpriteUVBorder(_temp_id, border);
        agk::SetSpritePosition(_temp_id, x, y);
        agk::SetSpriteDepth(_temp_id, z_index);
        agk::SetSpriteVisible(_temp_id, stato);
        agk::SetSpriteSize(_temp_id, size_x, size_y);
    }
    //printf("Sprite : %i - Nome : %s\n", _ris, nome_sprite.c_str());
    return _ris; 
}

And this is the new version of fireworks...

+ Code Snippet

//Fuochi D'Artificio
    if(_fuochi && fps % 2 == 0){
        for(int w = 0; w < Fire.size(); w++){
            //Posizione fuochi d'artificio
            Fire[w].cy += Fire[w].vel;
            if(Fire[w].cy < 200){
                if(Fire[w].fr == 1){
                    Fire[w].fr = 2;
                } else if(Fire[w].fr == 2){
                    Fire[w].fr = 1;
                }
            } else {
                Fire[w].fr++;
                if(Fire[w].fr > 9){
                    Fire[w].fr = 1;
                    Fire[w].cy = 0;
                }
            }
            printf("F : %i - Frame : %i - Co2 : %i\n", Fire[w].id_sp, Fire[w].fr, Fire[w].cy);
            agk::SetSpriteFrame(Fire[w].id_sp, Fire[w].fr);
            agk::SetSpriteY(Fire[w].id_sp, Fire[w].oy - Fire[w].cy);
            agk::SetSpriteVisible(Fire[w].id_sp, 1);
        }
    }

And the vector now is...

void InizializzaFuochi(){
    Fire[0].cy = 0;
    Fire[0].vel = 2;
    Fire[0].fr = 1;
    Fire[0].oy = Opzioni[0].device_height - 100;
    Fire[0].id_sp = CreaSprite("fu1", "fverde", 0, Fire[0].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[0].id_sp, 100, 100, 9);
    
    Fire[1].cy = 0;
    Fire[1].vel = 3;
    Fire[1].fr = 1;
    Fire[1].oy = Opzioni[0].device_height - 200;
    Fire[1].id_sp = CreaSprite("fu2", "fblu", int(((Opzioni[0].device_width / 2) - (Opzioni[0].device_width / 3))) + 50, Fire[1].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[1].id_sp, 100, 100, 9);
    
    Fire[2].cy = 0;
    Fire[2].vel = 2;
    Fire[2].fr = 1;
    Fire[2].oy = Opzioni[0].device_height - 100;
    Fire[2].id_sp = CreaSprite("fu3", "fviola", (Opzioni[0].device_width / 2) - 100, Fire[2].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[2].id_sp, 100, 100, 9);
    
    Fire[3].cy = 0;
    Fire[3].vel = 3;
    Fire[3].fr = 1;
    Fire[3].oy = Opzioni[0].device_height - 200;
    Fire[3].id_sp = CreaSprite("fu4", "fblu", Opzioni[0].device_width - (Opzioni[0].device_width / 3) - 75, Fire[3].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[3].id_sp, 100, 100, 9);
    
    Fire[4].cy = 0;
    Fire[4].vel = 2;
    Fire[4].fr = 1;
    Fire[4].oy = Opzioni[0].device_height - 100;
    Fire[4].id_sp = CreaSprite("fu5", "fverde", Opzioni[0].device_width - 200, Fire[4].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[4].id_sp, 100, 100, 9);
}

+ Code Snippet

void InizializzaFuochi(){
    Fire[0].cy = 0;
    Fire[0].vel = 2;
    Fire[0].fr = 1;
    Fire[0].oy = Opzioni[0].device_height - 100;
    Fire[0].id_sp = CreaSprite("fu1", "fverde", 0, Fire[0].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[0].id_sp, 100, 100, 9);
    
    Fire[1].cy = 0;
    Fire[1].vel = 3;
    Fire[1].fr = 1;
    Fire[1].oy = Opzioni[0].device_height - 200;
    Fire[1].id_sp = CreaSprite("fu2", "fblu", int(((Opzioni[0].device_width / 2) - (Opzioni[0].device_width / 3))) + 50, Fire[1].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[1].id_sp, 100, 100, 9);
    
    Fire[2].cy = 0;
    Fire[2].vel = 2;
    Fire[2].fr = 1;
    Fire[2].oy = Opzioni[0].device_height - 100;
    Fire[2].id_sp = CreaSprite("fu3", "fviola", (Opzioni[0].device_width / 2) - 100, Fire[2].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[2].id_sp, 100, 100, 9);
    
    Fire[3].cy = 0;
    Fire[3].vel = 3;
    Fire[3].fr = 1;
    Fire[3].oy = Opzioni[0].device_height - 200;
    Fire[3].id_sp = CreaSprite("fu4", "fblu", Opzioni[0].device_width - (Opzioni[0].device_width / 3) - 75, Fire[3].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[3].id_sp, 100, 100, 9);
    
    Fire[4].cy = 0;
    Fire[4].vel = 2;
    Fire[4].fr = 1;
    Fire[4].oy = Opzioni[0].device_height - 100;
    Fire[4].id_sp = CreaSprite("fu5", "fverde", Opzioni[0].device_width - 200, Fire[4].oy, 200, 200, 20, 0);
    agk::SetSpriteAnimation(Fire[4].id_sp, 100, 100, 9);
}

Ok now the fireworks don't fire the 12 sprite doesn't exist, but now only 1 fire go over the max count!!!
Ahahah make me crazy!

Long life to Steve!

Back to top

Profile PM Website

Ancient Lady

Valued Member

20

Years of Service

User Offline

Joined: 17th Mar 2004

Location: Anchorage, Alaska, USA

Posted: 24th Jan 2013 22:22

Link

Try changing this: if(_fuochi && fps % 2 == 0)
to this: if(_fuochi && ((fps % 2) == 0))

In theory, assuming normal precedence, your code should produce what you intend, but I never assume that compilers really do that.

Plus, it makes it much more readable and easier for a human being to parse.

And I just found a page that says the order of evaluation (at run time) is not necessarily the same order as the compiler uses.

All of your sprite ids are in the range of 10000 or more because you are using the automatic id generation version of CreateSprite.

And I am still quite suspicious of your use of integers for X and Y values instead of the floats used by the AppGameKit function and your own CreaSprite function.

Is your fps variable a float or integer and how are you setting it?

Cheers,
Ancient Lady
AGK Community Tester and AppGameKit Master

Back to top

Profile PM

xGEKKOx

AGK Master

15

Years of Service

User Offline

Joined: 7th Dec 2008

Location: Italy

Posted: 25th Jan 2013 02:22

Link

The fps is an int.
For fps i never had problems, cause is an integer that do ++ on the loop function.
When arrive at 10000 return to 1.

I think is the float VS int as you said.
Now the ID problem is solved, but the coordinate still exist.
I wanna investigate on the compiler as you said.

Long life to Steve!

Back to top

Profile PM Website

xGEKKOx

AGK Master

15

Years of Service

User Offline

Joined: 7th Dec 2008

Location: Italy

Posted: 25th Jan 2013 04:15

Link

Well incredible again....
All is solved creating and deleting the sprite each time i need fireworks.
But is strange, maybe the mistake is on other sprites.

I will post something if i understand better.

Long life to Steve!

Back to top

Profile PM Website

Sorry your browser is not supported!

AppGameKit Classic Chat / Strange Sprite BUG : Sprite 12 doesnt exist