Random array int gets reset midcode...

Author

Message

AlexMes

19

Years of Service

User Offline

Joined: 3rd Nov 2005

Location:

Posted: 26th Sep 2018 00:31

Link

Sorry i dont know how to properly describe my problem in the title. But basicly I got an array with questions and answers. Its going to be a trivia game/app. I got an integer set to randomly select a question from the big array. The code works as intended I would say 90% of the time but 10% of the time it will select a question and get the answers from another array entree. So here is how I define the array:

type myQuestionType
    question as string
    answer1 as string
    answer2 as string
    answer3 as string
    answer4 as string
    image as string
endtype

questionsLoaded = 1
		questions as myQuestionType[3]
		
		questions[0].question = "Question 1?"
		questions[0].image = "qimage1.jpg"
		questions[0].answer1 = "answer1"
		questions[0].answer2 = "answer2"
		questions[0].answer3 = "answer3"
		questions[0].answer4 = "answer4"

questions[1].question = "Question 2?"
		questions[1].image = "qimage1.jpg"
		questions[1].answer1 = "a"
		questions[1].answer2 = "b"
		questions[1].answer3 = "c"
		questions[1].answer4 = "d"

questions[2].question = "Question 3?"
		questions[2].image = "qimage1.jpg"
		questions[2].answer1 = "111"
		questions[2].answer2 = "222"
		questions[2].answer3 = "333"
		questions[2].answer4 = "444"

function newQuestion()
	iRandomQuestion = random(1,(questions.length-1))
	sCurrentQuestion = str(iRandomQuestion) + ": " + questions[iRandomQuestion].question
	sCurrentImage = questions[iRandomQuestion].image
	sCurrentAnswer1 = questions[iRandomQuestion].answer1
	sCurrentAnswer2 = questions[iRandomQuestion].answer2
	sCurrentAnswer3 = questions[iRandomQuestion].answer3
	sCurrentAnswer4 = questions[iRandomQuestion].answer4
endfunction

+ Code Snippet

type myQuestionType
    question as string
    answer1 as string
    answer2 as string
    answer3 as string
    answer4 as string
    image as string
endtype

		questionsLoaded = 1
		questions as myQuestionType[3]
		
		questions[0].question = "Question 1?"
		questions[0].image = "qimage1.jpg"
		questions[0].answer1 = "answer1"
		questions[0].answer2 = "answer2"
		questions[0].answer3 = "answer3"
		questions[0].answer4 = "answer4"

		questions[1].question = "Question 2?"
		questions[1].image = "qimage1.jpg"
		questions[1].answer1 = "a"
		questions[1].answer2 = "b"
		questions[1].answer3 = "c"
		questions[1].answer4 = "d"

		questions[2].question = "Question 3?"
		questions[2].image = "qimage1.jpg"
		questions[2].answer1 = "111"
		questions[2].answer2 = "222"
		questions[2].answer3 = "333"
		questions[2].answer4 = "444"

function newQuestion()
	iRandomQuestion = random(1,(questions.length-1))
	sCurrentQuestion = str(iRandomQuestion) + ": " + questions[iRandomQuestion].question
	sCurrentImage = questions[iRandomQuestion].image
	sCurrentAnswer1 = questions[iRandomQuestion].answer1
	sCurrentAnswer2 = questions[iRandomQuestion].answer2
	sCurrentAnswer3 = questions[iRandomQuestion].answer3
	sCurrentAnswer4 = questions[iRandomQuestion].answer4
endfunction

So ofcourse the function is called whenever a new question has to be loaded (start of the game or after a correct answer. My real question array is bigger than this but now you got an idea.

My problem: Like i said it works as intended for 90% of the time but sometimes it loads question[0].question (Question 1) but loads the answers of question[1].answer1 . So somehow iRandomQuestion integer went from 0 to 1 for example.

Anyone know what might be wrong? I tried to put a lock on the function so it can only be run once at a time, but still get this behavior.

I use this code for the buttons:

+ Code Snippet

			if button(overlayButton) = 1 and overlayButtonActive = 0
				overlayButtonActive = 1
				delay(1)
				showOverlayWin = 0
				hideSprite(overlayButton)
				if GetSpriteExists(overlayImage) = 1
					deleteSprite(overlayImage)
				endif
				newQuestion = 1
			endIf

Function button(sprite) 
returnValue = 0 `reset value for check
If GetPointerX() > GetSpriteXByOffset( sprite ) - ( GetSpriteWidth( sprite ) / 2 )
 If GetPointerX() < GetSpriteXByOffset( sprite ) + ( GetSpriteWidth( sprite ) / 2 )
   If GetPointerY() > GetSpriteYByOffset( sprite ) - ( GetSpriteHeight( sprite ) / 2 )
    If GetPointerY() < GetSpriteYByOffset( sprite ) + ( GetSpriteHeight( sprite ) / 2 )
      If GetPointerState() = 1
        returnValue = 1
      Endif
     Endif
   Endif
  Endif
Endif
EndFunction returnValue

newQuestion = 1 will trigger the newQuestion function in the main loop

Back to top

Profile PM

smallg

Valued Member

18

Years of Service

User Offline

Joined: 8th Dec 2005

Location: steam

Posted: 26th Sep 2018 09:50

Link

Most likely reason is that your button script is returning returnValue = 0
Not sure why that would give the incorrect answers though, you must have some other code that doesn't update the answer text if the question is not above 0?

life's one big game
spec= 4ghz, 16gb ram, AMD R9 2700 gpu

Back to top

Profile PM Email

AlexMes

19

Years of Service

User Offline

Joined: 3rd Nov 2005

Location:

Posted: 26th Sep 2018 14:22

Link

Fixed it, was a bug somewhere else in the code. Sorry

Can close topic.

Back to top

Profile PM

Phaelax

DBPro Master

21

Years of Service

User Offline

Joined: 16th Apr 2003

Location: Metropia

Posted: 26th Sep 2018 15:59

Link

I know you already solved this but,

Right off the bat, I see this line:

iRandomQuestion = random(1,(questions.length-1))

It'll never return 0, therefore you'll never see the first question. As for your problem, your code snippet shows no reason as to why the question and its answers wouldn't match up so the problem is definitely somewhere else in your code that you haven't shown.

And just a tidbit on your button function, might consider breaking it down into two functions and making the selection more modular.

I would find this much easier to read and reuse:

+ Code Snippet

function button(sprite)
	x1 = getSpriteXByOffset(sprite) - getSpriteWidth(sprite) / 2
	y1 = getSpriteYByOffset(sprite) - getSpriteHeight(sprite) / 2
	x2 = getSpriteXByOffset(sprite) + getSpriteWidth(sprite) / 2
	y1 = getSpriteYByOffset(sprite) + getSpriteHeight(sprite) / 2

	if pointInside(getPointerX(), getPointerY(), x1, y1, x2, y2) = 1
		if getPointerState() = 1
			exitfunction 1
		endif
	endif
endfunction 0


function pointInside(px, py, x1, y1, x2, y2)
	if px > x1 and px < x2 and py > y1 and py < y2 then exitfunction 1
endfunction 0

Tiled TMX Importer V.2
XML Parser V.2
Base64 Encoder/Decoder
Purple Token - Free online hi-score database
Legend of Zelda

"I like offending people, because I think people who get offended should be offended." - Linus Torvalds

Back to top

Profile PM Email Website

Bengismo

7

Years of Service

User Offline

Joined: 20th Nov 2017

Location: Yorkshire, England

Posted: 26th Sep 2018 16:04 Edited at: 26th Sep 2018 21:40

Link

or just use GetSpriteHit().... it makes the button check a very easy one line function

+ Code Snippet

function button(sprite)
    if GetPointerPressed() and GetSpriteHit(getPointerX(), getPointerY()) = sprite then    exitfunction 1
endfunction 0

...and use GetPointerPressed() so you dont need a lockout variable

Back to top

Profile PM

Sorry your browser is not supported!

Newcomers AppGameKit Corner / Random array int gets reset midcode...